27008 2009-07-06 14:37:39 -0700 bugzilla-tool fails with bugzilla 3.0 2009-07-06 19:30:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned oldest_to_newest 130025 0 eric 2009-07-06 14:37:39 -0700 I found one error, which I fixed: - self.browser['knob'] = ['resolve'] + self.browser['bug_status'] = ['RESOLVED'] But now I'm hitting this nasty: Traceback (most recent call last): File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 579, in <module> main() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 576, in main return tool.main() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 571, in main return command_object.execute(command_options, command_args, self) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 354, in execute self.land_patches(bug_id, bugs_to_patches[bug_id], options, tool) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 331, in land_patches tool.bugs.close_bug_as_fixed(bug_id, comment_text) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/bugzilla.py", line 292, in close_bug_as_fixed self.browser.select_form(name="changeform") File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 505, in select_form File "build/bdist.macosx-10.5-i386/egg/mechanize/_html.py", line 546, in __getattr__ File "build/bdist.macosx-10.5-i386/egg/mechanize/_html.py", line 559, in forms File "build/bdist.macosx-10.5-i386/egg/mechanize/_html.py", line 228, in forms mechanize._html.ParseError% 130026 1 eric 2009-07-06 14:39:09 -0700 The parse error was hit while trying to land patches from: https://bugs.webkit.org/show_bug.cgi?id=25061 130072 2 32339 eric 2009-07-06 18:06:16 -0700 Created attachment 32339 patch 130085 3 32339 mjs 2009-07-06 18:35:06 -0700 Comment on attachment 32339 patch r=me 130095 4 eric 2009-07-06 19:19:01 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py Committed r45580 M WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a M WebKitLibraries/WebKitSystemInterface.h M WebKitLibraries/ChangeLog M WebKitLibraries/libWebKitSystemInterfaceLeopard.a M WebKitLibraries/libWebKitSystemInterfaceTiger.a r45563 = fd162b32e95aa06b3b031cce2246b7ae56518018 (trunk) M WebCore/ChangeLog M WebCore/bindings/v8/V8Binding.cpp r45564 = ea9915cd1c5417e26ccbc8e09b4f2afb874ab791 (trunk) M WebKit/mac/WebCoreSupport/WebSystemInterface.m M WebKit/mac/ChangeLog M WebCore/ChangeLog M WebCore/WebCore.base.exp M WebCore/page/mac/EventHandlerMac.mm M WebCore/page/EventHandler.h M WebCore/page/EventHandler.cpp M WebCore/platform/mac/WebCoreSystemInterface.mm M WebCore/platform/mac/WebCoreSystemInterface.h r45565 = 8b5e4f39ff02cd99377a0399d61a6d2332f479d7 (trunk) M JavaScriptCore/wtf/FastMalloc.cpp M JavaScriptCore/ChangeLog r45566 = 162c8cf48ef64628018343b5c2c1de20e65afc59 (trunk) M WebCore/ChangeLog M WebCore/rendering/RenderTextControl.cpp A LayoutTests/platform/mac/editing/input/text-control-ime-input-expected.txt A LayoutTests/platform/mac/editing/input/text-control-ime-input.html M LayoutTests/ChangeLog r45567 = 7deab11294610e0e1d008d61c69150772ed18397 (trunk) M WebCore/ChangeLog M WebCore/rendering/RenderFlexibleBox.cpp M WebCore/rendering/RenderBlock.cpp M WebCore/rendering/RenderBlock.h M LayoutTests/ChangeLog A LayoutTests/fast/flexbox/repaint-scrollbar-expected.txt A LayoutTests/fast/flexbox/repaint-scrollbar.html A LayoutTests/fast/flexbox/resources/repaint-scrollbar.js r45568 = 52339b5a0ebb8366f59f26c4b326f14f225fb789 (trunk) M WebCore/ChangeLog M WebCore/platform/graphics/Color.h M WebCore/WebCore.order M WebCore/rendering/RenderThemeMac.mm M WebCore/rendering/RenderThemeSafari.h M WebCore/rendering/RenderThemeChromiumSkia.cpp M WebCore/rendering/RenderThemeChromiumSkia.h M WebCore/rendering/RenderThemeChromiumMac.mm M WebCore/rendering/RenderThemeSafari.cpp M WebCore/rendering/RenderThemeChromiumMac.h M WebCore/rendering/RenderThemeMac.h M WebCore/rendering/RenderTheme.cpp M WebCore/rendering/RenderTheme.h M WebCore/css/CSSStyleSelector.cpp r45569 = 39f68b4dc18c91faaea1ed952b85c522950630a8 (trunk) M WebCore/ChangeLog M WebCore/rendering/InlineBox.cpp M WebCore/rendering/RenderSVGInlineText.cpp M WebCore/rendering/SVGInlineTextBox.h M WebCore/rendering/SVGInlineFlowBox.h M WebCore/rendering/RenderSVGText.cpp M WebCore/rendering/RenderSVGInline.cpp M WebCore/rendering/SVGRootInlineBox.h M WebCore/rendering/InlineBox.h r45570 = 0bc3a1356efe435f43de58095372a73b869cb918 (trunk) M WebCore/ChangeLog M WebCore/bridge/runtime_root.h M WebCore/bridge/runtime_root.cpp r45571 = a361203ec36c76ebe90e51fb1eea51fcb8ca00d7 (trunk) M WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a M WebKitLibraries/WebKitSystemInterface.h M WebKitLibraries/ChangeLog M WebKitLibraries/libWebKitSystemInterfaceLeopard.a M WebKitLibraries/libWebKitSystemInterfaceTiger.a M WebCore/ChangeLog M WebCore/platform/mac/WebCoreSystemInterface.mm M WebCore/platform/mac/WebCoreSystemInterface.h M WebCore/rendering/RenderThemeMac.mm M WebCore/rendering/MediaControlElements.cpp M WebCore/rendering/MediaControlElements.h M WebCore/rendering/RenderMedia.h M WebCore/rendering/RenderMedia.cpp r45572 = 3de935e2cb09e93bfbe864f99f3549f9a4311e27 (trunk) M WebCore/ChangeLog M WebCore/bindings/scripts/CodeGeneratorV8.pm D WebCore/bindings/v8/V8Binding.cpp M WebCore/bindings/v8/V8Proxy.cpp M WebCore/bindings/v8/WorkerContextExecutionProxy.cpp M WebCore/bindings/v8/V8LazyEventListener.cpp M WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp M WebCore/bindings/v8/custom/V8CustomXPathNSResolver.cpp M WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp M WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp M WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp M WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp M WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp M WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp M WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp M WebCore/bindings/v8/custom/V8HTMLIFrameElementCustom.cpp M WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp M WebCore/bindings/v8/V8Binding.h r45574 = 7a83c6d177143459ffd49e7ad6fe2106bc8e26ab (trunk) M WebCore/ChangeLog M WebCore/rendering/RenderThemeMac.mm M LayoutTests/platform/mac-snowleopard/Skipped M LayoutTests/ChangeLog r45576 = f92b4bb3f1edfaa42e65b90f807fc0ab27627e66 (trunk) M WebCore/editing/Editor.cpp M WebCore/ChangeLog r45577 = 4f84fae9cc27fa079c630ce518ee8f26a1b2dfbd (trunk) M WebCore/ChangeLog M WebCore/html/CanvasRenderingContext2D.cpp r45578 = 33e9db66e2eca89b9619ef0f6e18535b696643c7 (trunk) M WebKit/mac/Plugins/WebNetscapeContainerCheckPrivate.mm M WebKit/mac/Plugins/WebNetscapeContainerCheckContextInfo.mm M WebKit/mac/Plugins/WebNetscapeContainerCheckContextInfo.h M WebKit/mac/ChangeLog r45579 = 7adf5b839435bdfeff30989c260552c8273d3635 (trunk) M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py r45580 = 04d18f40d7fb3455553af530df851fcf6f66425b (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/45580 130097 5 eric 2009-07-06 19:30:30 -0700 Sorry! I'll bump https://bugs.webkit.org/show_bug.cgi?id=26920 up in my queue. That's what's causing all that extra junk in the bug comment! 32339 2009-07-06 18:06:16 -0700 2009-07-06 18:35:06 -0700 patch bugzilla_requires_a_filename.patch text/plain 2298 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5OTMxMTNjLi5hNDc5YmNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct MDYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wgZmFpbHMgdG8gY2xvc2Ug YnVncyB3aXRoIGJ1Z3ppbGxhIDMuMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjcwMDgKKworICAgICAgICBVcGRhdGUgYnVnemlsbGEucHkgdG8gbWF0 Y2ggY2hhbmdlcyBpbiB0aGUgYnVnIHBhZ2UgImNoYW5nZWZvcm0iCisgICAgICAgIFVwZGF0ZSBz Y20ucHkgdG8gYWRkIGJ1Z19pZHMgdG8gYXR0YWNobWVudHMgdG8gbWFrZSBlcnJvciByZXBvcnRp bmcgbmljZXIuCisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHk6CisgICAg ICAgICogU2NyaXB0cy9tb2R1bGVzL3NjbS5weToKKwogMjAwOS0wNy0wMyAgTWFjaWVqIFN0YWNo b3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5IGIv V2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CmluZGV4IGY2MzhlYWUuLjIx ZjZjZDIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKQEAgLTE0Myw2 ICsxNDMsNyBAQCBjbGFzcyBCdWd6aWxsYToKICAgICAgICAgYXR0YWNobWVudHMgPSBbXQogICAg ICAgICBmb3IgZWxlbWVudCBpbiBzb3VwLmZpbmRBbGwoJ2F0dGFjaG1lbnQnKToKICAgICAgICAg ICAgIGF0dGFjaG1lbnQgPSB7fQorICAgICAgICAgICAgYXR0YWNobWVudFsnYnVnX2lkJ10gPSBi dWdfaWQKICAgICAgICAgICAgIGF0dGFjaG1lbnRbJ2lzX29ic29sZXRlJ10gPSAoZWxlbWVudC5o YXNfa2V5KCdpc29ic29sZXRlJykgYW5kIGVsZW1lbnRbJ2lzb2Jzb2xldGUnXSA9PSAiMSIpCiAg ICAgICAgICAgICBhdHRhY2htZW50Wydpc19wYXRjaCddID0gKGVsZW1lbnQuaGFzX2tleSgnaXNw YXRjaCcpIGFuZCBlbGVtZW50Wydpc3BhdGNoJ10gPT0gIjEiKQogICAgICAgICAgICAgYXR0YWNo bWVudFsnaWQnXSA9IHN0cihlbGVtZW50LmZpbmQoJ2F0dGFjaGlkJykuc3RyaW5nKQpAQCAtMjkz LDYgKzI5NCw2IEBAIGNsYXNzIEJ1Z3ppbGxhOgogICAgICAgICBpZiBjb21tZW50X3RleHQ6CiAg ICAgICAgICAgICBsb2coY29tbWVudF90ZXh0KQogICAgICAgICAgICAgc2VsZi5icm93c2VyWydj b21tZW50J10gPSBjb21tZW50X3RleHQKLSAgICAgICAgc2VsZi5icm93c2VyWydrbm9iJ10gPSBb J3Jlc29sdmUnXQorICAgICAgICBzZWxmLmJyb3dzZXJbJ2J1Z19zdGF0dXMnXSA9IFsnUkVTT0xW RUQnXQogICAgICAgICBzZWxmLmJyb3dzZXJbJ3Jlc29sdXRpb24nXSA9IFsnRklYRUQnXQogICAg ICAgICBzZWxmLmJyb3dzZXIuc3VibWl0KCkKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9zY20ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5Cmlu ZGV4IDIyYTU2M2IuLjk1NWNlM2MgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9k dWxlcy9zY20ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQpAQCAt OTksNyArOTksNyBAQCBjbGFzcyBTQ006CiAKICAgICAgICAgcmV0dXJuX2NvZGUgPSBwYXRjaF9h cHBseV9wcm9jZXNzLndhaXQoKQogICAgICAgICBpZiByZXR1cm5fY29kZToKLSAgICAgICAgICAg IHJhaXNlIFNjcmlwdEVycm9yKCJQYXRjaCAiICsgcGF0Y2hbJ3VybCddICsgIiBmYWlsZWQgdG8g ZG93bmxvYWQgYW5kIGFwcGx5LiIpCisgICAgICAgICAgICByYWlzZSBTY3JpcHRFcnJvcigiUGF0 Y2ggJXMgZnJvbSBidWcgJXMgZmFpbGVkIHRvIGRvd25sb2FkIGFuZCBhcHBseS4iICUgKHBhdGNo Wyd1cmwnXSwgcGF0Y2hbJ2J1Z19pZCddKSkKIAogICAgIGRlZiBydW5fc3RhdHVzX2FuZF9leHRy YWN0X2ZpbGVuYW1lcyhzZWxmLCBzdGF0dXNfY29tbWFuZCwgc3RhdHVzX3JlZ2V4cCk6CiAgICAg ICAgIGZpbGVuYW1lcyA9IFtd