<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>269985</bug_id>
          
          <creation_ts>2024-02-23 05:38:11 -0800</creation_ts>
          <short_desc>Cache reftest screenshots</short_desc>
          <delta_ts>2024-02-23 05:38:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>203784</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Sneddon [:gsnedders]">gsnedders</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2016363</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2024-02-23 05:38:11 -0800</bug_when>
    <thetext>Once we are finding reftests via rel=match, we can then have multiple tests using the same reference URL.

There&apos;s no reason to load the same reference URL hundreds (or even thousands, in the most common case!) of times.

e.g. ref-filled-green-100px-square.xht is used &gt;2k times; if we assume loading and doing the screenshot takes 25ms each time, then almost a minute is spent just taking screenshots of that URL.

Actually caching screenshots probably also would significantly decrease the cost of importing css/CSS2 (Bug 209735), as CSS2 counts for a large percentage of all reftests in WPT.

My initial inclination would be to cache per test runner worker (as this avoids having to synchronise caches).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2016364</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-02-23 05:38:18 -0800</bug_when>
    <thetext>&lt;rdar://problem/123504651&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>