<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>269878</bug_id>
          
          <creation_ts>2024-02-21 15:42:16 -0800</creation_ts>
          <short_desc>baseline-shift initial value should be `0px` rather than `baseline`</short_desc>
          <delta_ts>2024-02-28 15:43:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=250012</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, WPTImpact</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ahmad Saleem">ahmad.saleem792</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>karlcow</cc>
    
    <cc>ntim</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2015902</commentid>
    <comment_count>0</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2024-02-21 15:42:16 -0800</bug_when>
    <thetext>Hi Team,

As title says, this bug is to fix baseline-shift initial value as per CSS spec.

NOTE - It was in SVG spec but now getting removed in SVG2 but it is in CSS Inline spec, which should be followed.

Old SVG1.1 - https://www.w3.org/TR/SVG11/text.html#BaselineShiftProperty

SVG2 (SVGWG) - https://svgwg.org/svg2-draft/text.html#BaselineShiftProperty

&quot;SVG 2 will deprecate ‘baseline-shift’ and use ‘vertical-align’ instead.&quot;

CSS Spec - https://drafts.csswg.org/css-inline-3/#baseline-shift-property

WPT Test - https://wpt.fyi/results/css/css-inline/inheritance.html?label=master&amp;label=experimental&amp;aligned

&gt; Property baseline-shift has initial value 0px	

__

It is easy to fix by modifying:

&gt; Source/WebCore/rendering/style/SVGRenderStyle.h

From: static BaselineShift initialBaselineShift() { return BaselineShift::Baseline; }

To: static BaselineShift initialBaselineShift() { return BaselineShift::Length; }

and

From: static SVGLengthValue initialBaselineShiftValue() { return SVGLengthValue(0, SVGLengthType::Number); }

To: static SVGLengthValue initialBaselineShiftValue() { return SVGLengthValue(0, SVGLengthType::Pixels); }

__

Any input is welcome.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2015908</commentid>
    <comment_count>1</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2024-02-21 16:28:29 -0800</bug_when>
    <thetext>Web-Spec: https://drafts.csswg.org/css-inline-3/#property-index</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2015911</commentid>
    <comment_count>2</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2024-02-21 16:37:55 -0800</bug_when>
    <thetext>Draft PR - https://github.com/WebKit/WebKit/pull/24908</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2017616</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-02-28 15:43:30 -0800</bug_when>
    <thetext>&lt;rdar://problem/123792212&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>