26976 2009-07-05 04:05:36 -0700 WebInspector: suggest global properties based on async evaluation. 2009-07-06 13:48:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 pfeldman webkit-unassigned eric timothy oldest_to_newest 129841 0 pfeldman 2009-07-05 04:05:36 -0700 At the moment, empty string was evaluated to the global object (or scope chain objects) synchronously. This is not in line with the rest of the code and needs to be fixed for the real serialized evaluation. 129843 1 32271 pfeldman 2009-07-05 04:09:17 -0700 Created attachment 32271 Patch with the fix 129852 2 32272 pfeldman 2009-07-05 05:43:42 -0700 Created attachment 32272 Patch with the fix 129853 3 32273 pfeldman 2009-07-05 05:46:07 -0700 Created attachment 32273 Patch with the fix 130000 4 eric 2009-07-06 13:48:49 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Console.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r45562 32271 2009-07-05 04:09:17 -0700 2009-07-05 05:46:07 -0700 Patch with the fix eval_global.patch text/plain 4463 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjcyNzg1YS4uZjliM2FjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wNy0wNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWJJbnNwZWN0b3I6IHN1Z2dlc3QgZ2xvYmFsIHByb3BlcnRp ZXMgYmFzZWQgb24gYXN5bmMgZXZhbHVhdGlvbi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5NzYKKworICAgICAgICBCZWZvcmUgdGhpcyBjaGFu Z2UsIGVtcHR5IHN0cmluZyB3YXMgZXZhbHVhdGVkIHRvIHRoZSBnbG9iYWwgb2JqZWN0CisgICAg ICAgIChvciBzY29wZSBjaGFpbiBvYmplY3QpIHN5bmNocm9ub3VzbHkuIFRoaXMgaXMgbm93IGZp eGVkIGFuZCBnbG9iYWwKKyAgICAgICAgb2JqZWN0IGlzIGV2YWx1YXRlZCB1c2luZyB0aGUgc2Ft ZSBjb250cm9sIGZsb3cuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUuY29tcGxldGlvbnMp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGUucHJvdG90eXBlLl9ldmFsSW5JbnNwZWN0 ZWRXaW5kb3cpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX3ZhcmlhYmxl c0luU2NvcGUpOgorCiAyMDA5LTA3LTA1ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZS5qcwppbmRleCBiY2UxNzg0Li5iMzQwNjFlIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQ29uc29sZS5qcwpAQCAtMjYwLDE2ICsyNjAsNyBAQCBXZWJJbnNwZWN0b3IuQ29u c29sZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgdmFyIHJl cG9ydENvbXBsZXRpb25zID0gdGhpcy5fcmVwb3J0Q29tcGxldGlvbnMuYmluZCh0aGlzLCBiZXN0 TWF0Y2hPbmx5LCBjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2ssIGRvdE5vdGF0aW9uLCBicmFja2V0 Tm90YXRpb24sIHByZWZpeCk7Ci0gICAgICAgIGlmIChleHByZXNzaW9uU3RyaW5nKSB7Ci0gICAg ICAgICAgICB0aGlzLl9ldmFsSW5JbnNwZWN0ZWRXaW5kb3coZXhwcmVzc2lvblN0cmluZywgcmVw b3J0Q29tcGxldGlvbnMpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8gVGhlcmUg aXMgbm8gZXhwcmVzc2lvblN0cmluZywgc28gdGhlIGNvbXBsZXRpb24gc2hvdWxkIGhhcHBlbiBh Z2FpbnN0IGdsb2JhbCBwcm9wZXJ0aWVzLgotICAgICAgICAgICAgLy8gT3IgaWYgdGhlIGRlYnVn Z2VyIGlzIHBhdXNlZCwgYWdhaW5zdCBwcm9wZXJ0aWVzIGluIHNjb3BlIG9mIHRoZSBzZWxlY3Rl ZCBjYWxsIGZyYW1lLgotICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0 cyAmJiBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMucGF1c2VkKQotICAgICAgICAgICAgICAg IHJlcG9ydENvbXBsZXRpb25zKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy52YXJpYWJsZXNJ blNjb3BlRm9yU2VsZWN0ZWRDYWxsRnJhbWUoKSk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAg ICAgICAgICAgcmVwb3J0Q29tcGxldGlvbnMoSW5zcGVjdG9yQ29udHJvbGxlci5pbnNwZWN0ZWRX aW5kb3coKSk7Ci0gICAgICAgIH0KKyAgICAgICAgdGhpcy5fZXZhbEluSW5zcGVjdGVkV2luZG93 KGV4cHJlc3Npb25TdHJpbmcsIHJlcG9ydENvbXBsZXRpb25zKTsKICAgICB9LAogICAgIAogICAg IF9yZXBvcnRDb21wbGV0aW9uczogZnVuY3Rpb24oYmVzdE1hdGNoT25seSwgY29tcGxldGlvbnNS ZWFkeUNhbGxiYWNrLCBkb3ROb3RhdGlvbiwgYnJhY2tldE5vdGF0aW9uLCBwcmVmaXgsIHJlc3Vs dCkgewpAQCAtMzk3LDcgKzM4OCw2IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5ldmFsdWF0ZUluU2Vs ZWN0ZWRDYWxsRnJhbWUoZXhwcmVzc2lvbiwgZmFsc2UsIGNhbGxiYWNrKTsKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQotCiAgICAgICAgIHRoaXMuZG9FdmFsSW5XaW5kb3coZXhwcmVz c2lvbiwgY2FsbGJhY2spOwogICAgIH0sCiAgICAgCkBAIC00MzEsNiArNDIxLDExIEBAIFdlYklu c3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZSA9IHsKICAgICAKICAgICBkb0V2YWxJbldpbmRvdzog ZnVuY3Rpb24oZXhwcmVzc2lvbiwgY2FsbGJhY2spCiAgICAgeworICAgICAgICBpZiAoIWV4cHJl c3Npb24pIHsKKyAgICAgICAgICAgIC8vIFRoZXJlIGlzIG5vIGV4cHJlc3Npb24sIHNvIHRoZSBj b21wbGV0aW9uIHNob3VsZCBoYXBwZW4gYWdhaW5zdCBnbG9iYWwgcHJvcGVydGllcy4KKyAgICAg ICAgICAgIGV4cHJlc3Npb24gPSAidGhpcyI7CisgICAgICAgIH0KKwogICAgICAgICAvLyBTdXJy b3VuZCB0aGUgZXhwcmVzc2lvbiBpbiB3aXRoIHN0YXRlbWVudHMgdG8gaW5qZWN0IG91ciBjb21t YW5kIGxpbmUgQVBJIHNvIHRoYXQKICAgICAgICAgLy8gdGhlIHdpbmRvdyBvYmplY3QgcHJvcGVy dGllcyBzdGlsbCB0YWtlIG1vcmUgcHJlY2VkZW50IHRoYW4gb3VyIEFQSSBmdW5jdGlvbnMuCiAg ICAgICAgIGV4cHJlc3Npb24gPSAid2l0aCAod2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQ SSkgeyB3aXRoICh3aW5kb3cpIHsgIiArIGV4cHJlc3Npb24gKyAiIH0gfSI7CmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCBmM2Y0NTNmLi44MWRjNDhj IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz CisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAgLTM3 MCw2ICszNzAsMTIgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUgPSB7CiAK ICAgICBkb0V2YWxJbkNhbGxGcmFtZTogZnVuY3Rpb24oY2FsbEZyYW1lLCBjb2RlLCBjYWxsYmFj aykKICAgICB7CisgICAgICAgIGlmICghY29kZSkgeworICAgICAgICAgICAgLy8gRXZhbHVhdGUg YWdhaW5zdCBwcm9wZXJ0aWVzIGluIHNjb3BlIG9mIHRoZSBzZWxlY3RlZCBjYWxsIGZyYW1lLgor ICAgICAgICAgICAgc2V0VGltZW91dChjYWxsYmFjay5iaW5kKHRoaXMuX3ZhcmlhYmxlc0luU2Nv cGUoY2FsbEZyYW1lKSwgZmFsc2UpLCAwKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg fQorCiAgICAgICAgIGZ1bmN0aW9uIGRlbGF5ZWRFdmFsdWF0aW9uKCkKICAgICAgICAgewogICAg ICAgICAgICAgdHJ5IHsKQEAgLTM4MSwyMCArMzg3LDE1IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRz UGFuZWwucHJvdG90eXBlID0gewogICAgICAgICBzZXRUaW1lb3V0KGRlbGF5ZWRFdmFsdWF0aW9u LCAwKTsKICAgICB9LAogCi0gICAgdmFyaWFibGVzSW5TY29wZUZvclNlbGVjdGVkQ2FsbEZyYW1l OiBmdW5jdGlvbigpCisgICAgX3ZhcmlhYmxlc0luU2NvcGU6IGZ1bmN0aW9uKGNhbGxGcmFtZSkK ICAgICB7Ci0gICAgICAgIHZhciBzZWxlY3RlZENhbGxGcmFtZSA9IHRoaXMuc2lkZWJhclBhbmVz LmNhbGxzdGFjay5zZWxlY3RlZENhbGxGcmFtZTsKLSAgICAgICAgaWYgKCF0aGlzLl9wYXVzZWQg fHwgIXNlbGVjdGVkQ2FsbEZyYW1lKQotICAgICAgICAgICAgcmV0dXJuIHt9OwotCiAgICAgICAg IHZhciByZXN1bHQgPSB7fTsKLSAgICAgICAgdmFyIHNjb3BlQ2hhaW4gPSBzZWxlY3RlZENhbGxG cmFtZS5zY29wZUNoYWluOworICAgICAgICB2YXIgc2NvcGVDaGFpbiA9IGNhbGxGcmFtZS5zY29w ZUNoYWluOwogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHNjb3BlQ2hhaW4ubGVuZ3RoOyAr K2kpIHsKICAgICAgICAgICAgIHZhciBzY29wZU9iamVjdCA9IHNjb3BlQ2hhaW5baV07CiAgICAg ICAgICAgICBmb3IgKHZhciBwcm9wZXJ0eSBpbiBzY29wZU9iamVjdCkKICAgICAgICAgICAgICAg ICByZXN1bHRbcHJvcGVydHldID0gdHJ1ZTsKICAgICAgICAgfQotCiAgICAgICAgIHJldHVybiBy ZXN1bHQ7CiAgICAgfSwKIAo= 32272 2009-07-05 05:43:42 -0700 2009-07-05 05:46:07 -0700 Patch with the fix eval_global.patch application/octet-stream 4559 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjcyNzg1YS4uZjliM2FjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wNy0wNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWJJbnNwZWN0b3I6IHN1Z2dlc3QgZ2xvYmFsIHByb3BlcnRp ZXMgYmFzZWQgb24gYXN5bmMgZXZhbHVhdGlvbi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5NzYKKworICAgICAgICBCZWZvcmUgdGhpcyBjaGFu Z2UsIGVtcHR5IHN0cmluZyB3YXMgZXZhbHVhdGVkIHRvIHRoZSBnbG9iYWwgb2JqZWN0CisgICAg ICAgIChvciBzY29wZSBjaGFpbiBvYmplY3QpIHN5bmNocm9ub3VzbHkuIFRoaXMgaXMgbm93IGZp eGVkIGFuZCBnbG9iYWwKKyAgICAgICAgb2JqZWN0IGlzIGV2YWx1YXRlZCB1c2luZyB0aGUgc2Ft ZSBjb250cm9sIGZsb3cuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUuY29tcGxldGlvbnMp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGUucHJvdG90eXBlLl9ldmFsSW5JbnNwZWN0 ZWRXaW5kb3cpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX3ZhcmlhYmxl c0luU2NvcGUpOgorCiAyMDA5LTA3LTA1ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZS5qcwppbmRleCBiY2UxNzg0Li5iMzQwNjFlIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQ29uc29sZS5qcwpAQCAtMjYwLDE2ICsyNjAsNyBAQCBXZWJJbnNwZWN0b3IuQ29u c29sZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgdmFyIHJl cG9ydENvbXBsZXRpb25zID0gdGhpcy5fcmVwb3J0Q29tcGxldGlvbnMuYmluZCh0aGlzLCBiZXN0 TWF0Y2hPbmx5LCBjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2ssIGRvdE5vdGF0aW9uLCBicmFja2V0 Tm90YXRpb24sIHByZWZpeCk7Ci0gICAgICAgIGlmIChleHByZXNzaW9uU3RyaW5nKSB7Ci0gICAg ICAgICAgICB0aGlzLl9ldmFsSW5JbnNwZWN0ZWRXaW5kb3coZXhwcmVzc2lvblN0cmluZywgcmVw b3J0Q29tcGxldGlvbnMpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8gVGhlcmUg aXMgbm8gZXhwcmVzc2lvblN0cmluZywgc28gdGhlIGNvbXBsZXRpb24gc2hvdWxkIGhhcHBlbiBh Z2FpbnN0IGdsb2JhbCBwcm9wZXJ0aWVzLgotICAgICAgICAgICAgLy8gT3IgaWYgdGhlIGRlYnVn Z2VyIGlzIHBhdXNlZCwgYWdhaW5zdCBwcm9wZXJ0aWVzIGluIHNjb3BlIG9mIHRoZSBzZWxlY3Rl ZCBjYWxsIGZyYW1lLgotICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0 cyAmJiBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMucGF1c2VkKQotICAgICAgICAgICAgICAg IHJlcG9ydENvbXBsZXRpb25zKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy52YXJpYWJsZXNJ blNjb3BlRm9yU2VsZWN0ZWRDYWxsRnJhbWUoKSk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAg ICAgICAgICAgcmVwb3J0Q29tcGxldGlvbnMoSW5zcGVjdG9yQ29udHJvbGxlci5pbnNwZWN0ZWRX aW5kb3coKSk7Ci0gICAgICAgIH0KKyAgICAgICAgdGhpcy5fZXZhbEluSW5zcGVjdGVkV2luZG93 KGV4cHJlc3Npb25TdHJpbmcsIHJlcG9ydENvbXBsZXRpb25zKTsKICAgICB9LAogICAgIAogICAg IF9yZXBvcnRDb21wbGV0aW9uczogZnVuY3Rpb24oYmVzdE1hdGNoT25seSwgY29tcGxldGlvbnNS ZWFkeUNhbGxiYWNrLCBkb3ROb3RhdGlvbiwgYnJhY2tldE5vdGF0aW9uLCBwcmVmaXgsIHJlc3Vs dCkgewpAQCAtMzk3LDcgKzM4OCw2IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5ldmFsdWF0ZUluU2Vs ZWN0ZWRDYWxsRnJhbWUoZXhwcmVzc2lvbiwgZmFsc2UsIGNhbGxiYWNrKTsKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQotCiAgICAgICAgIHRoaXMuZG9FdmFsSW5XaW5kb3coZXhwcmVz c2lvbiwgY2FsbGJhY2spOwogICAgIH0sCiAgICAgCkBAIC00MzEsNiArNDIxLDExIEBAIFdlYklu c3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZSA9IHsKICAgICAKICAgICBkb0V2YWxJbldpbmRvdzog ZnVuY3Rpb24oZXhwcmVzc2lvbiwgY2FsbGJhY2spCiAgICAgeworICAgICAgICBpZiAoIWV4cHJl c3Npb24pIHsKKyAgICAgICAgICAgIC8vIFRoZXJlIGlzIG5vIGV4cHJlc3Npb24sIHNvIHRoZSBj b21wbGV0aW9uIHNob3VsZCBoYXBwZW4gYWdhaW5zdCBnbG9iYWwgcHJvcGVydGllcy4KKyAgICAg ICAgICAgIGV4cHJlc3Npb24gPSAidGhpcyI7CisgICAgICAgIH0KKwogICAgICAgICAvLyBTdXJy b3VuZCB0aGUgZXhwcmVzc2lvbiBpbiB3aXRoIHN0YXRlbWVudHMgdG8gaW5qZWN0IG91ciBjb21t YW5kIGxpbmUgQVBJIHNvIHRoYXQKICAgICAgICAgLy8gdGhlIHdpbmRvdyBvYmplY3QgcHJvcGVy dGllcyBzdGlsbCB0YWtlIG1vcmUgcHJlY2VkZW50IHRoYW4gb3VyIEFQSSBmdW5jdGlvbnMuCiAg ICAgICAgIGV4cHJlc3Npb24gPSAid2l0aCAod2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQ SSkgeyB3aXRoICh3aW5kb3cpIHsgIiArIGV4cHJlc3Npb24gKyAiIH0gfSI7CmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCBmM2Y0NTNmLi41NmI3MGNm IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz CisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAgLTM3 MCw4ICszNzAsMTQgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUgPSB7CiAK ICAgICBkb0V2YWxJbkNhbGxGcmFtZTogZnVuY3Rpb24oY2FsbEZyYW1lLCBjb2RlLCBjYWxsYmFj aykKICAgICB7CisgICAgICAgIHZhciBwYW5lbCA9IHRoaXM7CiAgICAgICAgIGZ1bmN0aW9uIGRl bGF5ZWRFdmFsdWF0aW9uKCkKICAgICAgICAgeworICAgICAgICAgICAgaWYgKCFjb2RlKSB7Cisg ICAgICAgICAgICAgICAgLy8gRXZhbHVhdGUgaW50byBwcm9wZXJ0aWVzIGluIHNjb3BlIG9mIHRo ZSBzZWxlY3RlZCBjYWxsIGZyYW1lLgorICAgICAgICAgICAgICAgIGNhbGxiYWNrKHBhbmVsLl92 YXJpYWJsZXNJblNjb3BlKGNhbGxGcmFtZSkpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgICAgIH0KICAgICAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICAgICAgY2FsbGJhY2so Y2FsbEZyYW1lLmV2YWx1YXRlKGNvZGUpKTsKICAgICAgICAgICAgIH0gY2F0Y2ggKGUpIHsKQEAg LTM4MSwyMCArMzg3LDE1IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBlID0g ewogICAgICAgICBzZXRUaW1lb3V0KGRlbGF5ZWRFdmFsdWF0aW9uLCAwKTsKICAgICB9LAogCi0g ICAgdmFyaWFibGVzSW5TY29wZUZvclNlbGVjdGVkQ2FsbEZyYW1lOiBmdW5jdGlvbigpCisgICAg X3ZhcmlhYmxlc0luU2NvcGU6IGZ1bmN0aW9uKGNhbGxGcmFtZSkKICAgICB7Ci0gICAgICAgIHZh ciBzZWxlY3RlZENhbGxGcmFtZSA9IHRoaXMuc2lkZWJhclBhbmVzLmNhbGxzdGFjay5zZWxlY3Rl ZENhbGxGcmFtZTsKLSAgICAgICAgaWYgKCF0aGlzLl9wYXVzZWQgfHwgIXNlbGVjdGVkQ2FsbEZy YW1lKQotICAgICAgICAgICAgcmV0dXJuIHt9OwotCiAgICAgICAgIHZhciByZXN1bHQgPSB7fTsK LSAgICAgICAgdmFyIHNjb3BlQ2hhaW4gPSBzZWxlY3RlZENhbGxGcmFtZS5zY29wZUNoYWluOwor ICAgICAgICB2YXIgc2NvcGVDaGFpbiA9IGNhbGxGcmFtZS5zY29wZUNoYWluOwogICAgICAgICBm b3IgKHZhciBpID0gMDsgaSA8IHNjb3BlQ2hhaW4ubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAg IHZhciBzY29wZU9iamVjdCA9IHNjb3BlQ2hhaW5baV07CiAgICAgICAgICAgICBmb3IgKHZhciBw cm9wZXJ0eSBpbiBzY29wZU9iamVjdCkKICAgICAgICAgICAgICAgICByZXN1bHRbcHJvcGVydHld ID0gdHJ1ZTsKICAgICAgICAgfQotCiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfSwKIAo= 32273 2009-07-05 05:46:07 -0700 2009-07-05 05:47:32 -0700 Patch with the fix eval_global.patch text/plain 4559 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjcyNzg1YS4uZjliM2FjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wNy0wNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWJJbnNwZWN0b3I6IHN1Z2dlc3QgZ2xvYmFsIHByb3BlcnRp ZXMgYmFzZWQgb24gYXN5bmMgZXZhbHVhdGlvbi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5NzYKKworICAgICAgICBCZWZvcmUgdGhpcyBjaGFu Z2UsIGVtcHR5IHN0cmluZyB3YXMgZXZhbHVhdGVkIHRvIHRoZSBnbG9iYWwgb2JqZWN0CisgICAg ICAgIChvciBzY29wZSBjaGFpbiBvYmplY3QpIHN5bmNocm9ub3VzbHkuIFRoaXMgaXMgbm93IGZp eGVkIGFuZCBnbG9iYWwKKyAgICAgICAgb2JqZWN0IGlzIGV2YWx1YXRlZCB1c2luZyB0aGUgc2Ft ZSBjb250cm9sIGZsb3cuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5cGUuY29tcGxldGlvbnMp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGUucHJvdG90eXBlLl9ldmFsSW5JbnNwZWN0 ZWRXaW5kb3cpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX3ZhcmlhYmxl c0luU2NvcGUpOgorCiAyMDA5LTA3LTA1ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZS5qcwppbmRleCBiY2UxNzg0Li5iMzQwNjFlIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQ29uc29sZS5qcwpAQCAtMjYwLDE2ICsyNjAsNyBAQCBXZWJJbnNwZWN0b3IuQ29u c29sZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgdmFyIHJl cG9ydENvbXBsZXRpb25zID0gdGhpcy5fcmVwb3J0Q29tcGxldGlvbnMuYmluZCh0aGlzLCBiZXN0 TWF0Y2hPbmx5LCBjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2ssIGRvdE5vdGF0aW9uLCBicmFja2V0 Tm90YXRpb24sIHByZWZpeCk7Ci0gICAgICAgIGlmIChleHByZXNzaW9uU3RyaW5nKSB7Ci0gICAg ICAgICAgICB0aGlzLl9ldmFsSW5JbnNwZWN0ZWRXaW5kb3coZXhwcmVzc2lvblN0cmluZywgcmVw b3J0Q29tcGxldGlvbnMpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8gVGhlcmUg aXMgbm8gZXhwcmVzc2lvblN0cmluZywgc28gdGhlIGNvbXBsZXRpb24gc2hvdWxkIGhhcHBlbiBh Z2FpbnN0IGdsb2JhbCBwcm9wZXJ0aWVzLgotICAgICAgICAgICAgLy8gT3IgaWYgdGhlIGRlYnVn Z2VyIGlzIHBhdXNlZCwgYWdhaW5zdCBwcm9wZXJ0aWVzIGluIHNjb3BlIG9mIHRoZSBzZWxlY3Rl ZCBjYWxsIGZyYW1lLgotICAgICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0 cyAmJiBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMucGF1c2VkKQotICAgICAgICAgICAgICAg IHJlcG9ydENvbXBsZXRpb25zKFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy52YXJpYWJsZXNJ blNjb3BlRm9yU2VsZWN0ZWRDYWxsRnJhbWUoKSk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAg ICAgICAgICAgcmVwb3J0Q29tcGxldGlvbnMoSW5zcGVjdG9yQ29udHJvbGxlci5pbnNwZWN0ZWRX aW5kb3coKSk7Ci0gICAgICAgIH0KKyAgICAgICAgdGhpcy5fZXZhbEluSW5zcGVjdGVkV2luZG93 KGV4cHJlc3Npb25TdHJpbmcsIHJlcG9ydENvbXBsZXRpb25zKTsKICAgICB9LAogICAgIAogICAg IF9yZXBvcnRDb21wbGV0aW9uczogZnVuY3Rpb24oYmVzdE1hdGNoT25seSwgY29tcGxldGlvbnNS ZWFkeUNhbGxiYWNrLCBkb3ROb3RhdGlvbiwgYnJhY2tldE5vdGF0aW9uLCBwcmVmaXgsIHJlc3Vs dCkgewpAQCAtMzk3LDcgKzM4OCw2IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5ldmFsdWF0ZUluU2Vs ZWN0ZWRDYWxsRnJhbWUoZXhwcmVzc2lvbiwgZmFsc2UsIGNhbGxiYWNrKTsKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQotCiAgICAgICAgIHRoaXMuZG9FdmFsSW5XaW5kb3coZXhwcmVz c2lvbiwgY2FsbGJhY2spOwogICAgIH0sCiAgICAgCkBAIC00MzEsNiArNDIxLDExIEBAIFdlYklu c3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZSA9IHsKICAgICAKICAgICBkb0V2YWxJbldpbmRvdzog ZnVuY3Rpb24oZXhwcmVzc2lvbiwgY2FsbGJhY2spCiAgICAgeworICAgICAgICBpZiAoIWV4cHJl c3Npb24pIHsKKyAgICAgICAgICAgIC8vIFRoZXJlIGlzIG5vIGV4cHJlc3Npb24sIHNvIHRoZSBj b21wbGV0aW9uIHNob3VsZCBoYXBwZW4gYWdhaW5zdCBnbG9iYWwgcHJvcGVydGllcy4KKyAgICAg ICAgICAgIGV4cHJlc3Npb24gPSAidGhpcyI7CisgICAgICAgIH0KKwogICAgICAgICAvLyBTdXJy b3VuZCB0aGUgZXhwcmVzc2lvbiBpbiB3aXRoIHN0YXRlbWVudHMgdG8gaW5qZWN0IG91ciBjb21t YW5kIGxpbmUgQVBJIHNvIHRoYXQKICAgICAgICAgLy8gdGhlIHdpbmRvdyBvYmplY3QgcHJvcGVy dGllcyBzdGlsbCB0YWtlIG1vcmUgcHJlY2VkZW50IHRoYW4gb3VyIEFQSSBmdW5jdGlvbnMuCiAg ICAgICAgIGV4cHJlc3Npb24gPSAid2l0aCAod2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQ SSkgeyB3aXRoICh3aW5kb3cpIHsgIiArIGV4cHJlc3Npb24gKyAiIH0gfSI7CmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCBmM2Y0NTNmLi41NmI3MGNm IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz CisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAgLTM3 MCw4ICszNzAsMTQgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUgPSB7CiAK ICAgICBkb0V2YWxJbkNhbGxGcmFtZTogZnVuY3Rpb24oY2FsbEZyYW1lLCBjb2RlLCBjYWxsYmFj aykKICAgICB7CisgICAgICAgIHZhciBwYW5lbCA9IHRoaXM7CiAgICAgICAgIGZ1bmN0aW9uIGRl bGF5ZWRFdmFsdWF0aW9uKCkKICAgICAgICAgeworICAgICAgICAgICAgaWYgKCFjb2RlKSB7Cisg ICAgICAgICAgICAgICAgLy8gRXZhbHVhdGUgaW50byBwcm9wZXJ0aWVzIGluIHNjb3BlIG9mIHRo ZSBzZWxlY3RlZCBjYWxsIGZyYW1lLgorICAgICAgICAgICAgICAgIGNhbGxiYWNrKHBhbmVsLl92 YXJpYWJsZXNJblNjb3BlKGNhbGxGcmFtZSkpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgICAgIH0KICAgICAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICAgICAgY2FsbGJhY2so Y2FsbEZyYW1lLmV2YWx1YXRlKGNvZGUpKTsKICAgICAgICAgICAgIH0gY2F0Y2ggKGUpIHsKQEAg LTM4MSwyMCArMzg3LDE1IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBlID0g ewogICAgICAgICBzZXRUaW1lb3V0KGRlbGF5ZWRFdmFsdWF0aW9uLCAwKTsKICAgICB9LAogCi0g ICAgdmFyaWFibGVzSW5TY29wZUZvclNlbGVjdGVkQ2FsbEZyYW1lOiBmdW5jdGlvbigpCisgICAg X3ZhcmlhYmxlc0luU2NvcGU6IGZ1bmN0aW9uKGNhbGxGcmFtZSkKICAgICB7Ci0gICAgICAgIHZh ciBzZWxlY3RlZENhbGxGcmFtZSA9IHRoaXMuc2lkZWJhclBhbmVzLmNhbGxzdGFjay5zZWxlY3Rl ZENhbGxGcmFtZTsKLSAgICAgICAgaWYgKCF0aGlzLl9wYXVzZWQgfHwgIXNlbGVjdGVkQ2FsbEZy YW1lKQotICAgICAgICAgICAgcmV0dXJuIHt9OwotCiAgICAgICAgIHZhciByZXN1bHQgPSB7fTsK LSAgICAgICAgdmFyIHNjb3BlQ2hhaW4gPSBzZWxlY3RlZENhbGxGcmFtZS5zY29wZUNoYWluOwor ICAgICAgICB2YXIgc2NvcGVDaGFpbiA9IGNhbGxGcmFtZS5zY29wZUNoYWluOwogICAgICAgICBm b3IgKHZhciBpID0gMDsgaSA8IHNjb3BlQ2hhaW4ubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAg IHZhciBzY29wZU9iamVjdCA9IHNjb3BlQ2hhaW5baV07CiAgICAgICAgICAgICBmb3IgKHZhciBw cm9wZXJ0eSBpbiBzY29wZU9iamVjdCkKICAgICAgICAgICAgICAgICByZXN1bHRbcHJvcGVydHld ID0gdHJ1ZTsKICAgICAgICAgfQotCiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfSwKIAo=