<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26969</bug_id>
          
          <creation_ts>2009-07-04 12:28:13 -0700</creation_ts>
          <short_desc>Fix ASSERT in WebCore::DocumentThreadableLoader::didFail</short_desc>
          <delta_ts>2009-08-12 19:59:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Robert Hogan">robert</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>eric</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>yael</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>129801</commentid>
    <comment_count>0</comment_count>
      <attachid>32259</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2009-07-04 12:28:13 -0700</bug_when>
    <thetext>Created attachment 32259
backtrace

Following the instructions at  http://meyerhome.net/~ben/frametest/ (see https://bugs.webkit.org/show_bug.cgi?id=25283) results in hitting an assert in WebCore::DocumentThreadableLoader::didFail.

The problem is that DocumentThreadableLoader calls WebCore::SubresourceLoader::create with a request containing an &quot;OPTIONS&quot; httpMethod() (set in WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight) . This method is not supported by QNetworkReplyHandler, which then calls didFail(). This call returns it to DocumentThreadableLoader::didFail, where of course the m_loader object is still null, since it is still being created.

I think didFail() should expect to handle calls when the m_loader object is still null. The m_loader object is inaccessible to QNetworkReplyHandler and it seems reasonable to call didFail() if the http method is not supported and therefore request has failed.

The following works for me:

void DocumentThreadableLoader::didFail(SubresourceLoader* loader, const ResourceError&amp; error)
{
    ASSERT(m_client);
    // If the httpMethod() of the request passed to SubresourceLoader::create is not supported by
    // the client we must expect to call didFail() while m_loader is still null.
    ASSERT_UNUSED(loader, loader == m_loader || !m_loader);

    m_client-&gt;didFail(error);
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129802</commentid>
    <comment_count>1</comment_count>
      <attachid>32260</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2009-07-04 12:35:44 -0700</bug_when>
    <thetext>Created attachment 32260
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129812</commentid>
    <comment_count>2</comment_count>
      <attachid>32260</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2009-07-04 15:40:01 -0700</bug_when>
    <thetext>Comment on attachment 32260
proposed patch

r=me

I would advise making the comment a bit shorter if possible. I don&apos;t think mentioning the bug number in the code is necessary, as long as it&apos;s in the ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129813</commentid>
    <comment_count>3</comment_count>
      <attachid>32263</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2009-07-04 15:53:10 -0700</bug_when>
    <thetext>Created attachment 32263
patch updated with shorter inline comment</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129814</commentid>
    <comment_count>4</comment_count>
      <attachid>32263</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2009-07-04 15:57:45 -0700</bug_when>
    <thetext>Comment on attachment 32263
patch updated with shorter inline comment

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129984</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-06 13:26:31 -0700</bug_when>
    <thetext>The ChangeLog line is wrong:

2009-07-04  Robert Hogan &lt;robert@roberthogan.net)

The script would have left 2 spaces between your name and &lt; and would have closed the email address with a &gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>130020</commentid>
    <comment_count>6</comment_count>
      <attachid>32325</attachid>
    <who name="Robert Hogan">robert</who>
    <bug_when>2009-07-06 14:27:34 -0700</bug_when>
    <thetext>Created attachment 32325
updated changelog

oh gack - i&apos;m using git so have been creating the changelog entries manually, a strategy that is clearly paying dividends.. :-/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>130022</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-06 14:31:42 -0700</bug_when>
    <thetext>prepare-ChangeLog works fine with git.  it even has some git-specific options:
prepare-ChangeLog --help
prepare-ChangeLog [-d|--diff] [-h|--help] [-o|--open] [--git-commit=&lt;committish&gt;] [--git-reviewer=&lt;name&gt;] [svndir1 [svndir2 ...]]
  -d|--diff      Spew diff to stdout when running
  --git-commit   Populate the ChangeLogs from the specified git commit
  --git-index    Populate the ChangeLogs from the git index only
  --git-reviewer When populating the ChangeLogs from a git commit claim that the spcified name reviewed the change.
                 This option is useful when the git commit lacks a Signed-Off-By: line
  -h|--help      Show this help message
  -o|--open      Open ChangeLogs in an editor when done
  --[no-]update  Update ChangeLogs from svn before adding entry (default: update)

commit-log-editor also works with git as well. :)

resolve-ChangeLogs -f
is helpful for when git mis-merges ChangeLogs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>130139</commentid>
    <comment_count>8</comment_count>
      <attachid>32325</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-07 00:14:46 -0700</bug_when>
    <thetext>Comment on attachment 32325
updated changelog

We normally use full english words, like &quot;Constructor&quot; instead of ctor.

This looks fine.  I assume this fails on the Qt or Gtk builds?  In which case it would have made sense to make a layout test for them.  I will OK it as is though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>130424</commentid>
    <comment_count>9</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-07-08 07:07:07 -0700</bug_when>
    <thetext>From the bug description, it seems that existing layout tests for cross-origin XMLHttpRequest may trigger this crash on platforms that don&apos;t support OPTIONS method.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>131995</commentid>
    <comment_count>10</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2009-07-15 12:17:38 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/45935.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139709</commentid>
    <comment_count>11</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2009-08-12 19:59:40 -0700</bug_when>
    <thetext>*** Bug 28242 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>32259</attachid>
            <date>2009-07-04 12:28:13 -0700</date>
            <delta_ts>2009-07-04 12:28:13 -0700</delta_ts>
            <desc>backtrace</desc>
            <filename>didfail-bt.txt</filename>
            <type>text/plain</type>
            <size>9575</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">Z2RiIC9ob21lL3JvYmVydC9EZXZlbG9wbWVudC9hcm9yYS9hcm9yYSAtLWludGVycHJldGVyPW1p
MiAtcXVpZXQKRXhpdGVkIG5vcm1hbGx5KGdkYikgcXVpdGdkYiAvaG9tZS9yb2JlcnQvRGV2ZWxv
cG1lbnQvYXJvcmEvYXJvcmEgLS1pbnRlcnByZXRlcj1taTIgLXF1aWV0CihnZGIpIHAgci5odHRw
TWV0aG9kKCkKcCByLmh0dHBNZXRob2QoKQokMzgzID0gKGNvbnN0IFdlYkNvcmU6OlN0cmluZyAm
KSBAMHg5ZGJjYTYwOiB7bV9pbXBsID0gezxXVEY6OkZhc3RBbGxvY0Jhc2U+ID0gezxObyBkYXRh
IGZpZWxkcz59LCBtX3B0ciA9IDB4OWRiZGRmOH19Cl5kb25lKGdkYikgYnQKYnQKIzAgIDB4Yjc0
MWVkMTMgaW4gV2ViQ29yZTo6RG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyOjpkaWRGYWlsICh0aGlz
PTB4YTAyZWUzOCwgbG9hZGVyPTB4OWRiZWRlMCwgZXJyb3I9QDB4YmY5NWQzNWMpIGF0IC4uLy4u
Ly4uL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHA6MTY3CiMxICAw
eGI3NDY2ZDkxIGluIFdlYkNvcmU6OlN1YnJlc291cmNlTG9hZGVyOjpkaWRGYWlsICh0aGlzPTB4
OWRiZWRlMCwgZXJyb3I9QDB4YmY5NWQzNWMpIGF0IC4uLy4uLy4uL1dlYkNvcmUvbG9hZGVyL1N1
YnJlc291cmNlTG9hZGVyLmNwcDoyMDMKIzIgIDB4Yjc0NjNmMDkgaW4gV2ViQ29yZTo6UmVzb3Vy
Y2VMb2FkZXI6OmRpZEZhaWwgKHRoaXM9MHg5ZGJlZGUwLCBlcnJvcj1AMHhiZjk1ZDM1YykgYXQg
Li4vLi4vLi4vV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOjQyNwojMyAgMHhiNzZk
ZjJjOCBpbiBXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6c3RhcnQgKHRoaXM9MHhhMDMz
Y2YwKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBs
eUhhbmRsZXIuY3BwOjM5NQojNCAgMHhiNzZkZmUxMSBpbiBRTmV0d29ya1JlcGx5SGFuZGxlciAo
dGhpcz0weGEwMzNjZjAsIGhhbmRsZT0weGEwMzNlYTgsIGxvYWRNb2RlPVdlYkNvcmU6OlFOZXR3
b3JrUmVwbHlIYW5kbGVyOjpMb2FkTm9ybWFsKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3BsYXRmb3Jt
L25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwOjE2MAojNSAgMHhiNzZkYjI2OCBp
biBXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQgKHRoaXM9MHhhMDMzZWE4LCBmcmFtZT0w
eDhhZmEzMTgpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJj
ZUhhbmRsZVF0LmNwcDoxMzcKIzYgIDB4Yjc1MzZlNzMgaW4gV2ViQ29yZTo6UmVzb3VyY2VIYW5k
bGU6OmNyZWF0ZSAocmVxdWVzdD1AMHhiZjk1ZDRmYywgY2xpZW50PTB4OWRiZWRlMCwgZnJhbWU9
MHg4YWZhMzE4LCBkZWZlcnNMb2FkaW5nPWZhbHNlLCBzaG91bGRDb250ZW50U25pZmY9ZmFsc2Us
IG1pZ2h0RG93bmxvYWRGcm9tSGFuZGxlPXRydWUpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcGxhdGZv
cm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5jcHA6NjUKIzcgIDB4Yjc0NjU1YTUgaW4gV2ViQ29y
ZTo6UmVzb3VyY2VMb2FkZXI6OmxvYWQgKHRoaXM9MHg5ZGJlZGUwLCByPUAweGJmOTVkNmFjKSBh
dCAuLi8uLi8uLi9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHA6MTMxCiM4ICAweGI3
NDY3ZmEwIGluIFdlYkNvcmU6OlN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUgKGZyYW1lPTB4OGFm
YTMxOCwgY2xpZW50PTB4YTAyZWU0NCwgcmVxdWVzdD1AMHhiZjk1ZDlkNCwgc2tpcENhbkxvYWRD
aGVjaz1mYWxzZSwgc2VuZFJlc291cmNlTG9hZENhbGxiYWNrcz1mYWxzZSwgc2hvdWxkQ29udGVu
dFNuaWZmPWZhbHNlKSBhdCAuLi8uLi8uLi9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRl
ci5jcHA6MTAxCiM5ICAweGI3NDFmYmM2IGluIERvY3VtZW50VGhyZWFkYWJsZUxvYWRlciAodGhp
cz0weGEwMmVlMzgsIGRvY3VtZW50PTB4OTFhM2UxMCwgY2xpZW50PTB4YTAzNDRmNCwgcmVxdWVz
dD1AMHhiZjk1ZDlkNCwgY2FsbGJhY2tzU2V0dGluZz1XZWJDb3JlOjpEb05vdFNlbmRMb2FkQ2Fs
bGJhY2tzLCBjb250ZW50U25pZmY9V2ViQ29yZTo6RG9Ob3RTbmlmZkNvbnRlbnQsIHN0b3JlZENy
ZWRlbnRpYWxzPVdlYkNvcmU6OkRvTm90QWxsb3dTdG9yZWRDcmVkZW50aWFscywgY3Jvc3NPcmln
aW5SZWRpcmVjdFBvbGljeT1XZWJDb3JlOjpEZW55Q3Jvc3NPcmlnaW5SZWRpcmVjdCkgYXQgLi4v
Li4vLi4vV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmNwcDoxMDAKIzEw
IDB4Yjc0MjAwNTkgaW4gV2ViQ29yZTo6RG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyOjpjcmVhdGUg
KGRvY3VtZW50PTB4OTFhM2UxMCwgY2xpZW50PTB4YTAzNDRmNCwgcmVxdWVzdD1AMHhiZjk1ZDlk
NCwgY2FsbGJhY2tzU2V0dGluZz1XZWJDb3JlOjpEb05vdFNlbmRMb2FkQ2FsbGJhY2tzLCBjb250
ZW50U25pZmY9V2ViQ29yZTo6RG9Ob3RTbmlmZkNvbnRlbnQsIHN0b3JlZENyZWRlbnRpYWxzPVdl
YkNvcmU6OkRvTm90QWxsb3dTdG9yZWRDcmVkZW50aWFscywgY3Jvc3NPcmlnaW5SZWRpcmVjdFBv
bGljeT1XZWJDb3JlOjpEZW55Q3Jvc3NPcmlnaW5SZWRpcmVjdCkgYXQgLi4vLi4vLi4vV2ViQ29y
ZS9sb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmNwcDo4MwojMTEgMHhiNzQ2YzU0MSBp
biBXZWJDb3JlOjpUaHJlYWRhYmxlTG9hZGVyOjpjcmVhdGUgKGNvbnRleHQ9MHg5MWEzZTQwLCBj
bGllbnQ9MHhhMDM0NGY0LCByZXF1ZXN0PUAweGJmOTVkOWQ0LCBjYWxsYmFja3NTZXR0aW5nPVdl
YkNvcmU6OkRvTm90U2VuZExvYWRDYWxsYmFja3MsIGNvbnRlbnRTbmlmZj1XZWJDb3JlOjpEb05v
dFNuaWZmQ29udGVudCwgc3RvcmVkQ3JlZGVudGlhbHM9V2ViQ29yZTo6RG9Ob3RBbGxvd1N0b3Jl
ZENyZWRlbnRpYWxzLCBjcm9zc09yaWdpblJlZGlyZWN0UG9saWN5PVdlYkNvcmU6OkRlbnlDcm9z
c09yaWdpblJlZGlyZWN0KSBhdCAuLi8uLi8uLi9XZWJDb3JlL2xvYWRlci9UaHJlYWRhYmxlTG9h
ZGVyLmNwcDo1NAojMTIgMHhiNzY5ZmI2YyBpbiBXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6bG9h
ZFJlcXVlc3RBc3luY2hyb25vdXNseSAodGhpcz0weGEwMzQ0ZTgsIHJlcXVlc3Q9QDB4YmY5NWQ5
ZDQpIGF0IC4uLy4uLy4uL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDo2NzcKIzEzIDB4
Yjc2YTBlZWUgaW4gV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6Om1ha2VDcm9zc09yaWdpbkFjY2Vz
c1JlcXVlc3RXaXRoUHJlZmxpZ2h0ICh0aGlzPTB4YTAzNDRlOCwgZWM9QDB4YmY5NWRjNDgpIGF0
IC4uLy4uLy4uL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDo1ODUKIzE0IDB4Yjc2YTE4
ZDYgaW4gV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6Om1ha2VDcm9zc09yaWdpbkFjY2Vzc1JlcXVl
c3QgKHRoaXM9MHhhMDM0NGU4LCBlYz1AMHhiZjk1ZGM0OCkgYXQgLi4vLi4vLi4vV2ViQ29yZS94
bWwvWE1MSHR0cFJlcXVlc3QuY3BwOjUxNAojMTUgMHhiNzZhMTlkZCBpbiBXZWJDb3JlOjpYTUxI
dHRwUmVxdWVzdDo6Y3JlYXRlUmVxdWVzdCAodGhpcz0weGEwMzQ0ZTgsIGVjPUAweGJmOTVkYzQ4
KSBhdCAuLi8uLi8uLi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHA6NDc2CiMxNiAweGI3
NmExZTgxIGluIFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpzZW5kICh0aGlzPTB4YTAzNDRlOCwg
Ym9keT1AMHhiZjk1ZGMzYywgZWM9QDB4YmY5NWRjNDgpIGF0IC4uLy4uLy4uL1dlYkNvcmUveG1s
L1hNTEh0dHBSZXF1ZXN0LmNwcDo0NDAKIzE3IDB4YjcwOGU3YTcgaW4gV2ViQ29yZTo6SlNYTUxI
dHRwUmVxdWVzdDo6c2VuZCAodGhpcz0weGIwM2M5MDYwLCBleGVjPTB4YjI0YjIyMTQsIGFyZ3M9
QDB4YmY5NWU5MWMpIGF0IC4uLy4uLy4uL1dlYkNvcmUvYmluZGluZ3MvanMvSlNYTUxIdHRwUmVx
dWVzdEN1c3RvbS5jcHA6MTMxCiMxOCAweGI3OTg5N2QwIGluIFdlYkNvcmU6OmpzWE1MSHR0cFJl
cXVlc3RQcm90b3R5cGVGdW5jdGlvblNlbmQgKGV4ZWM9MHhiMjRiMjIxNCwgdGhpc1ZhbHVlPXtt
X3B0ciA9IDB4YjAzYzkwNjB9LCBhcmdzPUAweGJmOTVlOTFjKSBhdCBnZW5lcmF0ZWQvZGVidWcv
SlNYTUxIdHRwUmVxdWVzdC5jcHA6MzYwCiMxOSAweGI2Zjg0MGUwIGluIEpTQzo6SW50ZXJwcmV0
ZXI6OnByaXZhdGVFeGVjdXRlICh0aGlzPTB4OGE3MzEwMCwgZmxhZz1KU0M6OkludGVycHJldGVy
OjpOb3JtYWwsIHJlZ2lzdGVyRmlsZT0weDhhNzMxMDgsIGNhbGxGcmFtZT0weGIyNGIyMTY4LCBl
eGNlcHRpb249MHg4YTZkMWI4KSBhdCAuLi8uLi8uLi9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRl
ci9JbnRlcnByZXRlci5jcHA6MzA4OAojMjAgMHhiNmY4ODI5YiBpbiBKU0M6OkludGVycHJldGVy
OjpleGVjdXRlICh0aGlzPTB4OGE3MzEwMCwgZnVuY3Rpb25Cb2R5Tm9kZT0weDllMDM5MTAsIGNh
bGxGcmFtZT0weDhjMmFiZWMsIGZ1bmN0aW9uPTB4YjQyM2Q3ZTAsIHRoaXNPYmo9MHhiNDIzMzgy
MCwgYXJncz1AMHhiZjk1ZjhkNCwgc2NvcGVDaGFpbj0weDllYWJkYzAsIGV4Y2VwdGlvbj0weDhh
NmQxYjgpIGF0IC4uLy4uLy4uL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVy
LmNwcDo3MDgKIzIxIDB4YjZmYmViYmMgaW4gSlNDOjpKU0Z1bmN0aW9uOjpjYWxsICh0aGlzPTB4
YjQyM2Q3ZTAsIGV4ZWM9MHg4YzJhYmVjLCB0aGlzVmFsdWU9e21fcHRyID0gMHhiNDIzMzgyMH0s
IGFyZ3M9QDB4YmY5NWY4ZDQpIGF0IC4uLy4uLy4uL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNG
dW5jdGlvbi5jcHA6MTA4CiMyMiAweGI2Zjk0OTM3IGluIEpTQzo6Y2FsbCAoZXhlYz0weDhjMmFi
ZWMsIGZ1bmN0aW9uT2JqZWN0PXttX3B0ciA9IDB4YjQyM2Q3ZTB9LCBjYWxsVHlwZT1KU0M6OkNh
bGxUeXBlSlMsIGNhbGxEYXRhPUAweGJmOTVmOGVjLCB0aGlzVmFsdWU9e21fcHRyID0gMHhiNDIz
MzgyMH0sIGFyZ3M9QDB4YmY5NWY4ZDQpIGF0IC4uLy4uLy4uL0phdmFTY3JpcHRDb3JlL3J1bnRp
bWUvQ2FsbERhdGEuY3BwOjM5CiMyMyAweGI3MGExZTI1IGluIFdlYkNvcmU6OkpTRXZlbnRMaXN0
ZW5lcjo6aGFuZGxlRXZlbnQgKHRoaXM9MHg5ZTA2YmQ4LCBldmVudD0weDlmYTdmZTAsIGlzV2lu
ZG93RXZlbnQ9ZmFsc2UpIGF0IC4uLy4uLy4uL1dlYkNvcmUvYmluZGluZ3MvanMvSlNFdmVudExp
c3RlbmVyLmNwcDoxMzIKIzI0IDB4YjcyMzQwYjMgaW4gV2ViQ29yZTo6Tm9kZTo6aGFuZGxlTG9j
YWxFdmVudHMgKHRoaXM9MHg5MWEzZTEwLCBldmVudD0weDlmYTdmZTAsIHVzZUNhcHR1cmU9ZmFs
c2UpIGF0IC4uLy4uLy4uL1dlYkNvcmUvZG9tL05vZGUuY3BwOjIzOTUKIzI1IDB4YjcyMzBiZmYg
aW4gV2ViQ29yZTo6Tm9kZTo6ZGlzcGF0Y2hHZW5lcmljRXZlbnQgKHRoaXM9MHg5MWEzZTEwLCBw
cnBFdmVudD17bV9wdHIgPSAweGJmOTVmYTVjfSkgYXQgLi4vLi4vLi4vV2ViQ29yZS9kb20vTm9k
ZS5jcHA6MjUxNgojMjYgMHhiNzIzMTk3ZCBpbiBXZWJDb3JlOjpOb2RlOjpkaXNwYXRjaEV2ZW50
ICh0aGlzPTB4OTFhM2UxMCwgZT17bV9wdHIgPSAweGJmOTVmYWE0fSwgZWM9QDB4YmY5NWZhYTgp
IGF0IC4uLy4uLy4uL1dlYkNvcmUvZG9tL05vZGUuY3BwOjI0NDkKIzI3IDB4YjcxZjUzNWEgaW4g
V2ViQ29yZTo6RG9jdW1lbnQ6OmZpbmlzaGVkUGFyc2luZyAodGhpcz0weDkxYTNlMTApIGF0IC4u
Ly4uLy4uL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcDozOTA2CiMyOCAweGI3Mzk5Yjg4IGluIFdl
YkNvcmU6OkhUTUxQYXJzZXI6OmZpbmlzaGVkICh0aGlzPTB4OGEyZjA4OCkgYXQgLi4vLi4vLi4v
V2ViQ29yZS9odG1sL0hUTUxQYXJzZXIuY3BwOjE2MTcKIzI5IDB4YjczYjQ0MTQgaW4gV2ViQ29y
ZTo6SFRNTFRva2VuaXplcjo6ZW5kICh0aGlzPTB4OWNjMjlmOCkgYXQgLi4vLi4vLi4vV2ViQ29y
ZS9odG1sL0hUTUxUb2tlbml6ZXIuY3BwOjE4MjkKIzMwIDB4YjczYmJiZGYgaW4gV2ViQ29yZTo6
SFRNTFRva2VuaXplcjo6d3JpdGUgKHRoaXM9MHg5Y2MyOWY4LCBzdHI9QDB4YmY5NWZiZmMsIGFw
cGVuZERhdGE9ZmFsc2UpIGF0IC4uLy4uLy4uL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmNw
cDoxNzczCiMzMSAweGI3M2I3N2M5IGluIFdlYkNvcmU6OkhUTUxUb2tlbml6ZXI6Om5vdGlmeUZp
bmlzaGVkICh0aGlzPTB4OWNjMjlmOCkgYXQgLi4vLi4vLi4vV2ViQ29yZS9odG1sL0hUTUxUb2tl
bml6ZXIuY3BwOjIwMzYKIzMyIDB4Yjc0MDQ2M2UgaW4gV2ViQ29yZTo6Q2FjaGVkU2NyaXB0Ojpj
aGVja05vdGlmeSAodGhpcz0weDlmYTg0ZTgpIGF0IC4uLy4uLy4uL1dlYkNvcmUvbG9hZGVyL0Nh
Y2hlZFNjcmlwdC5jcHA6MTA1CiMzMyAweGI3NDA0NzRhIGluIFdlYkNvcmU6OkNhY2hlZFNjcmlw
dDo6ZGF0YSAodGhpcz0weDlmYTg0ZTgsIGRhdGE9e21fcHRyID0gMHhiZjk1ZmQ3NH0sIGFsbERh
dGFSZWNlaXZlZD10cnVlKSBhdCAuLi8uLi8uLi9XZWJDb3JlL2xvYWRlci9DYWNoZWRTY3JpcHQu
Y3BwOjk1CiMzNCAweGI3NDVhMWUxIGluIFdlYkNvcmU6OkxvYWRlcjo6SG9zdDo6ZGlkRmluaXNo
TG9hZGluZyAodGhpcz0weDhlMjU0OTgsIGxvYWRlcj0weDlmYWJjYjApIGF0IC4uLy4uLy4uL1dl
YkNvcmUvbG9hZGVyL2xvYWRlci5jcHA6MzI1CiMzNSAweGI3NDY2ZWU4IGluIFdlYkNvcmU6OlN1
YnJlc291cmNlTG9hZGVyOjpkaWRGaW5pc2hMb2FkaW5nICh0aGlzPTB4OWZhYmNiMCkgYXQgLi4v
Li4vLi4vV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwOjE4MwojMzYgMHhiNzQ2
M2M3NCBpbiBXZWJDb3JlOjpSZXNvdXJjZUxvYWRlcjo6ZGlkRmluaXNoTG9hZGluZyAodGhpcz0w
eDlmYWJjYjApIGF0IC4uLy4uLy4uL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcDo0
MTYKIzM3IDB4Yjc2ZGZhYTIgaW4gV2ViQ29yZTo6UU5ldHdvcmtSZXBseUhhbmRsZXI6OmZpbmlz
aCAodGhpcz0weDljYTdiNTgpIGF0IC4uLy4uLy4uL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9x
dC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHA6MjM2CiMzOCAweGI3NmRmYmM4IGluIFdlYkNvcmU6
OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpxdF9tZXRhY2FsbCAodGhpcz0weDljYTdiNTgsIF9jPVFN
ZXRhT2JqZWN0OjpJbnZva2VNZXRhTWV0aG9kLCBfaWQ9MSwgX2E9MHg5ZmE4ODEwKSBhdCAuL21v
Y19RTmV0d29ya1JlcGx5SGFuZGxlci5jcHA6NzYKIzM5IDB4YjU0ZmIzN2IgaW4gUU1ldGFDYWxs
RXZlbnQ6OnBsYWNlTWV0YUNhbGwgKHRoaXM9MHg5ZWE3NjkwLCBvYmplY3Q9MHg5Y2E3YjU4KSBh
dCAvdmFyL3RtcC9xdC14MTEtc3JjLTQuNS4wL3NyYy9jb3JlbGliL2tlcm5lbC9xb2JqZWN0LmNw
cDo0ODkKIzQwIDB4YjU0ZmNlYzggaW4gUU9iamVjdDo6ZXZlbnQgKHRoaXM9MHg5Y2E3YjU4LCBl
PTB4OWVhNzY5MCkgYXQgL3Zhci90bXAvcXQteDExLXNyYy00LjUuMC9zcmMvY29yZWxpYi9rZXJu
ZWwvcW9iamVjdC5jcHA6MTEwOQojNDEgMHhiNWE2ZWE3ZiBpbiBRQXBwbGljYXRpb25Qcml2YXRl
Ojpub3RpZnlfaGVscGVyICh0aGlzPTB4ODg0YTYzOCwgcmVjZWl2ZXI9MHg5Y2E3YjU4LCBlPTB4
OWVhNzY5MCkgYXQgL3Zhci90bXAvcXQteDExLXNyYy00LjUuMC9zcmMvZ3VpL2tlcm5lbC9xYXBw
bGljYXRpb24uY3BwOjQwODQKIzQyIDB4YjVhNzI2YjkgaW4gUUFwcGxpY2F0aW9uOjpub3RpZnkg
KHRoaXM9MHhiZjk2MDU4YywgcmVjZWl2ZXI9MHg5Y2E3YjU4LCBlPTB4OWVhNzY5MCkgYXQgL3Zh
ci90bXAvcXQteDExLXNyYy00LjUuMC9zcmMvZ3VpL2tlcm5lbC9xYXBwbGljYXRpb24uY3BwOjM2
MzEKIzQzIDB4YjU0ZWI4MWIgaW4gUUNvcmVBcHBsaWNhdGlvbjo6bm90aWZ5SW50ZXJuYWwgKHRo
aXM9MHhiZjk2MDU4YywgcmVjZWl2ZXI9MHg5Y2E3YjU4LCBldmVudD0weDllYTc2OTApIGF0IC92
YXIvdG1wL3F0LXgxMS1zcmMtNC41LjAvc3JjL2NvcmVsaWIva2VybmVsL3Fjb3JlYXBwbGljYXRp
b24uY3BwOjYwMgojNDQgMHhiNTRlYzk4ZSBpbiBRQ29yZUFwcGxpY2F0aW9uUHJpdmF0ZTo6c2Vu
ZFBvc3RlZEV2ZW50cyAocmVjZWl2ZXI9MHgwLCBldmVudF90eXBlPTAsIGRhdGE9MHg4ODRhNTY4
KSBhdCAvdmFyL3RtcC9xdC14MTEtc3JjLTQuNS4wL3NyYy9jb3JlbGliL2tlcm5lbC9xY29yZWFw
cGxpY2F0aW9uLmg6MjEzCiM0NSAweGI1NGVjYzNkIGluIFFDb3JlQXBwbGljYXRpb246OnNlbmRQ
b3N0ZWRFdmVudHMgKHJlY2VpdmVyPTB4MCwgZXZlbnRfdHlwZT0wKSBhdCAvdmFyL3RtcC9xdC14
MTEtc3JjLTQuNS4wL3NyYy9jb3JlbGliL2tlcm5lbC9xY29yZWFwcGxpY2F0aW9uLmNwcDoxMTMy
CiM0NiAweGI1NTE3YzhmIGluIHBvc3RFdmVudFNvdXJjZURpc3BhdGNoIChzPTB4ODg1MmYxMCkg
YXQgL3Zhci90bXAvcXQteDExLXNyYy00LjUuMC9zcmMvY29yZWxpYi9rZXJuZWwvcWNvcmVhcHBs
aWNhdGlvbi5oOjIxOAojNDcgMHhiNTMwN2I4OCBpbiBnX21haW5fY29udGV4dF9kaXNwYXRjaCAo
KSBmcm9tIC91c3IvbGliL2xpYmdsaWItMi4wLnNvLjAKIzQ4IDB4YjUzMGIwZWIgaW4gPz8gKCkg
ZnJvbSAvdXNyL2xpYi9saWJnbGliLTIuMC5zby4wCiM0OSAweGI1MzBiMjY4IGluIGdfbWFpbl9j
b250ZXh0X2l0ZXJhdGlvbiAoKSBmcm9tIC91c3IvbGliL2xpYmdsaWItMi4wLnNvLjAKIzUwIDB4
YjU1MTgwM2UgaW4gUUV2ZW50RGlzcGF0Y2hlckdsaWI6OnByb2Nlc3NFdmVudHMgKHRoaXM9MHg4
ODUwM2YwLCBmbGFncz1AMHhiZjk2MDQ5OCkgYXQgL3Zhci90bXAvcXQteDExLXNyYy00LjUuMC9z
cmMvY29yZWxpYi9rZXJuZWwvcWV2ZW50ZGlzcGF0Y2hlcl9nbGliLmNwcDozMjMKIzUxIDB4YjVi
MDhiZDUgaW4gUUd1aUV2ZW50RGlzcGF0Y2hlckdsaWI6OnByb2Nlc3NFdmVudHMgKHRoaXM9MHg4
ODUwM2YwLCBmbGFncz1AMHhiZjk2MDRjOCkgYXQgL3Zhci90bXAvcXQteDExLXNyYy00LjUuMC9z
cmMvZ3VpL2tlcm5lbC9xZ3VpZXZlbnRkaXNwYXRjaGVyX2dsaWIuY3BwOjIwMgojNTIgMHhiNTRl
YTllZCBpbiBRRXZlbnRMb29wOjpwcm9jZXNzRXZlbnRzICh0aGlzPTB4YmY5NjA1NDAsIGZsYWdz
PUAweGJmOTYwNTA4KSBhdCAvdmFyL3RtcC9xdC14MTEtc3JjLTQuNS4wL3NyYy9jb3JlbGliL2tl
cm5lbC9xZXZlbnRsb29wLmNwcDoxNDkKIzUzIDB4YjU0ZWFkNWQgaW4gUUV2ZW50TG9vcDo6ZXhl
YyAodGhpcz0weGJmOTYwNTQwLCBmbGFncz1AMHhiZjk2MDU0OCkgYXQgL3Zhci90bXAvcXQteDEx
LXNyYy00LjUuMC9zcmMvY29yZWxpYi9rZXJuZWwvcWV2ZW50bG9vcC5jcHA6MjAwCiM1NCAweGI1
NGVjY2ZjIGluIFFDb3JlQXBwbGljYXRpb246OmV4ZWMgKCkgYXQgL3Zhci90bXAvcXQteDExLXNy
Yy00LjUuMC9zcmMvY29yZWxpYi9rZXJuZWwvcWNvcmVhcHBsaWNhdGlvbi5jcHA6ODgwCiM1NSAw
eGI1YTZlMjE3IGluIFFBcHBsaWNhdGlvbjo6ZXhlYyAoKSBhdCAvdmFyL3RtcC9xdC14MTEtc3Jj
LTQuNS4wL3NyYy9ndWkva2VybmVsL3FhcHBsaWNhdGlvbi5jcHA6MzU1MwojNTYgMHgwODEyYjAy
NCBpbiBtYWluIChhcmdjPTEsIGFyZ3Y9MHhiZjk2MDY1NCkgYXQgbWFpbi5jcHA6MzcKXmRvbmU=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32260</attachid>
            <date>2009-07-04 12:35:44 -0700</date>
            <delta_ts>2009-07-04 15:58:02 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>0001-Handle-null-m_loader-in-didFail.patch</filename>
            <type>text/plain</type>
            <size>1889</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">RnJvbSBhZDhiZjExNGNkNTk3ZDc1ZDc4MWZjYmNmZjdkY2EwODA5NTgxYjY2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBtd2VuZ2UgPHJvYmVydEByb2JlcnRob2dhbi5uZXQ+CkRhdGU6
IFNhdCwgNCBKdWwgMjAwOSAyMDozMjo0NCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEhhbmRsZSBu
dWxsIG1fbG9hZGVyIGluIGRpZEZhaWwoKQoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFdlYkNvcmUvbG9hZGVyL0Rv
Y3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHAgfCAgICA1ICsrKystCiAyIGZpbGVzIGNoYW5nZWQs
IDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwODQ5ZmMyLi43ZGQ4ZjM2IDEwMDY0
NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE1IEBACisyMDA5LTA3LTA0ICBSb2JlcnQgSG9nYW4gPHJvYmVydEByb2JlcnRob2dhbi5u
ZXQpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2OTY5CisKKyAgICAgICAgSWYg
dGhlIGh0dHBNZXRob2QoKSBvZiB0aGUgcmVxdWVzdCBwYXNzZWQgdG8gU3VicmVzb3VyY2VMb2Fk
ZXI6OmNyZWF0ZSBpcyBub3QKKyAgICAgICAgc3VwcG9ydGVkIGJ5IHRoZSBjbGllbnQgd2UgbXVz
dCBleHBlY3QgdG8gY2FsbCBkaWRGYWlsKCkgd2hpbGUgbV9sb2FkZXIgaXMgc3RpbGwgbnVsbC4K
KworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudFRocmVhZGFibGVMb2FkZXIuY3BwOgorICAgICAg
ICAoRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyOjpkaWRGYWlsKTpDaGFuZ2VkLgorCiAyMDA5LTA3
LTAzICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBBZGVsZSBQZXRlcnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50VGhy
ZWFkYWJsZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFRocmVhZGFibGVMb2Fk
ZXIuY3BwCmluZGV4IGFlNjcwMmIuLmIzZjAyNmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9hZGVy
L0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRG9jdW1l
bnRUaHJlYWRhYmxlTG9hZGVyLmNwcApAQCAtMTY0LDcgKzE2NCwxMCBAQCB2b2lkIERvY3VtZW50
VGhyZWFkYWJsZUxvYWRlcjo6ZGlkRmluaXNoTG9hZGluZyhTdWJyZXNvdXJjZUxvYWRlciogbG9h
ZGVyKQogdm9pZCBEb2N1bWVudFRocmVhZGFibGVMb2FkZXI6OmRpZEZhaWwoU3VicmVzb3VyY2VM
b2FkZXIqIGxvYWRlciwgY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IpCiB7CiAgICAgQVNTRVJU
KG1fY2xpZW50KTsKLSAgICBBU1NFUlRfVU5VU0VEKGxvYWRlciwgbG9hZGVyID09IG1fbG9hZGVy
KTsKKyAgICAvLyBJZiB0aGUgaHR0cE1ldGhvZCgpIG9mIHRoZSByZXF1ZXN0IHBhc3NlZCB0byBT
dWJyZXNvdXJjZUxvYWRlcjo6Y3JlYXRlIGlzIG5vdCBzdXBwb3J0ZWQgYnkKKyAgICAvLyB0aGUg
Y2xpZW50IHdlIG11c3QgZXhwZWN0IGEgY2FsbCB0byBkaWRGYWlsKCkgd2hpbGUgbV9sb2FkZXIg
aXMgc3RpbGwgbnVsbC4KKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjY5NjkKKyAgICBBU1NFUlRfVU5VU0VEKGxvYWRlciwgbG9hZGVyID09IG1fbG9hZGVy
IHx8ICFtX2xvYWRlcik7CiAKICAgICBtX2NsaWVudC0+ZGlkRmFpbChlcnJvcik7CiB9Ci0tIAox
LjYuMC40Cgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32263</attachid>
            <date>2009-07-04 15:53:10 -0700</date>
            <delta_ts>2009-07-06 14:27:34 -0700</delta_ts>
            <desc>patch updated with shorter inline comment</desc>
            <filename>0001-Handle-null-m_loader-in-didFail.patch</filename>
            <type>text/plain</type>
            <size>1738</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">RnJvbSA0NDA0MGNkNGU2Yzc2MTU5ODhhOWY4M2Q4NjU0ZWEzY2E1ODQyMWI3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBtd2VuZ2UgPHJvYmVydEByb2JlcnRob2dhbi5uZXQ+CkRhdGU6
IFNhdCwgNCBKdWwgMjAwOSAyMDozMjo0NCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEhhbmRsZSBu
dWxsIG1fbG9hZGVyIGluIGRpZEZhaWwoKQoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFdlYkNvcmUvbG9hZGVyL0Rv
Y3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHAgfCAgICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAx
NCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh
bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg0OWZjMi4uN2RkOGYzNiAxMDA2NDQK
LS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNSBAQAorMjAwOS0wNy0wNCAgUm9iZXJ0IEhvZ2FuIDxyb2JlcnRAcm9iZXJ0aG9nYW4ubmV0
KQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjk2OQorCisgICAgICAgIElmIHRo
ZSBodHRwTWV0aG9kKCkgb2YgdGhlIHJlcXVlc3QgcGFzc2VkIHRvIFN1YnJlc291cmNlTG9hZGVy
OjpjcmVhdGUgaXMgbm90CisgICAgICAgIHN1cHBvcnRlZCBieSB0aGUgY2xpZW50IHdlIG11c3Qg
ZXhwZWN0IHRvIGNhbGwgZGlkRmFpbCgpIHdoaWxlIG1fbG9hZGVyIGlzIHN0aWxsIG51bGwuCisK
KyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmNwcDoKKyAgICAgICAg
KERvY3VtZW50VGhyZWFkYWJsZUxvYWRlcjo6ZGlkRmFpbCk6Q2hhbmdlZC4KKwogMjAwOS0wNy0w
MyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
QWRlbGUgUGV0ZXJzb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFRocmVh
ZGFibGVMb2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVy
LmNwcAppbmRleCBhZTY3MDJiLi5kZDVjYTc2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9E
b2N1bWVudFRocmVhZGFibGVMb2FkZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50
VGhyZWFkYWJsZUxvYWRlci5jcHAKQEAgLTE2NCw3ICsxNjQsOCBAQCB2b2lkIERvY3VtZW50VGhy
ZWFkYWJsZUxvYWRlcjo6ZGlkRmluaXNoTG9hZGluZyhTdWJyZXNvdXJjZUxvYWRlciogbG9hZGVy
KQogdm9pZCBEb2N1bWVudFRocmVhZGFibGVMb2FkZXI6OmRpZEZhaWwoU3VicmVzb3VyY2VMb2Fk
ZXIqIGxvYWRlciwgY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IpCiB7CiAgICAgQVNTRVJUKG1f
Y2xpZW50KTsKLSAgICBBU1NFUlRfVU5VU0VEKGxvYWRlciwgbG9hZGVyID09IG1fbG9hZGVyKTsK
KyAgICAvLyBtX2xvYWRlciBtYXkgYmUgbnVsbCBpZiB3ZSBhcnJpdmUgaGVyZSB2aWEgU3VicmVz
b3VyY2VMb2FkZXI6OmNyZWF0ZSBpbiB0aGUgY3RvcgorICAgIEFTU0VSVF9VTlVTRUQobG9hZGVy
LCBsb2FkZXIgPT0gbV9sb2FkZXIgfHwgIW1fbG9hZGVyKTsKIAogICAgIG1fY2xpZW50LT5kaWRG
YWlsKGVycm9yKTsKIH0KLS0gCjEuNi4wLjQKCg==
</data>
<flag name="review"
          id="16743"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32325</attachid>
            <date>2009-07-06 14:27:34 -0700</date>
            <delta_ts>2009-07-07 00:14:46 -0700</delta_ts>
            <desc>updated changelog</desc>
            <filename>0001-Handle-null-m_loader-in-didFail.patch</filename>
            <type>text/plain</type>
            <size>1739</size>
            <attacher name="Robert Hogan">robert</attacher>
            
              <data encoding="base64">RnJvbSBjY2I1M2Y2OTQxZTNjNjM5YzJhMjUzYjM3YmY1Y2M5NGU4ZDlkZDhkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBtd2VuZ2UgPHJvYmVydEByb2JlcnRob2dhbi5uZXQ+CkRhdGU6
IFNhdCwgNCBKdWwgMjAwOSAyMDozMjo0NCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEhhbmRsZSBu
dWxsIG1fbG9hZGVyIGluIGRpZEZhaWwoKQoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFdlYkNvcmUvbG9hZGVyL0Rv
Y3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHAgfCAgICAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCAx
NCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh
bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg0OWZjMi4uZTVkM2M2YSAxMDA2NDQK
LS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNSBAQAorMjAwOS0wNy0wNCAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHJvYmVydGhvZ2FuLm5l
dD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5NjkKKworICAgICAgICBJZiB0
aGUgaHR0cE1ldGhvZCgpIG9mIHRoZSByZXF1ZXN0IHBhc3NlZCB0byBTdWJyZXNvdXJjZUxvYWRl
cjo6Y3JlYXRlIGlzIG5vdAorICAgICAgICBzdXBwb3J0ZWQgYnkgdGhlIGNsaWVudCB3ZSBtdXN0
IGV4cGVjdCB0byBjYWxsIGRpZEZhaWwoKSB3aGlsZSBtX2xvYWRlciBpcyBzdGlsbCBudWxsLgor
CisgICAgICAgICogbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHA6CisgICAgICAg
IChEb2N1bWVudFRocmVhZGFibGVMb2FkZXI6OmRpZEZhaWwpOkNoYW5nZWQuCisKIDIwMDktMDct
MDMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5
IEFkZWxlIFBldGVyc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRUaHJl
YWRhYmxlTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRl
ci5jcHAKaW5kZXggYWU2NzAyYi4uZGQ1Y2E3NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIv
RG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu
dFRocmVhZGFibGVMb2FkZXIuY3BwCkBAIC0xNjQsNyArMTY0LDggQEAgdm9pZCBEb2N1bWVudFRo
cmVhZGFibGVMb2FkZXI6OmRpZEZpbmlzaExvYWRpbmcoU3VicmVzb3VyY2VMb2FkZXIqIGxvYWRl
cikKIHZvaWQgRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyOjpkaWRGYWlsKFN1YnJlc291cmNlTG9h
ZGVyKiBsb2FkZXIsIGNvbnN0IFJlc291cmNlRXJyb3ImIGVycm9yKQogewogICAgIEFTU0VSVCht
X2NsaWVudCk7Ci0gICAgQVNTRVJUX1VOVVNFRChsb2FkZXIsIGxvYWRlciA9PSBtX2xvYWRlcik7
CisgICAgLy8gbV9sb2FkZXIgbWF5IGJlIG51bGwgaWYgd2UgYXJyaXZlIGhlcmUgdmlhIFN1YnJl
c291cmNlTG9hZGVyOjpjcmVhdGUgaW4gdGhlIGN0b3IKKyAgICBBU1NFUlRfVU5VU0VEKGxvYWRl
ciwgbG9hZGVyID09IG1fbG9hZGVyIHx8ICFtX2xvYWRlcik7CiAKICAgICBtX2NsaWVudC0+ZGlk
RmFpbChlcnJvcik7CiB9Ci0tIAoxLjYuMC40Cgo=
</data>
<flag name="review"
          id="16787"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>