26960 2009-07-03 21:40:24 -0700 [Gtk] caret offset not updated when selecting text 2009-07-27 17:53:04 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux VERIFIED FIXED Gtk P3 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro jmalonzo walker.willie xan.lopez oldest_to_newest 129768 0 jdiggs 2009-07-03 21:40:24 -0700 Steps to reproduce: 1. Launch Epiphany and Accerciser. 2. In Epiphany, position the caret within some text. 3. In Accerciser's tree of accessibles on the left, highlight the accessible text object which corresponds to the object chosen in step 2. 4. In Accerciser's iPython Console, type: acc.queryText().caretOffset 5. In Epiphany, press Shift + Right Arrow two times to select two characters to the right 6. In Accerciser's iPython Console, type: acc.queryText().caretOffset Expected results: The offset returned in step 6 would reflect the new location of the caret (the step 4 offset + 2). Actual results: The offset returned in step 6 is the same as the step 4 offset. (Xan, I believe that the fix for this bug, combined with your fixes for bug 26814 and bug 26815, should cause the presentation of selected text by ATs like Orca to JustWork(tm) -- which will be awesome. Sorry for not catching this one the other day!!) 129792 1 32255 xan.lopez 2009-07-04 09:03:50 -0700 Created attachment 32255 caretoffset.patch Well, it was basically the same bug than the other cases, but in a different place. 129807 2 32255 jmalonzo 2009-07-04 14:20:35 -0700 Comment on attachment 32255 caretoffset.patch This looks fine. r=me. We need to think of a way to test these changes in the future while we don't have an AXController in DRT yet. Maybe more unit tests. 129953 3 jdiggs 2009-07-06 08:18:11 -0700 This patch seems to be working nicely. Thanks!! 130177 4 jmalonzo 2009-07-07 03:51:30 -0700 (In reply to comment #3) > This patch seems to be working nicely. Thanks!! Thanks for verifying Joanmarie. Fix landed in r45549. 135076 5 jdiggs 2009-07-27 17:53:04 -0700 (re)Verifying. :-) Thanks. 32255 2009-07-04 09:03:50 -0700 2009-07-04 14:20:34 -0700 caretoffset.patch caretoffset.patch text/plain 2371 xan.lopez RnJvbSA1YjMwY2JhNDYyZTkwNDAwOTk2NGYwMjdiYTUxMmQ2YjVhNTg0MjA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBT YXQsIDQgSnVsIDIwMDkgMTI6MTc6NTkgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTA3LTA0 ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNjk2MAogICAgICAgIFtHdGtdIGNhcmV0IG9mZnNldCBub3QgdXBkYXRlZCB3aGVuIHNl bGVjdGluZyB0ZXh0CgogICAgICAgIFJlcG9ydCB0aGUgY2FyZXQgb2Zmc2V0IGZyb20gdGhlIGVu ZCBvZiB0aGUgc2VsZWN0aW9uIHNvIGl0IHdvcmtzCiAgICAgICAgY29ycmVjdGx5IGZvciBtdWx0 aS1jaGFyIHNlbGVjdGlvbnMgdG9vIChpZSwgYW55dGhpbmcgdGhhdCBpcyBub3QKICAgICAgICB0 aGUgemVybyB3aWR0aCBjYXJldCkuCgogICAgICAgICogYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgogICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV90 ZXh0X2dldF9jYXJldF9vZmZzZXQpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL2d0ay9BY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgICAgICAgICAgfCAgICAyICstCiAyIGZpbGVz IGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwODQ5ZmMyLi45NzNl NDQ0IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDA5LTA3LTA0ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5NjAKKyAgICAgICAgW0d0 a10gY2FyZXQgb2Zmc2V0IG5vdCB1cGRhdGVkIHdoZW4gc2VsZWN0aW5nIHRleHQKKworICAgICAg ICBSZXBvcnQgdGhlIGNhcmV0IG9mZnNldCBmcm9tIHRoZSBlbmQgb2YgdGhlIHNlbGVjdGlvbiBz byBpdCB3b3JrcworICAgICAgICBjb3JyZWN0bHkgZm9yIG11bHRpLWNoYXIgc2VsZWN0aW9ucyB0 b28gKGllLCBhbnl0aGluZyB0aGF0IGlzIG5vdAorICAgICAgICB0aGUgemVybyB3aWR0aCBjYXJl dCkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3Jh cHBlckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV90ZXh0X2dldF9jYXJldF9v ZmZzZXQpOgorCiAyMDA5LTA3LTAzICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwIGIvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAK aW5kZXggNTYzNmQxNy4uYTA2MTNiMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKQEAgLTU1OSw3 ICs1NTksNyBAQCBzdGF0aWMgZ3VuaWNoYXIgd2Via2l0X2FjY2Vzc2libGVfdGV4dF9nZXRfY2hh cmFjdGVyX2F0X29mZnNldChBdGtUZXh0KiB0ZXh0LCBnaQogc3RhdGljIGdpbnQgd2Via2l0X2Fj Y2Vzc2libGVfdGV4dF9nZXRfY2FyZXRfb2Zmc2V0KEF0a1RleHQqIHRleHQpCiB7CiAgICAgLy8g VE9ETzogVmVyaWZ5IHRoaXMgZm9yIFJUTCB0ZXh0LgotICAgIHJldHVybiBjb3JlKHRleHQpLT5z ZWxlY3Rpb24oKS5zdGFydCgpLm9mZnNldEluQ29udGFpbmVyTm9kZSgpOworICAgIHJldHVybiBj b3JlKHRleHQpLT5zZWxlY3Rpb24oKS5lbmQoKS5vZmZzZXRJbkNvbnRhaW5lck5vZGUoKTsKIH0K IAogc3RhdGljIEF0a0F0dHJpYnV0ZVNldCogd2Via2l0X2FjY2Vzc2libGVfdGV4dF9nZXRfcnVu X2F0dHJpYnV0ZXMoQXRrVGV4dCogdGV4dCwgZ2ludCBvZmZzZXQsIGdpbnQqIHN0YXJ0X29mZnNl dCwgZ2ludCogZW5kX29mZnNldCkKLS0gCjEuNi4zLjMKCg==