26958 2009-07-03 18:46:22 -0700 Change edit link to review link in request messages 2009-07-03 20:28:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 17457 1 ddkilzer webkit-unassigned mitz oldest_to_newest 129758 0 32249 ddkilzer 2009-07-03 18:46:22 -0700 Created attachment 32249 Patch Mitz says that request messages should have a "review" link instead of and "edit" link. I'll add the bug number to the ChangeLog before committing. 129759 1 ddkilzer 2009-07-03 18:47:28 -0700 This is the only change after copying the file: $ diff -u BugsSite/template/en/default/request/email.txt.tmpl BugsSite/template/en/custom/request/email.txt.tmpl --- BugsSite/template/en/default/request/email.txt.tmpl 2009-07-02 21:30:23.000000000 -0700 +++ BugsSite/template/en/custom/request/email.txt.tmpl 2009-07-03 17:54:13.000000000 -0700 @@ -69,7 +69,7 @@ [% FILTER bullet = wrap(80) %] Attachment [% attidsummary %] [%- END %] -[%+ urlbase %]attachment.cgi?id=[% attachment.id %]&action=edit +[%+ urlbase %]attachment.cgi?id=[% attachment.id %]&action=review [%- END %] [%- FILTER bullet = wrap(80) %] 129762 2 ddkilzer 2009-07-03 20:28:08 -0700 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M BugsSite/ChangeLog A BugsSite/template/en/custom/request/email.txt.tmpl Committed r45540 <http://trac.webkit.org/changeset/45540> 32249 2009-07-03 18:46:22 -0700 2009-07-03 18:49:40 -0700 Patch 0001-Change-edit-link-to-review-link-in-request-messages.patch text/plain 4596 ddkilzer RnJvbSAyYjMyMjQwN2UyOTNkNmNiNjBlYTNlNzI4MzJkMWRmOTg0YTY0NjQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBELiBLaWx6ZXIgPGRka2lsemVyQHdlYmtpdC5vcmc+ CkRhdGU6IEZyaSwgMyBKdWwgMjAwOSAxODo0MzozMSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdICAg ICAgICAgQ2hhbmdlIGVkaXQgbGluayB0byByZXZpZXcgbGluayBpbiByZXF1ZXN0IG1lc3NhZ2Vz CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIHRlbXBsYXRl L2VuL2N1c3RvbS9yZXF1ZXN0L2VtYWlsLnR4dC50bXBsOiBDb3BpZWQgZnJvbSBCdWdzU2l0ZS90 ZW1wbGF0ZS9lbi9kZWZhdWx0L3JlcXVlc3QvZW1haWwudHh0LnRtcGwuCiAgICAgICAgQ2hhbmdl ZCBsaW5rIGZyb20gImFjdGlvbj1lZGl0IiB0byAiYWN0aW9uPXJldmlldyIuCi0tLQogQnVnc1Np dGUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA5ICsrCiBC dWdzU2l0ZS90ZW1wbGF0ZS9lbi9jdXN0b20vcmVxdWVzdC9lbWFpbC50eHQudG1wbCB8ICAgODIg KysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgOTEgaW5zZXJ0aW9ucygrKSwg MCBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBCdWdzU2l0ZS90ZW1wbGF0ZS9lbi9j dXN0b20vcmVxdWVzdC9lbWFpbC50eHQudG1wbAoKZGlmZiAtLWdpdCBhL0J1Z3NTaXRlL0NoYW5n ZUxvZyBiL0J1Z3NTaXRlL0NoYW5nZUxvZwppbmRleCA4ZDU4ZmU4Li41YzY5OWUxIDEwMDY0NAot LS0gYS9CdWdzU2l0ZS9DaGFuZ2VMb2cKKysrIGIvQnVnc1NpdGUvQ2hhbmdlTG9nCkBAIC0xLDUg KzEsMTQgQEAKIDIwMDktMDctMDMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAorICAgICAgICBDaGFuZ2UgZWRpdCBsaW5rIHRvIHJldmlldyBsaW5rIGluIHJlcXVlc3QgbWVz c2FnZXMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHRlbXBsYXRlL2VuL2N1c3RvbS9yZXF1ZXN0L2VtYWlsLnR4dC50bXBsOiBDb3BpZWQgZnJvbSBC dWdzU2l0ZS90ZW1wbGF0ZS9lbi9kZWZhdWx0L3JlcXVlc3QvZW1haWwudHh0LnRtcGwuCisgICAg ICAgIENoYW5nZWQgbGluayBmcm9tICJhY3Rpb249ZWRpdCIgdG8gImFjdGlvbj1yZXZpZXciLgor CisyMDA5LTA3LTAzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKICAgICAg ICAgQnVnIDI2OTUwOiBNYWtlIHRoZSBzdW1tYXJ5IGFuZCBhbGlhcyBmaWVsZHMgc3VwcG9ydCBj bGljay10by1lZGl0CiAgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjY5NTA+CiAKZGlmZiAtLWdpdCBhL0J1Z3NTaXRlL3RlbXBsYXRlL2VuL2N1c3RvbS9y ZXF1ZXN0L2VtYWlsLnR4dC50bXBsIGIvQnVnc1NpdGUvdGVtcGxhdGUvZW4vY3VzdG9tL3JlcXVl c3QvZW1haWwudHh0LnRtcGwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYjNm OTQyYgotLS0gL2Rldi9udWxsCisrKyBiL0J1Z3NTaXRlL3RlbXBsYXRlL2VuL2N1c3RvbS9yZXF1 ZXN0L2VtYWlsLnR4dC50bXBsCkBAIC0wLDAgKzEsODIgQEAKK1slIyBUaGUgY29udGVudHMgb2Yg dGhpcyBmaWxlIGFyZSBzdWJqZWN0IHRvIHRoZSBNb3ppbGxhIFB1YmxpYworICAjIExpY2Vuc2Ug VmVyc2lvbiAxLjEgKHRoZSAiTGljZW5zZSIpOyB5b3UgbWF5IG5vdCB1c2UgdGhpcyBmaWxlCisg ICMgZXhjZXB0IGluIGNvbXBsaWFuY2Ugd2l0aCB0aGUgTGljZW5zZS4gWW91IG1heSBvYnRhaW4g YSBjb3B5IG9mCisgICMgdGhlIExpY2Vuc2UgYXQgaHR0cDovL3d3dy5tb3ppbGxhLm9yZy9NUEwv CisgICMKKyAgIyBTb2Z0d2FyZSBkaXN0cmlidXRlZCB1bmRlciB0aGUgTGljZW5zZSBpcyBkaXN0 cmlidXRlZCBvbiBhbiAiQVMKKyAgIyBJUyIgYmFzaXMsIFdJVEhPVVQgV0FSUkFOVFkgT0YgQU5Z IEtJTkQsIGVpdGhlciBleHByZXNzIG9yCisgICMgaW1wbGllZC4gU2VlIHRoZSBMaWNlbnNlIGZv ciB0aGUgc3BlY2lmaWMgbGFuZ3VhZ2UgZ292ZXJuaW5nCisgICMgcmlnaHRzIGFuZCBsaW1pdGF0 aW9ucyB1bmRlciB0aGUgTGljZW5zZS4KKyAgIworICAjIFRoZSBPcmlnaW5hbCBDb2RlIGlzIHRo ZSBCdWd6aWxsYSBCdWcgVHJhY2tpbmcgU3lzdGVtLgorICAjCisgICMgVGhlIEluaXRpYWwgRGV2 ZWxvcGVyIG9mIHRoZSBPcmlnaW5hbCBDb2RlIGlzIE5ldHNjYXBlIENvbW11bmljYXRpb25zCisg ICMgQ29ycG9yYXRpb24uIFBvcnRpb25zIGNyZWF0ZWQgYnkgTmV0c2NhcGUgYXJlCisgICMgQ29w eXJpZ2h0IChDKSAxOTk4IE5ldHNjYXBlIENvbW11bmljYXRpb25zIENvcnBvcmF0aW9uLiBBbGwK KyAgIyBSaWdodHMgUmVzZXJ2ZWQuCisgICMKKyAgIyBDb250cmlidXRvcihzKTogICAgIE15ayBN ZWxleiA8bXlrQG1vemlsbGEub3JnPgorICAjICAgICAgICAgICAgICAgICAgICAgSmVmZiBIZWRs dW5kIDxqZWZmLmhlZGx1bmRAbWF0cml4c2kuY29tPgorICAjICAgICAgICAgICAgICAgICAgICAg RnLDqWTDqXJpYyBCdWNsaW4gPExwU29saXRAZ21haWwuY29tPgorICAjJV0KKworWyUgUFJPQ0VT UyBnbG9iYWwvdmFyaWFibGVzLm5vbmUudG1wbCAlXQorCitbJSBidWdpZHN1bW1hcnkgPSBidWcu YnVnX2lkIF8gJzogJyBfIGJ1Zy5zaG9ydF9kZXNjICVdCitbJSBhdHRpZHN1bW1hcnkgPSBhdHRh Y2htZW50LmlkIF8gJzogJyBfIGF0dGFjaG1lbnQuZGVzY3JpcHRpb24gJV0KK1slIHN0YXR1c2Vz ID0geyAnKycgPT4gImdyYW50ZWQiICwgJy0nID0+ICdkZW5pZWQnICwgJ1gnID0+ICJjYW5jZWxl ZCIgLAorICAgICAgICAgICAgICAgICc/JyA9PiAiYXNrZWQiIH0gJV0KKworWyUgdG9faWRlbnRp dHkgPSAiIiAlXQorWyUgb25fYmVoYWxmX29mID0gMCAlXQorWyUgSUYgZmxhZy5zdGF0dXMgPT0g Jz8nICVdCisgIFslIHN1YmplY3Rfc3RhdHVzID0gInJlcXVlc3RlZCIgJV0KKyAgWyUgSUYgZmxh Zy5zZXR0ZXIuaWQgPT0gdXNlci5pZCAlXQorICAgIFslIHRvX2lkZW50aXR5ID0gZmxhZy5yZXF1 ZXN0ZWUuaWRlbnRpdHkgXyAiIGZvciIgJV0KKyAgWyUgRUxTRSAlXQorICAgIFslIG9uX2JlaGFs Zl9vZiA9IDEgJV0KKyAgICBbJSBJRiBmbGFnLnJlcXVlc3RlZSAlXVslIHRvX2lkZW50aXR5ID0g IiB0byAiIF8gZmxhZy5yZXF1ZXN0ZWUuaWRlbnRpdHkgJV1bJSBFTkQgJV0KKyAgWyUgRU5EICVd CitbJSBFTFNFICVdCisgIFslIElGIGZsYWcucmVxdWVzdGVyICVdCisgICAgWyUgdG9faWRlbnRp dHkgPSBmbGFnLnJlcXVlc3Rlci5pZGVudGl0eSBfICIncyByZXF1ZXN0IGZvciIgJV0KKyAgWyUg RU5EICVdCisgIFslIHN1YmplY3Rfc3RhdHVzID0gc3RhdHVzZXMuJHtmbGFnLnN0YXR1c30gJV0K K1slIEVORCAlXQorRnJvbTogWyUgUGFyYW0oJ21haWxmcm9tJykgJV0KK1RvOiBbJSB0byAlXQor U3ViamVjdDogWyUgZmxhZy50eXBlLm5hbWUgJV0gWyUrIHN1YmplY3Rfc3RhdHVzICVdOiBbWyUg dGVybXMuQnVnICVdIFslKyBidWcuYnVnX2lkICVdXSBbJSBidWcuc2hvcnRfZGVzYyAlXQorWyUt IElGIGF0dGFjaG1lbnQgJV0gOgorICBbQXR0YWNobWVudCBbJSBhdHRhY2htZW50LmlkICVdXSBb JSBhdHRhY2htZW50LmRlc2NyaXB0aW9uICVdWyUgRU5EICVdCitYLUJ1Z3ppbGxhLVR5cGU6IHJl cXVlc3QKK1slKyB0aHJlYWRpbmdtYXJrZXIgJV0KKworWyUrIFVTRSB3cmFwIC0lXQorWyUtIEZJ TFRFUiBidWxsZXQgPSB3cmFwKDgwKSAtJV0KKworWyUgSUYgb25fYmVoYWxmX29mICVdCitbJSB1 c2VyLmlkZW50aXR5ICVdIGhhcyByZWFzc2lnbmVkIFslIGZsYWcuc2V0dGVyLmlkZW50aXR5ICVd J3MgcmVxdWVzdCBmb3IgWyUgZmxhZy50eXBlLm5hbWUgJV0KK1slIHRvX2lkZW50aXR5ICVdOgor WyUgRUxTRSAlXQorWyUgdXNlci5pZGVudGl0eSAlXSBoYXMgWyUgc3RhdHVzZXMuJHtmbGFnLnN0 YXR1c30gJV0gWyUrIHRvX2lkZW50aXR5ICVdIFslKyBmbGFnLnR5cGUubmFtZSAlXToKK1slIEVO RCAlXQorCitbJSB0ZXJtcy5CdWcgJV0gWyUrIGJ1Z2lkc3VtbWFyeSAlXQorWyUgRU5EICVdCitb JSsgdXJsYmFzZSAlXXNob3dfYnVnLmNnaT9pZD1bJSBidWcuYnVnX2lkICVdCitbJSBJRiBhdHRh Y2htZW50ICVdCisKK1slIEZJTFRFUiBidWxsZXQgPSB3cmFwKDgwKSAlXQorQXR0YWNobWVudCBb JSBhdHRpZHN1bW1hcnkgJV0KK1slLSBFTkQgJV0KK1slKyB1cmxiYXNlICVdYXR0YWNobWVudC5j Z2k/aWQ9WyUgYXR0YWNobWVudC5pZCAlXSZhY3Rpb249cmV2aWV3CitbJS0gRU5EICVdCitbJS0g RklMVEVSIGJ1bGxldCA9IHdyYXAoODApICVdCisKK1slIFVTRSBCdWd6aWxsYSAlXQorWyUgSUYg QnVnemlsbGEuY2dpLnBhcmFtKCJjb21tZW50IikgJiYgQnVnemlsbGEuY2dpLnBhcmFtKCJjb21t ZW50IikubGVuZ3RoID4gMCAlXQorLS0tLS0tLSBBZGRpdGlvbmFsIENvbW1lbnRzIGZyb20gWyUg dXNlci5pZGVudGl0eSAlXQorWyUrIEJ1Z3ppbGxhLmNnaS5wYXJhbSgiY29tbWVudCIpICVdCitb JSBFTkQgJV0KKworWyUtIEVORCAlXQotLSAKMS42LjMuMwoK