26955 2009-07-03 12:22:48 -0700 Use RGBColor::create in V8 bindings codegenerator 2009-07-17 00:43:39 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 ager ager abarth dglazkov japhet oldest_to_newest 129735 0 32245 ager 2009-07-03 12:22:48 -0700 Created attachment 32245 Use RGBColor::create in V8 bindings codegen Patch to the V8 bindings codegenerator to correctly use RGBColor::create to create RGBColor objects. This avoid memory leaks because of errors in refcounting. 129793 1 dglazkov 2009-07-04 09:12:50 -0700 Would you consider upstreaming RGBColor bindings as well, since you're working in this area? 129794 2 32245 dglazkov 2009-07-04 10:00:46 -0700 Comment on attachment 32245 Use RGBColor::create in V8 bindings codegen The change looks fine. I would really love to see the RGBColor upstreamed, though :) 130690 3 japhet 2009-07-09 11:18:46 -0700 Landed as r45666. 132512 4 abarth 2009-07-17 00:43:39 -0700 This bug claims to have been landed. 32245 2009-07-03 12:22:48 -0700 2009-07-04 10:00:46 -0700 Use RGBColor::create in V8 bindings codegen codegen-rgbcolor.diff text/plain 5702 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTUzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDctMDMgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0 ZSB0aGUgVjggYmluZGluZ3MgY29kZWdlbmVyYXRvciB0byB1c2UgdGhlIFJHQkNvbG9yOjpjcmVh dGUKKyAgICAgICAgbWV0aG9kIHRvIGhhbmRsZSByZWZjb3VudHMgZm9yIFJHQkNvbG9yIG9iamVj dHMgY29ycmVjdGx5LgorICAgICAgICAKKyAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvclY4LnBtOiBVc2UgUkdCQ29sb3I6OmNyZWF0ZSB0byBjcmVhdGUgUkdCQ29sb3Igb2Jq ZWN0cy4KKwogMjAwOS0wNy0wMiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgSmFuIEFsb256by4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNDU1MzUpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC02MjYs NyArNjI2LDcgQEAgRU5ECiAgICAgICAgIG15ICRjbGFzc0luZGV4ID0gdWMoJGF0dHJUeXBlKTsK ICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICByZXR1cm4gVjhQcm94eTo6Y29u dmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjokY2xhc3NJbmRleCwgd3JhcHBlcik7XG4iKTsK ICAgICB9IGVsc2UgewotICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgIHJldHVy biAiLk5hdGl2ZVRvSlNWYWx1ZSgkYXR0cmlidXRlLT5zaWduYXR1cmUsICRyZXN1bHQpLiI7XG4i KTsKKyAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICAiIC4gUmV0dXJuTmF0aXZl VG9KU1ZhbHVlKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZSwgJHJlc3VsdCwgIiAgICAiKS4iO1xuIik7 CiAgICAgfQogCiAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgfVxuXG4iKTsgICMgZW5k IG9mIGdldHRlcgpAQCAtMTU0OSw3ICsxNTQ5LDcgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25DYWxs U3RyaW5nKCkKICAgICAgICAgbXkgJGNsYXNzSW5kZXggPSB1YygkcmV0dXJuVHlwZSk7CiAgICAg ICAgICRyZXN1bHQgLj0gJGluZGVudCAuICJyZXR1cm4gVjhQcm94eTo6Y29udmVydFRvVjhPYmpl Y3QoVjhDbGFzc0luZGV4OjokY2xhc3NJbmRleCwgd3JhcHBlcik7XG4iOwogICAgIH0gZWxzZSB7 Ci0gICAgICAgICRyZXN1bHQgLj0gJGluZGVudCAuICJyZXR1cm4gIiAuIE5hdGl2ZVRvSlNWYWx1 ZSgkZnVuY3Rpb24tPnNpZ25hdHVyZSwgJHJldHVybikgLiAiO1xuIjsKKyAgICAgICAgJHJlc3Vs dCAuPSAkaW5kZW50IC4gUmV0dXJuTmF0aXZlVG9KU1ZhbHVlKCRmdW5jdGlvbi0+c2lnbmF0dXJl LCAkcmV0dXJuLCAkaW5kZW50KSAuICI7XG4iOwogICAgIH0KIAogICAgIHJldHVybiAkcmVzdWx0 OwpAQCAtMTk3NiwzMyArMTk3NiwzNCBAQCBzdWIgSXNET01Ob2RlVHlwZQogfQogCiAKLXN1YiBO YXRpdmVUb0pTVmFsdWUKK3N1YiBSZXR1cm5OYXRpdmVUb0pTVmFsdWUKIHsKICAgICBteSAkc2ln bmF0dXJlID0gc2hpZnQ7CiAgICAgbXkgJHZhbHVlID0gc2hpZnQ7CisgICAgbXkgJGluZGVudCA9 IHNoaWZ0OwogICAgIG15ICR0eXBlID0gJGNvZGVHZW5lcmF0b3ItPlN0cmlwTW9kdWxlKCRzaWdu YXR1cmUtPnR5cGUpOwogICAgIG15ICRjbGFzc05hbWU9ICJWOCR0eXBlIjsKIAotICAgIHJldHVy biAidjg6OkRhdGU6Ok5ldyhzdGF0aWNfY2FzdDxkb3VibGU+KCR2YWx1ZSkpIiBpZiAkdHlwZSBl cSAiRE9NVGltZVN0YW1wIjsKLSAgICByZXR1cm4gIiR2YWx1ZSA/IHY4OjpUcnVlKCkgOiB2ODo6 RmFsc2UoKSIgaWYgJHR5cGUgZXEgImJvb2xlYW4iOwotICAgIHJldHVybiAidjg6OlVuZGVmaW5l ZCgpIiBpZiAkdHlwZSBlcSAidm9pZCI7CisgICAgcmV0dXJuICJyZXR1cm4gdjg6OkRhdGU6Ok5l dyhzdGF0aWNfY2FzdDxkb3VibGU+KCR2YWx1ZSkpIiBpZiAkdHlwZSBlcSAiRE9NVGltZVN0YW1w IjsKKyAgICByZXR1cm4gInJldHVybiAkdmFsdWUgPyB2ODo6VHJ1ZSgpIDogdjg6OkZhbHNlKCki IGlmICR0eXBlIGVxICJib29sZWFuIjsKKyAgICByZXR1cm4gInJldHVybiB2ODo6VW5kZWZpbmVk KCkiIGlmICR0eXBlIGVxICJ2b2lkIjsKIAogICAgICMgRm9yIGFsbCB0aGUgdHlwZXMgd2hlcmUg d2UgdXNlICdpbnQnIGFzIHRoZSByZXByZXNlbnRhdGlvbiB0eXBlLAogICAgICMgd2UgdXNlIElu dGVnZXI6Ok5ldyB3aGljaCBoYXMgYSBmYXN0IFNtaSBjb252ZXJzaW9uIGNoZWNrLgotICAgIHJl dHVybiAidjg6OkludGVnZXI6Ok5ldygkdmFsdWUpIiBpZiBHZXROYXRpdmVUeXBlKCR0eXBlKSBl cSAiaW50IjsKKyAgICByZXR1cm4gInJldHVybiB2ODo6SW50ZWdlcjo6TmV3KCR2YWx1ZSkiIGlm IEdldE5hdGl2ZVR5cGUoJHR5cGUpIGVxICJpbnQiOwogCi0gICAgcmV0dXJuICJ2ODo6TnVtYmVy OjpOZXcoJHZhbHVlKSIgaWYgJGNvZGVHZW5lcmF0b3ItPklzUHJpbWl0aXZlVHlwZSgkdHlwZSkg b3IgJHR5cGUgZXEgIlNWR1BhaW50VHlwZSI7CisgICAgcmV0dXJuICJyZXR1cm4gdjg6Ok51bWJl cjo6TmV3KCR2YWx1ZSkiIGlmICRjb2RlR2VuZXJhdG9yLT5Jc1ByaW1pdGl2ZVR5cGUoJHR5cGUp IG9yICR0eXBlIGVxICJTVkdQYWludFR5cGUiOwogCiAgICAgaWYgKCRjb2RlR2VuZXJhdG9yLT5J c1N0cmluZ1R5cGUoJHR5cGUpKSB7CiAgICAgICAgIG15ICRjb252ID0gJHNpZ25hdHVyZS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57IkNvbnZlcnROdWxsU3RyaW5nVG8ifTsKICAgICAgICAgaWYgKGRl ZmluZWQgJGNvbnYpIHsKLSAgICAgICAgICAgIHJldHVybiAidjhTdHJpbmdPck51bGwoJHZhbHVl KSIgaWYgJGNvbnYgZXEgIk51bGwiOwotICAgICAgICAgICAgcmV0dXJuICJ2OFN0cmluZ09yVW5k ZWZpbmVkKCR2YWx1ZSkiIGlmICRjb252IGVxICJVbmRlZmluZWQiOwotICAgICAgICAgICAgcmV0 dXJuICJ2OFN0cmluZ09yRmFsc2UoJHZhbHVlKSIgaWYgJGNvbnYgZXEgIkZhbHNlIjsKKyAgICAg ICAgICAgIHJldHVybiAicmV0dXJuIHY4U3RyaW5nT3JOdWxsKCR2YWx1ZSkiIGlmICRjb252IGVx ICJOdWxsIjsKKyAgICAgICAgICAgIHJldHVybiAicmV0dXJuIHY4U3RyaW5nT3JVbmRlZmluZWQo JHZhbHVlKSIgaWYgJGNvbnYgZXEgIlVuZGVmaW5lZCI7CisgICAgICAgICAgICByZXR1cm4gInJl dHVybiB2OFN0cmluZ09yRmFsc2UoJHZhbHVlKSIgaWYgJGNvbnYgZXEgIkZhbHNlIjsKIAogICAg ICAgICAgICAgZGllICJVbmtub3duIHZhbHVlIGZvciBDb252ZXJ0TnVsbFN0cmluZ1RvIGV4dGVu ZGVkIGF0dHJpYnV0ZSI7CiAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuICJ2OFN0cmluZygkdmFs dWUpIjsKKyAgICAgICAgcmV0dXJuICJyZXR1cm4gdjhTdHJpbmcoJHZhbHVlKSI7CiAgICAgfQog CiAgICAgIyBWOCBzcGVjaWZpYy4KQEAgLTIwMTIsMzAgKzIwMTMsMzIgQEAgc3ViIE5hdGl2ZVRv SlNWYWx1ZQogCiAgICAgIyBzcGVjaWFsIGNhc2UgZm9yIG5vbi1ET00gbm9kZSBpbnRlcmZhY2Vz CiAgICAgaWYgKElzRE9NTm9kZVR5cGUoJHR5cGUpKSB7Ci0gICAgICAgIHJldHVybiAiVjhQcm94 eTo6Y29udmVydE5vZGVUb1Y4T2JqZWN0KCR2YWx1ZSkiOworICAgICAgICByZXR1cm4gInJldHVy biBWOFByb3h5Ojpjb252ZXJ0Tm9kZVRvVjhPYmplY3QoJHZhbHVlKSI7CiAgICAgfQogCiAgICAg aWYgKCR0eXBlIGVxICJFdmVudFRhcmdldCIgb3IgJHR5cGUgZXEgIlNWR0VsZW1lbnRJbnN0YW5j ZSIpIHsKLSAgICAgICAgcmV0dXJuICJWOFByb3h5Ojpjb252ZXJ0RXZlbnRUYXJnZXRUb1Y4T2Jq ZWN0KCR2YWx1ZSkiOworICAgICAgICByZXR1cm4gInJldHVybiBWOFByb3h5Ojpjb252ZXJ0RXZl bnRUYXJnZXRUb1Y4T2JqZWN0KCR2YWx1ZSkiOwogICAgIH0KIAogICAgIGlmICgkdHlwZSBlcSAi RXZlbnQiKSB7Ci0gICAgICAgIHJldHVybiAiVjhQcm94eTo6Y29udmVydEV2ZW50VG9WOE9iamVj dCgkdmFsdWUpIjsKKyAgICAgICAgcmV0dXJuICJyZXR1cm4gVjhQcm94eTo6Y29udmVydEV2ZW50 VG9WOE9iamVjdCgkdmFsdWUpIjsKICAgICB9CiAKICAgICBpZiAoJHR5cGUgZXEgIkV2ZW50TGlz dGVuZXIiKSB7Ci0gICAgICAgIHJldHVybiAiVjhQcm94eTo6Y29udmVydEV2ZW50TGlzdGVuZXJU b1Y4T2JqZWN0KCR2YWx1ZSkiOworICAgICAgICByZXR1cm4gInJldHVybiBWOFByb3h5Ojpjb252 ZXJ0RXZlbnRMaXN0ZW5lclRvVjhPYmplY3QoJHZhbHVlKSI7CiAgICAgfQogCiAgICAgaWYgKCR0 eXBlIGVxICJSR0JDb2xvciIpIHsKLSAgICAgICAgcmV0dXJuICJWOFByb3h5Ojpjb252ZXJ0VG9W OE9iamVjdChWOENsYXNzSW5kZXg6OlJHQkNPTE9SLCBuZXcgUkdCQ29sb3IoJHZhbHVlKSkiOwor ICAgICAgICBteSAkY29uc3RydWN0ID0gIlJlZlB0cjxSR0JDb2xvcj4gcmdiY29sb3IgPSBSR0JD b2xvcjo6Y3JlYXRlKCR2YWx1ZSk7XG4iOworICAgICAgICBteSAkY29udmVydCA9ICJWOFByb3h5 Ojpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OlJHQkNPTE9SLCBXVEY6OmdldFB0cihy Z2Jjb2xvcikpIjsKKyAgICAgICAgcmV0dXJuICRjb25zdHJ1Y3QgLiAkaW5kZW50IC4gInJldHVy biAiIC4gJGNvbnZlcnQ7CiAgICAgfQogCiAgICAgaWYgKCR0eXBlIGVxICJXb3JrZXJDb250ZXh0 IiBvciAkdHlwZSBlcSAiV29ya2VyTG9jYXRpb24iIG9yICR0eXBlIGVxICJXb3JrZXJOYXZpZ2F0 b3IiKSB7CiAgICAgICAgICRpbXBsSW5jbHVkZXN7IldvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94 eS5oIn0gPSAxOwogICAgICAgICBteSAkY2xhc3NJbmRleCA9IHVjKCR0eXBlKTsKIAotICAgICAg ICByZXR1cm4gIldvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6VG9WOE9iamVjdChWOENsYXNz SW5kZXg6OiRjbGFzc0luZGV4LCAkdmFsdWUpIjsKKyAgICAgICAgcmV0dXJuICJyZXR1cm4gV29y a2VyQ29udGV4dEV4ZWN1dGlvblByb3h5OjpUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6JGNsYXNz SW5kZXgsICR2YWx1ZSkiOwogICAgIH0KIAogICAgIGVsc2UgewpAQCAtMjA0Nyw3ICsyMDUwLDcg QEAgc3ViIE5hdGl2ZVRvSlNWYWx1ZQogICAgICAgICAgICAgJHZhbHVlID0gR2VuZXJhdGVTVkdT dGF0aWNQb2RUeXBlV3JhcHBlcigkdHlwZSwgJHZhbHVlKTsKICAgICAgICAgfQogCi0gICAgICAg IHJldHVybiAiVjhQcm94eTo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjokY2xhc3NJ bmRleCwgJHZhbHVlKSI7CisgICAgICAgIHJldHVybiAicmV0dXJuIFY4UHJveHk6OmNvbnZlcnRU b1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6JGNsYXNzSW5kZXgsICR2YWx1ZSkiOwogICAgIH0KIH0K IAo=