269548 2024-02-15 21:53:46 -0800 Adopt more smart pointers in AXObjectCache.cpp 2024-02-19 04:08:18 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez dpino andresg_22 dpino webkit-bug-importer oldest_to_newest 2014321 0 cdumez 2024-02-15 21:53:46 -0800 Adopt more smart pointers in AXObjectCache.cpp, as reported by the static analyzer. 2014322 1 webkit-bug-importer 2024-02-15 21:54:09 -0800 <rdar://problem/123066225> 2014324 2 cdumez 2024-02-15 21:55:50 -0800 Pull request: https://github.com/WebKit/WebKit/pull/24582 2014711 3 ews-feeder 2024-02-16 16:16:29 -0800 Committed 274894@main (4c899d7a2ab1): <https://commits.webkit.org/274894@main> Reviewed commits have been landed. Closing PR #24582 and removing active labels. 2015050 4 dpino 2024-02-19 03:55:19 -0800 Debian Stable build bot is failing after this change: https://build.webkit.org/#/builders/46/builds/37636 ``` In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-1.cpp:7: ../../../Source/WebCore/accessibility/AXTextMarker.cpp: In member function ‘WebCore::AXTextMarker::operator WebCore::CharacterOffset() const’: ../../../Source/WebCore/accessibility/AXTextMarker.cpp:163:28: error: ‘auto’ parameter not permitted in this context 163 | CharacterOffset result(RefPtr { m_data.node }.get(), m_data.characterStart, m_data.characterOffset); | ^~~~~~ ``` 2015051 5 dpino 2024-02-19 03:56:36 -0800 Re-opening for pull request https://github.com/webkit/webkit/pull/24734 2015054 6 ews-feeder 2024-02-19 04:08:16 -0800 Committed 274968@main (fe3079fddbfb): <https://commits.webkit.org/274968@main> Reviewed commits have been landed. Closing PR #24734 and removing active labels.