<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>269521</bug_id>
          
          <creation_ts>2024-02-15 15:53:01 -0800</creation_ts>
          <short_desc>[JSC] Add option to toggle allocation profiling hooks</short_desc>
          <delta_ts>2024-02-16 09:36:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=262827</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=266110</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Degazio">d_degazio</reporter>
          <assigned_to name="David Degazio">d_degazio</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2014201</commentid>
    <comment_count>0</comment_count>
    <who name="David Degazio">d_degazio</who>
    <bug_when>2024-02-15 15:53:01 -0800</bug_when>
    <thetext>rdar://123044980

In https://bugs.webkit.org/show_bug.cgi?id=262827 we introduced some preprocessor hooks allowing for WebKit contributors to decorate different points in the WebKit allocators with profiling code. However, it&apos;s a bit of a nuisance for this profiling to only be toggle-able at build time. In order to allow switching allocation profiling extensions on or off more conveniently, let&apos;s add a new option to JSC reserved for use in allocation profiling extensions. The main value of this option is that it will communicate its value through the additional bytes of g_config reserved in https://bugs.webkit.org/show_bug.cgi?id=266110, so it may be linked against and queried in the libPAS/bmalloc layer via external reference to g_config, unlike other JSC options which are managed at a later stage and have a C++ interface.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2014212</commentid>
    <comment_count>1</comment_count>
    <who name="David Degazio">d_degazio</who>
    <bug_when>2024-02-15 16:20:00 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/24561</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2014524</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-02-16 09:36:33 -0800</bug_when>
    <thetext>Committed 274842@main (f76e442c710f): &lt;https://commits.webkit.org/274842@main&gt;

Reviewed commits have been landed. Closing PR #24561 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>