26951 2009-07-03 01:21:57 -0700 bugzilla-tool forgot how to obsolete patches 2009-07-06 15:32:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs webkit-unassigned eric oldest_to_newest 129686 0 mjs 2009-07-03 01:21:57 -0700 With the bugzilla 3.0 upgrade, bugzilla-tool forgot how to properly obsolete previews patches when posting a diff. 129687 1 32226 mjs 2009-07-03 01:24:28 -0700 Created attachment 32226 patch 129688 2 32226 eric 2009-07-03 01:27:45 -0700 Comment on attachment 32226 patch The check-for-global-initializers change seems unrelated and should be removed, no? Otherwise looks fine. 130037 3 eric 2009-07-06 15:32:47 -0700 Landed as http://trac.webkit.org/changeset/45544 32226 2009-07-03 01:24:28 -0700 2009-07-03 01:27:45 -0700 patch bugzilla_requires_a_filename.patch text/plain 2471 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ1NTMw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDct MDMgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBidWd6aWxsYS10b29sIGZvcmdvdCBob3cg dG8gb2Jzb2xldGUgcGF0Y2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjY5NTEKKworICAgICAgICAqIFNjcmlwdHMvY2hlY2stZm9yLWdsb2JhbC1p bml0aWFsaXplcnM6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5OgorCiAy MDA5LTA3LTAyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkIGJ1aWxkIGZpeCAoQ2Fpcm8gdGhpcyB0aW1lKSBmb3IgRHVtcFJlbmRlclRy ZWUuCkluZGV4OiBTY3JpcHRzL2NoZWNrLWZvci1nbG9iYWwtaW5pdGlhbGl6ZXJzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNjcmlwdHMvY2hlY2stZm9yLWdsb2JhbC1pbml0aWFsaXplcnMJKHJldmlzaW9uIDQ1 NTI4KQorKysgU2NyaXB0cy9jaGVjay1mb3ItZ2xvYmFsLWluaXRpYWxpemVycwkod29ya2luZyBj b3B5KQpAQCAtOTEsNyArOTEsNyBAQCBmb3IgbXkgJGZpbGUgKHNvcnQgQGZpbGVzKSB7CiAgICAg ICAgICRzaG9ydE5hbWUgPX4gcy8uKlwvLy87CiAKICAgICAgICAgIyBTcGVjaWFsIGNhc2VzIGZv ciBmaWxlcyB0aGF0IGhhdmUgaW5pdGlhbGl6ZXJzIGluIGRlYnVnIGJ1aWxkcy4KLSAgICAgICAg aWYgKCRjb25maWd1cmF0aW9uIGVxICJEZWJ1ZyIgb3IgJHZhcmlhbnQgZXEgImRlYnVnIiBvciAk ZGVidWdSb290KSB7CisgICAgICAgIGlmICgkY29uZmlndXJhdGlvbiBlcSAiRGVidWciIG9yICR2 YXJpYW50IGVxICJkZWJ1ZyIgb3IgJGRlYnVnUm9vdCBvciAkY29uZmlndXJhdGlvbiBlcSAiUmVs ZWFzZSIpIHsKICAgICAgICAgICAgIGlmICgkdGFyZ2V0IGVxICJKYXZhU2NyaXB0Q29yZSIpIHsK ICAgICAgICAgICAgICAgICBuZXh0IGlmICRzaG9ydE5hbWUgZXEgIkFsbEluT25lRmlsZS5vIjsK ICAgICAgICAgICAgICAgICBuZXh0IGlmICRzaG9ydE5hbWUgZXEgIk9wY29kZS5vIjsKSW5kZXg6 IFNjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTY3JpcHRzL21vZHVs ZXMvYnVnemlsbGEucHkJKHJldmlzaW9uIDQ1NTI4KQorKysgU2NyaXB0cy9tb2R1bGVzL2J1Z3pp bGxhLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNDgsNyArMTQ4LDcgQEAgY2xhc3MgQnVnemlsbGE6 CiAgICAgICAgICAgICBhdHRhY2htZW50WydpZCddID0gc3RyKGVsZW1lbnQuZmluZCgnYXR0YWNo aWQnKS5zdHJpbmcpCiAgICAgICAgICAgICBhdHRhY2htZW50Wyd1cmwnXSA9IHNlbGYuYXR0YWNo bWVudF91cmxfZm9yX2lkKGF0dGFjaG1lbnRbJ2lkJ10pCiAgICAgICAgICAgICBhdHRhY2htZW50 WyduYW1lJ10gPSB1bmljb2RlKGVsZW1lbnQuZmluZCgnZGVzYycpLnN0cmluZykKLSAgICAgICAg ICAgIGF0dGFjaG1lbnRbJ3R5cGUnXSA9IHN0cihlbGVtZW50LmZpbmQoJ2N0eXBlJykuc3RyaW5n KQorICAgICAgICAgICAgYXR0YWNobWVudFsndHlwZSddID0gc3RyKGVsZW1lbnQuZmluZCgndHlw ZScpLnN0cmluZykKIAogICAgICAgICAgICAgcmV2aWV3X2ZsYWcgPSBlbGVtZW50LmZpbmQoJ2Zs YWcnLCBhdHRycz17Im5hbWUiIDogInJldmlldyJ9KQogICAgICAgICAgICAgaWYgcmV2aWV3X2Zs YWcgYW5kIHJldmlld19mbGFnWydzdGF0dXMnXSA9PSAnKyc6CkBAIC0yNTcsNyArMjU3LDcgQEAg Y2xhc3MgQnVnemlsbGE6CiAgICAgICAgICAgICByZXR1cm4KIAogICAgICAgICBzZWxmLmJyb3dz ZXIub3BlbihzZWxmLmF0dGFjaG1lbnRfdXJsX2Zvcl9pZChhdHRhY2htZW50X2lkLCAnZWRpdCcp KQotICAgICAgICBzZWxmLmJyb3dzZXIuc2VsZWN0X2Zvcm0obnI9MCkKKyAgICAgICAgc2VsZi5i cm93c2VyLnNlbGVjdF9mb3JtKG5yPTEpCiAgICAgICAgIHNlbGYuYnJvd3Nlci5maW5kX2NvbnRy b2woJ2lzb2Jzb2xldGUnKS5pdGVtc1swXS5zZWxlY3RlZCA9IFRydWUKICAgICAgICAgIyBBbHNv IGNsZWFyIGFueSByZXZpZXcgZmxhZyAodG8gcmVtb3ZlIGl0IGZyb20gcmV2aWV3L2NvbW1pdCBx dWV1ZXMpCiAgICAgICAgIHNlbGYuYnJvd3Nlci5maW5kX2NvbnRyb2wodHlwZT0nc2VsZWN0Jywg bnI9MCkudmFsdWUgPSAoIlgiLCk=