269477 2024-02-15 10:03:49 -0800 auto-start-reverse WPT is failing 2025-08-21 20:30:08 -0700 1 1 1 Unclassified WebKit SVG Safari 17 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=138456 https://svgwg.org/svg2-draft/painting.html#InterfaceSVGMarkerElement InRadar P2 Normal --- 138456 1 karlcow karlcow ahmad.saleem792 sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 2013991 0 karlcow 2024-02-15 10:03:49 -0800 In expose auto-start-reverse enum value https://bugzilla.mozilla.org/show_bug.cgi?id=1685543 related to https://github.com/w3c/svgwg/issues/424 > RESOLVED: Where SVG 2 has added a new attribute value for an attribute that has an existing DOM enumeration, we will add matching new enumeration values https://github.com/w3c/svgwg/issues/424#issuecomment-387176205 The spec is: https://svgwg.org/svg2-draft/painting.html#InterfaceSVGMarkerElement Currently Safari fails: https://wpt.fyi/results/svg/types/scripted/SVGAnimatedEnumeration-SVGMarkerElement.html What the test is doing. function createMarker() { let markerElement = document.createElementNS("http://www.w3.org/2000/svg", "marker"); markerElement.setAttribute("markerUnits", "userSpaceOnUse"); markerElement.setAttribute("orient", "auto"); return markerElement; } let markerElement = createMarker(); // Switch to 'auto-start-reverse' value - by modifying orientType. markerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO_START_REVERSE; assert_equals(markerElement.orientAngle.baseVal.value, 0); assert_equals(markerElement.orientAngle.baseVal.unitType, SVGAngle.SVG_ANGLETYPE_UNSPECIFIED); assert_equals(markerElement.orientType.baseVal, SVGMarkerElement.SVG_MARKER_ORIENT_AUTO_START_REVERSE); assert_equals(markerElement.getAttribute('orient'), "auto-start-reverse"); }, "Test auto-start-reverse"); 2013993 1 karlcow 2024-02-15 10:07:22 -0800 but it seems the spec has not been updated yet?! I don't see SVG_MARKER_ORIENT_AUTO_START_REVERSE 2014031 2 ahmad.saleem792 2024-02-15 11:26:11 -0800 Some WPTs: > marker-orient-001.svg > SVGAnimatedEnumeration-SVGMarkerElement.html > animate-marker-orient-from-auto-to-auto-start-reverse.html ___ NOTE - from `See Also` - we do support it but I think we don't have all the hooks configured properly or something else. Still need to investigate but adding information here as note keeping. 2014234 3 karlcow 2024-02-15 17:19:49 -0800 The goal is to add const unsigned short SVG_MARKER_ORIENT_AUTO_START_REVERSE = 3; to the idl file https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGMarkerElement.idl The equivalent on Gecko https://searchfox.org/mozilla-central/source/dom/webidl/SVGMarkerElement.webidl But to make sure to not break anything too. So probably a couple of modifications in the process. Once it is done, all the tests from https://wpt.fyi/results/svg/types/scripted/SVGAnimatedEnumeration-SVGMarkerElement.html will pass. 2014268 4 ahmad.saleem792 2024-02-15 18:29:22 -0800 (In reply to Karl Dubost from comment #3) > The goal is to add > const unsigned short SVG_MARKER_ORIENT_AUTO_START_REVERSE = 3; > to the idl file > https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGMarkerElement.idl > > The equivalent on Gecko > https://searchfox.org/mozilla-central/source/dom/webidl/SVGMarkerElement. > webidl > > But to make sure to not break anything too. So probably a couple of > modifications in the process. > > Once it is done, all the tests from > https://wpt.fyi/results/svg/types/scripted/SVGAnimatedEnumeration- > SVGMarkerElement.html > > will pass. Tried this: > Source/WebCore/svg/SVGMarkerElement.idl: const unsigned short SVG_MARKER_ORIENT_AUTO_START_REVERSE = 3; > Source/WebCore/svg/SVGMarkerTypes.h (in enum - SVGMarkerOrientType): Change: SVGMarkerOrientAutoStartReverse = SVGMarkerOrientUnknown to: SVGMarkerOrientAutoStartReverse > Source/WebCore/svg/SVGMarkerElement.h (in enum): SVG_MARKER_ORIENT_AUTO_START_REVERSE = SVGMarkerOrientAutoStartReverse and (this might not be required): void setOrientToAutoReverseAngle(const SVGAngle&); > Source/WebCore/svg/SVGMarkerElement.cpp: void SVGMarkerElement::setOrientToAutoReverseAngle(const SVGAngle& autoreverseangle) { Ref { m_orientAngle } -> baseVal()->newValueSpecifiedUnits(autoreverseangle.unitType(), autoreverseangle.valueInSpecifiedUnits()); invalidateMarkerResource(); } (Similar to setOrientToAuto) - but need fixing. ___ This compiles but don't progress anything and get 'Type Error'. Just initial start. 2014317 5 karlcow 2024-02-15 21:52:49 -0800 Ahmad, This probably needs to be changed too. https://searchfox.org/wubkat/rev/c40451f6052e2805fb1c6abfb61fa322c67caf5b/Source/WebCore/svg/SVGMarkerTypes.h#40-48 2016105 6 webkit-bug-importer 2024-02-22 10:04:26 -0800 <rdar://problem/123453058> 2137130 7 karlcow 2025-08-18 01:42:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/49526 2138156 8 ews-feeder 2025-08-21 20:30:06 -0700 Committed 299042@main (ced6588f9f23): <https://commits.webkit.org/299042@main> Reviewed commits have been landed. Closing PR #49526 and removing active labels.