269472 2024-02-15 09:35:07 -0800 REGRESSION(274694@main): Causes crashes when multiple threads are rendering PDF pages 2024-02-15 09:42:21 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 268536 1 commit-queue commit-queue lerica simon.fraser webkit-bug-importer oldest_to_newest 2013976 0 commit-queue 2024-02-15 09:35:07 -0800 https://commits.webkit.org/274694@main introduced a regression: Causes crashes when multiple threads are rendering PDF pages This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 2013978 1 469883 commit-queue 2024-02-15 09:35:13 -0800 Created attachment 469883 REVERT of 274694@main Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 2013979 2 simon.fraser 2024-02-15 09:36:38 -0800 This caused crashes when rdar://119632313 is enabled, which causes multiple threads to be triggering loading at the same time. The "semaphore per request" is needed. 2013982 3 ews-feeder 2024-02-15 09:41:34 -0800 Committed 274738@main (c030c01b1e1b): <https://commits.webkit.org/274738@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469883. 2013983 4 webkit-bug-importer 2024-02-15 09:42:21 -0800 <rdar://problem/123019776> 469883 2024-02-15 09:35:13 -0800 2024-02-15 09:41:35 -0800 REVERT of 274694@main bug-269472-20240215173512.patch text/plain 5382 commit-queue RnJvbSA5OTFlNTZhYmI3NGFjZTRkODE0YzM1Y2VlZjJlODcyOWZlMGRkY2MwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDb21taXQgUXVldWUgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgpEYXRlOiBUaHUsIDE1IEZlYiAyMDI0IDE3OjM1OjEwICswMDAwClN1YmplY3Q6IFtQQVRDSF0g VW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIDI3NDY5NEBtYWluLgogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2OTQ3MgoKQ2F1c2VzIGNyYXNoZXMgd2hlbiBtdWx0aXBsZSB0 aHJlYWRzIGFyZSByZW5kZXJpbmcgUERGIHBhZ2VzCgpSZXZlcnRlZCBjaGFuZ2VzZXQ6CgoiRGVh ZGxvY2sgdW5kZXIgflBsdWdpblZpZXcoKSB3aXRoIFBERlBsdWdpbi4iCmh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjg1MzYKaHR0cHM6Ly9jb21taXRzLndlYmtpdC5v cmcvMjc0Njk0QG1haW4KLS0tCiAuLi4vUGx1Z2lucy9QREYvUERGSW5jcmVtZW50YWxMb2FkZXIu aCAgICAgICAgICB8ICAyIC0tCiAuLi4vUGx1Z2lucy9QREYvUERGSW5jcmVtZW50YWxMb2FkZXIu bW0gICAgICAgICB8IDEzICsrKysrLS0tLS0tLS0KIC4uLi9XZWJQcm9jZXNzL1BsdWdpbnMvUERG L1BERlBsdWdpbkJhc2UuaCAgICAgIHwgIDEgLQogLi4uLXBsdWdpbi1oYW5nLWR1cmluZy1kZXN0 cnVjdGlvbi1leHBlY3RlZC50eHQgfCAgMyAtLS0KIC4uLi9wZGYvcGRmLXBsdWdpbi1oYW5nLWR1 cmluZy1kZXN0cnVjdGlvbi5odG1sIHwgMTcgLS0tLS0tLS0tLS0tLS0tLS0KIDUgZmlsZXMgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspLCAzMSBkZWxldGlvbnMoLSkKIGRlbGV0ZSBtb2RlIDEwMDY0 NCBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy9wbHVnaW5zL3BkZi9wZGYtcGx1Z2luLWhhbmctZHVy aW5nLWRlc3RydWN0aW9uLWV4cGVjdGVkLnR4dAogZGVsZXRlIG1vZGUgMTAwNjQ0IExheW91dFRl c3RzL2NvbXBvc2l0aW5nL3BsdWdpbnMvcGRmL3BkZi1wbHVnaW4taGFuZy1kdXJpbmctZGVzdHJ1 Y3Rpb24uaHRtbAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5z L1BERi9QREZJbmNyZW1lbnRhbExvYWRlci5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1Bs dWdpbnMvUERGL1BERkluY3JlbWVudGFsTG9hZGVyLmgKaW5kZXggMWZjZGU2YWViOWRlLi4xMzA2 OGY4OGI1YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BE Ri9QREZJbmNyZW1lbnRhbExvYWRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9Q bHVnaW5zL1BERi9QREZJbmNyZW1lbnRhbExvYWRlci5oCkBAIC0zMSw3ICszMSw2IEBACiAjaW5j bHVkZSA8d3RmL1RocmVhZFNhZmVSZWZDb3VudGVkLmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZFNh ZmVXZWFrUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgotI2luY2x1ZGUgPHd0Zi90 aHJlYWRzL0JpbmFyeVNlbWFwaG9yZS5oPgogCiBPQkpDX0NMQVNTIFBERkRvY3VtZW50OwogCkBA IC0xMTksNyArMTE4LDYgQEAgcHJpdmF0ZToKIAogICAgIFJldGFpblB0cjxQREZEb2N1bWVudD4g bV9iYWNrZ3JvdW5kVGhyZWFkRG9jdW1lbnQ7CiAgICAgUmVmUHRyPFRocmVhZD4gbV9wZGZUaHJl YWQ7Ci0gICAgQmluYXJ5U2VtYXBob3JlIG1fZGF0YVNlbWFwaG9yZTsKIAogICAgIFJlZjxQREZQ bHVnaW5TdHJlYW1Mb2FkZXJDbGllbnQ+IG1fc3RyZWFtTG9hZGVyQ2xpZW50OwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGSW5jcmVtZW50YWxM b2FkZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGSW5jcmVt ZW50YWxMb2FkZXIubW0KaW5kZXggOWUwNzYwYTY4NzIwLi5mZTVhMjA2Y2FjYmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZJbmNyZW1lbnRhbExv YWRlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGSW5j cmVtZW50YWxMb2FkZXIubW0KQEAgLTI5NCw3ICsyOTQsNiBAQCB2b2lkIFBERkluY3JlbWVudGFs TG9hZGVyOjpjbGVhcigpCiAgICAgLy8gd2UgY2FuIGZvcmNlIHRoZSBQREZUaHJlYWQgdG8gY29t cGxldGUgcXVpY2tseQogICAgIGlmIChtX3BkZlRocmVhZCkgewogICAgICAgICB1bmNvbmRpdGlv bmFsQ29tcGxldGVPdXRzdGFuZGluZ1JhbmdlUmVxdWVzdHMoKTsKLSAgICAgICAgbV9kYXRhU2Vt YXBob3JlLnNpZ25hbCgpOwogICAgICAgICBtX3BkZlRocmVhZC0+d2FpdEZvckNvbXBsZXRpb24o KTsKICAgICB9CiB9CkBAIC02NTAsMjEgKzY0OSwxOSBAQCBzaXplX3QgUERGSW5jcmVtZW50YWxM b2FkZXI6OmRhdGFQcm92aWRlckdldEJ5dGVzQXRQb3NpdGlvbih2b2lkKiBidWZmZXIsIG9mZl90 CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAorICAgIFdURjo6U2VtYXBob3JlIGRhdGFTZW1h cGhvcmUgeyAwIH07CiAgICAgc2l6ZV90IGJ5dGVzUHJvdmlkZWQgPSAwOwotICAgIC8vIERvIG5v dCBkaXNwYXRjaCBtYWluIHJ1bmxvb3AgKGFnYWluKSBhbmQgd2FpdCBhbnltb3JlIGlmIHBsdWdp biBoYXMgYmVlbiBkZXN0cm95ZWQuCi0gICAgaWYgKHBsdWdpbi0+aGFzQmVlbkRlc3Ryb3llZCgp KQotICAgICAgICByZXR1cm4gMDsKIAotICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGhp cywgcHJvdGVjdGVkTG9hZGVyID0gUmVmIHsgKnRoaXMgfSwgcG9zaXRpb24sIGNvdW50LCBidWZm ZXIsICZieXRlc1Byb3ZpZGVkXSB7Ci0gICAgICAgIHByb3RlY3RlZExvYWRlci0+Z2V0UmVzb3Vy Y2VCeXRlc0F0UG9zaXRpb24oY291bnQsIHBvc2l0aW9uLCBbdGhpcywgY291bnQsIGJ1ZmZlciwg JmJ5dGVzUHJvdmlkZWRdKGNvbnN0IHVpbnQ4X3QqIGJ5dGVzLCBzaXplX3QgYnl0ZXNDb3VudCkg eworICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbcHJvdGVjdGVkTG9hZGVyID0gUmVmIHsg KnRoaXMgfSwgcG9zaXRpb24sIGNvdW50LCBidWZmZXIsICZkYXRhU2VtYXBob3JlLCAmYnl0ZXNQ cm92aWRlZF0geworICAgICAgICBwcm90ZWN0ZWRMb2FkZXItPmdldFJlc291cmNlQnl0ZXNBdFBv c2l0aW9uKGNvdW50LCBwb3NpdGlvbiwgW2NvdW50LCBidWZmZXIsICZkYXRhU2VtYXBob3JlLCAm Ynl0ZXNQcm92aWRlZF0oY29uc3QgdWludDhfdCogYnl0ZXMsIHNpemVfdCBieXRlc0NvdW50KSB7 CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChieXRlc0NvdW50IDw9IGNvdW50KTsKICAgICAg ICAgICAgIG1lbWNweShidWZmZXIsIGJ5dGVzLCBieXRlc0NvdW50KTsKICAgICAgICAgICAgIGJ5 dGVzUHJvdmlkZWQgPSBieXRlc0NvdW50OwotICAgICAgICAgICAgbV9kYXRhU2VtYXBob3JlLnNp Z25hbCgpOworICAgICAgICAgICAgZGF0YVNlbWFwaG9yZS5zaWduYWwoKTsKICAgICAgICAgfSk7 CiAgICAgfSk7CiAKLSAgICBtX2RhdGFTZW1hcGhvcmUud2FpdCgpOworICAgIGRhdGFTZW1hcGhv cmUud2FpdCgpOwogCiAjaWYgIUxPR19ESVNBQkxFRAogICAgIGRlY3JlbWVudFRocmVhZHNXYWl0 aW5nT25DYWxsYmFjaygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1Bs dWdpbnMvUERGL1BERlBsdWdpbkJhc2UuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVn aW5zL1BERi9QREZQbHVnaW5CYXNlLmgKaW5kZXggNTRhNmQ2NDhmZTU5Li43ODIxZTViNzM3OTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVn aW5CYXNlLmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBs dWdpbkJhc2UuaApAQCAtMjI3LDcgKzIyNyw2IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBi b29sIGRvY3VtZW50RmluaXNoZWRMb2FkaW5nKCkgY29uc3QgeyByZXR1cm4gbV9kb2N1bWVudEZp bmlzaGVkTG9hZGluZzsgfQotICAgIGJvb2wgaGFzQmVlbkRlc3Ryb3llZCgpIGNvbnN0IHsgcmV0 dXJuIG1faGFzQmVlbkRlc3Ryb3llZDsgfQogICAgIHVpbnQ2NF90IHN0cmVhbWVkQnl0ZXMoKSBj b25zdCB7IHJldHVybiBtX3N0cmVhbWVkQnl0ZXM7IH0KICAgICB2b2lkIGVuc3VyZURhdGFCdWZm ZXJMZW5ndGgodWludDY0X3QpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGlu Zy9wbHVnaW5zL3BkZi9wZGYtcGx1Z2luLWhhbmctZHVyaW5nLWRlc3RydWN0aW9uLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3BsdWdpbnMvcGRmL3BkZi1wbHVnaW4taGFu Zy1kdXJpbmctZGVzdHJ1Y3Rpb24tZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCA4YmIyNWRjODBmZWUuLjAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9wbHVnaW5zL3BkZi9wZGYtcGx1Z2luLWhhbmctZHVyaW5nLWRlc3RydWN0aW9uLWV4 cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDMgKzAsMCBAQAotVGhpcyB0ZXN0IHBhc3Nl cyBpZiBpdCBkb2VzIG5vdCB0aW1lb3V0LgotCi0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Nv bXBvc2l0aW5nL3BsdWdpbnMvcGRmL3BkZi1wbHVnaW4taGFuZy1kdXJpbmctZGVzdHJ1Y3Rpb24u aHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3BsdWdpbnMvcGRmL3BkZi1wbHVnaW4taGFu Zy1kdXJpbmctZGVzdHJ1Y3Rpb24uaHRtbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg YWI4M2U1ODI2NjkzLi4wMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcv cGx1Z2lucy9wZGYvcGRmLXBsdWdpbi1oYW5nLWR1cmluZy1kZXN0cnVjdGlvbi5odG1sCisrKyAv ZGV2L251bGwKQEAgLTEsMTcgKzAsMCBAQAotPHNjcmlwdD4KLSAgaWYgKHdpbmRvdy50ZXN0UnVu bmVyKQotICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwotICBvbmxvYWQgPSBhc3luYyAoKSA9 PiB7Ci0gICAgbGV0IGlmcmFtZTAgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdpZnJhbWUnKTsK LSAgICBpZnJhbWUwLnNyYyA9ICdkYXRhOmFwcGxpY2F0aW9uL3BkZix4JzsKLSAgICBkb2N1bWVu dC5ib2R5LmFwcGVuZChpZnJhbWUwKTsKLQotICAgIGF3YWl0IGNhY2hlcy5oYXMoJ2EnKTsKLSAg ICBhd2FpdCBjYWNoZXMuaGFzKCdhJyk7Ci0KLSAgICAkdm0ucHJpbnQoJ2JlZm9yZScpOwotICAg IGlmcmFtZTAucmVtb3ZlKCk7Ci0gICAgJHZtLnByaW50KCdhZnRlcicpOwotICB9OwotPC9zY3Jp cHQ+Ci08cD5UaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IHRpbWVvdXQuPC9wPgpcIE5v IG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK