269429 2024-02-14 20:07:01 -0800 Use enum class for SVG Angle Types as suggested in 274778@main 2026-02-26 02:02:28 -0800 1 1 1 Unclassified WebKit SVG Safari Technology Preview Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=267180 InRadar P2 Normal --- 1 ahmad.saleem792 karlcow karlcow sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 2013779 0 ahmad.saleem792 2024-02-14 20:07:01 -0800 Hi Team, We will rename this bug once the PR lands to commit number but this is about FIXME added by Karl: PR Link - https://github.com/WebKit/WebKit/pull/22653 // FIXME: change the casing style of the enum type or naming of the Angle Value // see https://github.com/WebKit/WebKit/pull/22653#discussion_r1448856015 Where it should be changed to this as per Tim: enum class Type : uint8_t { Unknown, Deg, Rad, Grad, Turn, } WebKit Source (pre PR): https://github.com/WebKit/WebKit/blob/49fef559975eadeb4609dfe423aed84f43dcacb9/Source/WebCore/svg/SVGAngleValue.h#L32 Just wanted to raise before we forget. Thanks! 2013968 1 karlcow 2024-02-15 09:09:34 -0800 How would you solve the difference with IDL? https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGAngleValue.h https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGAngle.idl 2015958 2 webkit-bug-importer 2024-02-21 20:07:14 -0800 <rdar://problem/123419968> 2060316 3 ahmad.saleem792 2024-09-15 09:39:19 -0700 I tried it today but got stuck here: /Users/ahmadsaleem/OpenSource/Source/WebCore/svg/SVGMarkerElement.cpp:163:62: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'SVGAngleValue::Type' 163 | Ref { m_orientAngle }->baseVal()->newValueSpecifiedUnits(angle.unitType(), a... | 2060418 4 karlcow 2024-09-16 05:49:24 -0700 ExceptionOr<void> newValueSpecifiedUnits(unsigned short unitType, float valueInSpecifiedUnits); https://github.com/WebKit/WebKit/blob/84cc6561cbc81c2b2cb3bc36e8d704b78ffe635a/Source/WebCore/svg/SVGAngleValue.h#L54-L55 newValueSpecifiedUnits is expecting a "unsigned short unitType" but not the enum declaration. so probably the types need to be aligned everywhere in the code, whichever is chosen. 2185162 5 karlcow 2026-02-26 02:02:28 -0800 Pull request: https://github.com/WebKit/WebKit/pull/59498