26942 2009-07-02 16:33:21 -0700 Dump As Text doing the wrong thing when overflow is set on replaced elements 2009-07-02 16:53:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hyatt hyatt darin mitz oldest_to_newest 129617 0 hyatt 2009-07-02 16:33:21 -0700 Setting overflow to hidden on replaced elements actually affected the dumping of text results. This should not be happening, since a replaced element doesn't do anything with the overflow value. The implication here is that some code must be looking at the style()->overflowX() value instead of hasOverflowClip on the renderer. 129618 1 hyatt 2009-07-02 16:34:12 -0700 See checkin r45500 for tests that changed when I went from hidden back to visible as the default for replaced elements. 129621 2 32207 hyatt 2009-07-02 16:39:50 -0700 Created attachment 32207 Patch 129624 3 32207 mitz 2009-07-02 16:41:37 -0700 Comment on attachment 32207 Patch r=me assuming the find-on-page tests that were added with Darin’s change still pass 129631 4 hyatt 2009-07-02 16:53:15 -0700 Fixed in r45506. 32207 2009-07-02 16:39:50 -0700 2009-07-02 16:41:37 -0700 Patch patch.txt text/plain 1273 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ1NTAz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDct MDIgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRleHRJdGVyYXRvciBzaG91bGQgdXNlIGhhc092 ZXJmbG93Q2xpcCB3aGVuIGNoZWNraW5nIGZvciBvdmVyZmxvdyBpbnN0ZWFkIG9mIGxvb2tpbmcg YXQgdGhlIHN0eWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjY5NDIKKworICAgICAgICAqIGVkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmZ1bGx5Q2xpcHNDb250ZW50cyk6CisKIDIwMDktMDctMDIgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g QmVybnN0ZWluLgpJbmRleDogZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGVkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAkocmV2aXNpb24gNDU0NzcpCisrKyBlZGl0aW5nL1Rl eHRJdGVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NSwxMCArMTY1LDcgQEAgc3RhdGlj IHVuc2lnbmVkIGRlcHRoQ3Jvc3NpbmdTaGFkb3dCb3VuZAogc3RhdGljIGlubGluZSBib29sIGZ1 bGx5Q2xpcHNDb250ZW50cyhOb2RlKiBub2RlKQogewogICAgIFJlbmRlck9iamVjdCogcmVuZGVy ZXIgPSBub2RlLT5yZW5kZXJlcigpOwotICAgIGlmICghcmVuZGVyZXIgfHwgIXJlbmRlcmVyLT5p c0JveCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgUmVuZGVyU3R5bGUqIHN0eWxlID0g cmVuZGVyZXItPnN0eWxlKCk7Ci0gICAgaWYgKHN0eWxlLT5vdmVyZmxvd1goKSA9PSBPVklTSUJM RSAmJiBzdHlsZS0+b3ZlcmZsb3dZKCkgPT0gT1ZJU0lCTEUpCisgICAgaWYgKCFyZW5kZXJlciB8 fCAhcmVuZGVyZXItPmlzQm94KCkgfHwgIXJlbmRlcmVyLT5oYXNPdmVyZmxvd0NsaXAoKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIHJldHVybiB0b1JlbmRlckJveChyZW5kZXJlciktPnNp emUoKS5pc0VtcHR5KCk7CiB9Cg==