<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>269335</bug_id>
          
          <creation_ts>2024-02-13 16:49:46 -0800</creation_ts>
          <short_desc>Move iPadMini UA overrides to Quirks.cpp</short_desc>
          <delta_ts>2024-10-10 02:17:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>Safari 17</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>281212</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Karl Dubost">karlcow</reporter>
          <assigned_to name="Karl Dubost">karlcow</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2013364</commentid>
    <comment_count>0</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2024-02-13 16:49:46 -0800</bug_when>
    <thetext>Currently the iPad UA override are handled in Source/WebKit/UIProcess/iOS/WebPageProxyIOS.mm
The Quirks are usually handled in Source/WebCore/page/Quirks.cpp

It creates two separate places for checking the domain names where things are handled differently. 
Let&apos;s move in the same place. 

Note that this will not solve the needsQuirk check which needs to be solved separately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2013365</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-02-13 16:49:56 -0800</bug_when>
    <thetext>&lt;rdar://problem/122920694&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2013381</commentid>
    <comment_count>2</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2024-02-13 17:54:11 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/24391</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2013524</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-02-14 09:34:50 -0800</bug_when>
    <thetext>Committed 274631@main (c0bc71135b42): &lt;https://commits.webkit.org/274631@main&gt;

Reviewed commits have been landed. Closing PR #24391 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>