<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26920</bug_id>
          
          <creation_ts>2009-07-02 00:05:35 -0700</creation_ts>
          <short_desc>bugzilla-tool dumps too much junk the the commit comment from git</short_desc>
          <delta_ts>2009-08-17 15:18:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ddkilzer</cc>
    
    <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>129471</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-02 00:05:35 -0700</bug_when>
    <thetext>bugzilla-tool dumps too much junk the the commit comment from git

Only happens when the commit needs to rebase I  think.

Example:

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebKitTools/ChangeLog
        M       WebKitTools/Scripts/bugzilla-tool
        M       WebKitTools/Scripts/modules/scm.py
Committed r45469
        M       WebCore/dom/MessageChannel.cpp
        M       WebCore/dom/MessagePortChannel.cpp
        M       WebCore/dom/default/PlatformMessagePortChannel.cpp
        M       WebCore/dom/MessagePortChannel.h
        M       WebCore/ChangeLog
r45467 = a08d526b1bd9d60aa510e837f37ef18283db029a (trunk)
        M       WebCore/ChangeLog
        M       WebCore/rendering/RenderLayerBacking.cpp
        A      
LayoutTests/platform/mac/compositing/geometry/root-layer-update-expected.png
        A      
LayoutTests/platform/mac/compositing/geometry/root-layer-update-expected.txt
        A      
LayoutTests/platform/mac/compositing/geometry/root-layer-update-expected.checksum
        M       LayoutTests/ChangeLog
        A       LayoutTests/compositing/geometry/root-layer-update.html
r45468 = 25496daa3193049bc58b8c6255dbdba7af72f00a (trunk)
        M       WebKitTools/ChangeLog
        M       WebKitTools/Scripts/modules/scm.py
        M       WebKitTools/Scripts/bugzilla-tool
r45469 = 21a28c8eebc35fcfe1b6453a264f3e208128e89c (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/45469</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129522</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2009-07-02 10:15:53 -0700</bug_when>
    <thetext>I don&apos;t think including the list of files that were committed is useful in any case.  The revision number (rXXXX) and a link to Trac are probably sufficient.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>130098</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-06 19:31:11 -0700</bug_when>
    <thetext>Another victim of this bug! https://bugs.webkit.org/show_bug.cgi?id=27008</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136759</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-03 13:35:39 -0700</bug_when>
    <thetext>*** Bug 27949 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140818</commentid>
    <comment_count>4</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-08-17 13:37:24 -0700</bug_when>
    <thetext>Example of less-verbose commit message:

&lt;https://bugs.webkit.org/show_bug.cgi?id=28393#c2&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140820</commentid>
    <comment_count>5</comment_count>
      <attachid>34989</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-08-17 13:43:49 -0700</bug_when>
    <thetext>Created attachment 34989
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140822</commentid>
    <comment_count>6</comment_count>
      <attachid>34989</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2009-08-17 13:45:21 -0700</bug_when>
    <thetext>Comment on attachment 34989
Patch v1

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140827</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 13:56:13 -0700</bug_when>
    <thetext>Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140844</commentid>
    <comment_count>8</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-08-17 15:17:59 -0700</bug_when>
    <thetext>Committed r47393: &lt;http://trac.webkit.org/changeset/47393&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140845</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-08-17 15:18:05 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34989</attachid>
            <date>2009-08-17 13:43:49 -0700</date>
            <delta_ts>2009-08-17 13:45:20 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-26920-20090817134349.patch</filename>
            <type>text/plain</type>
            <size>1453</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA3NDZjMGZiLi5lYTIwYTcyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMDgt
MTcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAorICAgICAgICA8aHR0cDov
L3dlYmtpdC5vcmcvYi8yNjkyMD4gYnVnemlsbGEtdG9vbCBkdW1wcyB0b28gbXVjaCBqdW5rIHRo
ZSB0aGUgY29tbWl0IGNvbW1lbnQgZnJvbSBnaXQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBOZXcgY29tbWl0IG1lc3NhZ2U6CisgICAgICAgICAgICBD
b21taXR0ZWQgcjEyMzQ1OiA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTIzNDU+
CisKKyAgICAgICAgKiBTY3JpcHRzL2J1Z3ppbGxhLXRvb2w6CisgICAgICAgIChidWdfY29tbWVu
dF9mcm9tX2NvbW1pdF90ZXh0KTogUHJpbnQgb3V0IGEgY29tcGFjdCwKKyAgICAgICAgc3RhbmRh
cmRpemVkIGNvbW1pdCBtZXNzYWdlIGZvciBib3RoIGdpdCBhbmQgc3ZuLgorCisyMDA5LTA4LTE3
ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKICAgICAgICAgPGh0dHA6Ly93
ZWJraXQub3JnL2IvMjgzOTM+IGNoZWNrLXdlYmtpdC1zdHlsZTogYWRkIGNoZWNrIGZvciB1c2Ug
b2Ygc3RkOjptYXgoKS9zdGQ6Om1pbigpIGluc3RlYWQgb2YgTUFYKCkvTUlOKCkKIAogICAgICAg
ICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw
dHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRl
eCAyZTY2Y2VhLi5mNjA5ZmExIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3pp
bGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC0yMTgs
OCArMjE4LDcgQEAgY2xhc3MgQXBwbHlQYXRjaGVzRnJvbUJ1ZyhDb21tYW5kKToKIGRlZiBidWdf
Y29tbWVudF9mcm9tX2NvbW1pdF90ZXh0KHNjbSwgY29tbWl0X3RleHQpOgogICAgIG1hdGNoID0g
cmUuc2VhcmNoKHNjbS5jb21taXRfc3VjY2Vzc19yZWdleHAoKSwgY29tbWl0X3RleHQsIHJlLk1V
TFRJTElORSkKICAgICBzdm5fcmV2aXNpb24gPSBtYXRjaC5ncm91cCgnc3ZuX3JldmlzaW9uJykK
LSAgICBjb21taXRfdGV4dCArPSAoIlxuJXMiICUgdmlld19zb3VyY2VfdXJsKHN2bl9yZXZpc2lv
bikpCi0gICAgcmV0dXJuIGNvbW1pdF90ZXh0CisgICAgcmV0dXJuICJDb21taXR0ZWQgciVzOiA8
JXM+IiAlIChzdm5fcmV2aXNpb24sIHZpZXdfc291cmNlX3VybChzdm5fcmV2aXNpb24pKQogCiAK
IGNsYXNzIFdlYktpdExhbmRpbmdTY3JpcHRzOg==
</data>
<flag name="review"
          id="19162"
          type_id="1"
          status="+"
          setter="aroben"
    />
          </attachment>
      

    </bug>

</bugzilla>