269190 2024-02-12 06:49:31 -0800 [Skia] Building with USE_SKIA=ON still uses Cairo for ImageDiff 2024-02-14 05:46:02 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=269360 InRadar P2 Normal --- 268972 1 aperez cgarcia cgarcia fujii webkit-bug-importer oldest_to_newest 2012691 0 aperez 2024-02-12 06:49:31 -0800 Developer builds with USE_SKIA=ON still check for Cairo: -- Found Cairo: /usr/lib/x86_64-linux-gnu/libcairo.so (found version "1.18.0") This is still used by Tools/ImageDiff/ -- we should make it use Skia as well. 2012696 1 cgarcia 2024-02-12 07:15:43 -0800 Do we even use ImageDiff nowadays? 2012818 2 fujii 2024-02-12 11:52:47 -0800 Yes, ref tests are using ImageDiff. 2013106 3 cgarcia 2024-02-13 02:54:12 -0800 Pull request: https://github.com/WebKit/WebKit/pull/24333 2013140 4 ews-feeder 2024-02-13 05:44:38 -0800 Committed 274544@main (0e6f0245ab8d): <https://commits.webkit.org/274544@main> Reviewed commits have been landed. Closing PR #24333 and removing active labels. 2013141 5 webkit-bug-importer 2024-02-13 05:45:58 -0800 <rdar://problem/122868769>