26916 2009-07-01 22:12:17 -0700 bugzilla-tool needs scm unit tests 2009-08-04 12:18:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 27977 1 eric webkit-unassigned abarth levin oldest_to_newest 129457 0 eric 2009-07-01 22:12:17 -0700 bugzilla-tool needs PyUnit testing. Desperately. I looked at this a little the other day. I found that PyUnit (unitest module) uses a code style which does not conform to modern python style guides. This was very confusing, but shouldn't block me using it. I searched the web a little and did not find any guidance on the matter. git cl (a similar tool which Chromium uses) has a whole set of test suites: http://neugierig.org/software/git/?url=git-cl/tree/test but they're bash files... which is also kinda nasty. (elegant, but nasty). 137019 1 eric 2009-08-04 09:18:04 -0700 I've added a few tests. I'll keep this around for adding the scm_unittest.py (which are the tricky ones). 137077 2 34078 eric 2009-08-04 11:58:04 -0700 Created attachment 34078 Patch v1 137082 3 eric 2009-08-04 12:08:37 -0700 I've broken off the bugzilla bits into bug 27991. 137085 4 34078 abarth 2009-08-04 12:10:49 -0700 Comment on attachment 34078 Patch v1 This looks like a good start. We'll need to do more eventually, but I like the idea of building a fake repo in the tmp directory. 137087 5 eric 2009-08-04 12:18:14 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/scm.py A WebKitTools/Scripts/modules/scm_unittest.py Committed r46772 M WebKitTools/ChangeLog A WebKitTools/Scripts/modules/scm_unittest.py M WebKitTools/Scripts/modules/scm.py r46772 = 2216d9a41da59a3e65c137e9fdd39b75776a7286 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46772 34078 2009-08-04 11:58:04 -0700 2009-08-04 12:10:49 -0700 Patch v1 bug-26916-20090804115802.patch text/plain 7214 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0NzE2NzM1Li43ZDdlZTNlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMDgt MDQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wgbmVlZHMgdW5pdCB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5MTYK KworICAgICAgICBBZGQgc29tZSBiYXNpYyB1bml0IHRlc3RpbmcgZm9yIHNjbS5weS4KKworICAg ICAgICAqIFNjcmlwdHMvbW9kdWxlcy9zY20ucHk6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVz L3NjbV91bml0dGVzdC5weTogQWRkZWQuCisKKzIwMDktMDgtMDQgIEVyaWMgU2VpZGVsICA8ZXJp Y0B3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCiAKICAgICAg ICAgUkVHUkVTU0lPTihyNDY3MDApOiBidWd6aWxsYS10b29sIGxhbmQtZGlmZiBkb3VibGUtc3Bh Y2VzIENoYW5nZUxvZ3MKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9z Y20ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5CmluZGV4IDcwN2RiNDcu LjYzY2QzNzYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY20ucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQpAQCAtMzc4LDYgKzM3OCw3 IEBAIGNsYXNzIEdpdChTQ00pOgogICAgICMgQSBCICAgICA6IFtBLCBCXSAgKGRpZmZlcmVudCBm cm9tIGdpdCBkaWZmLCB3aGljaCB3b3VsZCB1c2UgInJldi1saXN0IEEuLkIiKQogICAgIGRlZiBj b21taXRfaWRzX2Zyb21fY29tbWl0aXNoX2FyZ3VtZW50cyhzZWxmLCBhcmdzKToKICAgICAgICAg aWYgbm90IGxlbihhcmdzKToKKyAgICAgICAgICAgICMgRklYTUU6IHRydW5rIGlzIG5vdCBhbHdh eXMgdGhlIHJlbW90ZSBicmFuY2ggbmFtZSwgbmVlZCBhIHdheSB0byBkZXRlY3QgdGhlIG5hbWUu CiAgICAgICAgICAgICBhcmdzLmFwcGVuZCgndHJ1bmsuLkhFQUQnKQogCiAgICAgICAgIGNvbW1p dF9pZHMgPSBbXQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbV91 bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY21fdW5pdHRlc3QucHkK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNWJmMjcyNgotLS0gL2Rldi9udWxs CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY21fdW5pdHRlc3QucHkKQEAgLTAs MCArMSwxMzkgQEAKKyMgQ29weXJpZ2h0IChDKSAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMKKyMg ICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3Zl IGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIuCisjICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3Jt IG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisjIGluIHRoZSBkb2N1 bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyMgZGlz dHJpYnV0aW9uLgorIyAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRo ZSBuYW1lcyBvZiBpdHMKKyMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3Ig cHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyMgdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNw ZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworIyAiQVMg SVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVU IE5PVAorIyBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJ TElUWSBBTkQgRklUTkVTUyBGT1IKKyMgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlN RUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09OVFJJQlVU T1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisjIFNQ RUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJV VCBOT1QKKyMgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBT RVJWSUNFUzsgTE9TUyBPRiBVU0UsCisjIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElO VEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0YgTElBQklM SVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJ TkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQg T0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitpbXBvcnQgb3MKK2ltcG9ydCBzdWJwcm9jZXNz CitpbXBvcnQgdGVtcGZpbGUKK2ltcG9ydCB1bml0dGVzdAorZnJvbSBtb2R1bGVzLnNjbSBpbXBv cnQgZGV0ZWN0X3NjbV9zeXN0ZW0sIFNDTSwgU2NyaXB0RXJyb3IKKworCisjIEV2ZW50dWFsbHkg d2Ugd2lsbCB3YW50IHRvIHdyaXRlIHRlc3RzIHdoaWNoIHdvcmsgZm9yIGJvdGggc2Ntcy4gKGxp a2UgdXBkYXRlX3dlYmtpdCwgY2hhbmdlZF9maWxlcywgZXRjLikKKyMgUGVyaGFwcyB0aHJvdWdo IHNvbWUgU0NNVGVzdCBiYXNlLWNsYXNzIHdoaWNoIGJvdGggU1ZOVGVzdCBhbmQgR2l0VGVzdCBp bmhlcml0IGZyb20uCisKK2RlZiBydW4oYXJncyk6CisgICAgU0NNLnJ1bl9jb21tYW5kKGFyZ3Mp CisKKyMgRXhpc3RzIHRvIHNoYXJlIHN2biByZXBvc2l0b3J5IGNyZWF0aW9uIGNvZGUgYmV0d2Vl biB0aGUgZ2l0IGFuZCBzdm4gdGVzdHMKK2NsYXNzIFNWTlRlc3RSZXBvc2l0b3J5OgorICAgIEBz dGF0aWNtZXRob2QKKyAgICBkZWYgX3NldHVwX3Rlc3RfY29tbWl0cyh0ZXN0X29iamVjdCk6Cisg ICAgICAgICMgQWRkIHNvbWUgdGVzdCBjb21taXRzCisgICAgICAgIG9zLmNoZGlyKHRlc3Rfb2Jq ZWN0LnN2bl9jaGVja291dF9wYXRoKQorICAgICAgICB0ZXN0X2ZpbGUgPSBvcGVuKCd0ZXN0X2Zp bGUnLCAndycpCisgICAgICAgIHRlc3RfZmlsZS53cml0ZSgidGVzdDEiKQorICAgICAgICB0ZXN0 X2ZpbGUuZmx1c2goKQorICAgICAgICAKKyAgICAgICAgcnVuKFsnc3ZuJywgJ2FkZCcsICd0ZXN0 X2ZpbGUnXSkKKyAgICAgICAgcnVuKFsnc3ZuJywgJ2NvbW1pdCcsICctLXF1aWV0JywgJy0tbWVz c2FnZScsICdpbml0aWFsIGNvbW1pdCddKQorICAgICAgICAKKyAgICAgICAgdGVzdF9maWxlLndy aXRlKCJ0ZXN0MiIpCisgICAgICAgIHRlc3RfZmlsZS5mbHVzaCgpCisgICAgICAgIAorICAgICAg ICBydW4oWydzdm4nLCAnY29tbWl0JywgJy0tcXVpZXQnLCAnLS1tZXNzYWdlJywgJ3NlY29uZCBj b21taXQnXSkKKyAgICAgICAgCisgICAgICAgIHRlc3RfZmlsZS53cml0ZSgidGVzdDMiKQorICAg ICAgICB0ZXN0X2ZpbGUuY2xvc2UoKQorICAgICAgICAKKyAgICAgICAgcnVuKFsnc3ZuJywgJ2Nv bW1pdCcsICctLXF1aWV0JywgJy0tbWVzc2FnZScsICd0aGlyZCBjb21taXQnXSkKKworICAgIEBj bGFzc21ldGhvZAorICAgIGRlZiBzZXR1cChjbHMsIHRlc3Rfb2JqZWN0KToKKyAgICAgICAgIyBD cmVhdGUgYW4gdGVzdCBTVk4gcmVwb3NpdG9yeQorICAgICAgICB0ZXN0X29iamVjdC5zdm5fcmVw b19wYXRoID0gdGVtcGZpbGUubWtkdGVtcChzdWZmaXg9InN2bl90ZXN0X3JlcG8iKQorICAgICAg ICB0ZXN0X29iamVjdC5zdm5fcmVwb191cmwgPSAiZmlsZTovLyVzIiAlIHRlc3Rfb2JqZWN0LnN2 bl9yZXBvX3BhdGggIyBOb3Qgc3VyZSB0aGlzIHdpbGwgd29yayBvbiB3aW5kb3dzCisgICAgICAg ICMgZ2l0IHN2biBjb21wbGFpbnMgaWYgd2UgZG9uJ3QgcGFzcyAtLXByZS0xLjUtY29tcGF0aWJs ZSwgbm90IHN1cmUgd2h5OgorICAgICAgICAjIEV4cGVjdGVkIEZTIGZvcm1hdCAnMic7IGZvdW5k IGZvcm1hdCAnMycgYXQgL3Vzci9sb2NhbC9saWJleGVjL2dpdC1jb3JlLy9naXQtc3ZuIGxpbmUg MTQ3NworICAgICAgICBydW4oWydzdm5hZG1pbicsICdjcmVhdGUnLCAnLS1wcmUtMS41LWNvbXBh dGlibGUnLCB0ZXN0X29iamVjdC5zdm5fcmVwb19wYXRoXSkKKworICAgICAgICAjIENyZWF0ZSBh IHRlc3Qgc3ZuIGNoZWNrb3V0CisgICAgICAgIHRlc3Rfb2JqZWN0LnN2bl9jaGVja291dF9wYXRo ID0gdGVtcGZpbGUubWtkdGVtcChzdWZmaXg9InN2bl90ZXN0X2NoZWNrb3V0IikKKyAgICAgICAg cnVuKFsnc3ZuJywgJ2NoZWNrb3V0JywgJy0tcXVpZXQnLCB0ZXN0X29iamVjdC5zdm5fcmVwb191 cmwsIHRlc3Rfb2JqZWN0LnN2bl9jaGVja291dF9wYXRoXSkKKworICAgICAgICBjbHMuX3NldHVw X3Rlc3RfY29tbWl0cyh0ZXN0X29iamVjdCkKKworICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiB0 ZWFyX2Rvd24oY2xzLCB0ZXN0X29iamVjdCk6CisgICAgICAgIHJ1bihbJ3JtJywgJy1yZicsIHRl c3Rfb2JqZWN0LnN2bl9yZXBvX3BhdGhdKQorICAgICAgICBydW4oWydybScsICctcmYnLCB0ZXN0 X29iamVjdC5zdm5fY2hlY2tvdXRfcGF0aF0pCisKKworY2xhc3MgU1ZOVGVzdCh1bml0dGVzdC5U ZXN0Q2FzZSk6CisKKyAgICBkZWYgc2V0VXAoc2VsZik6CisgICAgICAgIFNWTlRlc3RSZXBvc2l0 b3J5LnNldHVwKHNlbGYpCisgICAgICAgIG9zLmNoZGlyKHNlbGYuc3ZuX2NoZWNrb3V0X3BhdGgp CisKKyAgICBkZWYgdGVhckRvd24oc2VsZik6CisgICAgICAgIFNWTlRlc3RSZXBvc2l0b3J5LnRl YXJfZG93bihzZWxmKQorCisgICAgZGVmIHRlc3RfZGV0ZWN0aW9uKHNlbGYpOgorICAgICAgICBz Y20gPSBkZXRlY3Rfc2NtX3N5c3RlbShzZWxmLnN2bl9jaGVja291dF9wYXRoKQorICAgICAgICBz ZWxmLmFzc2VydEVxdWFsKHNjbS5kaXNwbGF5X25hbWUoKSwgInN2biIpCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoc2NtLnN1cHBvcnRzX2xvY2FsX2NvbW1pdHMoKSwgRmFsc2UpCisKK2NsYXNz IEdpdFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgorCisgICAgZGVmIF9zZXR1cF9naXRfY2xvbmVf b2Zfc3ZuX3JlcG9zaXRvcnkoc2VsZik6CisgICAgICAgIHNlbGYuZ2l0X2NoZWNrb3V0X3BhdGgg PSB0ZW1wZmlsZS5ta2R0ZW1wKHN1ZmZpeD0iZ2l0X3Rlc3RfY2hlY2tvdXQiKQorICAgICAgICAj IC0tcXVpZXQgZG9lc24ndCBtYWtlIGdpdCBzdm4gc2lsZW50LCBzbyB3ZSByZWRpcmVjdCBvdXRw dXQKKyAgICAgICAgYXJncyA9IFsnZ2l0JywgJ3N2bicsICctLXF1aWV0JywgJ2Nsb25lJywgc2Vs Zi5zdm5fcmVwb191cmwsIHNlbGYuZ2l0X2NoZWNrb3V0X3BhdGhdCisgICAgICAgIGdpdF9zdm5f Y2xvbmUgPSBzdWJwcm9jZXNzLlBvcGVuKGFyZ3MsIHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsIHN0 ZGVycj1zdWJwcm9jZXNzLlBJUEUpCisgICAgICAgIGdpdF9zdm5fY2xvbmUuY29tbXVuaWNhdGUo KSAjIGlnbm9yZSBvdXRwdXQKKyAgICAgICAgZ2l0X3N2bl9jbG9uZS53YWl0KCkKKworICAgIGRl ZiBfdGVhcl9kb3duX2dpdF9jbG9uZV9vZl9zdm5fcmVwb3NpdG9yeShzZWxmKToKKyAgICAgICAg cnVuKFsncm0nLCAnLXJmJywgc2VsZi5naXRfY2hlY2tvdXRfcGF0aF0pCisKKyAgICBkZWYgc2V0 VXAoc2VsZik6CisgICAgICAgIFNWTlRlc3RSZXBvc2l0b3J5LnNldHVwKHNlbGYpCisgICAgICAg IHNlbGYuX3NldHVwX2dpdF9jbG9uZV9vZl9zdm5fcmVwb3NpdG9yeSgpCisgICAgICAgIG9zLmNo ZGlyKHNlbGYuZ2l0X2NoZWNrb3V0X3BhdGgpCisKKyAgICBkZWYgdGVhckRvd24oc2VsZik6Cisg ICAgICAgIFNWTlRlc3RSZXBvc2l0b3J5LnRlYXJfZG93bihzZWxmKQorICAgICAgICBzZWxmLl90 ZWFyX2Rvd25fZ2l0X2Nsb25lX29mX3N2bl9yZXBvc2l0b3J5KCkKKworICAgIGRlZiB0ZXN0X2Rl dGVjdGlvbihzZWxmKToKKyAgICAgICAgc2NtID0gZGV0ZWN0X3NjbV9zeXN0ZW0oc2VsZi5naXRf Y2hlY2tvdXRfcGF0aCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzY20uZGlzcGxheV9uYW1l KCksICJnaXQiKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNjbS5zdXBwb3J0c19sb2NhbF9j b21taXRzKCksIFRydWUpCisKKyAgICBkZWYgdGVzdF9jb21taXRpc2hfcGFyc2luZyhzZWxmKToK KyAgICAgICAgc2NtID0gZGV0ZWN0X3NjbV9zeXN0ZW0oc2VsZi5naXRfY2hlY2tvdXRfcGF0aCkK KworICAgICAgICAjIE11bHRpcGxlIHJldmlzaW9ucyBhcmUgY2hlcnJ5LXBpY2tlZC4KKyAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbChsZW4oc2NtLmNvbW1pdF9pZHNfZnJvbV9jb21taXRpc2hfYXJn dW1lbnRzKFsnSEVBRH4yJ10pKSwgMSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChsZW4oc2Nt LmNvbW1pdF9pZHNfZnJvbV9jb21taXRpc2hfYXJndW1lbnRzKFsnSEVBRCcsICdIRUFEfjInXSkp LCAyKQorCisgICAgICAgICMgLi4uIGlzIGFuIGludmFsaWQgcmFuZ2Ugc3BlY2lmaWVyCisgICAg ICAgIHNlbGYuYXNzZXJ0UmFpc2VzKFNjcmlwdEVycm9yLCBzY20uY29tbWl0X2lkc19mcm9tX2Nv bW1pdGlzaF9hcmd1bWVudHMsIFsndHJ1bmsuLi5IRUFEJ10pCisKKworaWYgX19uYW1lX18gPT0g J19fbWFpbl9fJzoKKyAgICB1bml0dGVzdC5tYWluKCk=