26913 2009-07-01 18:27:00 -0700 bugzilla-tool needs to handle login failure 2009-07-02 16:53:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned levin ojan oldest_to_newest 129439 0 eric 2009-07-01 18:27:00 -0700 bugzilla-tool needs to handle login failure Right now bugzilla-tool will probably silently fail if you type your bugzilla credentials wrong. Need to fix that. The offending code can be found in Bugzilla.authenticate() 129610 1 32204 eric 2009-07-02 16:24:36 -0700 Created attachment 32204 patch 129612 2 eric 2009-07-02 16:27:17 -0700 Hopefully this will solve Ojan's issue with the tool. It was failing silently for him. I confirmed (when fixing this) that failing to authenticate would cause silent failure. 129625 3 32204 levin 2009-07-02 16:42:35 -0700 Comment on attachment 32204 patch > diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py > + match = re.search("<title>(.+)</title>", response.read()) You could do a non-greedy match here like this "<title>(.+?)</title>" (which would be more typical for grabbing the context of just one tag) but it isn't necessary here. 129627 4 eric 2009-07-02 16:49:39 -0700 Yeah, I wondered if I shouldn't make it non-greedy. Will fix and land. 129632 5 eric 2009-07-02 16:53:22 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py Committed r45507 M WebCore/editing/TextIterator.cpp M WebCore/ChangeLog r45506 = 55478c55c76eed28de6cfeca788a16c4604e8a02 (trunk) M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py r45507 = fad7ccb51023dad4d4b09407360f769d77de38df (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/45507 129633 6 eric 2009-07-02 16:53:49 -0700 Ojan: please give the tool another try when you get a chance. :) 32204 2009-07-02 16:24:36 -0700 2009-07-02 16:42:35 -0700 patch bugzilla_requires_a_filename.patch text/plain 2395 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZTk4N2U3Li4zZTA2N2ZjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMDktMDct MDIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wgbmVlZHMgdG8gaGFuZGxl IGxvZ2luIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI2OTEzCisKKyAgICAgICAgV2Ugbm93IGV4aXQoMSkgb24gbG9naW4gZmFpbHVyZS4K KworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weToKKworMjAwOS0wNy0wMiAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgTm8gcmV2aWV3LCBqdXN0 IGFkZGluZyBBbnR0aSBhcyBhIHJldmlld2VyLgogCiAgICAgICAgICogU2NyaXB0cy9tb2R1bGVz L2J1Z3ppbGxhLnB5OgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1 Z3ppbGxhLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CmluZGV4 IDIzMzUyMGUuLmJlMzQ2MDIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy9idWd6aWxsYS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEu cHkKQEAgLTI5LDYgKzI5LDcgQEAKICMgV2ViS2l0J3MgUHl0aG9uIG1vZHVsZSBmb3IgaW50ZXJh Y3Rpbmcgd2l0aCBCdWd6aWxsYQogCiBpbXBvcnQgZ2V0cGFzcworaW1wb3J0IHJlCiBpbXBvcnQg c3VicHJvY2VzcwogaW1wb3J0IHN5cwogaW1wb3J0IHVybGxpYjIKQEAgLTU0LDYgKzU1LDEwIEBA IGh0dHA6Ly93d3dzZWFyY2guc291cmNlZm9yZ2UubmV0L21lY2hhbml6ZS8KIGRlZiBsb2coc3Ry aW5nKToKICAgICBwcmludCA+PiBzeXMuc3RkZXJyLCBzdHJpbmcKIAorZGVmIGVycm9yKHN0cmlu Zyk6CisgICAgbG9nKHN0cmluZykKKyAgICBleGl0KDEpCisKICMgRklYTUU6IFRoaXMgc2hvdWxk IG5vdCBkZXBlbmQgb24gZ2l0IGZvciBjb25maWcgc3RvcmFnZQogZGVmIHJlYWRfY29uZmlnKGtl eSk6CiAgICAgIyBOZWVkIGEgd2F5IHRvIHJlYWQgZnJvbSBzdm4gdG9vCkBAIC0xOTYsNyArMjAx LDcgQEAgY2xhc3MgQnVnemlsbGE6CiAgICAgZGVmIGF1dGhlbnRpY2F0ZShzZWxmLCB1c2VybmFt ZT1Ob25lLCBwYXNzd29yZD1Ob25lKToKICAgICAgICAgaWYgc2VsZi5hdXRoZW50aWNhdGVkOgog ICAgICAgICAgICAgcmV0dXJuCi0gICAgICAgIAorCiAgICAgICAgIGlmIG5vdCB1c2VybmFtZToK ICAgICAgICAgICAgIHVzZXJuYW1lID0gcmVhZF9jb25maWcoInVzZXJuYW1lIikKICAgICAgICAg ICAgIGlmIG5vdCB1c2VybmFtZToKQEAgLTIxNCw5ICsyMTksMTQgQEAgY2xhc3MgQnVnemlsbGE6 CiAgICAgICAgIHNlbGYuYnJvd3Nlci5zZWxlY3RfZm9ybShuYW1lPSJsb2dpbiIpCiAgICAgICAg IHNlbGYuYnJvd3NlclsnQnVnemlsbGFfbG9naW4nXSA9IHVzZXJuYW1lCiAgICAgICAgIHNlbGYu YnJvd3NlclsnQnVnemlsbGFfcGFzc3dvcmQnXSA9IHBhc3N3b3JkCi0gICAgICAgIHNlbGYuYnJv d3Nlci5zdWJtaXQoKQorICAgICAgICByZXNwb25zZSA9IHNlbGYuYnJvd3Nlci5zdWJtaXQoKQor CisgICAgICAgIG1hdGNoID0gcmUuc2VhcmNoKCI8dGl0bGU+KC4rKTwvdGl0bGU+IiwgcmVzcG9u c2UucmVhZCgpKQorICAgICAgICAjIElmIHRoZSByZXN1bHRpbmcgcGFnZSBoYXMgYSB0aXRsZSwg YW5kIGl0IGNvbnRhaW5zIHRoZSB3b3JkICJpbnZhbGlkIiBhc3N1bWUgaXQncyB0aGUgbG9naW4g ZmFpbHVyZSBwYWdlLgorICAgICAgICBpZiBtYXRjaCBhbmQgcmUuc2VhcmNoKCJJbnZhbGlkIiwg bWF0Y2guZ3JvdXAoMSksIHJlLklHTk9SRUNBU0UpOgorICAgICAgICAgICAgIyBGSVhNRTogV2Ug Y291bGQgYWRkIHRoZSBhYmlsaXR5IHRvIHRyeSBhZ2FpbiBvbiBmYWlsdXJlLgorICAgICAgICAg ICAgZXJyb3IoIkJ1Z3ppbGxhIGxvZ2luIGZhaWxlZDogJXMiICUgbWF0Y2guZ3JvdXAoMSkpCiAK LSAgICAgICAgIyBXZSByZWFsbHkgc2hvdWxkIGNoZWNrIHRoZSByZXN1bHQgY29kZXMgYW5kIHRy eSBhZ2FpbiBhcyBuZWNlc3NhcnkKICAgICAgICAgc2VsZi5hdXRoZW50aWNhdGVkID0gVHJ1ZQog CiAgICAgZGVmIGFkZF9wYXRjaF90b19idWcoc2VsZiwgYnVnX2lkLCBwYXRjaF9maWxlX29iamVj dCwgZGVzY3JpcHRpb24sIGNvbW1lbnRfdGV4dD1Ob25lLCBtYXJrX2Zvcl9yZXZpZXc9RmFsc2Up Og==