26910 2009-07-01 17:04:37 -0700 [Chromium] Middle-click should set scrollbar position for Linux 2009-07-01 17:54:42 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Trivial --- 0 derat webkit-unassigned agl fishd oldest_to_newest 129419 0 derat 2009-07-01 17:04:37 -0700 To fix http://crbug.com/11976, I'd like middle-clicking on the scrollbar base in the Chromium Linux port to center the scrollbar thumb at the cursor. This is consistent with many other X11 applications (e.g. Firefox and GTK+ apps). I have a small patch that makes this change (for Linux, while leaving the Windows behavior untouched). Assuming that this sounds reasonable, I'll attach it to this bug soon. 129426 1 32164 derat 2009-07-01 17:25:01 -0700 Created attachment 32164 patch to resolve issue 129427 2 agl 2009-07-01 17:25:57 -0700 LGTM 129429 3 32164 levin 2009-07-01 17:42:58 -0700 Comment on attachment 32164 patch to resolve issue Style looks fine and your fellow platform developer thought it looked good, so r+. 32164 2009-07-01 17:25:01 -0700 2009-07-01 17:42:58 -0700 patch to resolve issue webkit_scrollbar_middle_click.diff text/plain 5028 derat SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ1NDU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMDct MDEgIERhbmllbCBFcmF0ICA8ZGVyYXRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMjY5MTA6IFNldCB0aGUgc2Nyb2xsYmFy IHRodW1iIG9uIHNjcm9sbGJhciBtaWRkbGUtY2xpY2sgZm9yIENocm9taXVtIExpbnV4LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5MTAKKworICAg ICAgICBUZXN0ZWQgYnkgYnVpbGRpbmcgQ2hyb21lIGFuZCBjaGVja2luZyB0aGF0IHRoZSBzY3Jv bGxiYXIgbW92ZXMgYXMgZXhwZWN0ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9T Y3JvbGxiYXJUaGVtZUNocm9taXVtLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9T Y3JvbGxiYXJUaGVtZUNocm9taXVtLmg6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vU2Ny b2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1 bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTGludXguaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJv bWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtV2luLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtV2luLmg6CisKIDIwMDktMDctMDEgIENocmlz IEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBP bGl2ZXIgSHVudC4KSW5kZXg6IHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21p dW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hy b21pdW0uY3BwCShyZXZpc2lvbiA0NTQzMSkKKysrIHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJh clRoZW1lQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsOSArMTI4LDQgQEAgdm9p ZCBTY3JvbGxiYXJUaGVtZUNocm9taXVtOjpwYWludFNjcm9sbAogICAgIFNjcm9sbGJhclRoZW1l OjpwYWludFNjcm9sbENvcm5lcih2aWV3LCBjb250ZXh0LCBjb3JuZXJSZWN0KTsKIH0KIAotYm9v bCBTY3JvbGxiYXJUaGVtZUNocm9taXVtOjpzaG91bGRDZW50ZXJPblRodW1iKFNjcm9sbGJhcios IGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZ0KQotewotICAgIHJldHVybiBldnQuc2hpZnRL ZXkoKSAmJiBldnQuYnV0dG9uKCkgPT0gTGVmdEJ1dHRvbjsKLX0KLQogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpJbmRleDogcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW0u aAkocmV2aXNpb24gNDU0MzEpCisrKyBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNo cm9taXVtLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDcgKzQ5LDYgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICB2aXJ0dWFsIEludFJlY3QgdHJhY2tSZWN0KFNjcm9sbGJhciosIGJvb2wg cGFpbnRpbmcgPSBmYWxzZSk7CiAKICAgICAgICAgdmlydHVhbCB2b2lkIHBhaW50U2Nyb2xsQ29y bmVyKFNjcm9sbFZpZXcqLCBHcmFwaGljc0NvbnRleHQqLCBjb25zdCBJbnRSZWN0Jik7Ci0gICAg ICAgIHZpcnR1YWwgYm9vbCBzaG91bGRDZW50ZXJPblRodW1iKFNjcm9sbGJhciosIGNvbnN0IFBs YXRmb3JtTW91c2VFdmVudCYpOwogCiAgICAgICAgIHZpcnR1YWwgdm9pZCBwYWludFRyYWNrQmFj a2dyb3VuZChHcmFwaGljc0NvbnRleHQqLCBTY3JvbGxiYXIqLCBjb25zdCBJbnRSZWN0Jik7CiAg ICAgICAgIHZpcnR1YWwgdm9pZCBwYWludFRpY2ttYXJrcyhHcmFwaGljc0NvbnRleHQqLCBTY3Jv bGxiYXIqLCBjb25zdCBJbnRSZWN0Jik7CkluZGV4OiBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxi YXJUaGVtZUNocm9taXVtTGludXguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL2Nocm9taXVt L1Njcm9sbGJhclRoZW1lQ2hyb21pdW1MaW51eC5jcHAJKHJldmlzaW9uIDQ1NDMxKQorKysgcGxh dGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTQ2LDYgKzE0NiwxMSBAQCB2b2lkIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1MaW51 eDo6cGFpbnRUCiAgICAgfQogfQogCitib29sIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1MaW51eDo6 c2hvdWxkQ2VudGVyT25UaHVtYihTY3JvbGxiYXIqLCBjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQm IGV2dCkKK3sKKyAgICByZXR1cm4gKGV2dC5zaGlmdEtleSgpICYmIGV2dC5idXR0b24oKSA9PSBM ZWZ0QnV0dG9uKSB8fCAoZXZ0LmJ1dHRvbigpID09IE1pZGRsZUJ1dHRvbik7Cit9CisKIEludFNp emUgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4OjpidXR0b25TaXplKFNjcm9sbGJhciogc2Ny b2xsYmFyKQogewogICAgIC8vIE9uIExpbnV4LCB3ZSBkb24ndCB1c2UgYnV0dG9ucwpJbmRleDog cGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4LmgJKHJl dmlzaW9uIDQ1NDMxKQorKysgcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1 bUxpbnV4LmgJKHdvcmtpbmcgY29weSkKQEAgLTQyLDcgKzQyLDcgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRUcmFja1BpZWNlKEdyYXBoaWNzQ29udGV4 dCosIFNjcm9sbGJhciosIGNvbnN0IEludFJlY3QmLCBTY3JvbGxiYXJQYXJ0KTsKICAgICAgICAg dmlydHVhbCB2b2lkIHBhaW50QnV0dG9uKEdyYXBoaWNzQ29udGV4dCosIFNjcm9sbGJhciosIGNv bnN0IEludFJlY3QmLCBTY3JvbGxiYXJQYXJ0KTsKICAgICAgICAgdmlydHVhbCB2b2lkIHBhaW50 VGh1bWIoR3JhcGhpY3NDb250ZXh0KiwgU2Nyb2xsYmFyKiwgY29uc3QgSW50UmVjdCYpOwotCisg ICAgICAgIHZpcnR1YWwgYm9vbCBzaG91bGRDZW50ZXJPblRodW1iKFNjcm9sbGJhciosIGNvbnN0 IFBsYXRmb3JtTW91c2VFdmVudCYpOwogICAgICAgICB2aXJ0dWFsIEludFNpemUgYnV0dG9uU2l6 ZShTY3JvbGxiYXIqKTsKICAgICAgICAgdmlydHVhbCBpbnQgbWluaW11bVRodW1iTGVuZ3RoKFNj cm9sbGJhciopOwogICAgIH07CkluZGV4OiBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVt ZUNocm9taXVtV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxi YXJUaGVtZUNocm9taXVtV2luLmNwcAkocmV2aXNpb24gNDU0MzEpCisrKyBwbGF0Zm9ybS9jaHJv bWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUz LDYgKzI1MywxMSBAQCBpbnQgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bVdpbjo6Z2V0Q2xhc3NpCiAg ICAgcmV0dXJuIChzY3JvbGxiYXItPnByZXNzZWRQYXJ0KCkgPT0gcGFydCkgPyAoREZDU19QVVNI RUQgfCBERkNTX0ZMQVQpIDogMDsKIH0KIAorYm9vbCBTY3JvbGxiYXJUaGVtZUNocm9taXVtV2lu OjpzaG91bGRDZW50ZXJPblRodW1iKFNjcm9sbGJhciosIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVu dCYgZXZ0KQoreworICAgIHJldHVybiBldnQuc2hpZnRLZXkoKSAmJiBldnQuYnV0dG9uKCkgPT0g TGVmdEJ1dHRvbjsKK30KKwogSW50U2l6ZSBTY3JvbGxiYXJUaGVtZUNocm9taXVtV2luOjpidXR0 b25TaXplKFNjcm9sbGJhciogc2Nyb2xsYmFyKQogewogICAgIC8vIE91ciBkZXNpcmVkIHJlY3Qg aXMgZXNzZW50aWFsbHkgdGhpY2tuZXNzIGJ5IHRoaWNrbmVzcy4KSW5kZXg6IHBsYXRmb3JtL2No cm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1XaW4uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9y bS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtV2luLmgJKHJldmlzaW9uIDQ1NDMxKQor KysgcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bVdpbi5oCSh3b3JraW5n IGNvcHkpCkBAIC00NCw2ICs0NCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmly dHVhbCB2b2lkIHBhaW50VHJhY2tQaWVjZShHcmFwaGljc0NvbnRleHQqLCBTY3JvbGxiYXIqLCBj b25zdCBJbnRSZWN0JiwgU2Nyb2xsYmFyUGFydCk7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBwYWlu dEJ1dHRvbihHcmFwaGljc0NvbnRleHQqLCBTY3JvbGxiYXIqLCBjb25zdCBJbnRSZWN0JiwgU2Ny b2xsYmFyUGFydCk7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBwYWludFRodW1iKEdyYXBoaWNzQ29u dGV4dCosIFNjcm9sbGJhciosIGNvbnN0IEludFJlY3QmKTsKKyAgICAgICAgdmlydHVhbCBib29s IHNob3VsZENlbnRlck9uVGh1bWIoU2Nyb2xsYmFyKiwgY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50 Jik7CiAgICAgICAgIHZpcnR1YWwgSW50U2l6ZSBidXR0b25TaXplKFNjcm9sbGJhciopOwogCiAg ICAgcHJpdmF0ZToK