268988 2024-02-08 07:58:09 -0800 The beforeinput event should fire before textInput 2024-05-22 00:06:08 -0700 1 1 1 Unclassified WebKit HTML Editing Safari Technology Preview Unspecified Unspecified REOPENED BrowserCompat, InRadar, WPTImpact P2 Normal --- 274500 1 zcorpan mike ahmad.saleem792 gsnedders karlcow mike webkit-bug-importer wenson_hsieh oldest_to_newest 2011750 0 zcorpan 2024-02-08 07:58:09 -0800 WebKit fires the textInput event before the beforeinput event when typing in an <input>, <textarea> or <div contenteditable>. Chromium fires beforeinput first, which matches the proposed spec. Spec: https://github.com/w3c/uievents/pull/362 Tests: https://github.com/web-platform-tests/wpt/pull/44472 Test results: https://wpt.fyi/results/uievents/textInput/api.html?label=pr_head&max-count=1&pr=44472 2013950 1 webkit-bug-importer 2024-02-15 07:59:28 -0800 <rdar://problem/123013293> 2015055 2 mike 2024-02-19 04:19:28 -0800 Pull request: https://github.com/WebKit/WebKit/pull/24735 2015158 3 mike 2024-02-19 10:08:53 -0800 I believe the patch in https://github.com/WebKit/WebKit/pull/24735 could fix this, but I don’t have any way to test it against the https://github.com/web-platform-tests/wpt/pull/44472 tests with my build — because the tests time out unexpectedly. From chatting with Sam, I’ve gleaned that the unexpected time out might be due to testdriver having not yet implemented something that the WPT tests rely on. The wpt.fyi runner apparently instead uses the WebDriver implementation in wptrunner, which does implement what the WPT tests rely on. 2015167 4 mike 2024-02-19 10:43:49 -0800 Don’t the existing WebKit test results at https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/events/input-events-fired-when-typing-expected.txt actually indicate that WebKit is already actually firing the beforeinput first, as expected? 2015399 5 mike 2024-02-19 21:02:55 -0800 (In reply to sideshowbarker from comment #4) > Don’t the existing WebKit test results at > https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/events/input- > events-fired-when-typing-expected.txt actually indicate that WebKit is > already actually firing the beforeinput first, as expected? Nevermind — that test as currently written doesn’t actually check for the textInput event at all. And when I modify it locally to add a check for the textInput event, I can see it too shows that textInput is getting fired before beforeinput. 2036305 6 ews-feeder 2024-05-19 15:43:56 -0700 Committed 278971@main (7da094e1da19): <https://commits.webkit.org/278971@main> Reviewed commits have been landed. Closing PR #24735 and removing active labels. 2036917 7 mike 2024-05-21 21:45:03 -0700 Reopened Bugzilla. REGRESSION (278971@main): [iOS] Form submission does not occur when pressing the return key, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=274500. 2036936 8 mike 2024-05-22 00:06:08 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28902