26896 2009-07-01 12:21:43 -0700 [QT] make layout tests in fast/css/getComputedStyle/ to pass 2009-07-02 07:15:53 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 26886 0 tonikitoo webkit-unassigned oldest_to_newest 129336 0 tonikitoo 2009-07-01 12:21:43 -0700 Right now fast/css/getComputedStyle/computed-style-font-family.html fails. Font attributes. The font-family should list three families: font-family: monospace, 'Lucida Grande', sans-serif; -font-size: 13px; +font-size: 14px; font-style: normal; font-variant: normal; font-weight: normal; we have set QWebSetting::DefaultFontSize to 14 , intentionally, so plan here is to "fix" DRT to use 13 , which is what is expected by the test results... 129346 1 32137 tonikitoo 2009-07-01 13:15:55 -0700 Created attachment 32137 patch patch for the bug. It was reviewed by Adam Treat on IRC: <manyoso> r=me <manyoso> on condition of one change! <manyoso> you have to add the bug report URL to the ChangeLog and check-in <manyoso> thanks! 129442 2 32137 eric 2009-07-01 19:06:28 -0700 Comment on attachment 32137 patch Please don't mark it as reviewed unless you're a reviewer. :( Makes the scripts unhappy. If Adam Marks this himself someone else can easily commit it. Otherwise he'll need to come take care of commiting for you.. 129501 3 32137 hausmann 2009-07-02 07:15:14 -0700 Comment on attachment 32137 patch Looks good, tried, works. And this time touches only Qt files :) 129502 4 hausmann 2009-07-02 07:15:53 -0700 Landed in r45473 32137 2009-07-01 13:15:55 -0700 2009-07-02 07:15:14 -0700 patch patch text/plain 5137 tonikitoo Y29tbWl0IDc0ZDUyMGZjZmJlYzgyY2EzYjA1YTg2MGRkODRiNTNhM2ExM2NlNWMKQXV0aG9yOiBB bnRvbmlvIEdvbWVzICh0b25pa2l0b28pIDxhbnRvbmlvLmdvbWVzQG9wZW5ib3NzYS5vcmc+CkRh dGU6ICAgV2VkIEp1bCAxIDE1OjE5OjAzIDIwMDkgLTA0MDAKCiAgICAyMDA5LTA3LTAxICBBbnRv bmlvIEdvbWVzICAgPGFudG9uaW8uZ29tZXNAb3BlbmJvc3NhLm9yZz4KICAgIAogICAgICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIFRyZWF0LgogICAgCiAgICAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjg5NgogICAgCiAgICAgICAgICAgIFtRdF0gU2V0 IERSVCdzIGRlZmF1bHQgZm9udHNpemUgdG8gMTMuCiAgICAKICAgICAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHA6CiAgICAKICAgICAgICAgICAgVXBkYXRlZCBj b21wdXRlZC1zdHlsZS1leHBlY3RlZC50eHQgYW5kIGNvbXB1dGVkLXN0eWxlLXdpdGhvdXQtcmVu ZGVyZXItZXhwZWN0ZWQudHh0CiAgICAgICAgICAgIGZpbGVzIGFjY29yZGluZyB0byB0aGUgZGVm YXVsdCBmb250IHNpemUgdmFsdWUgKDEzKSBzZXQgaW4gRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJl bmRlclRyZWUuY3BwIC4KICAgIAogICAgICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvY3NzL2dl dENvbXB1dGVkU3R5bGUvY29tcHV0ZWQtc3R5bGUtZXhwZWN0ZWQudHh0OgogICAgICAgICAgICAq IHBsYXRmb3JtL3F0L2Zhc3QvY3NzL2dldENvbXB1dGVkU3R5bGUvY29tcHV0ZWQtc3R5bGUtd2l0 aG91dC1yZW5kZXJlci1leHBlY3RlZC50eHQ6CgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUwOTk1ZDguLjQzMmE2NzQgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0wMSAgQW50b25pbyBHb21lcyAgIDxhbnRvbmlv LmdvbWVzQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBUcmVhdC4K KwkgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjY4OTYKKworICAgICAgICBVcGRhdGVkIGNvbXB1dGVkLXN0eWxlLWV4cGVjdGVkLnR4dCBh bmQgY29tcHV0ZWQtc3R5bGUtd2l0aG91dC1yZW5kZXJlci1leHBlY3RlZC50eHQKKyAgICAgICAg ZmlsZXMgYWNjb3JkaW5nIHRvIHRoZSBkZWZhdWx0IGZvbnQgc2l6ZSB2YWx1ZSAoMTMpIHNldCBp biBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHAgLgorCisgICAgICAgICogcGxh dGZvcm0vcXQvZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9jb21wdXRlZC1zdHlsZS1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vcXQvZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9j b21wdXRlZC1zdHlsZS13aXRob3V0LXJlbmRlcmVyLWV4cGVjdGVkLnR4dDoKKwogMjAwOS0wNi0z MCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgRGlzYWJsZSB0ZXN0 IHVzaW5nIGV2ZW50U2VuZGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv ZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9jb21wdXRlZC1zdHlsZS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2NvbXB1dGVk LXN0eWxlLWV4cGVjdGVkLnR4dAppbmRleCAzMjZlODVkLi43ZmI1ODUxIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2NvbXB1dGVk LXN0eWxlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2Nz cy9nZXRDb21wdXRlZFN0eWxlL2NvbXB1dGVkLXN0eWxlLWV4cGVjdGVkLnR4dApAQCAtMjksMTEg KzI5LDExIEBAIGRpc3BsYXk6IGJsb2NrOwogZW1wdHktY2VsbHM6IHNob3c7CiBmbG9hdDogbm9u ZTsKIGZvbnQtZmFtaWx5OiBBcmlhbDsKLWZvbnQtc2l6ZTogMTRweDsKK2ZvbnQtc2l6ZTogMTNw eDsKIGZvbnQtc3R5bGU6IG5vcm1hbDsKIGZvbnQtdmFyaWFudDogbm9ybWFsOwogZm9udC13ZWln aHQ6IG5vcm1hbDsKLWhlaWdodDogNTc4cHg7CitoZWlnaHQ6IDU3OXB4OwogbGVmdDogYXV0bzsK IGxldHRlci1zcGFjaW5nOiBub3JtYWw7CiBsaW5lLWhlaWdodDogbm9ybWFsOwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9jb21w dXRlZC1zdHlsZS13aXRob3V0LXJlbmRlcmVyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL3F0L2Zhc3QvY3NzL2dldENvbXB1dGVkU3R5bGUvY29tcHV0ZWQtc3R5bGUtd2l0aG91 dC1yZW5kZXJlci1leHBlY3RlZC50eHQKaW5kZXggNDQzMTMwYy4uYjgxN2UwMiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9jb21w dXRlZC1zdHlsZS13aXRob3V0LXJlbmRlcmVyLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9mYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2NvbXB1dGVkLXN0eWxlLXdp dGhvdXQtcmVuZGVyZXItZXhwZWN0ZWQudHh0CkBAIC0xNiw3ICsxNiw3IEBAIENvbXB1dGVkIHN0 eWxlIG9mIGFuIGVsZW1lbnQgd2hvc2UgcGFyZW50J3MgJ2Rpc3BsYXknIHZhbHVlIGlzICdub25l JzoKICAgICBib3JkZXItcmlnaHQtd2lkdGg6IDBweAogICAgIGJvcmRlci10b3AtY29sb3I6IHJn YigwLCAwLCAwKQogICAgIGJvcmRlci10b3Atc3R5bGU6IHNvbGlkCi0gICAgYm9yZGVyLXRvcC13 aWR0aDogMTRweAorICAgIGJvcmRlci10b3Atd2lkdGg6IDEzcHgKICAgICBib3R0b206IGF1dG8K ICAgICBjYXB0aW9uLXNpZGU6IHRvcAogICAgIGNsZWFyOiBub25lCkBAIC0yOCw3ICsyOCw3IEBA IENvbXB1dGVkIHN0eWxlIG9mIGFuIGVsZW1lbnQgd2hvc2UgcGFyZW50J3MgJ2Rpc3BsYXknIHZh bHVlIGlzICdub25lJzoKICAgICBlbXB0eS1jZWxsczogc2hvdwogICAgIGZsb2F0OiBub25lCiAg ICAgZm9udC1mYW1pbHk6IEFyaWFsCi0gICAgZm9udC1zaXplOiAxNHB4CisgICAgZm9udC1zaXpl OiAxM3B4CiAgICAgZm9udC1zdHlsZTogbm9ybWFsCiAgICAgZm9udC12YXJpYW50OiBub3JtYWwK ICAgICBmb250LXdlaWdodDogbm9ybWFsCkBAIC0yMDcsNyArMjA3LDcgQEAgQ29tcHV0ZWQgc3R5 bGUgb2YgYW4gZWxlbWVudCB3aG9zZSBwYXJlbnQncyAnZGlzcGxheScgdmFsdWUgaXMgJ25vbmUn OgogICAgIC13ZWJraXQtdGV4dC1zaXplLWFkanVzdDogYXV0bwogCiBBZnRlciBjaGFuZ2luZyBn cmFuZHBhcmVudCdzICdjb2xvcicgYW5kIHRoZSBwYXJlbnQncyAnZm9udC1zaXplJyBpbmhlcml0 ZWQgcHJvcGVydGllczoKLSAgICBib3JkZXItdG9wLXdpZHRoOiAxN3B4CisgICAgYm9yZGVyLXRv cC13aWR0aDogMTZweAogICAgIGNvbG9yOiByZ2IoMCwgMCwgMjU1KQogCiBBZnRlciBjaGFuZ2lu ZyB0aGUgcGFyZW50J3MgJ2Rpc3BsYXknIHByb3BlcnR5IHRvICdibG9jaycsIHNvIHRoYXQgdGhl IGNoaWxkIGdldHMgYSByZW5kZXJlcjoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxv ZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA5NDg0MjViLi5lMTY1NWMzIDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMDEgIEFudG9uaW8gR29tZXMgICA8YW50b25pby5nb21l c0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gVHJlYXQuCisJICAg ICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2 ODk2CisKKyAgICAgICAgW1F0XSBTZXQgRFJUJ3MgZGVmYXVsdCBmb250c2l6ZSB0byAxMy4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OldlYlBhZ2U6OldlYlBhZ2UpOgorCiAyMDA5LTA2LTMwICBYYW4gTG9wZXogIDx4 bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3Bw IGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4 IDc4ZDUzNWEuLjA4YmM5OTkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L3F0L0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9x dC9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTg5LDYgKzg5LDkgQEAgV2ViUGFnZTo6V2ViUGFnZShR V2lkZ2V0ICpwYXJlbnQsIER1bXBSZW5kZXJUcmVlICpkcnQpCiB7CiAgICAgc2V0dGluZ3MoKS0+ c2V0Rm9udFNpemUoUVdlYlNldHRpbmdzOjpNaW5pbXVtRm9udFNpemUsIDUpOwogICAgIHNldHRp bmdzKCktPnNldEZvbnRTaXplKFFXZWJTZXR0aW5nczo6TWluaW11bUxvZ2ljYWxGb250U2l6ZSwg NSk7CisgICAgLy8gVG8gZ2V0IERSVCBjb21wbGlhbnQgdG8gc29tZSBsYXlvdXQgdGVzdHMgbGV0 cyBzZXQgdGhlIGRlZmF1bHQgZm9udHNpemUgdG8gMTMuCisgICAgc2V0dGluZ3MoKS0+c2V0Rm9u dFNpemUoUVdlYlNldHRpbmdzOjpEZWZhdWx0Rm9udFNpemUsIDEzKTsKKyAgICBzZXR0aW5ncygp LT5zZXRGb250U2l6ZShRV2ViU2V0dGluZ3M6OkRlZmF1bHRGaXhlZEZvbnRTaXplLCAxMyk7CiAg ICAgc2V0dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdENhbk9w ZW5XaW5kb3dzLCB0cnVlKTsKICAgICBzZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRp bmdzOjpKYXZhc2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkLCB0cnVlKTsKICAgICBzZXR0aW5ncygp LT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpMaW5rc0luY2x1ZGVkSW5Gb2N1c0NoYWluLCBm YWxzZSk7Cg==