26891 2009-07-01 11:34:40 -0700 Remove unused code in SVGTransformList and SVGTransformDistance 2009-07-01 14:07:39 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin eric oldest_to_newest 129319 0 levin 2009-07-01 11:34:40 -0700 This code had the potential to use an uninitialized m_cx, m_cy. Since it is unused, I'm simply removing it. 129321 1 32131 levin 2009-07-01 11:38:30 -0700 Created attachment 32131 patch 129352 2 32131 eric 2009-07-01 13:36:12 -0700 Comment on attachment 32131 patch Why not fix the default constructor? I support removing the dead code though. Wow, this code is old. This was from yet-another attempt at animation by yours truly... forever ago. I think you shoudl fix the default constructor to zero everything instead of changing the callsites. 129361 3 levin 2009-07-01 14:07:39 -0700 Committed as http://trac.webkit.org/changeset/45448 I did a slight modification to change the default constructor as Eric suggested. 32131 2009-07-01 11:38:30 -0700 2009-07-01 13:36:12 -0700 patch bugzilla_requires_a_filename.patch text/plain 4716 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTdjZDQ1Ny4uY2ZjMWJkOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0wMSAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBjb2RlIGluIFNWR1RyYW5zZm9ybUxpc3QgYW5k IFNWR1RyYW5zZm9ybURpc3RhbmNlCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjY4OTE+CisKKyAgICAgICAgKiBzdmcvU1ZHVHJhbnNmb3JtRGlzdGFu Y2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVHJhbnNmb3JtRGlzdGFuY2U6OlNWR1RyYW5z Zm9ybURpc3RhbmNlKToKKyAgICAgICAgKiBzdmcvU1ZHVHJhbnNmb3JtTGlzdC5jcHA6CisgICAg ICAgICogc3ZnL1NWR1RyYW5zZm9ybUxpc3QuaDoKKwogMjAwOS0wNi0zMCAgSmVyZW15IE9ybG93 IChqb3Jsb3dAY2hyb21pdW0ub3JnKQogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmlu LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtRGlzdGFuY2UuY3BwIGIvV2Vi Q29yZS9zdmcvU1ZHVHJhbnNmb3JtRGlzdGFuY2UuY3BwCmluZGV4IDM0YWRjNjMuLjU5ZWI0YjMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybURpc3RhbmNlLmNwcAorKysgYi9X ZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1EaXN0YW5jZS5jcHAKQEAgLTMxLDEyICszMSw2IEBACiAj aW5jbHVkZSA8bWF0aC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Ci0gICAgCi1TVkdUcmFuc2Zv cm1EaXN0YW5jZTo6U1ZHVHJhbnNmb3JtRGlzdGFuY2UoKQotICAgIDogbV90eXBlKFNWR1RyYW5z Zm9ybTo6U1ZHX1RSQU5TRk9STV9VTktOT1dOKQotICAgICwgbV9hbmdsZSgwKQotewotfQogCiBT VkdUcmFuc2Zvcm1EaXN0YW5jZTo6U1ZHVHJhbnNmb3JtRGlzdGFuY2UoU1ZHVHJhbnNmb3JtOjpT VkdUcmFuc2Zvcm1UeXBlIHR5cGUsIGZsb2F0IGFuZ2xlLCBmbG9hdCBjeCwgZmxvYXQgY3ksIGNv bnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4JiB0cmFuc2Zvcm0pCiAgICAgOiBtX3R5cGUodHlwZSkK QEAgLTg3LDEzICs4MSwxNCBAQCBTVkdUcmFuc2Zvcm1EaXN0YW5jZTo6U1ZHVHJhbnNmb3JtRGlz dGFuY2UoY29uc3QgU1ZHVHJhbnNmb3JtJiBmcm9tU1ZHVHJhbnNmb3JtLAogICAgICAgICBtX2Fu Z2xlID0gdG9TVkdUcmFuc2Zvcm0uYW5nbGUoKSAtIGZyb21TVkdUcmFuc2Zvcm0uYW5nbGUoKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KIAog U1ZHVHJhbnNmb3JtRGlzdGFuY2UgU1ZHVHJhbnNmb3JtRGlzdGFuY2U6OnNjYWxlZERpc3RhbmNl KGZsb2F0IHNjYWxlRmFjdG9yKSBjb25zdAogewogICAgIHN3aXRjaCAobV90eXBlKSB7CiAgICAg Y2FzZSBTVkdUcmFuc2Zvcm06OlNWR19UUkFOU0ZPUk1fVU5LTk9XTjoKLSAgICAgICAgcmV0dXJu IFNWR1RyYW5zZm9ybURpc3RhbmNlKCk7CisgICAgICAgIHJldHVybiBTVkdUcmFuc2Zvcm1EaXN0 YW5jZShTVkdUcmFuc2Zvcm06OlNWR19UUkFOU0ZPUk1fVU5LTk9XTiwgMCwgMCwgMCwgVHJhbnNm b3JtYXRpb25NYXRyaXgoKSk7CiAgICAgY2FzZSBTVkdUcmFuc2Zvcm06OlNWR19UUkFOU0ZPUk1f Uk9UQVRFOgogICAgICAgICByZXR1cm4gU1ZHVHJhbnNmb3JtRGlzdGFuY2UobV90eXBlLCBtX2Fu Z2xlICogc2NhbGVGYWN0b3IsIG1fY3ggKiBzY2FsZUZhY3RvciwgbV9jeSAqIHNjYWxlRmFjdG9y LCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCgpKTsKICAgICBjYXNlIFNWR1RyYW5zZm9ybTo6U1ZHX1RS QU5TRk9STV9TQ0FMRToKQEAgLTExMiw3ICsxMDcsNyBAQCBTVkdUcmFuc2Zvcm1EaXN0YW5jZSBT VkdUcmFuc2Zvcm1EaXN0YW5jZTo6c2NhbGVkRGlzdGFuY2UoZmxvYXQgc2NhbGVGYWN0b3IpIGNv bgogICAgIH0KICAgICAKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4gU1ZH VHJhbnNmb3JtRGlzdGFuY2UoKTsKKyAgICByZXR1cm4gU1ZHVHJhbnNmb3JtRGlzdGFuY2UoU1ZH VHJhbnNmb3JtOjpTVkdfVFJBTlNGT1JNX1VOS05PV04sIDAsIDAsIDAsIFRyYW5zZm9ybWF0aW9u TWF0cml4KCkpOwogfQogCiBTVkdUcmFuc2Zvcm0gU1ZHVHJhbnNmb3JtRGlzdGFuY2U6OmFkZFNW R1RyYW5zZm9ybXMoY29uc3QgU1ZHVHJhbnNmb3JtJiBmaXJzdCwgY29uc3QgU1ZHVHJhbnNmb3Jt JiBzZWNvbmQpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1EaXN0YW5jZS5o IGIvV2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtRGlzdGFuY2UuaAppbmRleCA0NzBlMmViLi5jMjhj NDg5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1EaXN0YW5jZS5oCisrKyBi L1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybURpc3RhbmNlLmgKQEAgLTMxLDcgKzMxLDYgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAKICAgICBjbGFzcyBTVkdUcmFuc2Zvcm1EaXN0YW5j ZSB7CiAgICAgcHVibGljOgotICAgICAgICBTVkdUcmFuc2Zvcm1EaXN0YW5jZSgpOwogICAgICAg ICBTVkdUcmFuc2Zvcm1EaXN0YW5jZShjb25zdCBTVkdUcmFuc2Zvcm0mIGZyb21UcmFuc2Zvcm0s IGNvbnN0IFNWR1RyYW5zZm9ybSYgdG9UcmFuc2Zvcm0pOwogICAgICAgICAKICAgICAgICAgU1ZH VHJhbnNmb3JtRGlzdGFuY2Ugc2NhbGVkRGlzdGFuY2UoZmxvYXQgc2NhbGVGYWN0b3IpIGNvbnN0 OwpAQCAtNTIsNyArNTEsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGZsb2F0IG1f Y3k7CiAgICAgICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IG1fdHJhbnNmb3JtOyAvLyBmb3Igc3Rv cmluZyBzY2FsZSwgdHJhbnNsYXRpb24gb3IgbWF0cml4IHRyYW5zZm9ybXMKICAgICB9OwotfQor fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxFKFNWRykKICNlbmRpZiAv LyBTVkdUcmFuc2Zvcm1EaXN0YW5jZV9oCmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9TVkdUcmFu c2Zvcm1MaXN0LmNwcCBiL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybUxpc3QuY3BwCmluZGV4IGVk NDU3ZjQuLjY0OGYxZTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybUxpc3Qu Y3BwCisrKyBiL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybUxpc3QuY3BwCkBAIC0yNiw3ICsyNiw2 IEBACiAjaW5jbHVkZSAiVHJhbnNmb3JtYXRpb25NYXRyaXguaCIKICNpbmNsdWRlICJTVkdUcmFu c2Zvcm0uaCIKICNpbmNsdWRlICJTVkdTVkdFbGVtZW50LmgiCi0jaW5jbHVkZSAiU1ZHVHJhbnNm b3JtRGlzdGFuY2UuaCIKICNpbmNsdWRlICJTVkdUcmFuc2Zvcm1MaXN0LmgiCiAKIHVzaW5nIG5h bWVzcGFjZSBXZWJDb3JlOwpAQCAtNjUsMjMgKzY0LDYgQEAgU1ZHVHJhbnNmb3JtIFNWR1RyYW5z Zm9ybUxpc3Q6OmNvbmNhdGVuYXRlKCkgY29uc3QKICAgICByZXR1cm4gU1ZHVHJhbnNmb3JtKG1h dHJpeCk7CiB9CiAKLVNWR1RyYW5zZm9ybSBTVkdUcmFuc2Zvcm1MaXN0Ojpjb25jYXRlbmF0ZUZv clR5cGUoU1ZHVHJhbnNmb3JtOjpTVkdUcmFuc2Zvcm1UeXBlIHR5cGUpIGNvbnN0Ci17Ci0gICAg dW5zaWduZWQgaW50IGxlbmd0aCA9IG51bWJlck9mSXRlbXMoKTsKLSAgICBpZiAoIWxlbmd0aCkK LSAgICAgICAgcmV0dXJuIFNWR1RyYW5zZm9ybSgpOwotICAgIAotICAgIEV4Y2VwdGlvbkNvZGUg ZWMgPSAwOwotICAgIFNWR1RyYW5zZm9ybURpc3RhbmNlIHRvdGFsVHJhbnNmb3JtOwotICAgIGZv ciAodW5zaWduZWQgaW50IGkgPSAwOyBpIDwgbGVuZ3RoOyBpKyspIHsKLSAgICAgICAgY29uc3Qg U1ZHVHJhbnNmb3JtJiB0cmFuc2Zvcm0gPSBnZXRJdGVtKGksIGVjKTsKLSAgICAgICAgaWYgKHRy YW5zZm9ybS50eXBlKCkgPT0gdHlwZSkKLSAgICAgICAgICAgIHRvdGFsVHJhbnNmb3JtLmFkZFNW R1RyYW5zZm9ybSh0cmFuc2Zvcm0pOwotICAgIH0KLSAgICAKLSAgICByZXR1cm4gdG90YWxUcmFu c2Zvcm0uYWRkVG9TVkdUcmFuc2Zvcm0oU1ZHVHJhbnNmb3JtKCkpOwotfQotCiBTdHJpbmcgU1ZH VHJhbnNmb3JtTGlzdDo6dmFsdWVBc1N0cmluZygpIGNvbnN0CiB7CiAgICAgLy8gVE9ETzogV2Ug bWF5IHdhbnQgdG8gYnVpbGQgYSByZWFsIHRyYW5zZm9ybSBzdHJpbmcsIGluc3RlYWQgb2YgY29u Y2F0dGluZyB0byBhIG1hdHJpeCguLi4pLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHVHJh bnNmb3JtTGlzdC5oIGIvV2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtTGlzdC5oCmluZGV4IDQ0MjAx NmIuLmQwOTVmZTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybUxpc3QuaAor KysgYi9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1MaXN0LmgKQEAgLTQyLDcgKzQyLDYgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIC8vIEludGVybmFsIHVzZSBvbmx5CiAgICAgICAg IFNWR1RyYW5zZm9ybSBjb25jYXRlbmF0ZSgpIGNvbnN0OwotICAgICAgICBTVkdUcmFuc2Zvcm0g Y29uY2F0ZW5hdGVGb3JUeXBlKFNWR1RyYW5zZm9ybTo6U1ZHVHJhbnNmb3JtVHlwZSkgY29uc3Q7 CiAgCiAgICAgICAgIFN0cmluZyB2YWx1ZUFzU3RyaW5nKCkgY29uc3Q7