26878 2009-06-30 23:55:54 -0700 Incorrect event.keyIdentifier value for F10 and F11 keys 2022-10-06 13:26:25 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar P2 Normal --- 0 yurys webkit-unassigned commit-queue solushex webkit-bug-importer webkit.review.bot oldest_to_newest 129267 0 yurys 2009-06-30 23:55:54 -0700 Steps to reproduce: 1. Load the following HTML Chrome or Safari on Windows. <html> <body onkeydown="alert('event.keyIdentifier = ' + event.keyIdentifier);"> </body> </html> 2. Press F10 and F11 keys Result: For F10 key you'll see event.keyIdentifier = F11 alert For F11 key it will be event.keyIdentifier = U+005A 527822 1 120715 solushex 2011-12-28 19:29:56 -0800 Created attachment 120715 patch added missing f10 and f11 entries. 527823 2 webkit.review.bot 2011-12-28 19:31:26 -0800 Attachment 120715 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 527828 3 120715 darin 2011-12-28 19:45:52 -0800 Comment on attachment 120715 patch View in context: https://bugs.webkit.org/attachment.cgi?id=120715&action=review > b/Source/WebCore/ChangeLog:8 > + No new tests required. Why not? 527850 4 solushex 2011-12-28 22:38:44 -0800 (In reply to comment #3) > (From update of attachment 120715 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120715&action=review > > > b/Source/WebCore/ChangeLog:8 > > + No new tests required. > > Why not? i don't have the source tree on this machine :-\ 886369 5 120715 darin 2013-05-08 09:11:16 -0700 Comment on attachment 120715 patch View in context: https://bugs.webkit.org/attachment.cgi?id=120715&action=review > b/Source/WebCore/ChangeLog:1 > +2011-12-28 Rahul Abrol <solushex@gmail.com> This line is formatted incorrectly. >>> b/Source/WebCore/ChangeLog:8 >>> + No new tests required. >> >> Why not? > > i don't have the source tree on this machine :-\ So it’s wrong to say “no new tests required”. The change log would be better without this comment. 886381 6 120715 commit-queue 2013-05-08 09:38:01 -0700 Comment on attachment 120715 patch Rejecting attachment 120715 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 120715, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 149741 = 15972cccde39a3cae0119ab06d4b009fd3a1b76b r149742 = 3ee31df2f3c5f56992db99f868a87f2b746f11b5 r149743 = e69d6637a7718f1baa7118e3fc51122fc1b0d5e8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/408428 1903848 7 ews-feeder 2022-10-06 13:25:45 -0700 Committed 255238@main (25a848ab9af4): <https://commits.webkit.org/255238@main> Reviewed commits have been landed. Closing PR #5054 and removing active labels. 1903849 8 webkit-bug-importer 2022-10-06 13:26:25 -0700 <rdar://problem/100867561> 120715 2011-12-28 19:29:56 -0800 2013-05-08 09:38:00 -0700 patch patch.txt text/plain 1040 solushex LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSw0ICsxLDE2IEBACisyMDExLTEyLTI4IFJhaHVsIEFicm9sIDxzb2x1c2hleEBn bWFpbC5jb20+CisKKyAgICAgICAgSW5jb3JyZWN0IGV2ZW50LmtleUlkZW50aWZpZXIgdmFsdWUg Zm9yIEYxMCBhbmQgRjExIGtleXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI2ODc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHJlcXVpcmVkLgorCisgICAgICAgICogcGxhdGZvcm0v d2luL0tleUV2ZW50V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmtleUlkZW50aWZpZXJGb3JX aW5kb3dzS2V5Q29kZSk6CisKIDIwMTEtMTItMjggIENoYW5nU2VvayBPaCAgPHNoaXZhbWlkb3dA Z21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEZpeCBjb21waWxhdGlvbiBpc3N1ZSB3aGVuIHNl bGVjdGluZyBvcGVuZ2wgZm9yIEFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTMwOQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9LZXlFdmVudFdpbi5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vd2luL0tleUV2ZW50V2luLmNwcApAQCAtODIsOCArODIsMTAgQEAK ICAgICAgICAgICAgIHJldHVybiAiRjgiOwogICAgICAgICBjYXNlIFZLX0Y5OgogICAgICAgICAg ICAgcmV0dXJuICJGOSI7CiAgICAgICAgIGNhc2UgVktfRjEwOgorICAgICAgICAgICAgcmV0dXJu ICJGMTAiOworICAgICAgICBjYXNlIFZLX0YxMToKICAgICAgICAgICAgIHJldHVybiAiRjExIjsK ICAgICAgICAgY2FzZSBWS19GMTI6CiAgICAgICAgICAgICByZXR1cm4gIkYxMiI7CiAgICAgICAg IGNhc2UgVktfRjEzOgo=