<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26877</bug_id>
          
          <creation_ts>2009-06-30 23:27:07 -0700</creation_ts>
          <short_desc>[GTK] DRT fixes to pass new plugin test</short_desc>
          <delta_ts>2009-06-30 23:51:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Xan Lopez">xan.lopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>129256</commentid>
    <comment_count>0</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-06-30 23:27:07 -0700</bug_when>
    <thetext>bug #15457 requires a small modification in DRT in order to pass its new test. Done in attached patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129257</commentid>
    <comment_count>1</comment_count>
      <attachid>32112</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-06-30 23:30:42 -0700</bug_when>
    <thetext>Created attachment 32112
logsrc.patch

Fix DRT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129258</commentid>
    <comment_count>2</comment_count>
      <attachid>32113</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-06-30 23:31:06 -0700</bug_when>
    <thetext>Created attachment 32113
pluginlog.patch

Small cleanup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129260</commentid>
    <comment_count>3</comment_count>
      <attachid>32112</attachid>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2009-06-30 23:35:19 -0700</bug_when>
    <thetext>Comment on attachment 32112
logsrc.patch

Ok. r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129261</commentid>
    <comment_count>4</comment_count>
      <attachid>32113</attachid>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2009-06-30 23:36:37 -0700</bug_when>
    <thetext>Comment on attachment 32113
pluginlog.patch

Fine. r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129262</commentid>
    <comment_count>5</comment_count>
      <attachid>32115</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-06-30 23:39:06 -0700</bug_when>
    <thetext>Created attachment 32115
compilerwarning.patch

Fix compiler warnings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129263</commentid>
    <comment_count>6</comment_count>
      <attachid>32115</attachid>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2009-06-30 23:43:10 -0700</bug_when>
    <thetext>Comment on attachment 32115
compilerwarning.patch

&gt;      switch (variable) {
&gt;          case NPPVpluginNameString:
&gt; -            *((char **)value) = &quot;WebKit Test PlugIn&quot;;
&gt; +            *((char **)value) = (char*)&quot;WebKit Test PlugIn&quot;;

Please change these to static_casts before commit. r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129265</commentid>
    <comment_count>7</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-06-30 23:50:19 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 32115 [review])
&gt; &gt;      switch (variable) {
&gt; &gt;          case NPPVpluginNameString:
&gt; &gt; -            *((char **)value) = &quot;WebKit Test PlugIn&quot;;
&gt; &gt; +            *((char **)value) = (char*)&quot;WebKit Test PlugIn&quot;;
&gt; 
&gt; Please change these to static_casts before commit. r=me.
&gt; 

static_cost won&apos;t work in this case. I&apos;ll use const_cast.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>129266</commentid>
    <comment_count>8</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-06-30 23:51:46 -0700</bug_when>
    <thetext>All patches landed as r45429, r45430 and r45431, closing.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32112</attachid>
            <date>2009-06-30 23:30:42 -0700</date>
            <delta_ts>2009-06-30 23:35:19 -0700</delta_ts>
            <desc>logsrc.patch</desc>
            <filename>logsrc.patch</filename>
            <type>text/plain</type>
            <size>2377</size>
            <attacher name="Xan Lopez">xan.lopez</attacher>
            
              <data encoding="base64">RnJvbSBjYTEwZDZlNWNmYjU3MDJkYjI1YjJlYzA0Mjk4ODM4YjhjZGNkMzNiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX
ZWQsIDEgSnVsIDIwMDkgMDk6Mjc6MzUgKzAzMDAKU3ViamVjdDogW1BBVENIIDEvMl0gMjAwOS0w
Ni0zMCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjY4NzcKICAgICAgICBbR1RLXSBEUlQgZml4ZXMgdG8gcGFzcyBuZXcgcGx1Z2lu
IHRlc3QKCiAgICAgICAgTW9kaWZ5IG91ciBEUlQgYXMgZG9uZSBpbiBidWcgIzE1NDU3IHRvIGxv
ZyBsb2dTcmMgYXMgc3JjIGluIG9yZGVyCiAgICAgICAgdG8gcGFzcyB0ZXN0IHBsdWdpbnMvbmV0
c2NhcGUtcGx1Z2luLW1hcC1kYXRhLXRvLXNyYy5odG1sLgoKICAgICAgICAqIER1bXBSZW5kZXJU
cmVlL2d0ay9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcDoKICAgICAg
ICAod2Via2l0X3Rlc3RfcGx1Z2luX25ld19pbnN0YW5jZSk6Ci0tLQogV2ViS2l0VG9vbHMvQ2hh
bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysK
IC4uLi9ndGsvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHAgIHwgICAg
NSArKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5n
ZUxvZwppbmRleCAxNGNiOWQyLi44NjYwN2Q4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFu
Z2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDkt
MDYtMzAgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yNjg3NworICAgICAgICBbR1RLXSBEUlQgZml4ZXMgdG8gcGFzcyBuZXcg
cGx1Z2luIHRlc3QKKworICAgICAgICBNb2RpZnkgb3VyIERSVCBhcyBkb25lIGluIGJ1ZyAjMTU0
NTcgdG8gbG9nIGxvZ1NyYyBhcyBzcmMgaW4gb3JkZXIKKyAgICAgICAgdG8gcGFzcyB0ZXN0IHBs
dWdpbnMvbmV0c2NhcGUtcGx1Z2luLW1hcC1kYXRhLXRvLXNyYy5odG1sLgorCisgICAgICAgICog
RHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4u
Y3BwOgorICAgICAgICAod2Via2l0X3Rlc3RfcGx1Z2luX25ld19pbnN0YW5jZSk6CisKIDIwMDkt
MDYtMzAgIEFkcmllbiBOYWRlciAgPGNhbWFyYWRldHV4QGdtYWlsLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRl
clRyZWUvZ3RrL1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwIGIvV2Vi
S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2Nh
cGVQbHVnaW4uY3BwCmluZGV4IDRlMzcxMDAuLjU1NTUyYTAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv
b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1
Z2luLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvVGVzdE5ldHNjYXBl
UGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHAKQEAgLTExMSw2ICsxMTEsMTEgQEAgd2Via2l0
X3Rlc3RfcGx1Z2luX25ld19pbnN0YW5jZShOUE1JTUVUeXBlIG1pbWV0eXBlLAogICAgICAgICAg
ICAgICAgIG9iai0+bG9nU2V0V2luZG93ID0gVFJVRTsKICAgICAgICAgICAgIGVsc2UgaWYgKHN0
cmNhc2VjbXAoYXJnbltpXSwgInRlc3RucHJ1bnRpbWUiKSA9PSAwKQogICAgICAgICAgICAgICAg
IHRlc3ROUFJ1bnRpbWUoaW5zdGFuY2UpOworICAgICAgICAgICAgZWxzZSBpZiAoc3RyY2FzZWNt
cChhcmduW2ldLCAibG9nU3JjIikgPT0gMCkgeworICAgICAgICAgICAgICAgIGZvciAoaW50IGkg
PSAwOyBpIDwgYXJnYzsgaSsrKQorICAgICAgICAgICAgICAgICAgICBpZiAoc3RyY2FzZWNtcChh
cmduW2ldLCAic3JjIikgPT0gMCkKKyAgICAgICAgICAgICAgICAgICAgICAgIGxvZyhpbnN0YW5j
ZSwgInNyYzogJXMiLCBhcmd2W2ldKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogCiAgICAg
ICAgIGluc3RhbmNlLT5wZGF0YSA9IG9iajsKLS0gCjEuNi4zLjMKCg==
</data>
<flag name="review"
          id="16623"
          type_id="1"
          status="+"
          setter="jmalonzo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32113</attachid>
            <date>2009-06-30 23:31:06 -0700</date>
            <delta_ts>2009-06-30 23:36:37 -0700</delta_ts>
            <desc>pluginlog.patch</desc>
            <filename>pluginlog.patch</filename>
            <type>text/plain</type>
            <size>5148</size>
            <attacher name="Xan Lopez">xan.lopez</attacher>
            
              <data encoding="base64">RnJvbSAyMTg2OTMwNWE5MmU5MmI0ZThlMDQ2NDBkMjFlZGFlMGJhMTQ3ZDQzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX
ZWQsIDEgSnVsIDIwMDkgMDk6Mjk6NDcgKzAzMDAKU3ViamVjdDogW1BBVENIIDIvMl0gMjAwOS0w
Ni0zMCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjY4NzcKICAgICAgICBbR1RLXSBEUlQgZml4ZXMgdG8gcGFzcyBuZXcgcGx1Z2lu
IHRlc3QKCiAgICAgICAgVXNlIHRoZSBjb21tb24gcGx1Z2luTG9nIGZ1bmN0aW9uIGluc3RlYWQg
b2YgYSBsb2NhbCBjb3B5LgoKICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9UZXN0TmV0c2Nh
cGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcDoKICAgICAgICAod2Via2l0X3Rlc3RfcGx1
Z2luX25ld19pbnN0YW5jZSk6CiAgICAgICAgKHdlYmtpdF90ZXN0X3BsdWdpbl9kZXN0cm95X2lu
c3RhbmNlKToKICAgICAgICAod2Via2l0X3Rlc3RfcGx1Z2luX3NldF93aW5kb3cpOgogICAgICAg
ICh3ZWJraXRfdGVzdF9wbHVnaW5faGFuZGxlX2V2ZW50KToKLS0tCiBXZWJLaXRUb29scy9DaGFu
Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrCiAuLi4vZ3Rr
L1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwICB8ICAgNDggKystLS0t
LS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgNDQgZGVs
ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9v
bHMvQ2hhbmdlTG9nCmluZGV4IDg2NjA3ZDguLmE4ODAyMDEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv
b2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTUsNiArNSwyMSBA
QAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY4NzcK
ICAgICAgICAgW0dUS10gRFJUIGZpeGVzIHRvIHBhc3MgbmV3IHBsdWdpbiB0ZXN0CiAKKyAgICAg
ICAgVXNlIHRoZSBjb21tb24gcGx1Z2luTG9nIGZ1bmN0aW9uIGluc3RlYWQgb2YgYSBsb2NhbCBj
b3B5LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRzY2FwZVBsdWdpbi9U
ZXN0TmV0c2NhcGVQbHVnaW4uY3BwOgorICAgICAgICAod2Via2l0X3Rlc3RfcGx1Z2luX25ld19p
bnN0YW5jZSk6CisgICAgICAgICh3ZWJraXRfdGVzdF9wbHVnaW5fZGVzdHJveV9pbnN0YW5jZSk6
CisgICAgICAgICh3ZWJraXRfdGVzdF9wbHVnaW5fc2V0X3dpbmRvdyk6CisgICAgICAgICh3ZWJr
aXRfdGVzdF9wbHVnaW5faGFuZGxlX2V2ZW50KToKKworMjAwOS0wNi0zMCAgWGFuIExvcGV6ICA8
eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2ODc3
CisgICAgICAgIFtHVEtdIERSVCBmaXhlcyB0byBwYXNzIG5ldyBwbHVnaW4gdGVzdAorCiAgICAg
ICAgIE1vZGlmeSBvdXIgRFJUIGFzIGRvbmUgaW4gYnVnICMxNTQ1NyB0byBsb2cgbG9nU3JjIGFz
IHNyYyBpbiBvcmRlcgogICAgICAgICB0byBwYXNzIHRlc3QgcGx1Z2lucy9uZXRzY2FwZS1wbHVn
aW4tbWFwLWRhdGEtdG8tc3JjLmh0bWwuCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBS
ZW5kZXJUcmVlL2d0ay9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcCBi
L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5l
dHNjYXBlUGx1Z2luLmNwcAppbmRleCA1NTU1MmEwLi43NjAwMjVhIDEwMDY0NAotLS0gYS9XZWJL
aXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2Fw
ZVBsdWdpbi5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCkBAIC0zOCw0NiArMzgsNiBAQAogI2lu
Y2x1ZGUgPHN0ZGxpYi5oPgogI2luY2x1ZGUgPFgxMS9YbGliLmg+CiAKLXN0YXRpYyB2b2lkIGxv
ZyhOUFAgaW5zdGFuY2UsIGNvbnN0IGNoYXIqIGZvcm1hdCwgLi4uKQotewotICAgIHZhX2xpc3Qg
YXJnczsKLSAgICB2YV9zdGFydChhcmdzLCBmb3JtYXQpOwotICAgIGNoYXIgbWVzc2FnZVsyMDQ4
XSA9ICJQTFVHSU46ICI7Ci0gICAgdnNwcmludGYobWVzc2FnZSArIHN0cmxlbihtZXNzYWdlKSwg
Zm9ybWF0LCBhcmdzKTsKLSAgICB2YV9lbmQoYXJncyk7Ci0KLSAgICBOUE9iamVjdCogd2luZG93
T2JqZWN0ID0gMDsKLSAgICBOUEVycm9yIGVycm9yID0gYnJvd3Nlci0+Z2V0dmFsdWUoaW5zdGFu
Y2UsIE5QTlZXaW5kb3dOUE9iamVjdCwgJndpbmRvd09iamVjdCk7Ci0gICAgaWYgKGVycm9yICE9
IE5QRVJSX05PX0VSUk9SKSB7Ci0gICAgICAgIGZwcmludGYoc3RkZXJyLCAiRmFpbGVkIHRvIHJl
dHJpZXZlIHdpbmRvdyBvYmplY3Qgd2hpbGUgbG9nZ2luZzogJXNcbiIsIG1lc3NhZ2UpOwotICAg
ICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgTlBWYXJpYW50IGNvbnNvbGVWYXJpYW50OwotICAg
IGlmICghYnJvd3Nlci0+Z2V0cHJvcGVydHkoaW5zdGFuY2UsIHdpbmRvd09iamVjdCwgYnJvd3Nl
ci0+Z2V0c3RyaW5naWRlbnRpZmllcigiY29uc29sZSIpLCAmY29uc29sZVZhcmlhbnQpKSB7Ci0g
ICAgICAgIGZwcmludGYoc3RkZXJyLCAiRmFpbGVkIHRvIHJldHJpZXZlIGNvbnNvbGUgb2JqZWN0
IHdoaWxlIGxvZ2dpbmc6ICVzXG4iLCBtZXNzYWdlKTsKLSAgICAgICAgYnJvd3Nlci0+cmVsZWFz
ZW9iamVjdCh3aW5kb3dPYmplY3QpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgTlBP
YmplY3QqIGNvbnNvbGVPYmplY3QgPSBOUFZBUklBTlRfVE9fT0JKRUNUKGNvbnNvbGVWYXJpYW50
KTsKLQotICAgIE5QVmFyaWFudCBtZXNzYWdlVmFyaWFudDsKLSAgICBTVFJJTkdaX1RPX05QVkFS
SUFOVChtZXNzYWdlLCBtZXNzYWdlVmFyaWFudCk7Ci0KLSAgICBOUFZhcmlhbnQgcmVzdWx0Owot
ICAgIGlmICghYnJvd3Nlci0+aW52b2tlKGluc3RhbmNlLCBjb25zb2xlT2JqZWN0LCBicm93c2Vy
LT5nZXRzdHJpbmdpZGVudGlmaWVyKCJsb2ciKSwgJm1lc3NhZ2VWYXJpYW50LCAxLCAmcmVzdWx0
KSkgewotICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkZhaWxlZCB0byBpbnZva2UgY29uc29sZS5s
b2cgd2hpbGUgbG9nZ2luZzogJXNcbiIsIG1lc3NhZ2UpOwotICAgICAgICBicm93c2VyLT5yZWxl
YXNlb2JqZWN0KGNvbnNvbGVPYmplY3QpOwotICAgICAgICBicm93c2VyLT5yZWxlYXNlb2JqZWN0
KHdpbmRvd09iamVjdCk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBicm93c2VyLT5y
ZWxlYXNldmFyaWFudHZhbHVlKCZyZXN1bHQpOwotICAgIGJyb3dzZXItPnJlbGVhc2VvYmplY3Qo
Y29uc29sZU9iamVjdCk7Ci0gICAgYnJvd3Nlci0+cmVsZWFzZW9iamVjdCh3aW5kb3dPYmplY3Qp
OwotfQotCiBleHRlcm4gIkMiIHsKICAgICBOUEVycm9yIE5QX0luaXRpYWxpemUgKE5QTmV0c2Nh
cGVGdW5jcyAqYU1vemlsbGFWVGFibGUsIE5QUGx1Z2luRnVuY3MgKmFQbHVnaW5WVGFibGUpOwog
ICAgIE5QRXJyb3IgTlBfU2h1dGRvd24odm9pZCk7CkBAIC0xMTQsNyArNzQsNyBAQCB3ZWJraXRf
dGVzdF9wbHVnaW5fbmV3X2luc3RhbmNlKE5QTUlNRVR5cGUgbWltZXR5cGUsCiAgICAgICAgICAg
ICBlbHNlIGlmIChzdHJjYXNlY21wKGFyZ25baV0sICJsb2dTcmMiKSA9PSAwKSB7CiAgICAgICAg
ICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBhcmdjOyBpKyspCiAgICAgICAgICAgICAgICAg
ICAgIGlmIChzdHJjYXNlY21wKGFyZ25baV0sICJzcmMiKSA9PSAwKQotICAgICAgICAgICAgICAg
ICAgICAgICAgbG9nKGluc3RhbmNlLCAic3JjOiAlcyIsIGFyZ3ZbaV0pOworICAgICAgICAgICAg
ICAgICAgICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAic3JjOiAlcyIsIGFyZ3ZbaV0pOwogICAg
ICAgICAgICAgfQogICAgICAgICB9CiAKQEAgLTEzOSw3ICs5OSw3IEBAIHdlYmtpdF90ZXN0X3Bs
dWdpbl9kZXN0cm95X2luc3RhbmNlKE5QUCBpbnN0YW5jZSwgTlBTYXZlZERhdGEgKipzYXZlKQog
ICAgICAgICAgICAgZnJlZShvYmotPm9uVVJMTm90aWZ5KTsKIAogICAgICAgICBpZiAob2JqLT5s
b2dEZXN0cm95KQotICAgICAgICAgICAgbG9nKGluc3RhbmNlLCAiTlBQX0Rlc3Ryb3kiKTsKKyAg
ICAgICAgICAgIHBsdWdpbkxvZyhpbnN0YW5jZSwgIk5QUF9EZXN0cm95Iik7CiAKICAgICAgICAg
YnJvd3Nlci0+cmVsZWFzZW9iamVjdCgmb2JqLT5oZWFkZXIpOwogICAgIH0KQEAgLTE1NCw3ICsx
MTQsNyBAQCB3ZWJraXRfdGVzdF9wbHVnaW5fc2V0X3dpbmRvdyhOUFAgaW5zdGFuY2UsIE5QV2lu
ZG93ICp3aW5kb3cpCiAKICAgICBpZiAob2JqKSB7CiAgICAgICAgIGlmIChvYmotPmxvZ1NldFdp
bmRvdykgewotICAgICAgICAgICAgbG9nKGluc3RhbmNlLCAiTlBQX1NldFdpbmRvdzogJWQgJWQi
LCAoaW50KXdpbmRvdy0+d2lkdGgsIChpbnQpd2luZG93LT5oZWlnaHQpOworICAgICAgICAgICAg
cGx1Z2luTG9nKGluc3RhbmNlLCAiTlBQX1NldFdpbmRvdzogJWQgJWQiLCAoaW50KXdpbmRvdy0+
d2lkdGgsIChpbnQpd2luZG93LT5oZWlnaHQpOwogICAgICAgICAgICAgb2JqLT5sb2dTZXRXaW5k
b3cgPSBmYWxzZTsKICAgICAgICAgfQogICAgIH0KQEAgLTI0NCw3ICsyMDQsNyBAQCB3ZWJraXRf
dGVzdF9wbHVnaW5faGFuZGxlX2V2ZW50KE5QUCBpbnN0YW5jZSwgdm9pZCogZXZlbnQpCiAgICAg
ICAgIHJldHVybiAwOwogCiAgICAgWEV2ZW50KiBldnQgPSBzdGF0aWNfY2FzdDxYRXZlbnQqPihl
dmVudCk7Ci0gICAgbG9nKGluc3RhbmNlLCAiZXZlbnQgJWQiLCBldnQtPnR5cGUpOworICAgIHBs
dWdpbkxvZyhpbnN0YW5jZSwgImV2ZW50ICVkIiwgZXZ0LT50eXBlKTsKIAogICAgIHJldHVybiAw
OwogfQotLSAKMS42LjMuMwoK
</data>
<flag name="review"
          id="16624"
          type_id="1"
          status="+"
          setter="jmalonzo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32115</attachid>
            <date>2009-06-30 23:39:06 -0700</date>
            <delta_ts>2009-06-30 23:43:10 -0700</delta_ts>
            <desc>compilerwarning.patch</desc>
            <filename>compilerwarning.patch</filename>
            <type>text/plain</type>
            <size>3317</size>
            <attacher name="Xan Lopez">xan.lopez</attacher>
            
              <data encoding="base64">RnJvbSA1Mzg0N2QyYzEzMGRiYjg2YTFiOWVkODJjZjE1YmI5ZmNhOWU3ZmIyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX
ZWQsIDEgSnVsIDIwMDkgMDk6Mzg6MjMgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTA2LTMw
ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yNjg3NwogICAgICAgIFtHVEtdIERSVCBmaXhlcyB0byBwYXNzIG5ldyBwbHVnaW4gdGVz
dAoKICAgICAgICBTaWxlbmNlIGNvbXBpbGVyIHdhcm5pbmdzLgoKICAgICAgICBOZXdlciBHQ0Mg
ZG9uJ3QgbGlrZSB1c2luZyBvciByZXR1cm5pbmcgYSBzdGF0aWMgc3RyaW5nIHdoZXJlIGEKICAg
ICAgICAnY2hhcionIGlzIGV4cGVjdGVkLiBJZGVhbGx5IHdlJ2QgY2hhbmdlIHRoZSBmdW5jdGlv
biBzaWduYXR1cmVzCiAgICAgICAgdG8gcmV0dXJuIG9yIHRha2UgJ2NvbnN0IGNoYXIqJyBJIHN1
cHBvc2UsIGJ1dCBzaW5jZSB3ZSBjYW4ndCBkbwogICAgICAgIHRoYXQganVzdCBjYXN0IHRoZSBz
dHJpbmdzIHRvICdjaGFyKicuCgogICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwOgogICAgICAgICh3ZWJraXRfdGVzdF9w
bHVnaW5fZ2V0X3ZhbHVlKToKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9ndGsvVGVzdE5l
dHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHAgIHwgICAgNiArKystLS0KIDIgZmls
ZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggYTg4
MDIwMS4uMTM0MGQ5YiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dl
YktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtNSw2ICs1LDIzIEBACiAgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjg3NwogICAgICAgICBbR1RLXSBEUlQgZml4
ZXMgdG8gcGFzcyBuZXcgcGx1Z2luIHRlc3QKIAorICAgICAgICBTaWxlbmNlIGNvbXBpbGVyIHdh
cm5pbmdzLgorCisgICAgICAgIE5ld2VyIEdDQyBkb24ndCBsaWtlIHVzaW5nIG9yIHJldHVybmlu
ZyBhIHN0YXRpYyBzdHJpbmcgd2hlcmUgYQorICAgICAgICAnY2hhcionIGlzIGV4cGVjdGVkLiBJ
ZGVhbGx5IHdlJ2QgY2hhbmdlIHRoZSBmdW5jdGlvbiBzaWduYXR1cmVzCisgICAgICAgIHRvIHJl
dHVybiBvciB0YWtlICdjb25zdCBjaGFyKicgSSBzdXBwb3NlLCBidXQgc2luY2Ugd2UgY2FuJ3Qg
ZG8KKyAgICAgICAgdGhhdCBqdXN0IGNhc3QgdGhlIHN0cmluZ3MgdG8gJ2NoYXIqJy4KKworICAg
ICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBl
UGx1Z2luLmNwcDoKKyAgICAgICAgKHdlYmtpdF90ZXN0X3BsdWdpbl9nZXRfdmFsdWUpOgorCisy
MDA5LTA2LTMwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjY4NzcKKyAgICAgICAgW0dUS10gRFJUIGZpeGVzIHRvIHBhc3Mg
bmV3IHBsdWdpbiB0ZXN0CisKICAgICAgICAgVXNlIHRoZSBjb21tb24gcGx1Z2luTG9nIGZ1bmN0
aW9uIGluc3RlYWQgb2YgYSBsb2NhbCBjb3B5LgogCiAgICAgICAgICogRHVtcFJlbmRlclRyZWUv
Z3RrL1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwOgpkaWZmIC0tZ2l0
IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0
TmV0c2NhcGVQbHVnaW4uY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3RO
ZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCmluZGV4IDc2MDAyNWEuLjMwODhk
OGMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9UZXN0TmV0c2Nh
cGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVu
ZGVyVHJlZS9ndGsvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHAKQEAg
LTIyNywxMCArMjI3LDEwIEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9nZXRfdmFsdWUoTlBQIGluc3Rh
bmNlLCBOUFBWYXJpYWJsZSB2YXJpYWJsZSwgdm9pZCAqdmFsdWUpCiAKICAgICBzd2l0Y2ggKHZh
cmlhYmxlKSB7CiAgICAgICAgIGNhc2UgTlBQVnBsdWdpbk5hbWVTdHJpbmc6Ci0gICAgICAgICAg
ICAqKChjaGFyICoqKXZhbHVlKSA9ICJXZWJLaXQgVGVzdCBQbHVnSW4iOworICAgICAgICAgICAg
KigoY2hhciAqKil2YWx1ZSkgPSAoY2hhciopIldlYktpdCBUZXN0IFBsdWdJbiI7CiAgICAgICAg
ICAgICBicmVhazsKICAgICAgICAgY2FzZSBOUFBWcGx1Z2luRGVzY3JpcHRpb25TdHJpbmc6Ci0g
ICAgICAgICAgICAqKChjaGFyICoqKXZhbHVlKSA9ICJTaW1wbGUgTmV0c2NhcGUgcGx1Zy1pbiB0
aGF0IGhhbmRsZXMgdGVzdCBjb250ZW50IGZvciBXZWJLaXQiOworICAgICAgICAgICAgKigoY2hh
ciAqKil2YWx1ZSkgPSAoY2hhciopIlNpbXBsZSBOZXRzY2FwZSBwbHVnLWluIHRoYXQgaGFuZGxl
cyB0ZXN0IGNvbnRlbnQgZm9yIFdlYktpdCI7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg
Y2FzZSBOUFBWcGx1Z2luTmVlZHNYRW1iZWQ6CiAgICAgICAgICAgICAqKChOUEJvb2wgKil2YWx1
ZSkgPSBUUlVFOwpAQCAtMjY2LDcgKzI2Niw3IEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9zZXRfdmFs
dWUoTlBQIGluc3RhbmNlLCBOUE5WYXJpYWJsZSB2YXJpYWJsZSwgdm9pZCAqdmFsdWUpCiBjaGFy
ICoKIE5QX0dldE1JTUVEZXNjcmlwdGlvbih2b2lkKQogewotICAgIHJldHVybiAiYXBwbGljYXRp
b24veC13ZWJraXQtdGVzdC1uZXRzY2FwZTp0ZXN0bmV0c2NhcGU6dGVzdCBuZXRzY2FwZSBjb250
ZW50IjsKKyAgICByZXR1cm4gKGNoYXIqKSJhcHBsaWNhdGlvbi94LXdlYmtpdC10ZXN0LW5ldHNj
YXBlOnRlc3RuZXRzY2FwZTp0ZXN0IG5ldHNjYXBlIGNvbnRlbnQiOwogfQogCiBOUEVycm9yCi0t
IAoxLjYuMy4zCgo=
</data>
<flag name="review"
          id="16626"
          type_id="1"
          status="+"
          setter="jmalonzo"
    />
          </attachment>
      

    </bug>

</bugzilla>