<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>268626</bug_id>
          
          <creation_ts>2024-02-02 08:42:10 -0800</creation_ts>
          <short_desc>Fix SharedMemoryUnix link with librt</short_desc>
          <delta_ts>2024-02-02 13:44:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=268521</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Olivier Blin">olivier.blin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>aperez</cc>
    
    <cc>cdumez</cc>
    
    <cc>loic.yhuel</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2010113</commentid>
    <comment_count>0</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2024-02-02 08:42:10 -0800</bug_when>
    <thetext>In 273951@main, SharedMemoryUnix has been moved from WebKit to WebCore.
Since it uses shm_open(), the matching librt test should be moved in WebCore cmake files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2010115</commentid>
    <comment_count>1</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2024-02-02 08:43:55 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/23746</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2010116</commentid>
    <comment_count>2</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2024-02-02 08:50:20 -0800</bug_when>
    <thetext>It failed with this error:

[22/68] Linking CXX executable bin/TestWebKitAPI/TestWebCore
FAILED: bin/TestWebKitAPI/TestWebCore 
: &amp;&amp; /usr/bin/clang++-12  -stdlib=libc++ -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -gsplit-dwarf -g -L/home/sah0146/vc/webkit.org/WebKit/WebKitBuild/DependenciesWPE/Root/lib -Wl,--disable-new-dtags @CMakeFiles/TestWebCore.rsp -o bin/TestWebKitAPI/TestWebCore  &amp;&amp; :
/usr/bin/ld: Source/WebCore/CMakeFiles/WebCore.dir/./__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-77.cpp.o: undefined reference to symbol &apos;shm_open@@GLIBC_2.2.5&apos;
/usr/bin/ld: /lib/x86_64-linux-gnu/librt.so.1: error adding symbols: DSO missing from command line
clang: error: linker command failed with exit code 1 (use -v to see invocation)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2010203</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2024-02-02 11:56:39 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 268619 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2010243</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-02-02 13:43:40 -0800</bug_when>
    <thetext>Committed 274015@main (1eb09af23ff7): &lt;https://commits.webkit.org/274015@main&gt;

Reviewed commits have been landed. Closing PR #23746 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2010244</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-02-02 13:44:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/122203867&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>