26859 2009-06-30 13:56:16 -0700 StorageNamespace.cpp build issue 2009-06-30 19:16:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 simon.maxime webkit-unassigned oldest_to_newest 129156 0 simon.maxime 2009-06-30 13:56:16 -0700 In WebCore/storage/StorageNamespace.cpp, namespace WebCore is closed after the #endif (which starts before the namespace). So if #if ENABLE(DOM_STORAGE) is true there is no problem, but if not it causes the build to fail. 129158 1 32093 simon.maxime 2009-06-30 14:07:15 -0700 Created attachment 32093 Patch for this bug 129183 2 32093 eric 2009-06-30 14:42:46 -0700 Comment on attachment 32093 Patch for this bug LGTM. 129233 3 jmalonzo 2009-06-30 19:16:26 -0700 (In reply to comment #2) > (From update of attachment 32093 [review]) > LGTM. > Landed in r45413. 32093 2009-06-30 14:07:15 -0700 2009-06-30 14:42:46 -0700 Patch for this bug 0001-Move-endif-ENABLE-DOM_STORAGE-position-so-that-the-b.patch text/plain 1613 simon.maxime RnJvbSBiNzI5MzQ5YmI4YWRmMmVmZGUwYjMxNTJjZGIxM2YxNWYxN2E3ODQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgU2ltb24gPHNpbW9uLm1heGltZUBnbWFpbC5jb20+ CkRhdGU6IFR1ZSwgMzAgSnVuIDIwMDkgMjM6MDY6MzMgKzAyMDAKU3ViamVjdDogW1BBVENIXSBN b3ZlICNlbmRpZiAvL0VOQUJMRShET01fU1RPUkFHRSkgcG9zaXRpb24gc28gdGhhdCB0aGUgYnVp bGQgZG9lc24ndCBmYWlsLgogVGhlIG5hbWVzcGFjZSBXZWJDb3JlIHdhcyBzdGFydGVkIGFmdGVy IHRoZSAjaWYgRU5BQkxFKERPTV9TVE9SQUdFKSBidXQgY2xvc2VkIGFmdGVyIHRoZSAjZW5kaWYu CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY4NTkKCi0tLQogV2Vi Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwog V2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2UuY3BwIHwgICAgNCArKy0tCiAyIGZpbGVz IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmNzNiNDhjLi5iMjUy YWVhIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDA5LTA2LTMwICBNYXhpbWUgU2ltb24gIDxzaW1vbi5tYXhp bWVAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1vdmVkICNlbmRpZiAvL0VOQUJMRShET01fU1RPUkFHRSkgcG9zaXRpb24KKyAgICAg ICAgc28gdGhhdCB0aGUgYnVpbGQgZG9lc24ndCBmYWlsLgorICAgICAgICBUaGUgbmFtZXNwYWNl IFdlYkNvcmUgd2FzIHN0YXJ0ZWQgYWZ0ZXIgdGhlICNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCisg ICAgICAgIGJ1dCBjbG9zZWQgYWZ0ZXIgdGhlICNlbmRpZi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2ODU5CisKKyAgICAgICAgV0FSTklORzogTk8g VEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VO YW1lc3BhY2UuY3BwOgorCiAyMDA5LTA2LTMwICBBZHJpZW4gTmFkZXIgIDxjYW1hcmFkZXR1eEBn bWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2UuY3BwIGIvV2ViQ29yZS9zdG9yYWdlL1N0 b3JhZ2VOYW1lc3BhY2UuY3BwCmluZGV4IGQ4ZDg1YTcuLjQ4Mjk1YjAgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvc3RvcmFnZS9TdG9yYWdlTmFtZXNwYWNlLmNwcAorKysgYi9XZWJDb3JlL3N0b3JhZ2Uv U3RvcmFnZU5hbWVzcGFjZS5jcHAKQEAgLTEyNCw2ICsxMjQsNiBAQCB2b2lkIFN0b3JhZ2VOYW1l c3BhY2U6OmNsb3NlKCkKICNlbmRpZgogfQogCi0jZW5kaWYgLy8gRU5BQkxFKERPTV9TVE9SQUdF KQotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKKyNlbmRpZiAvLyBFTkFCTEUoRE9NX1NUT1JB R0UpCi0tIAoxLjYuMy4zCgo=