268481 2024-01-31 10:26:40 -0800 Add `::first-line` UA stylesheet rules similar to `::placeholder` 2024-02-07 10:27:23 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=245523 InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 webkit-unassigned koivisto ntim webkit-bug-importer zalan oldest_to_newest 2009393 0 ahmad.saleem792 2024-01-31 10:26:40 -0800 Hi Team, In bug 244982 (254416@main), I added UA stylesheet rules for ::placeholder as per web-spec that it states that similar rules of ::first-line applies to ::placeholder but I never added them for ::first-line: Web-Spec: https://drafts.csswg.org/css-pseudo-4/#first-line-styling "User agents may apply other properties as well except for the following excluded properties: writing-mode direction text-orientation" __ So if I add following in html.css: ::first-line { direction: inherit !important; text-orientation: inherit !important; writing-mode: inherit !important; } __ We progress two WPT tests: https://wpt.fyi/results/css/CSS2/selectors?label=master&label=experimental&aligned&q=first-line-inherit%20safari%3Afail __ Just wanted to raise to get input whether it is right way to go ahead and do it. NOTE - We don't have CSS2 directory imported, so if I have to do this change, it would be without test case. Thanks! 2009414 1 ahmad.saleem792 2024-01-31 11:05:25 -0800 Note - if I expand this like: ::first-line { direction: inherit !important; text-orientation: inherit !important; writing-mode: inherit !important; transform: none !important; word-break: normal !important; border: none !important; border-image: none !important; border-radius: 0 !important; transition: all !important; margin: 0 !important; padding: 0 !important; position: static !important; } __ I also progress all except two tests in : https://wpt.fyi/results/css/css-pseudo/first-line-allowed-properties.html?label=master&label=experimental&aligned=&q=first-line 2010106 2 koivisto 2024-02-02 08:28:39 -0800 That sort of rule on UA stylesheet would likely regress performance as we would need to compute ::first-line pseudo-element for every element. I think the correct approach is to prevent these properties from being applied in the C++ level (see PropertyAllowList.h/.cpp) for a possible strategy. 2010119 3 ahmad.saleem792 2024-02-02 09:07:50 -0800 (In reply to Antti Koivisto from comment #2) > That sort of rule on UA stylesheet would likely regress performance as we > would need to compute ::first-line pseudo-element for every element. I think > the correct approach is to prevent these properties from being applied in > the C++ level (see PropertyAllowList.h/.cpp) for a possible strategy. Thanks! I can try and see how far I progress. But never tried that part of area. :-) 2011444 4 webkit-bug-importer 2024-02-07 10:27:23 -0800 <rdar://problem/122479591>