<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>268479</bug_id>
          
          <creation_ts>2024-01-31 09:56:43 -0800</creation_ts>
          <short_desc>REGRESSION (234750@main): [GTK][WPE] preferred language not passed to NetworkProcess if set in WebContext before creating WebView</short_desc>
          <delta_ts>2024-02-02 12:58:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=213214</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=188111</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Olivier Blin">olivier.blin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>loic.yhuel</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2009382</commentid>
    <comment_count>0</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2024-01-31 09:56:43 -0800</bug_when>
    <thetext>In GLib ports, since 234750@main, the user preferred language is not properly passed to the NetworkProcess if it is set in WebContext before creating the WebView.
This causes a wrong Accept-Language header in HTTP requests sent with libsoup.


The webkit_web_context_set_preferred_languages() API can be called before passing the WebContext at WebView creation.
Since 234750@main, this function calls the setOverrideLanguages() WebProcessPool API instead of the overrideUserPreferredLanguages() WTF API.

So WebProcessPool::platformInitializeNetworkProcess() can not get the real preferred language from the userPreferredLanguages() WTF API.
Instead, the NetworkProcess creation should use the overrideLanguages() WebProcessPool API, like already done for the WebProcess creation parameters (see also 226031@main).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2009384</commentid>
    <comment_count>1</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2024-01-31 10:01:41 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/23596</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2010229</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-02-02 12:58:20 -0800</bug_when>
    <thetext>Committed 274011@main (f2599adbe881): &lt;https://commits.webkit.org/274011@main&gt;

Reviewed commits have been landed. Closing PR #23596 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>