26843 2009-06-30 08:15:18 -0700 Fix run-time crashes in JavaScriptCore on Symbian with Metrowerks compiler 2009-07-06 10:19:28 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hausmann webkit-unassigned laszlo.gombos norbert.leser oldest_to_newest 129076 0 hausmann 2009-06-30 08:15:18 -0700 The Metrowerks compiler on the Symbian platform moves the globally defined Hashtables into read-only memory, despite one of the members being mutable. This causes crashes at run-time due to write access to read-only memory. This patch avoid the use of const with this compiler by introducing the JSC_CONST_HASHTABLE macro. 129078 1 32066 hausmann 2009-06-30 08:18:12 -0700 Created attachment 32066 Patch to fix run-time crashes with winscw 129176 2 32066 eric 2009-06-30 14:37:10 -0700 Comment on attachment 32066 Patch to fix run-time crashes with winscw Have we reported the issue to metroworks? It seems useful to have a link to an bug in their tracker (if such a thing exists) or some way of knowing when we can revert this. If this is the only way to fix this (modifying the source instead of passing an extra compiler flag or something), then this is totally a fine fix. It just would be nice to know when we can remove it. 129276 3 hausmann 2009-07-01 01:23:33 -0700 Yes, the issue is being tracked upstream in the Carbide Bugzilla at https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=8574 (the bugzilla seems to require account registration to see and comment on reports, but it's free for anyone) I'm all for removing the workaround as soon as the compiler is fixed and a new release is available. 129850 4 32066 mjs 2009-07-05 04:33:24 -0700 Comment on attachment 32066 Patch to fix run-time crashes with winscw r=me I would suggest maybe making the comment above JSC_CONST_HASHTABLE a bit shorter, just stating that it's a workaround for a compiler bug should do. 129964 5 hausmann 2009-07-06 10:19:28 -0700 Landed in 45553 32066 2009-06-30 08:18:12 -0700 2009-07-05 04:33:24 -0700 Patch to fix run-time crashes with winscw 0001-Fix-run-time-crashes-in-JavaScriptCore-with-the-Metr.patch text/plain 5866 hausmann RnJvbSA3NWM4NzQ4MzEwYzVmYzM0MjliZWJjMTFlNTY4ZWM3MjFlYWQyOGQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXJzIEtub2xsIDxsYXJzLmtub2xsQG5va2lhLmNvbT4KRGF0 ZTogVGh1LCAxMSBKdW4gMjAwOSAxMjoyMjowNCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBy dW4tdGltZSBjcmFzaGVzIGluIEphdmFTY3JpcHRDb3JlIHdpdGggdGhlIE1ldHJvd2Vya3MgY29t cGlsZXIgb24gU3ltYmlhbi4KClRoZSBNZXRyb3dlcmtzIGNvbXBpbGVyIG9uIHRoZSBTeW1iaWFu IHBsYXRmb3JtIG1vdmVzIHRoZSBnbG9iYWxseQpkZWZpbmVkIEhhc2h0YWJsZXMgaW50byByZWFk LW9ubHkgbWVtb3J5LCBkZXNwaXRlIG9uZSBvZiB0aGUgbWVtYmVycwpiZWluZyBtdXRhYmxlLiBU aGlzIGNhdXNlcyBjcmFzaGVzIGF0IHJ1bi10aW1lIGR1ZSB0byB3cml0ZSBhY2Nlc3MgdG8KcmVh ZC1vbmx5IG1lbW9yeS4KCkF2b2lkIHRoZSB1c2Ugb2YgY29uc3Qgd2l0aCB0aGlzIGNvbXBpbGVy IGJ5IGludHJvZHVjaW5nIHRoZQpKU0NfQ09OU1RfSEFTSFRBQkxFIG1hY3JvLgoKQmFzZWQgb24g aWRlYSBieSBOb3JiZXJ0IExlc2VyLgotLS0KIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgfCAgIDIwICsrKysrKysrKysrKysrKysrKysrCiBKYXZhU2NyaXB0Q29y ZS9jcmVhdGVfaGFzaF90YWJsZSAgICAgICAgICAgIHwgICAgMiArLQogSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0dsb2JhbERhdGEuY3BwICAgICB8ICAgMTYgKysrKysrKystLS0tLS0tLQogSmF2 YVNjcmlwdENvcmUvcnVudGltZS9Mb29rdXAuaCAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysr KysrCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxOCAr KysrKysrKysrKysrKysrKysKIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y SlMucG0gfCAgICAyICstCiA2IGZpbGVzIGNoYW5nZWQsIDYwIGluc2VydGlvbnMoKyksIDEwIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAwMzdiODRjLi5kNzdkMjc1IDEwMDY0NAotLS0gYS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMDYtMzAgIExhcnMgS25vbGwgIDxsYXJzLmtub2xsQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggcnVuLXRpbWUgY3Jhc2hlcyBpbiBKYXZhU2NyaXB0Q29yZSB3aXRoIHRoZSBNZXRyb3dlcmtz IGNvbXBpbGVyIG9uIFN5bWJpYW4uCisgICAgICAgIAorICAgICAgICBUaGUgTWV0cm93ZXJrcyBj b21waWxlciBvbiB0aGUgU3ltYmlhbiBwbGF0Zm9ybSBtb3ZlcyB0aGUgZ2xvYmFsbHkKKyAgICAg ICAgZGVmaW5lZCBIYXNodGFibGVzIGludG8gcmVhZC1vbmx5IG1lbW9yeSwgZGVzcGl0ZSBvbmUg b2YgdGhlIG1lbWJlcnMKKyAgICAgICAgYmVpbmcgbXV0YWJsZS4gVGhpcyBjYXVzZXMgY3Jhc2hl cyBhdCBydW4tdGltZSBkdWUgdG8gd3JpdGUgYWNjZXNzIHRvCisgICAgICAgIHJlYWQtb25seSBt ZW1vcnkuCisgICAgICAgIAorICAgICAgICBBdm9pZCB0aGUgdXNlIG9mIGNvbnN0IHdpdGggdGhp cyBjb21waWxlciBieSBpbnRyb2R1Y2luZyB0aGUKKyAgICAgICAgSlNDX0NPTlNUX0hBU0hUQUJM RSBtYWNyby4KKyAgICAgICAgCisgICAgICAgIEJhc2VkIG9uIGlkZWEgYnkgTm9yYmVydCBMZXNl ci4KKworICAgICAgICAqIGNyZWF0ZV9oYXNoX3RhYmxlOgorICAgICAgICAqIHJ1bnRpbWUvSlNH bG9iYWxEYXRhLmNwcDoKKyAgICAgICAgKiBydW50aW1lL0xvb2t1cC5oOgorCiAyMDA5LTA2LTMw ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9jcmVhdGVfaGFz aF90YWJsZSBiL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxlCmluZGV4IDI1ZDBiMDIu LjQxODQ1MDAgMTAwNzU1Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxlCisr KyBiL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxlCkBAIC0yNjgsNyArMjY4LDcgQEAg c3ViIG91dHB1dCgpIHsKICAgICB9CiAgICAgcHJpbnQgIiAgIHsgMCwgMCwgMCwgMCB9XG4iOwog ICAgIHByaW50ICJ9O1xuXG4iOwotICAgIHByaW50ICJleHRlcm4gY29uc3Qgc3RydWN0IEhhc2hU YWJsZSAkbmFtZSA9XG4iOworICAgIHByaW50ICJleHRlcm4gSlNDX0NPTlNUX0hBU0hUQUJMRSBI YXNoVGFibGUgJG5hbWUgPVxuIjsKICAgICBwcmludCAiICAgIFx7ICRjb21wYWN0U2l6ZSwgJGNv bXBhY3RIYXNoU2l6ZU1hc2ssICRuYW1lRW50cmllcywgMCBcfTtcbiI7CiAgICAgcHJpbnQgIn0g Ly8gbmFtZXNwYWNlXG4iOwogfQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0dsb2JhbERhdGEuY3BwIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEuY3Bw CmluZGV4IGQ1YzRlZTQuLmZmNzI4ZTggMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNHbG9iYWxEYXRhLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFs RGF0YS5jcHAKQEAgLTU5LDE0ICs1OSwxNCBAQCB1c2luZyBuYW1lc3BhY2UgV1RGOwogCiBuYW1l c3BhY2UgSlNDIHsKIAotZXh0ZXJuIGNvbnN0IEhhc2hUYWJsZSBhcnJheVRhYmxlOwotZXh0ZXJu IGNvbnN0IEhhc2hUYWJsZSBqc29uVGFibGU7Ci1leHRlcm4gY29uc3QgSGFzaFRhYmxlIGRhdGVU YWJsZTsKLWV4dGVybiBjb25zdCBIYXNoVGFibGUgbWF0aFRhYmxlOwotZXh0ZXJuIGNvbnN0IEhh c2hUYWJsZSBudW1iZXJUYWJsZTsKLWV4dGVybiBjb25zdCBIYXNoVGFibGUgcmVnRXhwVGFibGU7 Ci1leHRlcm4gY29uc3QgSGFzaFRhYmxlIHJlZ0V4cENvbnN0cnVjdG9yVGFibGU7Ci1leHRlcm4g Y29uc3QgSGFzaFRhYmxlIHN0cmluZ1RhYmxlOworZXh0ZXJuIEpTQ19DT05TVF9IQVNIVEFCTEUg SGFzaFRhYmxlIGFycmF5VGFibGU7CitleHRlcm4gSlNDX0NPTlNUX0hBU0hUQUJMRSBIYXNoVGFi bGUganNvblRhYmxlOworZXh0ZXJuIEpTQ19DT05TVF9IQVNIVEFCTEUgSGFzaFRhYmxlIGRhdGVU YWJsZTsKK2V4dGVybiBKU0NfQ09OU1RfSEFTSFRBQkxFIEhhc2hUYWJsZSBtYXRoVGFibGU7Citl eHRlcm4gSlNDX0NPTlNUX0hBU0hUQUJMRSBIYXNoVGFibGUgbnVtYmVyVGFibGU7CitleHRlcm4g SlNDX0NPTlNUX0hBU0hUQUJMRSBIYXNoVGFibGUgcmVnRXhwVGFibGU7CitleHRlcm4gSlNDX0NP TlNUX0hBU0hUQUJMRSBIYXNoVGFibGUgcmVnRXhwQ29uc3RydWN0b3JUYWJsZTsKK2V4dGVybiBK U0NfQ09OU1RfSEFTSFRBQkxFIEhhc2hUYWJsZSBzdHJpbmdUYWJsZTsKIAogc3RydWN0IFZQdHJT ZXQgewogICAgIFZQdHJTZXQoKTsKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv TG9va3VwLmggYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0xvb2t1cC5oCmluZGV4IDNiNzM1M2Qu LmMxYzVkN2IgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTG9va3VwLmgKKysr IGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Mb29rdXAuaApAQCAtMjksNiArMjksMTggQEAKICNp bmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAKKy8qCisgICAg VGhlIE1ldHJvd2Vya3MgY29tcGlsZXIgb24gdGhlIFN5bWJpYW4gcGxhdGZvcm0gbW92ZXMgdGhl IGdsb2JhbGx5CisgICAgZGVmaW5lZCBIYXNodGFibGVzIGludG8gcmVhZC1vbmx5IG1lbW9yeSwg ZGVzcGl0ZSBvbmUgb2YgdGhlIG1lbWJlcnMKKyAgICBiZWluZyBtdXRhYmxlLiBUaGlzIGNhdXNl cyBjcmFzaGVzIGF0IHJ1bi10aW1lIGR1ZSB0byB3cml0ZSBhY2Nlc3MgdG8KKyAgICByZWFkLW9u bHkgbWVtb3J5LgorKi8KKyNpZiBDT01QSUxFUihXSU5TQ1cpCisjZGVmaW5lIEpTQ19DT05TVF9I QVNIVEFCTEUKKyNlbHNlCisjZGVmaW5lIEpTQ19DT05TVF9IQVNIVEFCTEUgY29uc3QKKyNlbmRp ZgorCiBuYW1lc3BhY2UgSlNDIHsKIAogICAgIC8vIEhhc2ggdGFibGUgZ2VuZXJhdGVkIGJ5IHRo ZSBjcmVhdGVfaGFzaF90YWJsZSBzY3JpcHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY3M2I0OGMuLmJkYjRhYzYgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMDktMDYtMzAgIExhcnMgS25vbGwgIDxsYXJzLmtub2xsQG5va2lhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcnVuLXRpbWUg Y3Jhc2hlcyBpbiBKYXZhU2NyaXB0Q29yZSB3aXRoIHRoZSBNZXRyb3dlcmtzIGNvbXBpbGVyIG9u IFN5bWJpYW4uCisgICAgICAgIAorICAgICAgICBUaGUgTWV0cm93ZXJrcyBjb21waWxlciBvbiB0 aGUgU3ltYmlhbiBwbGF0Zm9ybSBtb3ZlcyB0aGUgZ2xvYmFsbHkKKyAgICAgICAgZGVmaW5lZCBI YXNodGFibGVzIGludG8gcmVhZC1vbmx5IG1lbW9yeSwgZGVzcGl0ZSBvbmUgb2YgdGhlIG1lbWJl cnMKKyAgICAgICAgYmVpbmcgbXV0YWJsZS4gVGhpcyBjYXVzZXMgY3Jhc2hlcyBhdCBydW4tdGlt ZSBkdWUgdG8gd3JpdGUgYWNjZXNzIHRvCisgICAgICAgIHJlYWQtb25seSBtZW1vcnkuCisgICAg ICAgIAorICAgICAgICBBdm9pZCB0aGUgdXNlIG9mIGNvbnN0IHdpdGggdGhpcyBjb21waWxlciBi eSBpbnRyb2R1Y2luZyB0aGUKKyAgICAgICAgSlNDX0NPTlNUX0hBU0hUQUJMRSBtYWNyby4KKyAg ICAgICAgCisgICAgICAgIEJhc2VkIG9uIGlkZWEgYnkgTm9yYmVydCBMZXNlci4KKworICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorCiAyMDA5LTA2LTMwICBB ZHJpZW4gTmFkZXIgIDxjYW1hcmFkZXR1eEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JKUy5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMu cG0KaW5kZXggNGY5YWExYS4uYmJiZTU0MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckpTLnBtCkBAIC0xOTEwLDcgKzE5MTAsNyBAQCB0YWJsZVNpemVMb29wOgog ICAgIHB1c2goQGltcGxDb250ZW50LCAifTtcblxuIik7CiAgICAgbXkgJHBlcmZlY3RTaXplTWFz ayA9ICRwZXJmZWN0U2l6ZSAtIDE7CiAgICAgbXkgJGNvbXBhY3RTaXplTWFzayA9ICRudW1FbnRy aWVzIC0gMTsKLSAgICBwdXNoKEBpbXBsQ29udGVudCwgInN0YXRpYyBjb25zdCBIYXNoVGFibGUg JG5hbWUgPVxuIik7CisgICAgcHVzaChAaW1wbENvbnRlbnQsICJzdGF0aWMgSlNDX0NPTlNUX0hB U0hUQUJMRSBIYXNoVGFibGUgJG5hbWUgPVxuIik7CiAgICAgcHVzaChAaW1wbENvbnRlbnQsICIj aWYgRU5BQkxFKFBFUkZFQ1RfSEFTSF9TSVpFKVxuIik7CiAgICAgcHVzaChAaW1wbENvbnRlbnQs ICIgICAgeyAkcGVyZmVjdFNpemVNYXNrLCAkbmFtZUVudHJpZXMsIDAgfTtcbiIpOwogICAgIHB1 c2goQGltcGxDb250ZW50LCAiI2Vsc2VcbiIpOwotLSAKMS42LjMuMS4xNjkuZzMzZmQKCg==