26842 2009-06-30 07:52:07 -0700 Build fix when ENABLE_DATABASE is off 2009-07-01 19:04:26 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 skyul webkit-unassigned jmalonzo mikkel oldest_to_newest 129072 0 skyul 2009-06-30 07:52:07 -0700 ScriptObjectQuarantine.cpp won't compile as Database.h is missing when ENABLE_DATABASE is off. Move #include "Database.h" into ENABLE(DATABASE) guard so toggling ENALBE_DATABASE off does not break builds. 129073 1 32065 skyul 2009-06-30 07:54:31 -0700 Created attachment 32065 ENABLE_DATABASE build fix Build fix. 129175 2 32065 eric 2009-06-30 14:34:42 -0700 Comment on attachment 32065 ENABLE_DATABASE build fix Looks fine. 129227 3 jmalonzo 2009-06-30 18:35:03 -0700 *** Bug 25113 has been marked as a duplicate of this bug. *** 129229 4 jmalonzo 2009-06-30 18:55:19 -0700 (In reply to comment #1) > Created an attachment (id=32065) [review] > ENABLE_DATABASE build fix > > Build fix. > I think this fix will break the other ports. If you look inside Database.h, the header is also used even if ENABLE_DATABASE is off (there's an else clause). Which port does this happen? If it's the Gtk port, you might want to move Database.h out of the ENABLE_DATABASE guard and put it in webcore_sources further up. 129441 5 eric 2009-07-01 19:04:26 -0700 r45462 32065 2009-06-30 07:54:31 -0700 2009-06-30 14:34:42 -0700 ENABLE_DATABASE build fix database-build-fix.diff text/plain 1195 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTM3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDYtMzAgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY4NDIKKyAgICAgICAg QnVpbGQgZml4IHdoZW4gRU5BQkxFX0RBVEFCQVNFIGlzIG9mZgorCisgICAgICAgIE1vdmUgRGF0 YWJhc2UuaCBpbnRvIEVOQUJMRShEQVRBQkFTRSkgZ3VhcmQgc28gdG9nZ2xpbmcgRU5BQkxFX0RB VEFCQVNFCisgICAgICAgIG9mZiBkb2VzIG5vdCBicmVhayBidWlsZHMuCisKKyAgICAgICAgKiBi aW5kaW5ncy9qcy9TY3JpcHRPYmplY3RRdWFyYW50aW5lLmNwcDoKKwogMjAwOS0wNi0zMCAgQWRy aWVuIE5hZGVyICA8Y2FtYXJhZGV0dXhAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFhhbiBMb3Blei4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0T2JqZWN0UXVhcmFu dGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRPYmplY3RR dWFyYW50aW5lLmNwcAkocmV2aXNpb24gNDUzNzQpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1Nj cmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSw2IEBA CiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiU2NyaXB0T2JqZWN0UXVhcmFudGluZS5o IgogCi0jaW5jbHVkZSAiRGF0YWJhc2UuaCIKICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1 ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiSlNET01CaW5kaW5nLmgiCkBAIC00Myw2ICs0Miw3IEBA CiAjaW5jbHVkZSA8cnVudGltZS9KU0xvY2suaD4KIAogI2lmIEVOQUJMRShEQVRBQkFTRSkKKyNp bmNsdWRlICJEYXRhYmFzZS5oIgogI2luY2x1ZGUgIkpTRGF0YWJhc2UuaCIKICNlbmRpZgogCg==