268410 2024-01-30 14:13:56 -0800 Limit size of target string stored in serialized session state 2025-03-17 07:06:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=264879 https://bugs.webkit.org/show_bug.cgi?id=289898 InRadar P2 Normal --- 1 nham nham mcatanzaro nham webkit-bug-importer oldest_to_newest 2009090 0 nham 2024-01-30 14:13:56 -0800 We've seen some MobileSafari launches that take a long time during session restoration because the _WKSessionState object contains a back/forward list item with an absurdly large target string (like >500KB in size). 2009091 1 nham 2024-01-30 14:14:12 -0800 rdar://120213426 2009098 2 nham 2024-01-30 14:21:41 -0800 Pull request: https://github.com/WebKit/WebKit/pull/23537 2009216 3 ews-feeder 2024-01-30 21:35:29 -0800 Committed 273810@main (624a3d6250ec): <https://commits.webkit.org/273810@main> Reviewed commits have been landed. Closing PR #23537 and removing active labels. 2011726 4 mcatanzaro 2024-02-08 06:56:50 -0800 This looks very similar to bug #264879, but unfortunately the patch that landed here is Mac-specific and therefore cannot help with that bug. (In reply to Ben Nham from comment #0) > We've seen some MobileSafari launches that take a long time during session > restoration I think this patch also doesn't help mobile Safari? It is a Mac-specific file, not a Cocoa file. It shouldn't be used on iOS. If it's used on iOS, then it's in the wrong location. 2011774 5 nham 2024-02-08 09:03:02 -0800 > unfortunately the patch that landed here is Mac-specific and therefore cannot help with that bug Despite the name of this file, it compiles on all Cocoa platforms. 2011779 6 nham 2024-02-08 09:11:07 -0800 That said I think if you want a fix for GTK then you'll probably have to do a platform-specific change for now given the structure of the code at the moment. For Cocoa, after looking at this some more, there are even more issues in the way this old code handles deserialization of >2MB session states. But we're going to fix that in the future. See https://bugs.webkit.org/show_bug.cgi?id=268994. 2011782 7 mcatanzaro 2024-02-08 09:21:26 -0800 (In reply to Ben Nham from comment #5) > Despite the name of this file, it compiles on all Cocoa platforms. Well the file name is actually OK, just the location is not. It should move from Source/WebKit/UIProcess/mac to Source/WebKit/UIProcess/Cocoa. (Unfortunately moving files is hard without XCode, so I won't attempt this myself.)