268251 2024-01-28 06:18:48 -0800 Add support for SVGAElement's text attribute 2024-02-17 22:46:22 -0800 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX https://github.com/w3c/svgwg/issues/931 InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 webkit-unassigned frances_c sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 2008271 0 ahmad.saleem792 2024-01-28 06:18:48 -0800 Hi Team, It is to add parity to HTMLAnchorElement and it is in web-spec: https://svgwg.org/svg2-draft/linking.html#InterfaceSVGAElement It seems easy to add and progress two WPT test cases in 'svg/idlharness.window.html'. I have local build with patch as well. Just wanted to raise this so we can do this. Thanks! 2008276 1 ahmad.saleem792 2024-01-28 06:34:44 -0800 >> Source/WebCore/svg/SVGAElement.cpp: String SVGAElement::text() { return textContent(); } void SVGAElement::setText(String&& text) { setTextContent(WTFMove(text)); } >> Source/WebCore/svg/SVGAElement.h: (In public) WEBCORE_EXPORT String text(); void setText(String&&); >> Source/WebCore/svg/SVGAElement.idl: [CEReactions=Needed] attribute DOMString text; __ That's it. 2008277 2 ahmad.saleem792 2024-01-28 06:35:58 -0800 @Frances - do you want to take this? 2008278 3 ahmad.saleem792 2024-01-28 06:41:13 -0800 Might have to add: >> Source/WebCore/svg/svgattrs.in: 'text' (without quotes) as well. 2008279 4 ahmad.saleem792 2024-01-28 06:41:57 -0800 Might progress this as well: https://wpt.fyi/results/svg/linking/scripted/a.text-setter-01.svg?label=master&label=experimental&aligned=&q=svg%2Flinking%2F and https://wpt.fyi/results/svg/linking/scripted/a.text-getter-01.svg?label=experimental&label=master&aligned=&q=svg%2Flinking%2F 2008491 5 frances_c 2024-01-29 08:39:51 -0800 Yes, I will work on this today. 2008498 6 frances_c 2024-01-29 08:58:06 -0800 Pull request: https://github.com/WebKit/WebKit/pull/23424 2009075 7 frances_c 2024-01-30 13:25:29 -0800 Relating to: https://bugs.webkit.org/show_bug.cgi?id=268407 2010484 8 webkit-bug-importer 2024-02-04 06:19:13 -0800 <rdar://problem/122268835> 2014908 9 ahmad.saleem792 2024-02-17 22:46:22 -0800 As mentioned - https://github.com/w3c/svgwg/issues/931 - Firefox is removing this. So WONTFIX.