26820 2009-06-29 16:49:58 -0700 Fix an inverted null check in V8Proxy 2009-06-30 09:27:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet japhet dglazkov oldest_to_newest 128919 0 japhet 2009-06-29 16:49:58 -0700 See summary. 128920 1 32027 japhet 2009-06-29 16:52:01 -0700 Created attachment 32027 patch 128926 2 eric 2009-06-29 17:40:31 -0700 I'm looking for a bug to test changes to bugzilla-tool with. This one, being simple and easy seems perfect. So I'll land this one for you in about 5 minutes unless someone beats me to it. :) 128927 3 eric 2009-06-29 17:41:15 -0700 Does this not affect layout tests? I would have expected to see either tests added or results changed? 128928 4 32027 levin 2009-06-29 17:52:35 -0700 Comment on attachment 32027 patch Either it needs a layout test or a comment about what layout test is being fixed. 129082 5 32027 dglazkov 2009-06-30 09:21:51 -0700 Comment on attachment 32027 patch This was a mis-type that occurred during upstreaming. It was discovered as a failure of an existing test, but the test hasn't yet been upstreamed: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/chrome/fast/dom/messageport-gc.html?revision=5770&view=markup The test needs some cleaning up before upstreaming and I am hesitant to hold up this fix for that. 129084 6 japhet 2009-06-30 09:27:07 -0700 Landed as r45377. 32027 2009-06-29 16:52:01 -0700 2009-06-30 09:21:51 -0700 patch patch.txt text/plain 1138 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTM1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDYtMjkgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggaW52ZXJ0ZWQgaWYvZWxzZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjY4MjAKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R0NQcm9sb2d1ZVZpc2l0b3I6OnZpc2l0RE9NV3JhcHBlcik6 IGlmIChwb3J0MiksIG5vdCBpZiAoIXBvcnQyKS4KKwogMjAwOS0wNi0yOSAgTmF0ZSBDaGFwaW4g IDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xh emtvdi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAkocmV2aXNpb24gNDUzNTkpCisrKyBX ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTMsNyAr MzUzLDcgQEAgcHVibGljOgogICAgICAgICBpZiAocG9ydDEtPmlzRW50YW5nbGVkKCkgJiYgIXBv cnQyKQogICAgICAgICAgICAgd3JhcHBlci5DbGVhcldlYWsoKTsKIAotICAgICAgICBpZiAoIXBv cnQyKSB7CisgICAgICAgIGlmIChwb3J0MikgewogICAgICAgICAgICAgLy8gQXMgcG9ydHMgYXJl IGFsd2F5cyBlbnRhbmdsZWQgaW4gcGFpcnMgb25seSBwZXJmb3JtIHRoZSBlbnRhbmdsZW1lbnQK ICAgICAgICAgICAgIC8vIG9uY2UgZm9yIGVhY2ggcGFpciAoc2VlIEFTU0VSVCBpbiBNZXNzYWdl UG9ydDo6dW5lbnRhbmdsZSgpKS4KICAgICAgICAgICAgIGlmIChwb3J0MSA8IHBvcnQyKSB7Cg==