26787 2009-06-28 19:22:49 -0700 REGRESSION (r45064): Drop caret remains in text control after the mouse exits 2009-12-22 11:30:03 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED https://bugs.webkit.org/attachment.cgi?bugid=26783&action=enter InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned abarth ap eric simon.fraser oldest_to_newest 128765 0 mitz 2009-06-28 19:22:49 -0700 Steps to reproduce: 1) Go to the URL 2) Drag a file to the file upload control, passing over the Description text field on the way over Results: A drag caret appears in the text field when the mouse passes over it, but does not disappear when the mouse exits the field, nor when the file is dropped on the control. The caret should disappear as soon as the mouse exits the field. 128771 1 mitz 2009-06-28 20:00:36 -0700 This was most likely caused by <http://trac.webkit.org/changeset/45064>. 128772 2 mitz 2009-06-28 20:00:57 -0700 <rdar://problem/7014793> 128773 3 mitz 2009-06-28 20:06:18 -0700 Confirmed that reverting r45064 and r45065 fixes the bug. 129547 4 eric 2009-07-02 12:25:58 -0700 I found bug 24731 which is unlikely to be related, but reminded me of this bug. 129548 5 eric 2009-07-02 12:28:18 -0700 Hum. I'm not sure how the caret is supposed to be set back when the mouse exits. Maybe before the dragging over other random parts of the page always returned "None" I'll have to try this in the debugger. 130448 6 eric 2009-07-08 10:10:01 -0700 I owe you a fix for this. I'll look today. 136777 7 simon.fraser 2009-08-03 14:10:00 -0700 Eric: any update? 136805 8 34010 eric 2009-08-03 15:33:23 -0700 Created attachment 34010 An update for smfr --- 6 files changed, 33 insertions(+), 7 deletions(-) 137247 9 eric 2009-08-04 21:22:32 -0700 Oh, did this never land? 137248 10 eric 2009-08-04 21:23:17 -0700 I think this was the patch I was trying to land when run-webkit-tests started failing with the zsh error for me. Will land now. 137250 11 34010 eric 2009-08-04 21:36:12 -0700 Comment on attachment 34010 An update for smfr Clearing review flag on attachment: 34010 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/forms/drag-into-textarea.html M LayoutTests/fast/forms/drag-out-of-textarea.html M WebCore/ChangeLog A WebCore/manual-tests/drag-caret.html M WebCore/page/DragController.cpp Committed r46792 M WebCore/ChangeLog M WebCore/page/DragController.cpp A WebCore/manual-tests/drag-caret.html M LayoutTests/ChangeLog M LayoutTests/fast/forms/drag-out-of-textarea.html M LayoutTests/fast/forms/drag-into-textarea.html r46792 = 9d9d45a380de61fd378173cac93fd81b2b9c865f (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46792 137251 12 eric 2009-08-04 21:36:15 -0700 All reviewed patches have been landed. Closing bug. 174287 13 ap 2009-12-22 10:09:43 -0800 This was also causing random crashes at page teardown time (usually in Node::isDescendantOf()). 174313 14 eric 2009-12-22 11:09:20 -0800 I'm confused by ap's comment. This was successfully fixed, yes? You were just noting this had other symptoms, no? 174317 15 ap 2009-12-22 11:30:03 -0800 Yes. 34010 2009-08-03 15:33:23 -0700 2009-08-04 21:36:11 -0700 An update for smfr bug-26787-20090803153320.patch text/plain 4321 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMjAxZjk2Li4zZWJmZWIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDgt MDMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04gKHI0NTA2NCk6IERyb3AgY2Fy ZXQgcmVtYWlucyBpbiB0ZXh0IGNvbnRyb2wgYWZ0ZXIgdGhlIG1vdXNlIGV4aXRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjc4NworCisgICAgICAg IEZpeCBzb21lIGJvZ3VzIGNvbW1lbnRzIG5vdGljZWQgZHVyaW5nIHRlc3RpbmcuCisKKyAgICAg ICAgKiBmYXN0L2Zvcm1zL2RyYWctaW50by10ZXh0YXJlYS5odG1sOgorICAgICAgICAqIGZhc3Qv Zm9ybXMvZHJhZy1vdXQtb2YtdGV4dGFyZWEuaHRtbDoKKwogMjAwOS0wOC0wMyAgSmFuIE1pY2hh ZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbR3RrXSBTa2lwIGFj Y2Vzc2liaWxpdHkvaW5wdXQtc2xpZGVyLmh0bWwgYXMgaXQgbmVlZHMKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvZHJhZy1pbnRvLXRleHRhcmVhLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2RyYWctaW50by10ZXh0YXJlYS5odG1sCmluZGV4IDczZGY3NGIuLmI4NTZh ZGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZHJhZy1pbnRvLXRleHRhcmVh Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kcmFnLWludG8tdGV4dGFyZWEuaHRt bApAQCAtMjEsOCArMjEsNyBAQCBmdW5jdGlvbiBydW5UZXN0KCkgewogICAgIAogICAgIGV2ZW50 U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOwogICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwot ICAgIC8vIFdhaXQgYSBtb21lbnQgc28gdGhhdCB0aGUgbW91c2VEb3duIHdpbGwga2ljayBvZmYg YSBkcmFnIGluc3RlYWQgb2YgYSBuZXcgc2VsZWN0aW9uLgotICAgIC8vIEZJWE1FOiBVZ2gsIGRv bid0IHdhbnQgZGVsYXlzIGluIGxheW91dCB0ZXN0cyEKKyAgICAvLyBMZWFwIHRoZSBldmVudCB0 aW1lIHNvIHRoYXQgbW91c2VNb3ZlIHdpbGwgc3RhcnQgYSBuZXcgZHJhZyBpbnN0ZWFkIG9mIGNo YW5naW5nIHNlbGVjdGlvbi4KICAgICBldmVudFNlbmRlci5sZWFwRm9yd2FyZCg0MDApOwogICAg IGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHR4LCB0eSk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VV cCgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kcmFnLW91dC1vZi10ZXh0 YXJlYS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kcmFnLW91dC1vZi10ZXh0YXJlYS5o dG1sCmluZGV4IGQzZDJjM2EuLjEzYzU5YzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvZHJhZy1vdXQtb2YtdGV4dGFyZWEuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2RyYWctb3V0LW9mLXRleHRhcmVhLmh0bWwKQEAgLTIxLDggKzIxLDcgQEAgZnVuY3Rpb24g cnVuVGVzdCgpIHsKIAogICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHR4LCB0eSk7CiAgICAg ZXZlbnRTZW5kZXIubW91c2VEb3duKCk7Ci0gICAgLy8gV2FpdCBhIG1vbWVudCBzbyB0aGF0IHRo ZSBtb3VzZURvd24gd2lsbCBraWNrIG9mZiBhIGRyYWcgaW5zdGVhZCBvZiBhIG5ldyBzZWxlY3Rp b24uCi0gICAgLy8gRklYTUU6IFVnaCwgZG9uJ3Qgd2FudCBkZWxheXMgaW4gbGF5b3V0IHRlc3Rz IQorICAgIC8vIExlYXAgdGhlIGV2ZW50IHRpbWUgc28gdGhhdCBtb3VzZU1vdmUgd2lsbCBzdGFy dCBhIG5ldyBkcmFnIGluc3RlYWQgb2YgY2hhbmdpbmcgc2VsZWN0aW9uLgogICAgIGV2ZW50U2Vu ZGVyLmxlYXBGb3J3YXJkKDQwMCk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oaXgsIGl5 KTsKICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDkyZDZhZjEuLmRiY2JmNjcgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMDktMDgtMDMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04gKHI0 NTA2NCk6IERyb3AgY2FyZXQgcmVtYWlucyBpbiB0ZXh0IGNvbnRyb2wgYWZ0ZXIgdGhlIG1vdXNl IGV4aXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Njc4NworCisgICAgICAgIEFkZCBiYWNrIG1pc3NpbmcgZHJhZ0NvbnRyb2xsZXIoKS0+Y2xlYXIo KSBjYWxsLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL2RyYWctY2FyZXQuaHRtbDogQWRkZWQu CisgICAgICAgICogcGFnZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE cmFnQ29udHJvbGxlcjo6dHJ5RG9jdW1lbnREcmFnKToKKwogMjAwOS0wOC0wMyAgRGlyayBQcmFu a2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vp bmlnLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvZHJhZy1jYXJldC5odG1sIGIv V2ViQ29yZS9tYW51YWwtdGVzdHMvZHJhZy1jYXJldC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjQzMzRhYjIKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL21hbnVh bC10ZXN0cy9kcmFnLWNhcmV0Lmh0bWwKQEAgLTAsMCArMSwzIEBACis8cD5UaGlzIHRlc3RzIGRy YWdnaW5nIG92ZXIgYW4gaW5wdXQgZWxlbWVudCwgdG8gbWFrZSBzdXJlIG5vIGRyYWctY3Vyc29y IGlzIGxlZnQgYmVoaW5kLjwvcD4KKzxwPjxpbnB1dD48L3A+Cis8cD5EcmFnIHNvbWUgdGV4dCBv dmVyIHRoZSBpbnB1dCBlbGVtZW50IGFuZCBtYWtlIHN1cmUgdGhlIERyYWcgQ2FyZXQgZGlzYXBw ZWFycyB3aGVuIHRoZSBkcmFnIGV4aXRzIHRoZSBpbnB1dCBlbGVtZW50LiBQZXIgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2Nzg3PC9wPgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxl ci5jcHAKaW5kZXggNjRjYjIxMi4uNGQ2ZDVkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0Ry YWdDb250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCkBA IC0yODEsOSArMjgxLDcgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6dHJ5RG9jdW1lbnREcmFnKERy YWdEYXRhKiBkcmFnRGF0YSwgRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uIGEKICAgICBpZiAobV9pc0hh bmRsaW5nRHJhZykgewogICAgICAgICBtX3BhZ2UtPmRyYWdDYXJldENvbnRyb2xsZXIoKS0+Y2xl YXIoKTsKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotCi0gICAgaWYgKChhY3Rpb25NYXNr ICYgRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uRWRpdCkgJiYgIW1faXNIYW5kbGluZ0RyYWcgJiYgY2Fu UHJvY2Vzc0RyYWcoZHJhZ0RhdGEpKSB7CisgICAgfSBlbHNlIGlmICgoYWN0aW9uTWFzayAmIERy YWdEZXN0aW5hdGlvbkFjdGlvbkVkaXQpICYmIGNhblByb2Nlc3NEcmFnKGRyYWdEYXRhKSkgewog ICAgICAgICBpZiAoZHJhZ0RhdGEtPmNvbnRhaW5zQ29sb3IoKSkgewogICAgICAgICAgICAgb3Bl cmF0aW9uID0gRHJhZ09wZXJhdGlvbkdlbmVyaWM7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK QEAgLTMwMiw2ICszMDAsOCBAQCBib29sIERyYWdDb250cm9sbGVyOjp0cnlEb2N1bWVudERyYWco RHJhZ0RhdGEqIGRyYWdEYXRhLCBEcmFnRGVzdGluYXRpb25BY3Rpb24gYQogICAgICAgICBvcGVy YXRpb24gPSBkcmFnSXNNb3ZlKGlubmVyRnJhbWUtPnNlbGVjdGlvbigpKSA/IERyYWdPcGVyYXRp b25Nb3ZlIDogRHJhZ09wZXJhdGlvbkNvcHk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0K KyAgICAvLyBJZiB3ZSdyZSBub3Qgb3ZlciBhbiBlZGl0YWJsZSByZWdpb24sIG1ha2Ugc3VyZSB3 ZSdyZSBjbGVhcmluZyBhbnkgcHJpb3IgZHJhZyBjdXJzb3IuCisgICAgbV9wYWdlLT5kcmFnQ2Fy ZXRDb250cm9sbGVyKCktPmNsZWFyKCk7CiAgICAgcmV0dXJuIGZhbHNlOwogfQ==