267827 2024-01-20 18:56:42 -0800 Begin using C++ coroutines for WebPageProxy::decidePolicyForNavigationAction 2024-05-21 01:31:17 -0700 1 1 1 Unclassified WebKit WebKit Process Model WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen dpino dpino webkit-bug-importer oldest_to_newest 2006404 0 achristensen 2024-01-20 18:56:42 -0800 ... 2006405 1 achristensen 2024-01-20 19:14:48 -0800 Pull request: https://github.com/WebKit/WebKit/pull/23021 2008232 2 webkit-bug-importer 2024-01-27 18:57:14 -0800 <rdar://problem/121762525> 2036411 3 ews-feeder 2024-05-20 08:16:57 -0700 Committed 278995@main (e90f899882e4): <https://commits.webkit.org/278995@main> Reviewed commits have been landed. Closing PR #23021 and removing active labels. 2036624 4 dpino 2024-05-20 23:56:40 -0700 Build bot 'GTK-Linux-64-bit-Release-Debian-11-Build' if failing after this patch with the following error: https://build.webkit.org/#/builders/992/builds/2441/steps/9/logs/stdio ``` In file included from ../../../Source/WebKit/Platform/CoroutineUtilities.h:31, from ../../../Source/WebKit/UIProcess/WebPageProxy.cpp:70, from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-9.cpp:2: /usr/include/c++/10/coroutine:295:2: error: #error "the coroutine header requires -fcoroutines" 295 | #error "the coroutine header requires -fcoroutines" | ^~~~~ In file included from ../../../Source/WebKit/UIProcess/WebPageProxy.cpp:70, from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-9.cpp:2: ../../../Source/WebKit/Platform/CoroutineUtilities.h:48:42: error: expected ‘)’ before ‘<’ token 48 | CoroutineHandle(std::coroutine_handle<PromiseType>&& handle) | ~ ^ | ) ``` 2036628 5 dpino 2024-05-21 00:00:32 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/28833 2036664 6 ews-feeder 2024-05-21 01:31:15 -0700 Committed 279046@main (3a3bb5a411b2): <https://commits.webkit.org/279046@main> Reviewed commits have been landed. Closing PR #28833 and removing active labels.