26777 2009-06-27 18:27:58 -0700 Page cache should allow HTTPS pages taking Cache-control header into account 2012-02-14 03:37:28 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 78597 1 koivisto beidson ap beidson darin ddkilzer emacemac7 matafagafo mjs mnot paulirish psolanki sam skyul oldest_to_newest 128687 0 koivisto 2009-06-27 18:27:58 -0700 HTTP pages that specify "Cache-control: no-store" should not be cacheable to the page cache. Currently they get cached if other factors don't stop it. This will make "no-store" work consistently and match other browsers. On HTTPS pages "Cache-control: no-store" and "Cache-control: no-cache" should prevent caching to the page cache. Otherwise they should be cacheable. Currently HTTPS pages are never allowed in the page cache. This will make page caching available on HTTPS pages in secure manner, improving performance and user experience. These changes would make WebKit page cache behave similarly to Firefox3 (https://bugzilla.mozilla.org/show_bug.cgi?id=441751). 128689 1 koivisto 2009-06-27 18:33:35 -0700 <rdar://problem/7013921> 128994 2 ap 2009-06-30 02:28:58 -0700 Consistency with Firefox is a strong argument - however, the current behavior is by design. To prevent a page from getting into page cache, one can add an onunload handler. 145260 3 beidson 2009-09-07 21:23:56 -0700 In addition to the bugzilla is their developer document of intended behavior: https://developer.mozilla.org/En/Using_Firefox_1.5_caching Adding another radar - <rdar://problem/7196487> - which tracks enabling https in the page cache (which seems closely related to this bug) 145266 4 ap 2009-09-07 22:35:26 -0700 One use case for the current design is the following scenario: - web search is performed using an engine that returns results with Cache-control: no-store (a totally reasonable thing to do); - a user clicks some search result, then goes back. We should be able to return to search results page without making another request to the server, which is slow, and may give different results. 145268 5 beidson 2009-09-07 22:47:32 -0700 I agree with Alexey here, for non-https pages. From a user-experience standpoint, this would be absolutely desirable. In general, there's been a struggle for browser vendors wanting to make the page cache work for more and more pages, and web developers wanting to opt out of the page cache for application-specific reasons. I get the impression that "Cache-control: no-cache" was set in stone by mozilla to be "the way to opt out." From a browser-engineer standpoint, and from the standpoint of someone who uses a web browser heavily, "opting out of the page cache" is the same thing as "opting in to low-performance-with-direct-user impact mode." Is it important for us to *let* them opt out? I think that maybe we should use this bug to track the https work. That is, we start letting https pages into the page cache, unless they send no-cache or no-store. 147400 6 beidson 2009-09-15 15:54:30 -0700 In addition to <rdar://problem/7013921>, the HTTPS specific aspect is also covered by <rdar://problem/7196487> 147708 7 mnot 2009-09-16 19:01:27 -0700 Cache-Control directives are targeted at HTTP caches, and RFC2616 explicitly states that caches and history lists are separate; see http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.13 In particular, see the note at the end. I'm concerned that while this text is confusing and indeed not very helpful at the moment, re-defining the semantics of existing cache directives in an ad hoc fashion is going to create more confusion and interoperability problems. In other words, we need to document this better, especially if the way that the directives work is going to change. The HTTPbis Working Group in the IETF is chartered to revise RFC2616, so this is a good opportunity to do that; for example, we could: * Rewrite section 13.13 to explicitly define CC: no-store as applying to history lists (which is within HTTPbis' charter), or * Define one or more new directives to explicitly control history lists (which isn't in HTTPbis' charter, but we can provide a forum for discussion and feedback), or * Refine the text in other ways. To make that happen, however, we need browser vendors (you) to actively participate in discussions; ideally, making proposals for text changes. You can see the current drafts at: http://tools.ietf.org/wg/httpbis/ and participate on the list at: http://lists.w3.org/Archives/Public/ietf-http-wg/ I've raised a HTTPbis ticket regarding this particular issue at: http://trac.tools.ietf.org/wg/httpbis/trac/ticket/197 (I'll leave it up to you to dediced whether to reopen this, open a new bug, etc.) Mark Nottingham IETF HTTPbis WG Chair / Part 6 (caching) Editor 147728 8 koivisto 2009-09-16 20:35:54 -0700 Right, RFC2616 as-is clearly does not apply to the page cache. Since this is a browser behavior the HTML5 specification might be the natural place to standardize it. It already acknowledges the existence of the page cache but does not currently go any further: "This specification does not specify when user agents should discard Document objects and when they should cache them." 147731 9 beidson 2009-09-16 20:46:13 -0700 Coincidental to the comments in this bug, I just blogged about recent and planned changes in our page cache behavior: http://webkit.org/blog/427/webkit-page-cache-i-the-basics/ 310426 10 ddkilzer 2010-11-17 12:00:42 -0800 See also Bug 49672. 555571 11 beidson 2012-02-13 14:02:59 -0800 Updating title to: "Page cache should allow HTTPS pages taking Cache-control header into account" We've long ignored Firefox's "cache-control: no-store" disqualification for normal HTTP pages and it hasn't identifiably caused any problems. But in introducing support for HTTPS it would be prudent to play the conservative part and disqualify both "cache-control: no-store" and "cache-control: no-cache" like they do. And that's what the patch I'm about to attach does. 555572 12 126830 beidson 2012-02-13 14:03:29 -0800 Created attachment 126830 Patch v1 - Fix + layout test 555588 13 beidson 2012-02-13 14:13:06 -0800 http://trac.webkit.org/changeset/107607 555589 14 beidson 2012-02-13 14:13:06 -0800 http://trac.webkit.org/changeset/107607 126830 2012-02-13 14:03:29 -0800 2012-02-13 14:05:04 -0800 Patch v1 - Fix + layout test patch.txt text/plain 7648 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OTQ0NTNmLi5jNzU4NTdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDIt MTMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83MTk2NDg3PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI2Nzc3CisgICAgICAgIEFkZCBodHRwcyBwYWdlcyB0byB0aGUgcGFnZSBjYWNoZSBpbiBz b21lIGNhc2VzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBodHRwL3Rlc3RzL25hdmlnYXRpb24vaHR0cHMtaW4tcGFnZS1jYWNoZS5odG1sOiBBZGRl ZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL25hdmlnYXRpb24vaHR0cHMtaW4tcGFnZS1jYWNoZS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNv dXJjZXMvaHR0cHMtaW4tcGFnZS1jYWNoZS0xLnBocDogQWRkZWQuCisgICAgICAgICogaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9odHRwcy1pbi1wYWdlLWNhY2hlLTIucGhwOiBBZGRl ZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL2h0dHBzLWluLXBh Z2UtY2FjaGUtMy5odG1sOiBBZGRlZC4KKwogMjAxMi0wMi0xMyAgQ2hyaXMgRmxlaXphY2ggIDxj ZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiA8bWFyaz4gZWxlbWVudCBzaG91bGQg YmUgZXhwb3NlZCB0aHJvdWdoIGF0dHJpYnV0ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvbmF2aWdhdGlvbi9odHRwcy1pbi1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9odHRwcy1pbi1wYWdlLWNhY2hlLWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42YjczODRhCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2h0dHBzLWlu LXBhZ2UtY2FjaGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorQUxFUlQ6IFRoaXMgcGFn ZSBpcyBodHRwcyBhbmQgaGFzIHRoZSBuby1zdG9yZSBjYWNoZS1jb250cm9sIGRpcmVjdGl2ZS4g SXQgc2hvdWxkIE5PVCBnbyBpbiB0byB0aGUgcGFnZSBjYWNoZS4KK0FMRVJUOiBUaGUgcGFnZSB3 YXMgcmVsb2FkZWQgb24gYmFjaywgbm90IGZyb20gdGhlIHBhZ2UgY2FjaGUuIEdvb2Qgam9iLiBS dW5uaW5nIHBhcnQgMiBvZiB0aGUgdGVzdC4KK0FMRVJUOiBUaGlzIHBhZ2UgaXMgaHR0cHMgYW5k IGhhcyB0aGUgbm8tY2FjaGUgY2FjaGUtY29udHJvbCBkaXJlY3RpdmUuIEl0IHNob3VsZCBOT1Qg Z28gaW4gdG8gdGhlIHBhZ2UgY2FjaGUuCitBTEVSVDogVGhlIHBhZ2Ugd2FzIHJlbG9hZGVkIG9u IGJhY2ssIG5vdCBmcm9tIHRoZSBwYWdlIGNhY2hlLiBHb29kIGpvYi4gUnVubmluZyBwYXJ0IDMg b2YgdGhlIHRlc3QuCitBTEVSVDogVGhpcyBwYWdlIGlzIGh0dHBzIGFuZCBzaG91bGQgZ28gaW4g dG8gdGhlIHBhZ2UgY2FjaGUuCitBTEVSVDogVGhlIHBhZ2Ugd2FzIHJlc3RvcmVkIGZyb20gdGhl IHBhZ2UgY2FjaGUuIEdvb2Qgam9iIQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL25hdmlnYXRpb24vaHR0cHMtaW4tcGFnZS1jYWNoZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9uYXZpZ2F0aW9uL2h0dHBzLWluLXBhZ2UtY2FjaGUuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi4xOTU0ZjUwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2h0dHBzLWluLXBhZ2UtY2FjaGUuaHRtbApAQCAt MCwwICsxLDEyIEBACis8c2NyaXB0PgorCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRl c3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKwlsYXlvdXRUZXN0Q29udHJvbGxlci5vdmVy cmlkZVByZWZlcmVuY2UoIldlYktpdFVzZXNQYWdlQ2FjaGVQcmVmZXJlbmNlS2V5IiwgMSk7Cit9 CisKK2lmIChsb2NhdGlvbi5wcm90b2NvbCAhPSAiaHR0cHM6IikKKyAgICBsb2NhdGlvbiA9ICJo dHRwczovLzEyNy4wLjAuMTo4NDQzL25hdmlnYXRpb24vcmVzb3VyY2VzL2h0dHBzLWluLXBhZ2Ut Y2FjaGUtMS5waHAiOworCis8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvaHR0cHMtaW4tcGFnZS1jYWNoZS0xLnBocCBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvaHR0cHMtaW4tcGFnZS1j YWNoZS0xLnBocApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4wZjcxN2U5Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291 cmNlcy9odHRwcy1pbi1wYWdlLWNhY2hlLTEucGhwCkBAIC0wLDAgKzEsMzIgQEAKKzw/cGhwCito ZWFkZXIoImNhY2hlLWNvbnRyb2w6IG5vLXN0b3JlIik7Cis/PgorPHNjcmlwdD4KKworZnVuY3Rp b24gbmV4dFRlc3QoKSB7CisJaWYgKHdpbmRvdy5zZXNzaW9uU3RvcmFnZS5odHRwc19pbl9wYWdl X2NhY2hlX3N0YXJ0ZWQpCisJCWRlbGV0ZSB3aW5kb3cuc2Vzc2lvblN0b3JhZ2UuaHR0cHNfaW5f cGFnZV9jYWNoZV9zdGFydGVkOworCWxvY2F0aW9uID0gImh0dHBzOi8vMTI3LjAuMC4xOjg0NDMv bmF2aWdhdGlvbi9yZXNvdXJjZXMvaHR0cHMtaW4tcGFnZS1jYWNoZS0yLnBocCI7Cit9CisKK3dp bmRvdy5vbnBhZ2VzaG93ID0gZnVuY3Rpb24oZXZ0KSB7CisJaWYgKGV2dC5wZXJzaXN0ZWQpIHsK KwkJYWxlcnQoIlRoZSBwYWdlIHdhcyByZXN0b3JlZCBmcm9tIHRoZSBwYWdlIGNhY2hlLiBJdCBz aG91bGQgTk9UIGhhdmUgYmVlbi4gUnVubmluZyBwYXJ0IDIgb2YgdGhlIHRlc3QuIik7CisJCW5l eHRUZXN0KCk7CisJfQorfQorCit3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKSB7CisJaWYgKHdp bmRvdy5zZXNzaW9uU3RvcmFnZS5odHRwc19pbl9wYWdlX2NhY2hlX3N0YXJ0ZWQpIHsKKwkJYWxl cnQoIlRoZSBwYWdlIHdhcyByZWxvYWRlZCBvbiBiYWNrLCBub3QgZnJvbSB0aGUgcGFnZSBjYWNo ZS4gR29vZCBqb2IuIFJ1bm5pbmcgcGFydCAyIG9mIHRoZSB0ZXN0LiIpOworCQluZXh0VGVzdCgp OworCQlyZXR1cm47CisJfQorCisJYWxlcnQoIlRoaXMgcGFnZSBpcyBodHRwcyBhbmQgaGFzIHRo ZSBuby1zdG9yZSBjYWNoZS1jb250cm9sIGRpcmVjdGl2ZS4gSXQgc2hvdWxkIE5PVCBnbyBpbiB0 byB0aGUgcGFnZSBjYWNoZS4iKTsKKwl3aW5kb3cuc2Vzc2lvblN0b3JhZ2UuaHR0cHNfaW5fcGFn ZV9jYWNoZV9zdGFydGVkID0gdHJ1ZTsKKwlzZXRUaW1lb3V0KCd3aW5kb3cubG9jYXRpb24gPSAi Z28tYmFjay5odG1sIicsIDApOworCit9CisKKzwvc2NyaXB0PgpcIE5vIG5ld2xpbmUgYXQgZW5k IG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9y ZXNvdXJjZXMvaHR0cHMtaW4tcGFnZS1jYWNoZS0yLnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvaHR0cHMtaW4tcGFnZS1jYWNoZS0yLnBocApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mOTk1M2RiCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9odHRwcy1pbi1wYWdl LWNhY2hlLTIucGhwCkBAIC0wLDAgKzEsMzIgQEAKKzw/cGhwCitoZWFkZXIoImNhY2hlLWNvbnRy b2w6IG5vLWNhY2hlIik7Cis/PgorPHNjcmlwdD4KKworZnVuY3Rpb24gbmV4dFRlc3QoKSB7CisJ aWYgKHdpbmRvdy5zZXNzaW9uU3RvcmFnZS5odHRwc19pbl9wYWdlX2NhY2hlX3N0YXJ0ZWQpCisJ CWRlbGV0ZSB3aW5kb3cuc2Vzc2lvblN0b3JhZ2UuaHR0cHNfaW5fcGFnZV9jYWNoZV9zdGFydGVk OworCWxvY2F0aW9uID0gImh0dHBzOi8vMTI3LjAuMC4xOjg0NDMvbmF2aWdhdGlvbi9yZXNvdXJj ZXMvaHR0cHMtaW4tcGFnZS1jYWNoZS0zLmh0bWwiOworfQorCit3aW5kb3cub25wYWdlc2hvdyA9 IGZ1bmN0aW9uKGV2dCkgeworCWlmIChldnQucGVyc2lzdGVkKSB7CisJCWFsZXJ0KCJUaGUgcGFn ZSB3YXMgcmVzdG9yZWQgZnJvbSB0aGUgcGFnZSBjYWNoZS4gSXQgc2hvdWxkIE5PVCBoYXZlIGJl ZW4uIFJ1bm5pbmcgcGFydCAzIG9mIHRoZSB0ZXN0LiIpOworCQluZXh0VGVzdCgpOworCX0KK30K Kword2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgeworCWlmICh3aW5kb3cuc2Vzc2lvblN0b3Jh Z2UuaHR0cHNfaW5fcGFnZV9jYWNoZV9zdGFydGVkKSB7CisJCWFsZXJ0KCJUaGUgcGFnZSB3YXMg cmVsb2FkZWQgb24gYmFjaywgbm90IGZyb20gdGhlIHBhZ2UgY2FjaGUuIEdvb2Qgam9iLiBSdW5u aW5nIHBhcnQgMyBvZiB0aGUgdGVzdC4iKTsKKwkJbmV4dFRlc3QoKTsKKwkJcmV0dXJuOworCX0K KworCWFsZXJ0KCJUaGlzIHBhZ2UgaXMgaHR0cHMgYW5kIGhhcyB0aGUgbm8tY2FjaGUgY2FjaGUt Y29udHJvbCBkaXJlY3RpdmUuIEl0IHNob3VsZCBOT1QgZ28gaW4gdG8gdGhlIHBhZ2UgY2FjaGUu Iik7CisJd2luZG93LnNlc3Npb25TdG9yYWdlLmh0dHBzX2luX3BhZ2VfY2FjaGVfc3RhcnRlZCA9 IHRydWU7CisJc2V0VGltZW91dCgnd2luZG93LmxvY2F0aW9uID0gImdvLWJhY2suaHRtbCInLCAw KTsKKworfQorCis8L3NjcmlwdD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL2h0dHBzLWlu LXBhZ2UtY2FjaGUtMy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jl c291cmNlcy9odHRwcy1pbi1wYWdlLWNhY2hlLTMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi4yMmI1ZmJmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9odHRwcy1pbi1wYWdlLWNhY2hlLTMuaHRtbApA QCAtMCwwICsxLDE4IEBACis8c2NyaXB0PgorCit3aW5kb3cub25wYWdlc2hvdyA9IGZ1bmN0aW9u KGV2dCkgeworCWlmICghZXZ0LnBlcnNpc3RlZCkKKwkJcmV0dXJuOworCisJYWxlcnQoIlRoZSBw YWdlIHdhcyByZXN0b3JlZCBmcm9tIHRoZSBwYWdlIGNhY2hlLiBHb29kIGpvYiEiKTsKKworCWlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisJCWxheW91dFRlc3RDb250cm9sbGVyLm5v dGlmeURvbmUoKTsKK30KKword2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgeworCWFsZXJ0KCJU aGlzIHBhZ2UgaXMgaHR0cHMgYW5kIHNob3VsZCBnbyBpbiB0byB0aGUgcGFnZSBjYWNoZS4iKTsK KwlzZXRUaW1lb3V0KCd3aW5kb3cubG9jYXRpb24gPSAiZ28tYmFjay5odG1sIicsIDApOworfQor Cis8L3NjcmlwdD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTlj ZWUzNC4uMDc0YzhjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTAyLTEzICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNzE5NjQ4Nz4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Njc3NworICAgICAgICBBZGQgaHR0cHMgcGFnZXMgdG8gdGhlIHBhZ2UgY2FjaGUgaW4gc29tZSBj YXNlcworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9odHRwcy1pbi1wYWdlLWNhY2hlLmh0bWwKKworICAg ICAgICAqIGhpc3RvcnkvUGFnZUNhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VDYWNo ZTo6Y2FuQ2FjaGVQYWdlQ29udGFpbmluZ1RoaXNGcmFtZSk6IEFsbG93IEhUVFBTIHBhZ2VzIHRo YXQgZG8gbm90IHNwZWNpZnkgY2FjaGUtY29udHJvbDogbm8tY2FjaGUKKyAgICAgICAgICBvciBj YWNoZS1jb250cm9sOiBuby1zdG9yZSBpbnRvIHRoZSBwYWdlIGNhY2hlLiBUaGlzIHdpbGwgbWF0 Y2ggRmlyZWZveCdzIGJlaGF2aW9yIGZvciBIVFRQUyBpbiB0aGVpciBiZmNhY2hlLgorCisyMDEy LTAyLTEzICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1MjAKICAgICAgICAgQ2xlYW51 cCBQYWdlQ2FjaGU6OmNhbkNhY2hlUGFnZUNvbnRhaW5pbmdUaGlzRnJhbWUgcmVhZGFiaWxpdHkK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCmluZGV4IDg2ZDYyZmMuLmEwZDVkZTQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAKQEAgLTI2MCw3ICsyNjAsNyBAQCBi b29sIFBhZ2VDYWNoZTo6Y2FuQ2FjaGVQYWdlQ29udGFpbmluZ1RoaXNGcmFtZShGcmFtZSogZnJh bWUpCiAgICAgICAgIC8vIERvIG5vdCBjYWNoZSBlcnJvciBwYWdlcyAodGhlc2UgY2FuIGJlIHJl Y29nbml6ZWQgYXMgcGFnZXMgd2l0aCBzdWJzdGl0dXRlIGRhdGEgb3IgdW5yZWFjaGFibGUgVVJM cykuCiAgICAgICAgICYmICEoZG9jdW1lbnRMb2FkZXItPnN1YnN0aXR1dGVEYXRhKCkuaXNWYWxp ZCgpICYmICFkb2N1bWVudExvYWRlci0+c3Vic3RpdHV0ZURhdGEoKS5mYWlsaW5nVVJMKCkuaXNF bXB0eSgpKQogICAgICAgICAmJiAoIWZyYW1lTG9hZGVyLT5zdWJmcmFtZUxvYWRlcigpLT5jb250 YWluc1BsdWdpbnMoKSB8fCBmcmFtZS0+cGFnZSgpLT5zZXR0aW5ncygpLT5wYWdlQ2FjaGVTdXBw b3J0c1BsdWdpbnMoKSkKLSAgICAgICAgJiYgIWRvY3VtZW50LT51cmwoKS5wcm90b2NvbElzKCJo dHRwcyIpCisgICAgICAgICYmICghZG9jdW1lbnQtPnVybCgpLnByb3RvY29sSXMoImh0dHBzIikg fHwgKCFkb2N1bWVudExvYWRlci0+cmVzcG9uc2UoKS5jYWNoZUNvbnRyb2xDb250YWluc05vQ2Fj aGUoKSAmJiAhZG9jdW1lbnRMb2FkZXItPnJlc3BvbnNlKCkuY2FjaGVDb250cm9sQ29udGFpbnNO b1N0b3JlKCkpKQogICAgICAgICAmJiAoIWZyYW1lLT5kb21XaW5kb3coKSB8fCAhZnJhbWUtPmRv bVdpbmRvdygpLT5oYXNFdmVudExpc3RlbmVycyhldmVudE5hbWVzKCkudW5sb2FkRXZlbnQpKQog I2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCiAgICAgICAgICYmICFkb2N1bWVudC0+aGFzT3BlbkRh dGFiYXNlcygpCg==