267679 2024-01-17 23:51:11 -0800 <input type=checkbox switch> paints outside its box and the thumb is slightly misaligned on macOS 2024-03-07 14:41:07 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annevk annevk akeerthi cdumez webkit-bug-importer wenson_hsieh oldest_to_newest 2005782 0 annevk 2024-01-17 23:51:11 -0800 As discovered in https://github.com/WebKit/WebKit/pull/22703#issuecomment-1890437523 <input type=checkbox> (and <input type=checkbox switch>) paint outside their box. Given it's only a couple points per pixel it's presumably shadows. 2005860 1 akeerthi 2024-01-18 08:34:25 -0800 If it's the shadows this is not a bug. If it's the control, then the implication is that these values are wrong: ``` static const int* checkboxMargins(NSControlSize controlSize) { static const int margins[4][4] = { // top right bottom left { 2, 2, 2, 2 }, { 2, 1, 2, 1 }, { 0, 0, 1, 0 }, { 2, 2, 2, 2 }, }; return margins[controlSize]; } ``` 2006112 2 annevk 2024-01-19 04:57:32 -0800 It's only the shadows. Is there a better way to test that? I guess we should rename the test at least to clarify shadows can leak here. 2007484 3 webkit-bug-importer 2024-01-24 23:52:14 -0800 <rdar://problem/121579531> 2019358 4 annevk 2024-03-07 09:23:41 -0800 When I add masking for the thumb this goes away, so I suspect this was a real bug after all. 2019360 5 annevk 2024-03-07 09:31:42 -0800 Pull request: https://github.com/WebKit/WebKit/pull/25582 2019372 6 annevk 2024-03-07 10:30:39 -0800 Hmm, there's still some bleeding on the bots, but noticeably less with that patch. 2019467 7 ews-feeder 2024-03-07 14:41:05 -0800 Committed 275808@main (5381f48e7a04): <https://commits.webkit.org/275808@main> Reviewed commits have been landed. Closing PR #25582 and removing active labels.