267623 2024-01-16 23:45:19 -0800 Quirks.cpp: Fix and extend domain method 2024-01-23 23:46:14 -0800 1 1 1 Unclassified WebKit WebKit Misc. Safari 17 Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=260938 https://bugs.webkit.org/show_bug.cgi?id=267569 InRadar P2 Normal --- 258603 1 karlcow webkit-unassigned annevk webkit-bug-importer oldest_to_newest 2005509 0 karlcow 2024-01-16 23:45:19 -0800 bool Quirks::isDomain(const String& domainString) const { return RegistrableDomain(m_document->topDocument().url()).string() == domainString; } was added with Bug 260938 https://github.com/WebKit/WebKit/pull/17329 but it broke at least one Quirk Bug 267569 Indeed Quirks::isDomain("www.example.com") will return false Quirks::isDomain("example.com") will return true because RegistrableDomain(m_document->topDocument().url()).string() returns only the top domain. So probably we need something along Quirks::isFullDomain("www.example.com") matches only www.example.com Quirks::isTopDomain("example.com") matches only example.com And maybe something along Quirks::isSubDomain("example.com") matching everything *.example.com Real names to be determined. 2005581 1 annevk 2024-01-17 05:43:39 -0800 isDomain should be renamed to isRegistrableDomain or maybe even topLevelDocumentRegistrableDomainIs. However it's not clear you want isRegistrableDomain to begin with here. After all, it can lead to bug 267569 happening. I would expect these to be useful: - topLevelDocumentDomainIs - topLevelDocumentDomainIsSubDomainOf / topLevelDocumentDomainEndsWith 2007126 2 webkit-bug-importer 2024-01-23 23:46:14 -0800 <rdar://problem/121499128>