<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26750</bug_id>
          
          <creation_ts>2009-06-26 01:38:00 -0700</creation_ts>
          <short_desc>Allow custom memory allocation control for JavaScriptCore/runtime directory&apos;s classes</short_desc>
          <delta_ts>2009-08-07 12:52:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>darin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>128437</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-06-26 01:38:00 -0700</bug_when>
    <thetext>Inherits runtime directory&apos;s classes from FastAllocBase (bug #20422), which has been instantiated by &apos;new&apos;:

class IdentifierTable
-&gt; instantiated in runtime/Identifier.cpp: line 70

stuct RegExpObjectData
-&gt; runtime/RegExpObject.cpp: line 62

class HashEntry
-&gt; runtime/Lookup.h: line 47

struct DateInstance::Cache
-&gt; runtime/DateInstance.cpp: line 33

class UString
-&gt; runtime/UString.cpp: line 212

struct RegExpConstructorPrivate
-&gt; runtime/RegExpConstructor.cpp: line 108

class ScopeChain
-&gt; untime/JSFunction.h: line 109</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128439</commentid>
    <comment_count>1</comment_count>
      <attachid>31916</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-06-26 01:40:02 -0700</bug_when>
    <thetext>Created attachment 31916
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128442</commentid>
    <comment_count>2</comment_count>
      <attachid>31917</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-06-26 01:41:09 -0700</bug_when>
    <thetext>Created attachment 31917
updated proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128465</commentid>
    <comment_count>3</comment_count>
      <attachid>31917</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-26 03:20:47 -0700</bug_when>
    <thetext>Comment on attachment 31917
updated proposed patch

Looks fine.  I still think we could just land these all as one big patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128467</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-26 03:27:26 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/DateInstance.cpp
	M	JavaScriptCore/runtime/Identifier.cpp
	M	JavaScriptCore/runtime/Lookup.h
	M	JavaScriptCore/runtime/RegExpConstructor.cpp
	M	JavaScriptCore/runtime/RegExpObject.h
	M	JavaScriptCore/runtime/ScopeChain.h
	M	JavaScriptCore/runtime/UString.h
Committed r45259
http://trac.webkit.org/changeset/45259</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128499</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-26 10:30:17 -0700</bug_when>
    <thetext>Rolling out http://trac.webkit.org/changeset/45259.  Caused:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/2322
http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r45259%20(2322)/results.html

plugins/undefined-property-crash.html
ASSERTION FAILED: s &lt;= HeapConstants&lt;heapType&gt;::cellSize
(/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/JavaScriptCore/runtime/Collector.cpp:278 void* JSC::Heap::heapAllocate(size_t) [with JSC::HeapType heapType = PrimaryHeap])</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128500</commentid>
    <comment_count>6</comment_count>
      <attachid>31917</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-26 10:30:36 -0700</bug_when>
    <thetext>Comment on attachment 31917
updated proposed patch

Caused crash on the bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128503</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-26 10:36:46 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/DateInstance.cpp
	M	JavaScriptCore/runtime/Identifier.cpp
	M	JavaScriptCore/runtime/Lookup.h
	M	JavaScriptCore/runtime/RegExpConstructor.cpp
	M	JavaScriptCore/runtime/RegExpObject.h
	M	JavaScriptCore/runtime/ScopeChain.h
	M	JavaScriptCore/runtime/UString.h
Committed r45269
http://trac.webkit.org/changeset/45269</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128504</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-26 10:37:23 -0700</bug_when>
    <thetext>I need to add a --no-close option to my landing script.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>135134</commentid>
    <comment_count>9</comment_count>
      <attachid>33606</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-28 00:45:36 -0700</bug_when>
    <thetext>Created attachment 33606
updated proposed patch

I need to send one patch for one class, so we will see which causes the assertion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>135256</commentid>
    <comment_count>10</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-07-28 10:13:18 -0700</bug_when>
    <thetext>I&apos;m concerned, because this seems to indicate that adding FastAllocBase as a base class is making some objects bigger!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>135270</commentid>
    <comment_count>11</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-28 10:51:07 -0700</bug_when>
    <thetext>I think I made a mistake in the r-d patch and inherit a class which has been instantiated by JS&apos;s GC also and that caused the problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>135815</commentid>
    <comment_count>12</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-30 05:06:16 -0700</bug_when>
    <thetext>I&apos;ve checked the problem: I&apos;ve inherited DateInstance::Cache form FastAllocBase but DataInstance is a JSObject so this caused the problem. DataInstance::Cache doesn&apos;t need to be inherited.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138043</commentid>
    <comment_count>13</comment_count>
      <attachid>33606</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-07 12:31:45 -0700</bug_when>
    <thetext>Comment on attachment 33606
updated proposed patch

Assuming everything still builds.  Does this need to be public FastAllocBase?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138058</commentid>
    <comment_count>14</comment_count>
      <attachid>33606</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-07 12:52:10 -0700</bug_when>
    <thetext>Comment on attachment 33606
updated proposed patch

Clearing review flag on attachment: 33606

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/RegExpObject.h
Committed r46907
	M	JavaScriptCore/runtime/RegExpObject.h
	M	JavaScriptCore/ChangeLog
r46907 = 44404206ca651e03bd169e7e01bca730b59bcd41 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46907</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138059</commentid>
    <comment_count>15</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-07 12:52:15 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31916</attachid>
            <date>2009-06-26 01:40:02 -0700</date>
            <delta_ts>2009-06-26 01:41:23 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>runtime.patch</filename>
            <type>text/plain</type>
            <size>4463</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1MjQ4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMDktMDYtMjYgIFpvbHRhbiBI
b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgCisKKyAgICAgICAgQWxsb3cgY3VzdG9tIG1lbW9y
eSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUKKwlkaXJlY3Rv
cnkncyBjbGFzc2VzIHdoaWNoIGluc3RhbnRpYXRlZCBieSBuZXc6CisKKyAgICAgICAgY2xhc3Mg
IElkZW50aWZpZXJUYWJsZQorICAgICAgICBzdHJ1Y3QgUmVnRXhwT2JqZWN0RGF0YQorICAgICAg
ICBjbGFzcyAgSGFzaEVudHJ5CisJc3RydWN0IERhdGFJbnN0YW5jZTo6Q2FjaGUgCisgICAgICAg
IGNsYXNzICBVU3RyaW5nCisJc3RydWN0IFJlZ0V4cENvbnN0cnVjdG9yUHJpdmF0ZQorICAgICAg
ICBjbGFzcyAgU2NvcGVDaGFpbgorCisgICAgICAgICogcnVudGltZS9EYXRlSW5zdGFuY2UuY3Bw
OgorICAgICAgICAqIHJ1bnRpbWUvSWRlbnRpZmllci5jcHA6CisgICAgICAgICogcnVudGltZS9M
b29rdXAuaDoKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cENvbnN0cnVjdG9yLmNwcDoKKyAgICAg
ICAgKiBydW50aW1lL1JlZ0V4cE9iamVjdC5oOgorICAgICAgICAqIHJ1bnRpbWUvU2NvcGVDaGFp
bi5oOgorICAgICAgICAqIHJ1bnRpbWUvVVN0cmluZy5oOgorCiAyMDA5LTA2LTI0ICBTYW0gV2Vp
bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFj
bG91Z2guCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVJbnN0YW5jZS5jcHAKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlSW5zdGFuY2UuY3BwCShyZXZp
c2lvbiA0NTI0OCkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZUluc3RhbmNlLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQCB1c2luZyBuYW1lc3BhY2UgV1RGOwogCiBu
YW1lc3BhY2UgSlNDIHsKIAotc3RydWN0IERhdGVJbnN0YW5jZTo6Q2FjaGUgeworc3RydWN0IERh
dGVJbnN0YW5jZTo6Q2FjaGUgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgZG91YmxlIG1f
Z3JlZ29yaWFuRGF0ZVRpbWVDYWNoZWRGb3JNUzsKICAgICBHcmVnb3JpYW5EYXRlVGltZSBtX2Nh
Y2hlZEdyZWdvcmlhbkRhdGVUaW1lOwogICAgIGRvdWJsZSBtX2dyZWdvcmlhbkRhdGVUaW1lVVRD
Q2FjaGVkRm9yTVM7CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5jcHAJKHJl
dmlzaW9uIDQ1MjQ4KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVudGlmaWVyLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIsNyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogdHlwZWRl
ZiBIYXNoTWFwPGNvbnN0IGNoYXIqLCBSZWZQdHI8VVN0cmluZzo6UmVwPiwgUHRySGFzaDxjb25z
dCBjaGFyKj4gPiBMaXRlcmFsSWRlbnRpZmllclRhYmxlOwogCi1jbGFzcyBJZGVudGlmaWVyVGFi
bGUgeworY2xhc3MgSWRlbnRpZmllclRhYmxlIDogcHVibGljIEZhc3RBbGxvY0Jhc2UgewogcHVi
bGljOgogICAgIH5JZGVudGlmaWVyVGFibGUoKQogICAgIHsKSW5kZXg6IEphdmFTY3JpcHRDb3Jl
L3J1bnRpbWUvTG9va3VwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9M
b29rdXAuaAkocmV2aXNpb24gNDUyNDgpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0xvb2t1
cC5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCw3ICs0NCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAg
IHR5cGVkZWYgUHJvcGVydHlTbG90OjpHZXRWYWx1ZUZ1bmMgR2V0RnVuY3Rpb247CiAgICAgdHlw
ZWRlZiB2b2lkICgqUHV0RnVuY3Rpb24pKEV4ZWNTdGF0ZSosIEpTT2JqZWN0KiBiYXNlT2JqZWN0
LCBKU1ZhbHVlIHZhbHVlKTsKIAotICAgIGNsYXNzIEhhc2hFbnRyeSB7CisgICAgY2xhc3MgSGFz
aEVudHJ5IDogcHVibGljIEZhc3RBbGxvY0Jhc2UgewogICAgIHB1YmxpYzoKICAgICAgICAgdm9p
ZCBpbml0aWFsaXplKFVTdHJpbmc6OlJlcCoga2V5LCB1bnNpZ25lZCBjaGFyIGF0dHJpYnV0ZXMs
IGludHB0cl90IHYxLCBpbnRwdHJfdCB2MikKICAgICAgICAgewpJbmRleDogSmF2YVNjcmlwdENv
cmUvcnVudGltZS9SZWdFeHBDb25zdHJ1Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlw
dENvcmUvcnVudGltZS9SZWdFeHBDb25zdHJ1Y3Rvci5jcHAJKHJldmlzaW9uIDQ1MjQ4KQorKysg
SmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBDb25zdHJ1Y3Rvci5jcHAJKHdvcmtpbmcgY29w
eSkKQEAgLTg4LDcgKzg4LDcgQEAgY29uc3QgQ2xhc3NJbmZvIFJlZ0V4cENvbnN0cnVjdG9yOjpp
bmZvIAogQGVuZAogKi8KIAotc3RydWN0IFJlZ0V4cENvbnN0cnVjdG9yUHJpdmF0ZSB7CitzdHJ1
Y3QgUmVnRXhwQ29uc3RydWN0b3JQcml2YXRlIDogcHVibGljIEZhc3RBbGxvY0Jhc2UgewogICAg
IC8vIEdsb2JhbCBzZWFyY2ggY2FjaGUgLyBzZXR0aW5ncwogICAgIFJlZ0V4cENvbnN0cnVjdG9y
UHJpdmF0ZSgpCiAgICAgICAgIDogbGFzdE51bVN1YlBhdHRlcm5zKDApCkluZGV4OiBKYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL1JlZ0V4cE9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRD
b3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmgJKHJldmlzaW9uIDQ1MjQ4KQorKysgSmF2YVNjcmlw
dENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtNTYsNyArNTYs
NyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICB2aXJ0dWFsIENhbGxUeXBlIGdldENhbGxE
YXRhKENhbGxEYXRhJik7CiAKLSAgICAgICAgc3RydWN0IFJlZ0V4cE9iamVjdERhdGEgeworICAg
ICAgICBzdHJ1Y3QgUmVnRXhwT2JqZWN0RGF0YSA6IHB1YmxpYyBGYXN0QWxsb2NCYXNlIHsKICAg
ICAgICAgICAgIFJlZ0V4cE9iamVjdERhdGEoUGFzc1JlZlB0cjxSZWdFeHA+IHJlZ0V4cCwgZG91
YmxlIGxhc3RJbmRleCkKICAgICAgICAgICAgICAgICA6IHJlZ0V4cChyZWdFeHApCiAgICAgICAg
ICAgICAgICAgLCBsYXN0SW5kZXgobGFzdEluZGV4KQpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVu
dGltZS9TY29wZUNoYWluLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9T
Y29wZUNoYWluLmgJKHJldmlzaW9uIDQ1MjQ4KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9T
Y29wZUNoYWluLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1NCw3ICsxNTQsNyBAQCBuYW1lc3BhY2Ug
SlNDIHsKIAogICAgIGNsYXNzIE5vU2NvcGVDaGFpbiB7fTsKIAotICAgIGNsYXNzIFNjb3BlQ2hh
aW4geworICAgIGNsYXNzIFNjb3BlQ2hhaW4gOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAg
ICAgIGZyaWVuZCBjbGFzcyBKSVQ7CiAgICAgcHVibGljOgogICAgICAgICBTY29wZUNoYWluKE5v
U2NvcGVDaGFpbikKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5oCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5oCShyZXZpc2lvbiA0NTI0
OCkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBA
IC03Myw3ICs3Myw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgdHlwZWRlZiBWZWN0b3I8Y2hh
ciwgMzI+IENTdHJpbmdCdWZmZXI7CiAKLSAgICBjbGFzcyBVU3RyaW5nIHsKKyAgICBjbGFzcyBV
U3RyaW5nIDogcHVibGljIEZhc3RBbGxvY0Jhc2UgewogICAgICAgICBmcmllbmQgY2xhc3MgSklU
OwogCiAgICAgcHVibGljOgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31917</attachid>
            <date>2009-06-26 01:41:09 -0700</date>
            <delta_ts>2009-06-26 10:30:36 -0700</delta_ts>
            <desc>updated proposed patch</desc>
            <filename>runtime.patch</filename>
            <type>text/plain</type>
            <size>4537</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1MjQ4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMDktMDYtMjYgIFpvbHRhbiBI
b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTI2NzUwICAgICAgICAKKworICAgICAgICBBbGxvdyBjdXN0b20gbWVtb3J5IGFs
bG9jYXRpb24gY29udHJvbCBmb3IgSmF2YVNjcmlwdENvcmUvcnVudGltZQorICAgICAgICBkaXJl
Y3RvcnkncyBjbGFzc2VzIHdoaWNoIGluc3RhbnRpYXRlZCBieSBuZXc6CisKKyAgICAgICAgY2xh
c3MgIElkZW50aWZpZXJUYWJsZQorICAgICAgICBzdHJ1Y3QgUmVnRXhwT2JqZWN0RGF0YQorICAg
ICAgICBjbGFzcyAgSGFzaEVudHJ5CisgICAgICAgIHN0cnVjdCBEYXRhSW5zdGFuY2U6OkNhY2hl
IAorICAgICAgICBjbGFzcyAgVVN0cmluZworICAgICAgICBzdHJ1Y3QgUmVnRXhwQ29uc3RydWN0
b3JQcml2YXRlCisgICAgICAgIGNsYXNzICBTY29wZUNoYWluCisKKyAgICAgICAgKiBydW50aW1l
L0RhdGVJbnN0YW5jZS5jcHA6CisgICAgICAgICogcnVudGltZS9JZGVudGlmaWVyLmNwcDoKKyAg
ICAgICAgKiBydW50aW1lL0xvb2t1cC5oOgorICAgICAgICAqIHJ1bnRpbWUvUmVnRXhwQ29uc3Ry
dWN0b3IuY3BwOgorICAgICAgICAqIHJ1bnRpbWUvUmVnRXhwT2JqZWN0Lmg6CisgICAgICAgICog
cnVudGltZS9TY29wZUNoYWluLmg6CisgICAgICAgICogcnVudGltZS9VU3RyaW5nLmg6CisKIDIw
MDktMDYtMjQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl
ZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0
ZUluc3RhbmNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVJ
bnN0YW5jZS5jcHAJKHJldmlzaW9uIDQ1MjQ4KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9E
YXRlSW5zdGFuY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBAIHVzaW5nIG5h
bWVzcGFjZSBXVEY7CiAKIG5hbWVzcGFjZSBKU0MgewogCi1zdHJ1Y3QgRGF0ZUluc3RhbmNlOjpD
YWNoZSB7CitzdHJ1Y3QgRGF0ZUluc3RhbmNlOjpDYWNoZSA6IHB1YmxpYyBGYXN0QWxsb2NCYXNl
IHsKICAgICBkb3VibGUgbV9ncmVnb3JpYW5EYXRlVGltZUNhY2hlZEZvck1TOwogICAgIEdyZWdv
cmlhbkRhdGVUaW1lIG1fY2FjaGVkR3JlZ29yaWFuRGF0ZVRpbWU7CiAgICAgZG91YmxlIG1fZ3Jl
Z29yaWFuRGF0ZVRpbWVVVENDYWNoZWRGb3JNUzsKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRp
bWUvSWRlbnRpZmllci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9J
ZGVudGlmaWVyLmNwcAkocmV2aXNpb24gNDUyNDgpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1l
L0lkZW50aWZpZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBAIG5hbWVzcGFj
ZSBKU0MgewogCiB0eXBlZGVmIEhhc2hNYXA8Y29uc3QgY2hhciosIFJlZlB0cjxVU3RyaW5nOjpS
ZXA+LCBQdHJIYXNoPGNvbnN0IGNoYXIqPiA+IExpdGVyYWxJZGVudGlmaWVyVGFibGU7CiAKLWNs
YXNzIElkZW50aWZpZXJUYWJsZSB7CitjbGFzcyBJZGVudGlmaWVyVGFibGUgOiBwdWJsaWMgRmFz
dEFsbG9jQmFzZSB7CiBwdWJsaWM6CiAgICAgfklkZW50aWZpZXJUYWJsZSgpCiAgICAgewpJbmRl
eDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Mb29rdXAuaAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL0xvb2t1cC5oCShyZXZpc2lvbiA0NTI0OCkKKysrIEphdmFTY3JpcHRD
b3JlL3J1bnRpbWUvTG9va3VwLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDcgKzQ0LDcgQEAgbmFt
ZXNwYWNlIEpTQyB7CiAgICAgdHlwZWRlZiBQcm9wZXJ0eVNsb3Q6OkdldFZhbHVlRnVuYyBHZXRG
dW5jdGlvbjsKICAgICB0eXBlZGVmIHZvaWQgKCpQdXRGdW5jdGlvbikoRXhlY1N0YXRlKiwgSlNP
YmplY3QqIGJhc2VPYmplY3QsIEpTVmFsdWUgdmFsdWUpOwogCi0gICAgY2xhc3MgSGFzaEVudHJ5
IHsKKyAgICBjbGFzcyBIYXNoRW50cnkgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgcHVi
bGljOgogICAgICAgICB2b2lkIGluaXRpYWxpemUoVVN0cmluZzo6UmVwKiBrZXksIHVuc2lnbmVk
IGNoYXIgYXR0cmlidXRlcywgaW50cHRyX3QgdjEsIGludHB0cl90IHYyKQogICAgICAgICB7Cklu
ZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENvbnN0cnVjdG9yLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENvbnN0cnVjdG9yLmNwcAkocmV2
aXNpb24gNDUyNDgpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENvbnN0cnVjdG9y
LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODgsNyArODgsNyBAQCBjb25zdCBDbGFzc0luZm8gUmVn
RXhwQ29uc3RydWN0b3I6OmluZm8gCiBAZW5kCiAqLwogCi1zdHJ1Y3QgUmVnRXhwQ29uc3RydWN0
b3JQcml2YXRlIHsKK3N0cnVjdCBSZWdFeHBDb25zdHJ1Y3RvclByaXZhdGUgOiBwdWJsaWMgRmFz
dEFsbG9jQmFzZSB7CiAgICAgLy8gR2xvYmFsIHNlYXJjaCBjYWNoZSAvIHNldHRpbmdzCiAgICAg
UmVnRXhwQ29uc3RydWN0b3JQcml2YXRlKCkKICAgICAgICAgOiBsYXN0TnVtU3ViUGF0dGVybnMo
MCkKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuaAkocmV2aXNpb24gNDUy
NDgpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cE9iamVjdC5oCSh3b3JraW5nIGNv
cHkpCkBAIC01Niw3ICs1Niw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIHZpcnR1YWwg
Q2FsbFR5cGUgZ2V0Q2FsbERhdGEoQ2FsbERhdGEmKTsKIAotICAgICAgICBzdHJ1Y3QgUmVnRXhw
T2JqZWN0RGF0YSB7CisgICAgICAgIHN0cnVjdCBSZWdFeHBPYmplY3REYXRhIDogcHVibGljIEZh
c3RBbGxvY0Jhc2UgewogICAgICAgICAgICAgUmVnRXhwT2JqZWN0RGF0YShQYXNzUmVmUHRyPFJl
Z0V4cD4gcmVnRXhwLCBkb3VibGUgbGFzdEluZGV4KQogICAgICAgICAgICAgICAgIDogcmVnRXhw
KHJlZ0V4cCkKICAgICAgICAgICAgICAgICAsIGxhc3RJbmRleChsYXN0SW5kZXgpCkluZGV4OiBK
YXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlQ2hhaW4uaAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL1Njb3BlQ2hhaW4uaAkocmV2aXNpb24gNDUyNDgpCisrKyBKYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL1Njb3BlQ2hhaW4uaAkod29ya2luZyBjb3B5KQpAQCAtMTU0LDcgKzE1
NCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgY2xhc3MgTm9TY29wZUNoYWluIHt9OwogCi0g
ICAgY2xhc3MgU2NvcGVDaGFpbiB7CisgICAgY2xhc3MgU2NvcGVDaGFpbiA6IHB1YmxpYyBGYXN0
QWxsb2NCYXNlIHsKICAgICAgICAgZnJpZW5kIGNsYXNzIEpJVDsKICAgICBwdWJsaWM6CiAgICAg
ICAgIFNjb3BlQ2hhaW4oTm9TY29wZUNoYWluKQpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGlt
ZS9VU3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9VU3RyaW5n
LmgJKHJldmlzaW9uIDQ1MjQ4KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9VU3RyaW5nLmgJ
KHdvcmtpbmcgY29weSkKQEAgLTczLDcgKzczLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICB0
eXBlZGVmIFZlY3RvcjxjaGFyLCAzMj4gQ1N0cmluZ0J1ZmZlcjsKIAotICAgIGNsYXNzIFVTdHJp
bmcgeworICAgIGNsYXNzIFVTdHJpbmcgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgICAg
IGZyaWVuZCBjbGFzcyBKSVQ7CiAKICAgICBwdWJsaWM6Cg==
</data>
<flag name="review"
          id="16465"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33606</attachid>
            <date>2009-07-28 00:45:36 -0700</date>
            <delta_ts>2009-08-07 12:52:10 -0700</delta_ts>
            <desc>updated proposed patch</desc>
            <filename>RegExpObjectData.patch</filename>
            <type>text/plain</type>
            <size>1279</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NDYwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMjggIFpvbHRhbiBI
b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9u
IGNvbnRyb2wgZm9yIFJlZ0V4cE9iamVjdERhdGEgc3RydWN0CisgICAgICAgIGh0dHA6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2NzUwCisKKyAgICAgICAgSW5oZXJpdHMgUmVn
RXhwT2JqZWN0RGF0YSBzdHJ1Y3QgZnJvbSBGYXN0QWxsb2NCYXNlIGJlY2F1c2UKKyAgICAgICAg
aXQgaGFzIGJlZW4gaW5zdGFudGlhdGVkIGJ5ICduZXcnIGluIEphdmFTY3JpcHRDb3JlL3J1bnRp
bWUvUmVnRXhwT2JqZWN0LmNwcDo2MgorCisgICAgICAgICogcnVudGltZS9SZWdFeHBPYmplY3Qu
aDoKKwogMjAwOS0wNy0yNyAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+
CiAKICAgICAgICAgRml4IG9mIG1pc3VzZSBvZiBzb3J0IGNvbW1hbmQuCkluZGV4OiBKYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL1JlZ0V4cE9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRD
b3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmgJKHJldmlzaW9uIDQ2NDU5KQorKysgSmF2YVNjcmlw
dENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtNTYsNyArNTYs
NyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICB2aXJ0dWFsIENhbGxUeXBlIGdldENhbGxE
YXRhKENhbGxEYXRhJik7CiAKLSAgICAgICAgc3RydWN0IFJlZ0V4cE9iamVjdERhdGEgeworICAg
ICAgICBzdHJ1Y3QgUmVnRXhwT2JqZWN0RGF0YSA6IEZhc3RBbGxvY0Jhc2UgewogICAgICAgICAg
ICAgUmVnRXhwT2JqZWN0RGF0YShQYXNzUmVmUHRyPFJlZ0V4cD4gcmVnRXhwLCBkb3VibGUgbGFz
dEluZGV4KQogICAgICAgICAgICAgICAgIDogcmVnRXhwKHJlZ0V4cCkKICAgICAgICAgICAgICAg
ICAsIGxhc3RJbmRleChsYXN0SW5kZXgpCg==
</data>
<flag name="commit-queue"
          id="18482"
          type_id="3"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>