26745 2009-06-25 17:53:23 -0700 bugzilla-tool land-patches failed when landing multiple patches 2009-06-26 01:32:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned levin oldest_to_newest 128348 0 eric 2009-06-25 17:53:23 -0700 Committed r45224 http://trac.webkit.org/changeset/45224 Traceback (most recent call last): File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 532, in <module> main() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 529, in main return tool.main() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 524, in main return command_object.execute(command_options, command_args, self) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 313, in execute self.land_patches(bug_id, bugs_to_patches[bug_id], options, tool) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 285, in land_patches tool.bugs.obsolete_attachment(patch['id'], comment_text) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/bugzilla.py", line 253, in obsolete_attachment self.browser['comment'] = comment_text File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 2895, in __setitem__ File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3222, in find_control File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3304, in _find_control ClientForm.AmbiguityError: more than one control matching name 'comment' I'm not sure what caused this yet. 128349 1 eric 2009-06-25 17:53:39 -0700 I was trying to land all the patches on https://bugs.webkit.org/show_bug.cgi?id=26336 128350 2 eric 2009-06-25 17:54:51 -0700 It also failed to mark the patch as obsolete, even though it said it was: all 10758 test cases succeeded Parsing ChangeLog: LayoutTests/ChangeLog Logging in as eric@webkit.org... Obsoleting attachment: 31458 Committing to http://svn.webkit.org/repository/webkit/trunk ... I suspect that might have been the problem. I might have broken attachment links somehow. I also currently have the patch for: https://bugs.webkit.org/show_bug.cgi?id=26740 in my tree, so it's possible this is a local-only break. 128361 3 31899 eric 2009-06-25 18:34:41 -0700 Created attachment 31899 patch 128363 4 31899 jmalonzo 2009-06-25 18:50:24 -0700 Comment on attachment 31899 patch > - self.browser['comment'] = comment_text > + # Bugzilla has two textareas named 'comment', one is somehow hidden. We want the first. > + self.browser.set_value(comment_text, name='comment', nr=0) It's fine. r=me. 128435 5 eric 2009-06-26 01:32:20 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed r45250 http://trac.webkit.org/changeset/45250 31899 2009-06-25 18:34:41 -0700 2009-06-25 18:50:24 -0700 patch bugzilla_requires_a_filename.patch text/plain 1233 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwMzkyNWQxLi5kZmM4OWJmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTQgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBGaXggb2Jzb2xldGVfYXR0 YWNobWVudCB0byB3b3JrIHdoZW4gcGFzc2VkIGEgY29tbWVudC4KKworICAgICAgICAqIFNjcmlw dHMvbW9kdWxlcy9idWd6aWxsYS5weToKKworMjAwOS0wNi0yNSAgRXJpYyBTZWlkZWwgIDxlcmlj QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAg ICAgICAgYnVnemlsbGEtdG9vbCBwb3N0LWRpZmYgbmVlZHMgdG8gb2Jzb2xldGUgb2xkIHBhdGNo ZXMgYmVmb3JlIHBvc3RpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI2NzQwCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy9idWd6aWxsYS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQpp bmRleCBiODA2ZDEzLi4wZWViMDFjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvYnVnemlsbGEucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3pp bGxhLnB5CkBAIC0yNTAsNyArMjUwLDggQEAgY2xhc3MgQnVnemlsbGE6CiAgICAgICAgIHNlbGYu YnJvd3Nlci5maW5kX2NvbnRyb2wodHlwZT0nc2VsZWN0JywgbnI9MCkudmFsdWUgPSAoIlgiLCkK ICAgICAgICAgaWYgY29tbWVudF90ZXh0OgogICAgICAgICAgICAgbG9nKGNvbW1lbnRfdGV4dCkK LSAgICAgICAgICAgIHNlbGYuYnJvd3NlclsnY29tbWVudCddID0gY29tbWVudF90ZXh0CisgICAg ICAgICAgICAjIEJ1Z3ppbGxhIGhhcyB0d28gdGV4dGFyZWFzIG5hbWVkICdjb21tZW50Jywgb25l IGlzIHNvbWVob3cgaGlkZGVuLiAgV2Ugd2FudCB0aGUgZmlyc3QuCisgICAgICAgICAgICBzZWxm LmJyb3dzZXIuc2V0X3ZhbHVlKGNvbW1lbnRfdGV4dCwgbmFtZT0nY29tbWVudCcsIG5yPTApCiAg ICAgICAgIHNlbGYuYnJvd3Nlci5zdWJtaXQoKQogICAgIAogICAgIGRlZiBwb3N0X2NvbW1lbnRf dG9fYnVnKHNlbGYsIGJ1Z19pZCwgY29tbWVudF90ZXh0KToK