26743 2009-06-25 17:16:29 -0700 [CHROMIUM] Multiple ASSERT_NOT_REACHED reached in Chromium font code 2009-06-28 04:13:30 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 nsylvain webkit-unassigned dglazkov oldest_to_newest 128334 0 nsylvain 2009-06-25 17:16:29 -0700 This is a follow up for bug 26484 The problem fixed in bug 26484 appears at multiple other places in the codebase. Short description: Chromium may not be able to load fonts when the browser process is going down because of the sandbox restrictions (and the lack of help from the browser process). We have some asserts in this case. But since it happens often during shutdown, we want to replace these asserts for LOG messages. I will submit a patch for review. 128520 1 31939 nsylvain 2009-06-26 11:12:07 -0700 Created attachment 31939 remove font asserts 128524 2 31939 dglazkov 2009-06-26 11:19:26 -0700 Comment on attachment 31939 remove font asserts r=me. 128732 3 eric 2009-06-28 04:13:30 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/chromium/FontChromiumWin.cpp M WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp M WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp M WebCore/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp Committed r45325 http://trac.webkit.org/changeset/45325 31939 2009-06-26 11:12:07 -0700 2009-06-26 11:19:26 -0700 remove font asserts remove_asserts.patch text/plain 5251 nsylvain SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTI3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzAgQEAKKzIwMDktMDYtMjYgIE5pY29sYXMgU3lsdmFpbiAgPG5zeWx2YWluQGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJZiBsb2FkaW5nIGEgZm9udCBmYWlscyBiZWNhdXNlIG9mIHRoZSBzYW5kYm94LCB3ZSBh c2sgdGhlIGJyb3dzZXIgcHJvY2VzcyB0byAKKyAgICAgICAgdHJ5IHRvIGxvYWQgaXQgYnkgY2Fs bGluZyBlbnN1cmVGb250TG9hZGVkLiBJZiBpdCBzdGlsbCBmYWlscyBhZnRlciAKKyAgICAgICAg ZW5zdXJlRm9udExvYWRlZCwgd2UgaGl0IGEgQVNTRVJUX05PVF9SRUFDSEVELiAKKworICAgICAg ICBUaGlzIGNhc2UgaGFwcGVucyBvbmNlIGluIGEgd2hpbGUgZHVyaW5nIGJyb3dzZXIgc2h1dGRv d24uIFRoZSBicm93c2VyIHdpbGwgCisgICAgICAgIHF1ZXVlIGEgbWVzc2FnZSB0byB0aGUgcmVu ZGVyZXIgdG8gc2h1dGRvd24sIGFuZCB3aWxsIHRoZW4gc3RvcCBhbnN3ZXJpbmcgc3luYyAKKyAg ICAgICAgbWVzc2FnZXMgZnJvbSB0aGUgcmVuZGVyZXIuIElmIHRoZSByZW5kZXJlciBpcyBzdGls bCBsb2FkaW5nIGEgcGFnZSBkdXJpbmcgdGhpcyAKKyAgICAgICAgdGltZSwgaXQgbWlnaHQgdHJ5 IHRvIGNhbGwgdGhlIGJyb3dzZXIgcHJvY2VzcyB0byBhc2sgdG8gbG9hZCBhIGZvbnQuIFRoZSAK KyAgICAgICAgYnJvd3NlciBwcm9jZXNzIHdpbGwgaWdub3JlIHRoZSByZXF1ZXN0LCBhbmQgdGhl IGZvbnQgd2lsbCBmYWlsIHRvIGxvYWQsIGV2ZW4gCisgICAgICAgIGFmdGVyIHRoZSBzZWNvbmQg dHJ5LiAKKworICAgICAgICBUaGlzIGlzIHVuZm9ydHVuYXRlLCBidXQgdGhlcmUgaXMgbm8gcmVh bCByaXNrIGhlcmUsIHNpbmNlIHRoZSByZW5kZXJlciB3aWxsIGJlIAorICAgICAgICBnb2luZyBh d2F5IGFzIHNvb24gYXMgaXQgcHJvY2Vzc2VzIGFub3RoZXIgbWVzc2FnZS4gCisKKyAgICAgICAg VGhpcyBjYW4ndCBiZSBsYXlvdXQgdGVzdGVkIGFzIGl0IGRlcGVuZHMgb24gdGhlIHNhbmRib3gu IAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjc0 MyAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdp bi5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udFBsYXRmb3Jt RGF0YUNocm9taXVtV2luLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9HbHlwaFBhZ2VUcmVlTm9kZUNocm9taXVtV2luLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9TaW1wbGVGb250RGF0YUNocm9taXVtV2luLmNwcDoKKwogMjAwOS0w Ni0yNiAgS2V2aW4gTWNDdWxsb3VnaCAgPGttY2N1bGxvdWdoQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJvbWl1bVdpbi5jcHAJKHJldmlzaW9uIDQ1 MjY5KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1X aW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTQsNyArMzk0LDkgQEAgdm9pZCBGb250OjpkcmF3 R2x5cGhzKEdyYXBoaWNzQ29udGV4dCogZwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K IAotICAgICAgICBBU1NFUlQoc3VjY2Vzcyk7CisgICAgICAgIGlmICghc3VjY2VzcykKKyAgICAg ICAgICAgIExPR19FUlJPUigiVW5hYmxlIHRvIGRyYXcgdGhlIGdseXBocyBhZnRlciBzZWNvbmQg YXR0ZW1wdCIpOworCiAgICAgICAgIGN1ckFkdmFuY2UgKz0gY3VyV2lkdGg7CiAgICAgfQogfQpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1EYXRh Q2hyb21pdW1XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vRm9udFBsYXRmb3JtRGF0YUNocm9taXVtV2luLmNwcAkocmV2aXNpb24gNDUyNjkp CisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFD aHJvbWl1bVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MSw3ICsxNDEsNyBAQCBTQ1JJUFRf Rk9OVFBST1BFUlRJRVMqIEZvbnRQbGF0Zm9ybURhdGE6CiAgICAgICAgICAgICAgICAgICAgIGhy ID0gU2NyaXB0R2V0Rm9udFByb3BlcnRpZXMoZGMsIHNjcmlwdENhY2hlKCksCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9zY3JpcHRGb250UHJvcGVy dGllcyk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChTX09LICE9IGhyKSB7Ci0gICAgICAgICAg ICAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAgICAgICAg ICAgIExPR19FUlJPUigiVW5hYmxlIHRvIGdldCB0aGUgZm9udCBwcm9wZXJ0aWVzIGFmdGVyIHNl Y29uZCBhdHRlbXB0Iik7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICB9CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0dseXBoUGFnZVRyZWVOb2RlQ2hyb21pdW1XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR2x5cGhQYWdlVHJlZU5vZGVDaHJvbWl1bVdpbi5j cHAJKHJldmlzaW9uIDQ1MjY5KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9HbHlwaFBhZ2VUcmVlTm9kZUNocm9taXVtV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODcs MTAgKzg3LDkgQEAgc3RhdGljIGJvb2wgZmlsbEJNUEdseXBocyh1bnNpZ25lZCBvZmZzZQogICAg ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNl IHsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBuZXZlciBoYXBwZW4uIFdlIHdh bnQgdG8gY3Jhc2ggdGhlCi0gICAgICAgICAgICAvLyBwcm9jZXNzIGFuZCByZWNlaXZlIGEgY3Jh c2ggZHVtcC4gV2Ugc2hvdWxkIHJldmlzaXQgdGhpcyBjb2RlIGxhdGVyLgorICAgICAgICAgICAg Ly8gRklYTUU6IEhhbmRsZSBncmFjZWZ1bGx5IHRoZSBlcnJvciBpZiB0aGlzIGNhbGwgYWxzbyBm YWlscy4KICAgICAgICAgICAgIC8vIFNlZSBodHRwOi8vY3JidWcuY29tLzY0MDEKLSAgICAgICAg ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgTE9HX0VSUk9SKCJVbmFibGUg dG8gZ2V0IHRoZSB0ZXh0IG1ldHJpY3MgYWZ0ZXIgc2Vjb25kIGF0dGVtcHQiKTsKICAgICAgICAg ICAgIGZpbGxFbXB0eUdseXBocyhwYWdlKTsKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAg ICAgICAgfQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaW1wbGVG b250RGF0YUNocm9taXVtV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1NpbXBsZUZvbnREYXRhQ2hyb21pdW1XaW4uY3BwCShyZXZpc2lvbiA0 NTI2OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2ltcGxlRm9udERh dGFDaHJvbWl1bVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcgKzYzLDcgQEAgdm9pZCBT aW1wbGVGb250RGF0YTo6cGxhdGZvcm1Jbml0KCkKICAgICAgICAgICAgIC8vIEZJWE1FOiBIYW5k bGUgZ3JhY2VmdWxseSB0aGUgZXJyb3IgaWYgdGhpcyBjYWxsIGFsc28gZmFpbHMuCiAgICAgICAg ICAgICAvLyBTZWUgaHR0cDovL2NyYnVnLmNvbS82NDAxLgogICAgICAgICAgICAgaWYgKCFHZXRU ZXh0TWV0cmljcyhkYywgJnRleHRNZXRyaWMpKQotICAgICAgICAgICAgICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOworICAgICAgICAgICAgICAgIExPR19FUlJPUigiVW5hYmxlIHRvIGdldCB0aGUg dGV4dCBtZXRyaWNzIGFmdGVyIHNlY29uZCBhdHRlbXB0Iik7CiAgICAgICAgIH0KICAgICB9CiAK QEAgLTE0MSw3ICsxNDEsNyBAQCB2b2lkIFNpbXBsZUZvbnREYXRhOjpkZXRlcm1pbmVQaXRjaCgp CiAgICAgICAgICAgICAvLyBGSVhNRTogSGFuZGxlIGdyYWNlZnVsbHkgdGhlIGVycm9yIGlmIHRo aXMgY2FsbCBhbHNvIGZhaWxzLgogICAgICAgICAgICAgLy8gU2VlIGh0dHA6Ly9jcmJ1Zy5jb20v NjQwMS4KICAgICAgICAgICAgIGlmICghR2V0VGV4dE1ldHJpY3MoZGMsICZ0ZXh0TWV0cmljKSkK LSAgICAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAgICBM T0dfRVJST1IoIlVuYWJsZSB0byBnZXQgdGhlIHRleHQgbWV0cmljcyBhZnRlciBzZWNvbmQgYXR0 ZW1wdCIpOwogICAgICAgICB9CiAgICAgfQogCkBAIC0xNjMsNyArMTYzLDcgQEAgZmxvYXQgU2lt cGxlRm9udERhdGE6OnBsYXRmb3JtV2lkdGhGb3JHbAogICAgICAgICAgICAgLy8gRklYTUU6IEhh bmRsZSBncmFjZWZ1bGx5IHRoZSBlcnJvciBpZiB0aGlzIGNhbGwgYWxzbyBmYWlscy4KICAgICAg ICAgICAgIC8vIFNlZSBodHRwOi8vY3JidWcuY29tLzY0MDEuCiAgICAgICAgICAgICBpZiAoIUdl dENoYXJXaWR0aEkoZGMsIGdseXBoLCAxLCAwLCAmd2lkdGgpKQotICAgICAgICAgICAgICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgICAgIExPR19FUlJPUigiVW5hYmxlIHRv IGdldCB0aGUgY2hhciB3aWR0aCBhZnRlciBzZWNvbmQgYXR0ZW1wdCIpOwogICAgICAgICB9CiAg ICAgfQogCg==