<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>267417</bug_id>
          
          <creation_ts>2024-01-11 09:51:48 -0800</creation_ts>
          <short_desc>[MSE][GStreamer] Dimension SourceBuffer size limit for all possible track types before init segment received</short_desc>
          <delta_ts>2024-01-15 06:20:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Enrique Ocaña">eocanha</reporter>
          <assigned_to name="Enrique Ocaña">eocanha</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2004475</commentid>
    <comment_count>0</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2024-01-11 09:51:48 -0800</bug_when>
    <thetext>SourceBuffer has separate max size limits for video, audio and text, but it has to parse the init segment first to know if there are any video, audio or text tracks. At the very first appendBuffer() there are not tracks parsed yet, so platformMaximumBufferSize() returns 0 (as no tracks are there), and the limit is taken from MediaElementSession as audio limit 15MB as no video track is present.

A potential buffer overflow at the very first appendBuffer() before tracks are parsed from init segment should be ignored.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1261</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2004511</commentid>
    <comment_count>1</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2024-01-11 11:21:16 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/22671</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2005068</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-01-15 06:19:27 -0800</bug_when>
    <thetext>Committed 273039@main (71e98e404115): &lt;https://commits.webkit.org/273039@main&gt;

Reviewed commits have been landed. Closing PR #22671 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2005069</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-01-15 06:20:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/121004491&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>