26733 2009-06-25 14:41:27 -0700 Add V8 methods to notify clients about context creation/destruction 2009-06-25 16:21:50 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 mpComplete webkit-unassigned oldest_to_newest 128278 0 mpComplete 2009-06-25 14:41:27 -0700 Add V8-only methods to FrameLoaderClient that V8 can use to send out notifications when it creates/destroys a script context. 128279 1 31877 mpComplete 2009-06-25 14:44:09 -0700 Created attachment 31877 adds 2 methods to FrameLoaderClient.h 128300 2 31877 fishd 2009-06-25 15:58:21 -0700 Comment on attachment 31877 adds 2 methods to FrameLoaderClient.h > Index: WebCore/ChangeLog ... > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=26733 > + > + Add V8-only methods to FrameLoaderClient that V8 can use to send > + out notifications when it creates/destroys a script context. Replace tabs with spaces > Index: WebCore/loader/FrameLoaderClient.h ... > +#if USE(V8) > + virtual void didCreateScriptContext() const { } > + virtual void didDestroyScriptContext() const { } I think these should be pure virtual like the other FrameLoaderClient methods. Otherwise, LG 128304 3 31884 mpComplete 2009-06-25 16:12:03 -0700 Created attachment 31884 made pure virtual 128308 4 fishd 2009-06-25 16:21:50 -0700 Landed as http://trac.webkit.org/changeset/45208 31877 2009-06-25 14:44:09 -0700 2009-06-25 15:58:21 -0700 adds 2 methods to FrameLoaderClient.h context.patch text/plain 1492 mpComplete SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTE5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDYtMjUgIE1hdHQgUGVycnkgIDxtcGNvbXBsZXRlQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCWh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjczMworCisJQWRkIFY4LW9ubHkg bWV0aG9kcyB0byBGcmFtZUxvYWRlckNsaWVudCB0aGF0IFY4IGNhbiB1c2UgdG8gc2VuZAorCW91 dCBub3RpZmljYXRpb25zIHdoZW4gaXQgY3JlYXRlcy9kZXN0cm95cyBhIHNjcmlwdCBjb250ZXh0 LgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50Lmg6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZUxvYWRlckNsaWVudDo6ZGlkQ3JlYXRlU2NyaXB0Q29udGV4dCk6CisgICAgICAg IChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudDo6ZGlkRGVzdHJveVNjcmlwdENvbnRleHQpOgor CiAyMDA5LTA2LTI1ICBBZGFtIExhbmdsZXkgIDxhZ2xAZ29vZ2xlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ckNsaWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50 LmgJKHJldmlzaW9uIDQ1MTc3KQorKysgV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQu aAkod29ya2luZyBjb3B5KQpAQCAtMjExLDcgKzIxMSwxMiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgICAgIHZpcnR1YWwgdm9pZCB3aW5kb3dPYmplY3RDbGVhcmVkKCkgPSAwOwogICAgICAg ICB2aXJ0dWFsIHZvaWQgZG9jdW1lbnRFbGVtZW50QXZhaWxhYmxlKCkgPSAwOwogICAgICAgICB2 aXJ0dWFsIHZvaWQgZGlkUGVyZm9ybUZpcnN0TmF2aWdhdGlvbigpIGNvbnN0ID0gMDsgLy8gIk5h dmlnYXRpb24iIGhlcmUgbWVhbnMgYSB0cmFuc2l0aW9uIGZyb20gb25lIHBhZ2UgdG8gYW5vdGhl ciB0aGF0IGVuZHMgdXAgaW4gdGhlIGJhY2svZm9yd2FyZCBsaXN0LgotICAgICAgICAKKworI2lm IFVTRShWOCkKKyAgICAgICAgdmlydHVhbCB2b2lkIGRpZENyZWF0ZVNjcmlwdENvbnRleHQoKSBj b25zdCB7IH0KKyAgICAgICAgdmlydHVhbCB2b2lkIGRpZERlc3Ryb3lTY3JpcHRDb250ZXh0KCkg Y29uc3QgeyB9CisjZW5kaWYKKwogICAgICAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJGb3JJY29u Tm90aWZpY2F0aW9uKGJvb2wgbGlzdGVuID0gdHJ1ZSkgPSAwOwogICAgICAgICAKICNpZiBQTEFU Rk9STShNQUMpCg== 31884 2009-06-25 16:12:03 -0700 2009-06-25 16:17:40 -0700 made pure virtual context2.patch text/plain 2259 mpComplete SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTIwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDYtMjUgIE1hdHQgUGVycnkgIDxtcGNvbXBsZXRlQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY3MzMKKworICAgICAg ICBBZGQgVjgtb25seSBtZXRob2RzIHRvIEZyYW1lTG9hZGVyQ2xpZW50IHRoYXQgVjggY2FuIHVz ZSB0byBzZW5kCisgICAgICAgIG91dCBub3RpZmljYXRpb25zIHdoZW4gaXQgY3JlYXRlcy9kZXN0 cm95cyBhIHNjcmlwdCBjb250ZXh0LgorCisgICAgICAgICogbG9hZGVyL0VtcHR5Q2xpZW50cy5o OgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlGcmFtZUxvYWRlckNsaWVudDo6ZGlkQ3JlYXRlU2Ny aXB0Q29udGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpFbXB0eUZyYW1lTG9hZGVyQ2xpZW50Ojpk aWREZXN0cm95U2NyaXB0Q29udGV4dCk6CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyQ2xp ZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudDo6ZGlkQ3JlYXRlU2Ny aXB0Q29udGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudDo6ZGlkRGVz dHJveVNjcmlwdENvbnRleHQpOgorCiAyMDA5LTA2LTI1ICBBZGFtIExhbmdsZXkgIDxhZ2xAZ29v Z2xlLmNvbT4KIAogICAgICAgICBUQlJlZDogZml4IGZvciBDaHJvbWl1bSB0cmVlLgpJbmRleDog V2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2Fk ZXIvRW1wdHlDbGllbnRzLmgJKHJldmlzaW9uIDQ1MTc3KQorKysgV2ViQ29yZS9sb2FkZXIvRW1w dHlDbGllbnRzLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4Myw2ICsyODMsMTEgQEAgcHVibGljOgog CiAgICAgdmlydHVhbCB2b2lkIHJlZ2lzdGVyRm9ySWNvbk5vdGlmaWNhdGlvbihib29sKSB7IH0K IAorI2lmIFVTRShWOCkKKyAgICB2aXJ0dWFsIHZvaWQgZGlkQ3JlYXRlU2NyaXB0Q29udGV4dCgp IHsgfQorICAgIHZpcnR1YWwgdm9pZCBkaWREZXN0cm95U2NyaXB0Q29udGV4dCgpIHsgfQorI2Vu ZGlmCisKICNpZiBQTEFURk9STShNQUMpCiAgICAgdmlydHVhbCBOU0NhY2hlZFVSTFJlc3BvbnNl KiB3aWxsQ2FjaGVSZXNwb25zZShEb2N1bWVudExvYWRlciosIHVuc2lnbmVkIGxvbmcsIE5TQ2Fj aGVkVVJMUmVzcG9uc2UqIHJlc3BvbnNlKSBjb25zdCB7IHJldHVybiByZXNwb25zZTsgfQogI2Vu ZGlmCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50LmgJKHJldmlzaW9uIDQ1MTc3KQor KysgV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAt MjExLDcgKzIxMSwxMiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwgdm9p ZCB3aW5kb3dPYmplY3RDbGVhcmVkKCkgPSAwOwogICAgICAgICB2aXJ0dWFsIHZvaWQgZG9jdW1l bnRFbGVtZW50QXZhaWxhYmxlKCkgPSAwOwogICAgICAgICB2aXJ0dWFsIHZvaWQgZGlkUGVyZm9y bUZpcnN0TmF2aWdhdGlvbigpIGNvbnN0ID0gMDsgLy8gIk5hdmlnYXRpb24iIGhlcmUgbWVhbnMg YSB0cmFuc2l0aW9uIGZyb20gb25lIHBhZ2UgdG8gYW5vdGhlciB0aGF0IGVuZHMgdXAgaW4gdGhl IGJhY2svZm9yd2FyZCBsaXN0LgotICAgICAgICAKKworI2lmIFVTRShWOCkKKyAgICAgICAgdmly dHVhbCB2b2lkIGRpZENyZWF0ZVNjcmlwdENvbnRleHQoKSA9IDA7CisgICAgICAgIHZpcnR1YWwg dm9pZCBkaWREZXN0cm95U2NyaXB0Q29udGV4dCgpID0gMDsKKyNlbmRpZgorCiAgICAgICAgIHZp cnR1YWwgdm9pZCByZWdpc3RlckZvckljb25Ob3RpZmljYXRpb24oYm9vbCBsaXN0ZW4gPSB0cnVl KSA9IDA7CiAgICAgICAgIAogI2lmIFBMQVRGT1JNKE1BQykK