26722 2009-06-25 08:26:38 -0700 REGRESSION: Web Inspector Console JS completion is busted for custom objects 2009-06-27 19:32:02 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P2 Major --- 1 ml bfulgham aroben pfeldman timothy oldest_to_newest 128186 0 ml 2009-06-25 08:26:38 -0700 Completion for JS code in the Web Inspector Console seems to work fine for DOM objects but fails for custom objects. 128187 1 31857 ml 2009-06-25 08:27:08 -0700 Created attachment 31857 Testcase 128188 2 aroben 2009-06-25 08:33:54 -0700 <rdar://problem/7006514> 128473 3 31927 pfeldman 2009-06-26 05:21:57 -0700 Created attachment 31927 patch with the fix 128690 4 bfulgham 2009-06-27 18:52:19 -0700 Assign for landing. 128691 5 bfulgham 2009-06-27 19:32:02 -0700 Committed in http://trac.webkit.org/changeset/45315 31857 2009-06-25 08:27:08 -0700 2009-06-25 08:27:08 -0700 Testcase inspector_completion.html text/html 678 ml PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+CjxodG1sPgoKICA8aGVhZD4KICAgIDx0 aXRsZT5XZWIgSW5zcGVjdG9yIEpTIENvbnNvbGUgQ29tcGxldGlvbiBUZXN0PC90aXRsZT4KICAg IDxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFy c2V0PXV0Zi04Ij4KCiAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0i dXRmLTgiPgoKICAgICAgdmFyIGNvbnRyb2xsZXIgPSB7CiAgICAgICAgZm9vOiAwLAogICAgICAg IGJhcjogMSwKICAgICAgICBiYXo6IDIKICAgICAgfTsKCiAgICA8L3NjcmlwdD4KCiAgPC9oZWFk PgoKICA8Ym9keT4KCiAgICA8cD5PcGVuIHVwIHRoZSBXZWIgSW5zcGVjdG9yLCBhbmQgaW4gdGhl IENvbnNvbGUsIHR5cGUgPGNvZGU+Y29udHJvbGxlcjwvY29kZT4sIHRoZW4gdHJ5IHRvIHVzZSB0 aGUgdGFiIGtleS1iYXNlZCBjb21wbGV0aW9uIHRvIGl0ZXJhdGUgdGhlIG9iamVjdCdzIHZhcmlv dXMgcHJvcGVydGllcywgd2hpY2ggc2hvdWxkIGJlIDxjb2RlPmZvbzwvY29kZT4sIDxjb2RlPmJh cjwvY29kZT4gYW5kIDxjb2RlPmJhejwvY29kZT4uCgogIDwvYm9keT4KCjwvaHRtbD4K 31927 2009-06-26 05:21:57 -0700 2009-06-26 09:33:04 -0700 patch with the fix complete_busted.patch text/plain 1305 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2RjNjg3NC4uNDZiOTYwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNi0yNiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWJJbnNwZWN0b3I6IEZpeCBjb21wbGV0aW9uIHdoZW4gaXRl cmF0aW5nIG9wdGlvbnMgdXNpbmcgVGFiLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNjcyMgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9UZXh0UHJvbXB0LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90 eXBlLl9jb21wbGV0aW9uc1JlYWR5KToKKwogMjAwOS0wNi0yNiAgWGFuIExvcGV6ICA8eGxvcGV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFuIEFsb256by4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKaW5kZXggYzU4Y2Y2NC4uMzA3NzJmNyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKQEAgLTE2NSw3ICsx NjUsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGZ1 bGxXb3JkUmFuZ2Uuc2V0U3RhcnQod29yZFByZWZpeFJhbmdlLnN0YXJ0Q29udGFpbmVyLCB3b3Jk UHJlZml4UmFuZ2Uuc3RhcnRPZmZzZXQpOwogICAgICAgICBmdWxsV29yZFJhbmdlLnNldEVuZChz ZWxlY3Rpb25SYW5nZS5lbmRDb250YWluZXIsIHNlbGVjdGlvblJhbmdlLmVuZE9mZnNldCk7CiAK LSAgICAgICAgaWYgKG9yaWdpbmFsV29yZFByZWZpeFJhbmdlLnRvU3RyaW5nKCkgIT0gZnVsbFdv cmRSYW5nZS50b1N0cmluZygpKQorICAgICAgICBpZiAob3JpZ2luYWxXb3JkUHJlZml4UmFuZ2Uu dG9TdHJpbmcoKSArIHNlbGVjdGlvblJhbmdlLnRvU3RyaW5nKCkgIT0gZnVsbFdvcmRSYW5nZS50 b1N0cmluZygpKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChjb21wbGV0aW9u cy5sZW5ndGggPT09IDEgfHwgc2VsZWN0aW9uLmlzQ29sbGFwc2VkIHx8IGF1dG8pIHsK