267205 2024-01-07 08:39:57 -0800 Fix warnings found by compiling with -Wfinal-dtor-non-final-class 2024-01-10 17:53:56 -0800 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 267387 1 ddkilzer ddkilzer kkinnunen webkit-bug-importer oldest_to_newest 2003484 0 ddkilzer 2024-01-07 08:39:57 -0800 Fix warnings found by compiling with -Wfinal-dtor-non-final-class Example: Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:64:19: error: class with destructor marked 'final' cannot be inherited from [-Werror,-Wfinal-dtor-non-final-class] 59 | class Connection : public CanMakeWeakPtr<Connection>, public IPC::MessageSender { | final 60 | WTF_MAKE_FAST_ALLOCATED; 61 | public: 62 | static std::unique_ptr<Connection> create(std::optional<Action>, PreferTestService, Reconnect); 63 | Connection(std::optional<Action>, PreferTestService, Reconnect); 64 | ~Connection() final { } | ^ Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:59:7: note: mark 'WebPushTool::Connection' as 'final' to silence this warning 59 | class Connection : public CanMakeWeakPtr<Connection>, public IPC::MessageSender { | ^ 1 error generated. 2003485 1 webkit-bug-importer 2024-01-07 08:40:12 -0800 <rdar://problem/120609974> 2003486 2 ddkilzer 2024-01-07 08:41:27 -0800 Pull request: https://github.com/WebKit/WebKit/pull/22487 2003620 3 ews-feeder 2024-01-08 09:21:47 -0800 Committed 272769@main (5381539f603f): <https://commits.webkit.org/272769@main> Reviewed commits have been landed. Closing PR #22487 and removing active labels.