267204 2024-01-07 08:33:20 -0800 Fix warnings found by compiling with -Wdeprecated-enum-enum-conversion 2024-01-10 17:53:56 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 267387 1 ddkilzer ddkilzer webkit-bug-importer oldest_to_newest 2003481 0 ddkilzer 2024-01-07 08:33:20 -0800 Fix warnings found by compiling with -Wdeprecated-enum-enum-conversion. Examples: Source/WebCore/platform/graphics/cg/ImageBackingStoreCG.cpp:52:193: error: bitwise operation between different enumeration types ('CGImageAlphaInfo' and 'CGImageByteOrderInfo') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] 52 | return adoptCF(CGImageCreate(width, height, bitsPerComponent, bytesPerPixel * 8, bytesPerRow, colorSpace.get(), (m_premultiplyAlpha ? kCGImageAlphaPremultipliedFirst : kCGImageAlphaFirst) | kCGImageByteOrder32Little, dataProvider.get(), nullptr, true, kCGRenderingIntentDefault)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm:99:116: error: arithmetic between different enumeration types ('NSWritingDirection' and 'NSWritingDirectionFormatType') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] 99 | RetainPtr<NSNumber> writingDirectionValue = adoptNS([[NSNumber alloc] initWithInteger:writingDirection + NSWritingDirectionOverride]); | ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm:86:120: error: arithmetic between different enumeration types ('NSWritingDirection' and 'NSWritingDirectionFormatType') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] 86 | RetainPtr<NSNumber> writingDirectionValue = adoptNS([[NSNumber alloc] initWithInteger:writingDirection + NSWritingDirectionOverride]); | ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Tools/TestWebKitAPI/cocoa/CGImagePixelReader.cpp:40:54: error: bitwise operation between different enumeration types ('CGImageAlphaInfo' and 'CGImageByteOrderInfo') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] 40 | auto bitmapInfo = kCGImageAlphaPremultipliedLast | kCGImageByteOrder32Big; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. 2003482 1 webkit-bug-importer 2024-01-07 08:33:45 -0800 <rdar://problem/120609798> 2003483 2 ddkilzer 2024-01-07 08:37:45 -0800 Pull request: https://github.com/WebKit/WebKit/pull/22486 2003518 3 ews-feeder 2024-01-07 15:45:43 -0800 Committed 272749@main (a99abdd48615): <https://commits.webkit.org/272749@main> Reviewed commits have been landed. Closing PR #22486 and removing active labels.