<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>26719</bug_id>
          
          <creation_ts>2009-06-25 04:35:51 -0700</creation_ts>
          <short_desc>A few fixes for bugzilla-tool</short_desc>
          <delta_ts>2009-06-25 14:26:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tor Arne Vestbø">vestbo</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>128162</commentid>
    <comment_count>0</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2009-06-25 04:35:51 -0700</bug_when>
    <thetext>A few fixes for bugzilla-tool</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128164</commentid>
    <comment_count>1</comment_count>
      <attachid>31852</attachid>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2009-06-25 04:40:12 -0700</bug_when>
    <thetext>Created attachment 31852
bugzilla-tool: use unicode instead of str when fetching the patch name

---
 2 files changed, 9 insertions(+), 1 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128165</commentid>
    <comment_count>2</comment_count>
      <attachid>31853</attachid>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2009-06-25 04:40:16 -0700</bug_when>
    <thetext>Created attachment 31853
bugzilla-tool: Add Simon Hausmann as reviewer

---
 2 files changed, 9 insertions(+), 0 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128167</commentid>
    <comment_count>3</comment_count>
      <attachid>31853</attachid>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2009-06-25 04:50:49 -0700</bug_when>
    <thetext>Comment on attachment 31853
bugzilla-tool: Add Simon Hausmann as reviewer

&gt; +++ b/WebKitTools/Scripts/modules/bugzilla.py
&gt; @@ -89,6 +89,7 @@ class Bugzilla:
&gt;          &quot;eric&quot; : &quot;Eric Seidel&quot;,
&gt;          &quot;fishd&quot; : &quot;Darin Fisher&quot;,
&gt;          &quot;gns&quot; : &quot;Gustavo Noronha&quot;,
&gt; +        &quot;hausmann&quot; : &quot;Simon Hausmann&quot;,

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128197</commentid>
    <comment_count>4</comment_count>
      <attachid>31852</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2009-06-25 09:00:31 -0700</bug_when>
    <thetext>Comment on attachment 31852
bugzilla-tool: use unicode instead of str when fetching the patch name

Please add the link to the bug in the changelog (even though in this case it doesn&apos;t really add anything).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128203</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-25 10:10:14 -0700</bug_when>
    <thetext>Yup, these look good.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128254</commentid>
    <comment_count>6</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-25 13:37:43 -0700</bug_when>
    <thetext>I&apos;m not sure why this is assigned to me?  Unless I&apos;m supposed to land it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128262</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-25 14:10:58 -0700</bug_when>
    <thetext>I need the reviewer fix, so will land.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128264</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-25 14:12:55 -0700</bug_when>
    <thetext>svn-apply doesn&apos;t seem to fix the ChangeLog correctly when applying this.  Odd.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128269</commentid>
    <comment_count>9</comment_count>
      <attachid>31853</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-25 14:18:19 -0700</bug_when>
    <thetext>Comment on attachment 31853
bugzilla-tool: Add Simon Hausmann as reviewer

This was already commited: http://trac.webkit.org/changeset/45174</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>128274</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-06-25 14:26:31 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
Committed r45192
http://trac.webkit.org/changeset/45192</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31852</attachid>
            <date>2009-06-25 04:40:12 -0700</date>
            <delta_ts>2009-06-25 09:00:31 -0700</delta_ts>
            <desc>bugzilla-tool: use unicode instead of str when fetching the patch name</desc>
            <filename>bugzilla_requires_a_filename.patch</filename>
            <type>text/plain</type>
            <size>1453</size>
            <attacher name="Tor Arne Vestbø">vestbo</attacher>
            
              <data encoding="base64">NDE5ZTBhMDljYTc4MWM5MzgxODVmOWZjMWIyMzE2NjFkOTg2MWFhMwpkaWZmIC0tZ2l0IGEvV2Vi
S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDA3ODIyMDQu
LjI5MzQ1YzcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU
b29scy9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgogCisgICAgICAgIGJ1Z3ppbGxhLXRvb2w6IHVzZSB1bmljb2RlIGluc3Rl
YWQgb2Ygc3RyIHdoZW4gZmV0Y2hpbmcgdGhlIHBhdGNoIG5hbWUKKworICAgICAgICAqIFNjcmlw
dHMvbW9kdWxlcy9idWd6aWxsYS5weToKKworMjAwOS0wNi0yNSAgVG9yIEFybmUgVmVzdGLDuCAg
PHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKICAgICAgICAgYnVnemlsbGEtdG9vbDogQWRkIFNpbW9uIEhhdXNtYW5uIGFz
IHJldmlld2VyCiAKICAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHk6CmRpZmYg
LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkgYi9XZWJLaXRU
b29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKaW5kZXggMWNiODViOS4uMjY0MWY5YiAx
MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CisrKyBi
L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQpAQCAtMTQ3LDcgKzE0Nyw3
IEBAIGNsYXNzIEJ1Z3ppbGxhOgogICAgICAgICAgICAgYXR0YWNobWVudF9saW5rID0gY2VsbHNb
MF0uZmluZCgnYScpCiAgICAgICAgICAgICBhdHRhY2htZW50Wyd1cmwnXSA9IHNlbGYuYnVnX3Nl
cnZlciArIGF0dGFjaG1lbnRfbGlua1snaHJlZiddICMgdXJscyBhcmUgcmVsYXRpdmUKICAgICAg
ICAgICAgIGF0dGFjaG1lbnRbJ2lkJ10gPSBhdHRhY2htZW50Wyd1cmwnXS5zcGxpdCgnPScpWzFd
ICMgZS5nLiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9hdHRhY2htZW50LmNnaT9pZD0zMTIyMwot
ICAgICAgICAgICAgYXR0YWNobWVudFsnbmFtZSddID0gc3RyKGF0dGFjaG1lbnRfbGluay5zdHJp
bmcpICMgdy9vIHN0ciBpdCByZXR1cm5zIHNvbWUgc29ydCBvZiBub24tc3RyaW5nIG9iamVjdAor
ICAgICAgICAgICAgYXR0YWNobWVudFsnbmFtZSddID0gdW5pY29kZShhdHRhY2htZW50X2xpbmsu
c3RyaW5nKSAjIHcvbyB1bmljb2RlIGl0IHJldHVybnMgc29tZSBzb3J0IG9mIG5vbi1zdHJpbmcg
b2JqZWN0CiAgICAgICAgICAgICAjIGF0dGFjaG1lbnRbJ3R5cGUnXSA9IGNlbGxzWzFdCiAgICAg
ICAgICAgICAjIGF0dGFjaG1lbnRbJ2RhdGUnXSA9IGNlbGxzWzJdCiAgICAgICAgICAgICAjIGF0
dGFjaG1lbnRbJ3NpemUnXSA9IGNlbGxzWzNdCg==
</data>
<flag name="review"
          id="16417"
          type_id="1"
          status="+"
          setter="levin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>31853</attachid>
            <date>2009-06-25 04:40:16 -0700</date>
            <delta_ts>2009-06-25 14:18:19 -0700</delta_ts>
            <desc>bugzilla-tool: Add Simon Hausmann as reviewer</desc>
            <filename>bugzilla_requires_a_filename.patch</filename>
            <type>text/plain</type>
            <size>990</size>
            <attacher name="Tor Arne Vestbø">vestbo</attacher>
            
              <data encoding="base64">YzRlZTY1Y2ZiZDI4MWU4ZWU5NDg3ZTk3NGExZmMwNzgwZWY5YWVlZQpkaWZmIC0tZ2l0IGEvV2Vi
S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDM0MWE5ZmIu
LjA3ODIyMDQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU
b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAwOS0wNi0yNSAgVG9yIEFybmUgVmVz
dGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYnVnemlsbGEtdG9vbDogQWRkIFNpbW9uIEhhdXNt
YW5uIGFzIHJldmlld2VyCisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHk6
CisKIDIwMDktMDYtMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IERhdmUgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz
L21vZHVsZXMvYnVnemlsbGEucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemls
bGEucHkKaW5kZXggZTU1ZWJjNi4uMWNiODViOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl
cy9idWd6aWxsYS5weQpAQCAtODksNiArODksNyBAQCBjbGFzcyBCdWd6aWxsYToKICAgICAgICAg
ImVyaWMiIDogIkVyaWMgU2VpZGVsIiwKICAgICAgICAgImZpc2hkIiA6ICJEYXJpbiBGaXNoZXIi
LAogICAgICAgICAiZ25zIiA6ICJHdXN0YXZvIE5vcm9uaGEiLAorICAgICAgICAiaGF1c21hbm4i
IDogIlNpbW9uIEhhdXNtYW5uIiwKICAgICAgICAgImh5YXR0IiA6ICJEYXZpZCBIeWF0dCIsCiAg
ICAgICAgICJqbWFsb256byIgOiAiSmFuIEFsb256byIsCiAgICAgICAgICJqdXN0aW4uZ2FyY2lh
IiA6ICJKdXN0aW4gR2FyY2lhIiwK
</data>

          </attachment>
      

    </bug>

</bugzilla>