26716 2009-06-25 01:51:43 -0700 [Gtk] Each XMLHttpRequest leaks memory. 2009-07-20 03:05:29 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Major --- 1 john.kjellberg webkit-unassigned ap jmalonzo xan.lopez oldest_to_newest 128132 0 john.kjellberg 2009-06-25 01:51:43 -0700 I have tried this with WebKit-r43841(and earlier versions also in the past) and GtkLauncher. I have loaded the attached file which makes a XMLHttpRequest request every 100ms. After a half an hour some MB of memory is missing. This continues until the system is really low on memory and slows down and the the oom-killer kills the app. I have checked memory usage in: /proc/<pid>/smaps and it shows increase in "[heap]" memory. This bug is really critical since it makes it impossible to create stable kiosk-applications and such. (This bug is sort of Bug#: 17534, however, I felt that that bug report was really misleading) 128133 1 31840 john.kjellberg 2009-06-25 01:53:13 -0700 Created attachment 31840 Test case making XMLHttpRequest every 100ms 130194 2 john.kjellberg 2009-07-07 06:42:58 -0700 I have now done more testing with the nightly build r41128. That is the last version supporting both "curl" and "soup" as HTTP backend. When using "soup" as backend it leaks memory, when using "curl" it doesn't. That the leak is related to "soup" is also confirmed by valgrid testing. I don't know if the leak is in how WebKit uses "soup" of if the leak is in soup itself. I use version 2.26.1 of libsoup. 130198 3 jmalonzo 2009-07-07 06:47:45 -0700 Marking this a Gtk bug for now since it's confirmed that it's in the soup backend. 130241 4 john.kjellberg 2009-07-07 10:49:58 -0700 I think I how found the problem in: WebCore/platform/network/soup/ResourceHandleSoup.cpp line 581 if ((equalIgnoringCase(protocol, "http") || equalIgnoringCase(protocol, "https")) && SOUP_URI_VALID_FOR_HTTP(soup_uri_new(urlString.utf8().data()))) the call to "soup_uri_new()" should be followed by a "soup_uri_free()". I will take a deeper look at it tomorrow and perhaps create a "proposed patch" if no one beats me too it. 133089 5 33075 xan.lopez 2009-07-20 02:38:59 -0700 Created attachment 33075 fixleak.patch I think you are totally right; patch attached. 133101 6 xan.lopez 2009-07-20 03:05:29 -0700 Patch landed as r46117. 31840 2009-06-25 01:53:13 -0700 2009-06-25 01:53:13 -0700 Test case making XMLHttpRequest every 100ms mem_test.htm text/html 232 john.kjellberg PGh0bWw+Cjxib2R5Pgo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CnZhciB4bWxIdHRw PW5ldyBYTUxIdHRwUmVxdWVzdCgpOwoKZnVuY3Rpb24gdGVzdCgpIHsKCXhtbEh0dHAub3Blbigi R0VUIiwibWVtX3Rlc3QuaHRtIiwgZmFsc2UpOwoJeG1sSHR0cC5zZW5kKG51bGwpOwogICAgc2V0 VGltZW91dCh0ZXN0LDEwMCk7Cn0KCnRlc3QoKTsKPC9zY3JpcHQ+ClRlc3QKPC9ib2R5Pgo8L2h0 bWw+Cg== 33075 2009-07-20 02:38:59 -0700 2009-07-20 02:54:47 -0700 fixleak.patch fixleak.patch text/plain 2380 xan.lopez RnJvbSBhNWFiMmRiNWM4ZTkyYzdhMzZhNzQ1NDVlNDc2ODU0MmQzNTY4NTA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBN b24sIDIwIEp1bCAyMDA5IDEyOjM3OjMxICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNy0y MCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjY3MTYKICAgICAgICBbR3RrXSBFYWNoIFhNTEh0dHBSZXF1ZXN0IGxlYWtzIG1lbW9y eS4KCiAgICAgICAgRnJlZSB0aGUgU291cFVSSSB3ZSBjcmVhdGUgdG8gY2hlY2sgdGhlIFVSSS4g Rml4IHN1Z2dlc3RlZCBieSBKb2huCiAgICAgICAgS2plbGxiZXJnLgoKICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgogICAgICAgIChXZWJDb3Jl OjopOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291 cmNlSGFuZGxlU291cC5jcHAgICB8ICAgIDYgKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMzdkYmViLi43NGM1NmU2IDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDA5LTA3LTIwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAorICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY3MTYKKyAgICAgICAgW0d0a10gRWFjaCBYTUxIdHRw UmVxdWVzdCBsZWFrcyBtZW1vcnkuCisKKyAgICAgICAgRnJlZSB0aGUgU291cFVSSSB3ZSBjcmVh dGUgdG8gY2hlY2sgdGhlIFVSSS4gRml4IHN1Z2dlc3RlZCBieSBKb2huCisgICAgICAgIEtqZWxs YmVyZy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6KToKKworMjAwOS0wNy0yMCAgWGFuIExvcGV6ICA8 eGxvcGV6QGlnYWxpYS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3Jvbmhh LgogCiAgICAgICAgIENoYW5nZSB0aGUgZ2xpYiB2ZXJzaW9uIGNoZWNrIHRvIGNoZWNrIGZvciB0 aGUgZmlyc3QgdW5zdGFibGUKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291 cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDM5MGNiYzMuLjlhYzU5NTMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNw cApAQCAtNTgzLDcgKzU4MywxMSBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFydChGcmFtZSog ZnJhbWUpCiAgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKHByb3RvY29sLCAiZGF0YSIpKQogICAg ICAgICByZXR1cm4gc3RhcnREYXRhKHVybFN0cmluZyk7CiAKLSAgICBpZiAoKGVxdWFsSWdub3Jp bmdDYXNlKHByb3RvY29sLCAiaHR0cCIpIHx8IGVxdWFsSWdub3JpbmdDYXNlKHByb3RvY29sLCAi aHR0cHMiKSkgJiYgU09VUF9VUklfVkFMSURfRk9SX0hUVFAoc291cF91cmlfbmV3KHVybFN0cmlu Zy51dGY4KCkuZGF0YSgpKSkpCisgICAgU291cFVSSSogdXJpID0gc291cF91cmlfbmV3KHVybFN0 cmluZy51dGY4KCkuZGF0YSgpKTsKKyAgICBib29sIGlzSFRUUE9ySFRUUFMgPSAoZXF1YWxJZ25v cmluZ0Nhc2UocHJvdG9jb2wsICJodHRwIikgfHwgZXF1YWxJZ25vcmluZ0Nhc2UocHJvdG9jb2ws ICJodHRwcyIpKSAmJiBTT1VQX1VSSV9WQUxJRF9GT1JfSFRUUCh1cmkpOworICAgIHNvdXBfdXJp X2ZyZWUodXJpKTsKKworICAgIGlmIChpc0hUVFBPckhUVFBTKQogICAgICAgICByZXR1cm4gc3Rh cnRIdHRwKHVybFN0cmluZyk7CiAKICAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UocHJvdG9jb2ws ICJmaWxlIikgfHwgZXF1YWxJZ25vcmluZ0Nhc2UocHJvdG9jb2wsICJmdHAiKSB8fCBlcXVhbEln bm9yaW5nQ2FzZShwcm90b2NvbCwgImZ0cHMiKSkKLS0gCjEuNi4zLjMKCg==